[Seaside-dev] WABrush questionable namings

[Philippe Marschall]

2008/2/24, Gerhard Obermann <obi068 at gmail.com>:
> Hi!
>
> During my trial to create a generic WABrush seaside editor
> i have found some questionable namings in WABrush and all subclasses!
> Ill hope that some of these could be addressed with Seaside 2.9!
> Here is the result after checking mostly all classes:
>
> - WASelectTag
>    - #enabled: aBlock <-> #disabled: Boolean .. Its a little bit confusing
> to use enabled: in that case
>
>
> - WATimeInput
>  - public api -> public
>  - initialize-release -> initialization
>
> - WAAnchorTag
>  - conveniance -> convenience
>  - #tag -> category accessing
>
> - WAHeadingTag
>   - #tag -> category accessing
>
> - WATagBrush
>  -#tag -> category accessing
>
> - WAImageTag
>  -#tag -> category accessing
>
> - WADivTag
>  - public api -> public
>
> - WAFormInputTag: .. why is it necessary to set also the class ?
>  with: aBlock
>  self type isNil ifFalse: [
>   self attributes at: 'type' ifAbsentPut: [ self type ].
>   self class: self type ].
>  super with: aBlock
>
> WATagBrush, WACheckboxTag, WARAdionButtonTag, WASubmitButtonTag
>  - #canHaveShortcut -> testing
>
> - WACheckboxTag
>  #submitFormNamed: -> conveniance (see WAAnchorTag)
>
> - WAButtonTag
>  - initialize-release -> initialization
>
> - WAImageButtonTag
>  - callback: -> callbacks
>
> - WAFormTag
>    - initialize-release -> initialization
>
> - WAGenericTag
>   - initialize-release -> initialization

Kent Beck, Smalltalk Best Practice Patterns, the pattern on 'Explicit
Initialization' says:

'Put #initialize methods in a method protocol called "initialize-release"'

Cheers
Philippe

> - WAHeadingTag
>   - conveniance -> convenience
>   - #tag -> accessing
>
> - WAImageTag
>    - initialize-release -> initialization
>    - #tag -> accessing
>
> Cheers
> Gerhard
>
> _______________________________________________
>  seaside-dev mailing list
>  seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>