[Seaside-dev] Re: Seaside-Core-css.516.mcz

[Lukas Renggli]

I committed Seaside-Core-lr.516 and Seaside-Adaptors-Swazoo-lr.20. I
think these two changes do the same as the original commits in a much
cleaner way. Is this ok? Or am I missing something?

Lukas

  Name: Seaside-Core-lr.516
  Author: lr
  Time: 16 July 2009, 10:14:58 pm
  UUID: 9cc400a9-89e6-4149-afe3-75cb472324e1
  Ancestors: Seaside-Core-lr.515

  - an alternative implementation to automatically set HTTPS if the
server adaptor signals it

  Name: Seaside-Adaptors-Swazoo-lr.20
  Author: lr
  Time: 16 July 2009, 10:13:59 pm
  UUID: 3ac52d69-435f-41ed-a320-23f0850f95a9
  Ancestors: Seaside-Adaptors-Swazoo-jf.19

  - an alternative implementation to automatically set HTTPS if the
server adaptor signals it

2009/7/16 Lukas Renggli <renggli at gmail.com>:
> What was the idea behind the changes in Seaside-Core-css.516.mcz and friends?
>
> I don't see the reason why the author is duplicating the scheme in
> WARequest, whereas the request URL already has a field scheme. As far
> as I see exactly the same could be achieved in a much cleaner way by
> only changing a few methods of WAUrl.
>
> Lukas
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>



-- 
Lukas Renggli
http://www.lukas-renggli.ch