[BUG][FIX] TextPlusMorph focus/cursor (was: [BUG] GeeMail no
Cursor)
Hernan Tylim
htylim at yahoo.com.ar
Thu Aug 19 12:03:51 UTC 2004
Hi Andreas,
I think that your problem with the GeeMail morph is fixed with a
fix I posted on April 11 ([FIX][BUG] Hidden Text Cursor). Would you
please take a look at it? What I would like to know if one is more
complete that the other as to push that one for fix approval.
Thanks
P.S: BTW, Since 3.7alpha that this bug is present in the image, I always
wondered why no other than me ever has a problem with it. Glad to know
that I am not alone :)
Regards,
Hernán
> -----Original Message-----
> From: squeak-dev-bounces at lists.squeakfoundation.org
> [mailto:squeak-dev-bounces at lists.squeakfoundation.org] On
> Behalf Of Andreas Gerdes
> Sent: Thursday, August 19, 2004 12:08 AM
> To: squeak-dev at lists.squeakfoundation.org
> Subject: [BUG][FIX] TextPlusMorph focus/cursor (was: [BUG]
> GeeMail no Cursor)
>
>
> Just by chance, a companion squeaker told me, that my bug-posting was
> answered today by Karl Ramberg -
> I did not get that mail and am wondering now, how many others
> I do not
> get and WHY!?
>
> Howsoever, thanks to Karl, I could fix the bug by applying
> the changes in:
> 5849TextMorphSelectionFix ( "Change Set: FocusFixes-rr | Date: 23
> March 2004 | Author: Romain Robbes")
> to the TextPlusMorph.
>
> Some questions are left for me:
> In the attached changeset, there is just this new line:
>
> paragraph isNil ifFalse:[paragraph focused: aBoolean].
>
> Focus is shown, then, but is never lost afterwards. This is
> normal for
> the GeeMailMorph, I always found that irritating.
> If I apply the changes described below, the TextPlusMorph shows and
> looses focus like any other TextMorph.
>
> ---------------
> keyboardFocusChange: aBoolean
> | parent |
>
> "we basically ignore loss of focus unless it is going to
> one of our
> siblings"
> aBoolean ifFalse: [^self].
> 1. ^^^ remove this and rather put the question around the
> "Inform...."-code like 2. below
>
> paragraph isNil ifFalse:[paragraph focused: aBoolean].
> ^^^ in the attached changeset I added this line
>
> "A hand is wanting to send us characters..."
> self hasFocus ifFalse: [self editor "Forces install"].
>
> 2. aBoolean ifTrue:[
> "Inform our siblings we have taken the focus"
> parent _ self parentGeeMail ifNil: [^self].
> parent allTextPlusMorphs do: [ :each |
> each == self ifFalse: [each keyboardFocusLostForSure]
> ]].
> self changed.
> 3. ^^^^ add this line
> ------------------
>
> Works nicely - any reason NOT to do so?
> Thanks
>
> Andreas
>
>
>
More information about the Squeak-dev
mailing list
|