[FIX] positionOfSubCollection-fix-avi

avi at beta4.com avi at beta4.com
Sun Dec 5 16:53:49 UTC 2004


from preamble:

"Change Set:		positionOfSubcollection-fix-avi
Date:			5 December 2004
Author:			Avi Bryant

This fixes an off-by-one error that caused #positionOfSubCollection: to
return the position of the last character before the subcollection
rather than the first character of the subcollection itself.  For
example, before this fix,
	'xyz' readStream positionOfSubCollection: 'x'
and
	'xyz' readStream positionOfSubCollection: 'q'
would *both* return 0, whereas now the first returns 1 and the second
returns 0.

This changset also modifies the only sender, SocketStream>>upToAll:,
which had previously tried to compensate for the off-by-one error
(although only in one of two places it should have, which was what
brought the bug to my attention).

With this fix, Comanche/Seaside/etc (and presumably many other network
clients and servers) should work properly again."!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: positionOfSubCollection-fix-avi.cs.gz
Type: application/octet-stream
Size: 1245 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20041205/fba91a78/positionOfSubCollection-fix-avi.cs.obj


More information about the Squeak-dev mailing list