TextMorphSelectionFix-rr ([et][er] almost there)

rrobbes rrobbes at info.unicaen.fr
Mon Mar 22 18:43:32 UTC 2004


Doug Way a écrit: 

> 
> This change looks like a good idea to me.  Two problems I noticed with 
> this, though: 
> 
> 1.  The lost-focus selection color did not look different enough to me... 
> at least with the default bright green color, the lost-focus color was 
> still almost as bright a green.  I fixed this by changing the line in 
> NewParagraph>>selectionColor to: 
> 
> self focused ifFalse: [color := color alphaMixed: 0.2 with: Color 
> veryVeryLightGray]. 
> 

Well I fiddled quite a bit to find a good color, and this looked
good on my screen ... I'll try this one too. 

> 2. The vertical-bar cursor (when there is no selection) does not 
> dissappear or change color when a window loses focus.  I'd say it should 
> probably dissappear (this is what Windows does and probably the Mac as 
> well), although changing color to the lost-focus selectionColor above 
> might be an option.  Hmm, no, it should really just dissappear. :-) 
> 

Haven't looked at that yet ... I think the option might be easier,
but I'll try to make it disappear ... 

> If we can address #2, I'd like to approve this one. 
> 
> - Doug 
> 
>  
> 
> rrobbes at info.unicaen.fr wrote: 
> 
>> from preamble: 
>> 
>> "Change Set:		FocusFixes-rr
>> Date:			23 March 2004
>> Author:			Romain Robbes 
>> 
>> V2 : provides more visual feedback by changing the selection
>> color upon focus change, as suggested by Hernán Tylim. 
>> 
>> Makes the selected text in a TextMorph not
>> disappear when the morph loses focus,
>> by removing the call to releaseEditor in
>> TextMorph>>keyboardFocusChange:  . 
>> 
>> This makes the TextMorphs' behavior more
>> consistent with text panes in the host platforms,
>> and makes Squeak a more consistent with itself,
>> as this will allow all menus to behave according to the 
>> menuKeyboardControl preference, including
>> the ones in a paragraph.  
>> 
>> Also included are the changes in PluggableTextMorph and
>> StrikeFont, to allow menus to be invoked modally, and
>> thus having keyboard control if the preference is set"!
>>   
>> 
>> ------------------------------------------------------------------------ 
>> 
>> 
>>   
>> 
>  
> 
> 
 



More information about the Squeak-dev mailing list