On Fri, 25 Dec 2009, David T. Lewis wrote:

> I ran into problems saving the large changes file patches, and reverted
> the update.  Sorry for the noise.
>

I guess the problem is related to #fileIndexFromSourcePointer: which 
returns 0 if sent to a StandardSourceFileArray when the argument is less 
than 16777216 (16r1000000), while ExpandedSourceFileArray returns 2. I 
guess that 0 is a valid result and some code expects this value.

Another difference between the two implementations is that 
ExpandedSourceFileArray new filePositionFromSourcePointer: 0 ===> -16777216
while
StandardSourceFileArray new filePositionFromSourcePointer: 0 ===> 0

> On a positive note, I have a changes file that has reached 426 MB without
> problems, so the updated sourcePointer address mapping works fine.

Great. :)


Levente

>
>> From my test image:
>
>  (CompiledMethod allInstances collect: [:e | e sourcePointer]) max hex ==> '36A39BF3'
>
>  (SourceFiles at: 2) size ==> 446930379
>
> Dave
>
> On Sat, Dec 26, 2009 at 04:29:49AM +0000, commits at source.squeak.org wrote:
>> David T. Lewis uploaded a new version of Files to project The Trunk:
>> http://source.squeak.org/trunk/Files-dtl.61.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Files-dtl.61
>> Author: dtl
>> Time: 25 December 2009, 11:24:59 am
>> UUID: 395f5d5e-f046-4747-8f2a-9cdb898fddcf
>> Ancestors: Files-dtl.59
>>
>> Revert Files-dtl.60.mcz, which caused problems with Monticello saves.
>>
>> =============== Diff against Files-dtl.59 ===============
>>
>
>