[squeak-dev] The Trunk: Files-tfel.165.mcz

Levente Uzonyi leves at caesar.elte.hu
Wed Aug 31 08:26:42 UTC 2016


On Tue, 30 Aug 2016, commits at source.squeak.org wrote:

> Tim Felgentreff uploaded a new version of Files to project The Trunk:
> http://source.squeak.org/trunk/Files-tfel.165.mcz
>
> ==================== Summary ====================
>
> Name: Files-tfel.165
> Author: tfel
> Time: 30 August 2016, 10:42:22.521946 am
> UUID: 45b18cd1-022d-824f-8b83-077e3908cb22
> Ancestors: Files-tfel.162, Files-dtl.164
>
> merge translation and read-only check from Squeakland Etoys
>
> =============== Diff against Files-dtl.164 ===============
>

snip

> Item was changed:
>  ----- Method: RemoteString>>string:onFileNumber: (in category 'private') -----
>  string: aString onFileNumber: fileNumber
>  	"Store this as my string if source files exist."
> + 	(SourceFiles at: fileNumber) ifNotNil: [:theFile |
> + 		theFile isReadOnly ifTrue: [^ nil].

Since we use read-only files for reading the sources, this change will 
break stuff. What's the point of this change anyway?

Levente

> - 	| theFile |
> - 	(SourceFiles at: fileNumber) == nil ifFalse:
> - 		[theFile := SourceFiles at: fileNumber.
>  		theFile setToEnd; cr.
> + 		self string: aString onFileNumber: fileNumber toFile: theFile].!
> - 		self string: aString onFileNumber: fileNumber toFile: theFile]!
>
>
>


More information about the Squeak-dev mailing list