Thanks, Chris and Bert.
I think I found the reason I had problems.
If you change instance variables but not any methods you get the
methodListMenu:  from MCOperationsBrowser but not the one  from MCCodeTool.

There is only 'browse origins' in the MCOperationsBrowser>>methodListMenu:

So the fix must be to fix MCCodeTool>>methodListMenu: to at least give
option to 'browse full' so one can get to the class.

Best,
Karl


On Tue, May 24, 2016 at 9:27 PM, Chris Muller <asqueaker at gmail.com> wrote:

> Hi Karl, mcModel is for the history function, the code shouldn't be
> getting there for a regular browse class.  Are you sure you didn't
> select "browse mc history" or "browse mc origin"?
>
> PS -- I still plan to try to fix the mc history function again..
>
> On Tue, May 24, 2016 at 12:31 PM, karl ramberg <karlramberg at gmail.com>
> wrote:
> > Ok, it only fails if MCMethodDefinition>>mcModel is nil in
> > MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference
> >
> > Once you have the MCMethodDefinition>>mcModel installed it will work the
> > next time, so my fix is still necessary
> >
> >
> >
> > Best,
> > Karl
> >
> > On Tue, May 24, 2016 at 6:41 PM, karl ramberg <karlramberg at gmail.com>
> wrote:
> >>
> >> Hm, weird.
> >> I removed the fix I did and now it works...
> >>
> >> Not sure what was going on
> >>
> >> Best,
> >> Karl
> >>
> >> On Tue, May 24, 2016 at 6:33 PM, Bert Freudenberg <bert at freudenbergs.de
> >
> >> wrote:
> >>>
> >>> Which menu item are you trying? You wrote “can open a browser from the
> >>> context menu” and for me both cmd-b and the context menu work for
> opening a
> >>> System Browser.
> >>>
> >>> - Bert -
> >>>
> >>>
> >>> On 24.05.2016, at 18:27, karl ramberg <karlramberg at gmail.com> wrote:
> >>>
> >>>
> >>> I know packageInfo is not the same as workingCopy but I'm not sure how
> to
> >>> reference it from the merge browser.
> >>>
> >>> How can this be working in your image ? packageInfo is not implemented
> >>> for MCMethodDefinition...
> >>>
> >>>
> >>> It's called from
> >>> MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference
> >>> ^ aClassOrMethodReference mcModel ifNil:
> >>> [ | pkgName rep | (UIManager confirm: 'Okay to add historical
> repository
> >>> ' , (rep := MCHttpRepository trunkBackup) description , ' to ' ,
> (pkgName :=
> >>> aClassOrMethodReference packageInfo packageName) , '?') ifTrue:
> >>> [ (MCWorkingCopy forPackageNamed: pkgName) repositoryGroup
> addRepository:
> >>> rep.
> >>> aClassOrMethodReference mcModel ] ]
> >>>
> >>> Best,
> >>> Karl
> >>>
> >>> On Tue, May 24, 2016 at 5:56 PM, Bert Freudenberg <
> bert at freudenbergs.de>
> >>> wrote:
> >>>>
> >>>> On 24.05.2016, at 17:17, karl ramberg <karlramberg at gmail.com> wrote:
> >>>> >
> >>>> > I'm pretty sure this is a proper fix so the MCMergeBrowser can open
> a
> >>>> > browser from the context menu:
> >>>>
> >>>> This appears to work fine for me even without that change.
> >>>>
> >>>> > MCMethodDefinition>>packageInfo
> >>>> >
> >>>> >        ^ self workingCopy! !
> >>>>
> >>>> … and a WorkingCopy most definitely is not the same as a PackageInfo
> ;)
> >>>>
> >>>> - Bert -
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >
> >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160525/35db96da/attachment.htm