[squeak-dev] [Discussion] Tools > "Metacello" and "Git Browser"

David T. Lewis lewis at mail.msen.com
Sun Aug 25 20:26:01 UTC 2019

On Sun, Aug 25, 2019 at 08:27:10PM +0200, Jakob Reschke wrote:
> Hi,
> I have never had a problem not specifying a default window color so far.
> And I use colorful windows all the time. What problem does it solve?
> Kind regards,
> Jakob

If you activate Extras -> Themes & Colors -> Colorful Windows to turn
on colorful winds, then the Tools menu entries will have colored box
icons to the left of each menu entry. The color of the box icon is
determined by defaultWindowColor for each tool. If no default color is
specified, then no colored box icon will be displayed in the Tools menu.

The earlier version of #gitInfrastructureMenuItemOn: that is in trunk
today did not honor window colors, instead it had hard-coded the menu
item color. I fixed this in my update, but in order for it to work
similarly to the other tool menu entries, it is necessary for the
tool (SqueakBrowser) to specify some window color other than the
default of Model>>#uniformWindowColor.

Note also that the current version in trunk is broken when colorful
windows is disabled. In that case, the git browser (and Metacello loader)
Tool menu entries will incorrectly display grey icons (but no icon
box should be displayed in this case).


> David T. Lewis <lewis at mail.msen.com> schrieb am So., 25. Aug. 2019, 17:25:
> >
> >    Menu icons are updated in the Tools menu, but note that the the Git
> >    browser needs to have a #defaultWindowColor in order for colorful
> > windows
> >    to work as expected. For example, add this in package Squit:
> >
> >      SquitBrowser>>defaultWindowColor
> >          ^ (Color r: 0.6 g: 0.7 b: 0.6)
> >


More information about the Squeak-dev mailing list