Amongst other aspects of trying out inboarding the sources (like a number of underscore assignments and block arguments being assigned to), the recompile threw up a long list (about 75!) of shadowed variable names.

Right now when a variable name is shadowed we only get a line appearing in the Transcript, which is alarmingly easy to miss. Given how many other alerts we get popping up for undeclared or unused variables, maybe we need to add one more for shadowing.

I'm slowly working down the following list, though one or two methods might well need more careful thought and consultation with the original author.



MenuMorph>>invokeModalAt:in:allowKeyboard: (originalFocusHolder is shadowed)
MenuMorph>>invokeAt:in:allowKeyboard: (originalFocusHolder is shadowed)
SketchEditorMorph>>initializeFor:inBounds:pasteUpMorph: (palette is shadowed)
BookMorph>>insertPageColored: (borderWidth is shadowed)
ObjectsTool>>highlightOnlySubmorph:in: (color is shadowed)
MCMethodDefinition>>printAnnotations:on: (timeStamp is shadowed)
PluggableListMorph>>getFilteredList (fullList is shadowed)
Parser>>collectTemporaryDeclarationsFrom: (mark is shadowed)
TextAnchorTest>>testResizeAnchoredMorph (anchoredMorph is shadowed)
SpaceTally>>spaceForInstance:depth:seen: (depth is shadowed)
BorderedMorph>>doFastWindowReframe: (owner is shadowed)
SoundService class>>defaultOrNil (default is shadowed)
MCClassDefinition>>createClass (traitComposition is shadowed)
ClassInspector>>streamSharedPoolsOn: (object is shadowed)
ClassInspector>>streamClassVariablesOn: (object is shadowed)
Project class>>makeANewLocalGallery (name is shadowed)
Project class>>cleanUpEtoysGarbage (name is shadowed)
ProcessTest>>testResumeTerminatingProcess (semaphore is shadowed)
ProcessTest>>testTerminateTerminatingProcess (semaphore is shadowed)
Context>>directedSuperSend:numArgs: (receiver is shadowed)
TestRunner>>findClassesForCategories: (environment is shadowed)
VariableNode>>variableGetterBlockIn: (index is shadowed)
ContextVariablesInspector>>streamTemporaryVariablesOn: (context is shadowed)
ContextVariablesInspector>>fieldAllTempVars (object is shadowed)
ContextInspector>>streamTemporaryVariablesOn: (context is shadowed)
ContextInspector>>streamStackVariablesOn: (object is shadowed)
TableLayoutTest>>testShrinkWrapIssue (container is shadowed)
TableLayoutTest>>testScrollPaneBarUpdate (container is shadowed)
BasicInspector>>fieldObjectClass (object is shadowed)
BasicInspector>>fieldObjectSize (object is shadowed)
BasicInspector>>streamIndexedVariablesOn: (object is shadowed)
TTFontFileHandle>>printOn: (filename is shadowed)
CompiledCodeInspector>>fieldHeader (object is shadowed)
CompiledCodeInspector>>fieldByteCodes (object is shadowed)
SqueakTheme class>>createDuller (name is shadowed)
Inspector>>streamError:on: (object is shadowed)
Inspector>>getContents (object is shadowed)
Inspector>>streamIndexedVariablesOn: (object is shadowed)
Inspector>>streamOn:truncate:collectFields: (object is shadowed)
Inspector>>valuePane (object is shadowed)
Inspector>>elementGetterAt: (object is shadowed)
SHTextStylerST80>>createTextAttributesForPixelHeight: (font is shadowed)
IndentingListItemMorph>>charactersOccluded (icon is shadowed)
FileList2 class>>endingSpecs (category is shadowed)
VersionsBrowser>>fileOutSelection (file is shadowed)
InspectorField class>>generateExpressionFrom:argumentNames: (name is shadowed)
FtpUrl>>retrieveContents (password is shadowed)
ClassBasedHelpTopic>>updateSubtopics (priority is shadowed)
LazyListMorph>>drawOn: (color is shadowed)
PluggableTreeMorph>>setSelectedPath: (setSelectedPathSelector is shadowed)
StringTest>>testFindLiteral (string is shadowed)
StringTest>>testFindSelector (string is shadowed)
StringTest>>testFindSymbol (string is shadowed)
SqueakMessageCategoriesHelp class>>addAllCategoriesTopicTo: (category is shadowed)
Ascii85ConverterTest>>testEncodeDecode (encoded is shadowed)
MVCMenuMorph>>invokeAt:in:allowKeyboard: (originalFocusHolder is shadowed)
HtmlEntityInspector>>fieldHtml (object is shadowed)
ReleaseBuilder class>>clearCaches (environment is shadowed)
ReleaseBuilder class>>cleanUpBitstreamVeraSans (name is shadowed)
ReleaseBuilder class>>checkForNilCategories (category is shadowed)
RxMatcher>>copy:replacingMatchesWith: (stream is shadowed)
Random>>next:into: (index is shadowed)
Random>>nextBytes:into:startingAt: (index is shadowed)
Random>>hashSeed: (index is shadowed)
PluggableMultiColumnListMorph>>selectionIndex: (listMorph is shadowed)
PluggableMultiColumnListMorph>>hoverRow: (listMorph is shadowed)
PluggableMultiColumnListMorph>>textColor: (listMorph is shadowed)
PluggableMultiColumnListMorph>>getFilteredList (fullList is shadowed)
PluggableMultiColumnListMorph>>rowAtLocation: (listMorph is shadowed)
PluggableMultiColumnListMorph>>updateColumns (listMorph is shadowed)
PluggableMultiColumnListMorph>>rowAboutToBecomeSelected: (listMorph is shadowed)
DockingBarMenuMorph>>popUpAdjacentTo:forHand:from: (owner is shadowed)
SystemWindow>>paneColorToUseWhenNotActive (color is shadowed)
CommunityTheme class>>createDark (name is shadowed)

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
"How many Kzin does it take to change a lightbulb?” 
"None. You can scream and leap in the dark."