[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] FilePlugin>>primitiveFileAtEnd for non-regular files (#232)

Eliot Miranda notifications at github.com
Tue Apr 3 13:38:12 UTC 2018


Hi Alistair,

> On Apr 3, 2018, at 4:19 AM, akgrant43 <notifications at github.com> wrote:
> 
> Hi Nicolas,
> 
> Thanks. I agree that this isn't simplifying the existing code, although I also think it isn't really adding complexity. It does result in an arguably correct response where before it was clearly incorrect.
> 
> Just for the record, the same incorrect behaviour currently exists in Squeak (#atEnd returns the wrong result for a non-regular file).
> 

Please add the gist of David's description of feof() to the code when you fix this.  That's extremely important information.  TIA
> Cheers,
> Alistair
> 
>> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/232#issuecomment-378252881
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180403/f28da5f6/attachment.html>


More information about the Vm-dev mailing list