[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] sqFileAtEnd() revert to previous error checking (#245)

akgrant43 notifications at github.com
Mon Apr 9 17:12:28 UTC 2018


sqFileAtEnd() hasn't done any error checking.  However adding it has
caused a report of primitive failures where previously none occurred.
No information is given about what the error is (errno isn't set), and
because no other functions are doing error checking we can't know how
far back the error occurred.
We can't limit error checking to this call because clearerr() clears not
only the error flag, but also the end-of-file flag.
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245

-- Commit Summary --

  * sqFileAtEnd() revert to previous error checking

-- File Changes --

    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c (36)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180409/544c2814/attachment.html>


More information about the Vm-dev mailing list