[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CONTRIBUTING.md: Add some style guidelines (#350)

Nicolas Cellier notifications at github.com
Sun Jan 6 10:57:28 UTC 2019


nicolas-cellier-aka-nice commented on this pull request.



> +
+C function declarations should have the type on one line and the 
+function name and parameters on the following line, e.g.:
+
+```
+static int 
+convertCopy(char *from, int fromLen, char *to, int toLen, int term)
+```
+
+This facilitates searching for function definitions by searching for the 
+name at the beginning of the line.
+
+
+## Tabs are 4 spaces
+
+The heading says it all.

A side note: the legacy platforms/win32 is using these settings:

8-space tabs stops
2-space indent

I don't want to create massive change of ownership for fixing that...
https://stackoverflow.com/questions/4112410/git-change-styling-whitespace-without-changing-ownership-blame

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/350#discussion_r245504143
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190106/61ca0328/attachment-0001.html>


More information about the Vm-dev mailing list