[Vm-dev] FloatMathPlugin: patch for squeak 4.19.2 fdlibm.h header

stes@PANDORA.BE stes at telenet.be
Sun Dec 13 17:56:18 UTC 2020


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


The #ifndef __LITTLE_ENDIAN only checks whether __LITTLE_ENDIAN is
NOT defined (ifndef=ifnotdefined).

Note that this is inside a code block that is #if defined(i386).

Basically they #define __LITTLE_ENDIAN in the common case of i386.

However this causes tons of warnings because at the cmake level,
__LITTLE_ENDIAN is already defined (on the C compiler command line).

So this patch is not breaking the big endian case (I may try SPARC someday), 
and also it does not break the x64 case.

Note that the cmake config file indicates a change was made to fix the x64,
which I think then had this unfortunate effect on the i386 case.

So if possible please apply the patch.

It fixes lots of warnings for me that looked quite suspicious to me ...

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJf1lWSAAoJEAwpOKXMq1Mae1gIAJu3x/immP3Jx7L6kqJRoopR
OQJQ3fltw9b37i7p1FSoZd3kdOZxe6oihREDZb6Ay8DegI0HFrGlyIib3HTKBCGU
DCPCSlw/5hFHhvhdzsjk++dqkq3XHPU9mSYPl9Wz6e4a3ceNBLxmoVCauHPZHiPu
PLLe5EDFgsMKIQtL62EU3ySXfGw60UgEHQpr/Q7l4SgNfHA3dTJjq7yoSdHBO/dr
xN9pqQQA500QeYdf8XPFrHQbonOn4iclDKEs+aDKFkumYRcKg57vLp3KiN2OwCIU
aMft14o4ISh0iK9uGe3oebdnTVNSkFb0fwQKYzEW1oOFCoYRm+ZCsNQF5UP2X5o=
=VNaO
-----END PGP SIGNATURE-----


More information about the Vm-dev mailing list