Squeak-dev February 2011

squeak-dev@lists.squeakfoundation.org

87 participants
295 discussions

The Inbox: Kernel-hsj.547.mcz
by commits＠source.squeak.org 16 Feb '11

16 Feb '11

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-hsj.547.mcz ==================== Summary ==================== Name: Kernel-hsj.547 Author: hsj Time: 16 February 2011, 1:45:07.199 pm UUID: 46e9ff86-8023-4720-a146-7eb8a2d2fb30 Ancestors: Kernel-fbs.546 Fixes inconsistency in return value of adoptInstance: on different VM's. =============== Diff against Kernel-fbs.546 =============== Item was changed: ----- Method: Behavior>>adoptInstance: (in category 'instance creation') ----- adoptInstance: anInstance "Change the class of anInstance to me. + Primitive (found in Cog and new VMs) follows the same rules as primitiveChangeClassTo:, but returns the class rather than the modified instance" - Primitive (only found in Cog) should follow the same rules as described in primitiveChangeClassTo:" <primitive: 160 error: ec> + anInstance primitiveChangeClassTo: self basicNew. + ^self! - ^anInstance primitiveChangeClassTo: self basicNew.!

1 0

The Trunk: Network-nice.107.mcz
by commits＠source.squeak.org 16 Feb '11

16 Feb '11

Nicolas Cellier uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-nice.107.mcz ==================== Summary ==================== Name: Network-nice.107 Author: nice Time: 16 February 2011, 1:50:18.09 am UUID: 57204c5b-6965-4865-b29e-f563894d6367 Ancestors: Network-nice.106 In the past I simplified MailMessage>>#readStringLineFrom: to just use generic Stream #nextLine utility. But it's nothing more than 1-message, 1-implementor, 1-sender so let it just be nothing. Anyway, when ones reach his quota of adding methods to Squeak, his next duty shall be removing old ones ;) Note that I bypassed deprecation, fingers crossed. =============== Diff against Network-nice.106 =============== Item was changed: ----- Method: MailMessage>>fieldsFrom:do: (in category 'parsing') ----- fieldsFrom: aStream do: aBlock "Invoke the given block with each of the header fields from the given stream. The block arguments are the field name and value. The streams position is left right after the empty line separating header and body." | savedLine line s | + savedLine := aStream nextLine. - savedLine := self readStringLineFrom: aStream. [aStream atEnd] whileFalse: [ line := savedLine. (line isEmpty) ifTrue: [^self]. "quit when we hit a blank line" + [savedLine := aStream nextLine. - [savedLine := self readStringLineFrom: aStream. (savedLine size > 0) and: [savedLine first isSeparator]] whileTrue: [ "lines starting with white space are continuation lines" s := ReadStream on: savedLine. s skipSeparators. line := line, ' ', s upToEnd]. self reportField: line withBlanksTrimmed to: aBlock]. "process final header line of a body-less message" (savedLine isEmpty) ifFalse: [self reportField: savedLine withBlanksTrimmed to: aBlock]. ! Item was removed: - ----- Method: MailMessage>>readStringLineFrom: (in category 'parsing') ----- - readStringLineFrom: aStream - "Read and answer the next line from the given stream. Consume the carriage return but do not append it to the string." - - ^aStream nextLine!

1 0

Daily Commit Log
by commits＠source.squeak.org 16 Feb '11

16 Feb '11

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2011-February/004287.h… Name: SystemReporter-laza.14 Ancestors: SystemReporter-laza.13 rename platform specific report methods ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004288.h… Name: SystemReporter-laza.15 Ancestors: SystemReporter-laza.14 catch the case where interpreterClass and cogitClass are not implemented ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004289.h… Name: SystemReporter-laza.16 Ancestors: SystemReporter-laza.15 - Created utility method to include text file contents safely - Made reportWin32VMConfig use above - Created reportLinuxOSDetails which shows the contents of '/etc/issue', '/etc/lsb-version' (and when it works '/proc/version') ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004290.h… Name: SystemReporter-laza.17 Ancestors: SystemReporter-laza.16 Change {} to #() ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004291.h… Name: Kernel-fbs.546 Ancestors: Kernel-nice.545 Allow one to declare a new class when one refers to the as-yet-undeclared class in a class-side method. (http://bugs.squeak.org/view.php?id=7606) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004292.h… Name: Traits-nice.287 Ancestors: Traits-nice.286 Implement convenient ClassTrait>>category just by symmetry with what we just did to Metaclass. We can now simplify senders of theNonMetaClass category by just category if we want to... ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004293.h… Name: Services-Base-nice.46 Ancestors: Services-Base-ar.45 theNonMetaclass category yourself.... I mean, any Metaclass shall now respondsTo: #category as well, so you don't have to tell her how to. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004294.h… Name: Tools-nice.298 Ancestors: Tools-nice.297 Let a Metaclass decide by herself to what category she belongs to. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-February/004295.h… Name: PackageInfo-Base-nice.53 Ancestors: PackageInfo-Base-cmm.52 A Metaclass now respondsTo: #category, so don't tell, just ask. =============================================

1 0

FtpUrl >> retrieveContents
by Nicolas Cellier 16 Feb '11

16 Feb '11

Several things I don't really understand 1) why a temp password is shadowing the inst. var. password 2) why a temp useName preempts the inst. var. username 3) why decoding authority incompletely while the job should have been performed by #privateInitializeFromText: already If it's the case, then the username@ has been removed from authority already (or it's too late for reading newtork code...) 4) why #privateInitializeFromText: decodes the username/password while #schemeName:authority:path:query: doesn't 5) why should 'SqueakUser' be hardcoded as 'anonymous' password in a generic FtpUrl (OK, OK, I've extrapolated the generic by myself) Shall the quality test be the understanding of code by a network-agnostic fool like me, that this method wouldn't pass the quality test. But maybe you have better metrics :) Nicolas

1 0

The Trunk: PackageInfo-Base-nice.53.mcz
by commits＠source.squeak.org 16 Feb '11

16 Feb '11

Nicolas Cellier uploaded a new version of PackageInfo-Base to project The Trunk: http://source.squeak.org/trunk/PackageInfo-Base-nice.53.mcz ==================== Summary ==================== Name: PackageInfo-Base-nice.53 Author: nice Time: 16 February 2011, 12:02:09.324 am UUID: 27c62178-0d9c-46ad-a2f2-a80b473740cb Ancestors: PackageInfo-Base-cmm.52 A Metaclass now respondsTo: #category, so don't tell, just ask. =============== Diff against PackageInfo-Base-cmm.52 =============== Item was changed: ----- Method: PackageInfo>>includesClass: (in category 'testing') ----- includesClass: aClass + ^ self includesSystemCategory: aClass category! - ^ self includesSystemCategory: aClass theNonMetaClass category!

1 0

The Trunk: Tools-nice.298.mcz
by commits＠source.squeak.org 15 Feb '11

15 Feb '11

Nicolas Cellier uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-nice.298.mcz ==================== Summary ==================== Name: Tools-nice.298 Author: nice Time: 15 February 2011, 11:59:03.132 pm UUID: a1dbba2a-1863-43f6-bc96-0d03c0d405d6 Ancestors: Tools-nice.297 Let a Metaclass decide by herself to what category she belongs to. =============== Diff against Tools-nice.297 =============== Item was changed: ----- Method: ChangeSorter>>annotationForPackageforSelector:ofClass: (in category 'annotation') ----- annotationForPackageforSelector: aSelector ofClass: aClass "Provide a line of content for an annotation pane, representing information about the given selector and class" "requestList" + | aCategory | + aClass ifNil: [ ^nil]. + aSelector ifNotNil: + [ aCategory := aClass organization categoryOfElement: aSelector. + (aCategory notNil and: [ aCategory first = $* ]) + ifTrue: [^ aCategory asString]] . - | aCategory | - aClass ifNil: [ ^nil] . - aSelector ifNil: [ aClass theNonMetaClass category asString ] . - aSelector ifNotNil: [ aCategory := aClass organization categoryOfElement: aSelector. - (aCategory notNil and: [ aCategory first = $* ]) - ifTrue: [^ aCategory asString]] . + "Ok. So the selector category does not indicate our package. We defer to the class category" + ^ aClass category asString. - "Ok. So the selector catagory does not indicate our package. We defer to the class catagory" - - ^ aClass theNonMetaClass category asString. !

1 0

The Trunk: Services-Base-nice.46.mcz
by commits＠source.squeak.org 15 Feb '11

15 Feb '11

Nicolas Cellier uploaded a new version of Services-Base to project The Trunk: http://source.squeak.org/trunk/Services-Base-nice.46.mcz ==================== Summary ==================== Name: Services-Base-nice.46 Author: nice Time: 15 February 2011, 11:55:54.067 pm UUID: 18874358-850a-4265-aae4-20c1e39d8feb Ancestors: Services-Base-ar.45 theNonMetaclass category yourself.... I mean, any Metaclass shall now respondsTo: #category as well, so you don't have to tell her how to. =============== Diff against Services-Base-ar.45 =============== Item was changed: ----- Method: BrowserRequestor>>getPackageForCategory (in category 'requests') ----- getPackageForCategory "answers a packageinfo for the current class category" + ^ PackageInfo named: self getClass category! - ^ PackageInfo named: self getClass theNonMetaClass category!

1 0

Re: [squeak-dev] The Inbox: Kernel-fbs.546.mcz
by Nicolas Cellier 15 Feb '11

15 Feb '11

I'm just wondering: does a Metaclass have a category ? on one hand, plenty of #category senders are protected with #theNonMetaClass and we could do the same on the other hand, we could just simplify lot of other code with this conveniency... Nicolas 2011/2/15 <commits(a)source.squeak.org>: > A new version of Kernel was added to project The Inbox: > http://source.squeak.org/inbox/Kernel-fbs.546.mcz > > ==================== Summary ==================== > > Name: Kernel-fbs.546 > Author: fbs > Time: 15 February 2011, 4:04:05.286 pm > UUID: 89f8153f-e938-c742-9f8b-002d8e55612c > Ancestors: Kernel-nice.545 > > Allow one to declare a new class when one refers to the as-yet-undeclared class in a class-side method. > > (http://bugs.squeak.org/view.php?id=7606) > > =============== Diff against Kernel-nice.545 =============== > > Item was added: > + ----- Method: Metaclass>>category (in category 'organization') ----- > + category > + ^ thisClass category! > > >

2 5

The Trunk: Traits-nice.287.mcz
by commits＠source.squeak.org 15 Feb '11

15 Feb '11

Nicolas Cellier uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-nice.287.mcz ==================== Summary ==================== Name: Traits-nice.287 Author: nice Time: 15 February 2011, 11:26:11.772 pm UUID: 6bcfef1a-0838-46e8-b148-b273f6a1ec78 Ancestors: Traits-nice.286 Implement convenient ClassTrait>>category just by symmetry with what we just did to Metaclass. We can now simplify senders of theNonMetaClass category by just category if we want to... =============== Diff against Traits-nice.286 =============== Item was added: + ----- Method: ClassTrait>>category (in category 'accessing') ----- + category + "Answer the category used for classifying this ClassTrait. + The category is shared between a Trait and its associated ClassTrait." + + ^baseTrait category!

1 0

The Trunk: Kernel-fbs.546.mcz
by commits＠source.squeak.org 15 Feb '11

15 Feb '11

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fbs.546.mcz ==================== Summary ==================== Name: Kernel-fbs.546 Author: fbs Time: 15 February 2011, 4:04:05.286 pm UUID: 89f8153f-e938-c742-9f8b-002d8e55612c Ancestors: Kernel-nice.545 Allow one to declare a new class when one refers to the as-yet-undeclared class in a class-side method. (http://bugs.squeak.org/view.php?id=7606) =============== Diff against Kernel-nice.545 =============== Item was added: + ----- Method: Metaclass>>category (in category 'organization') ----- + category + ^ thisClass category!

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
30
Older →

Jump to page: