Squeak-dev February 2011

squeak-dev@lists.squeakfoundation.org

87 participants
295 discussions

Re: [squeak-dev] add repositories to Monticello by script?
by Bernardo Ezequiel Contreras 21 Feb '11

21 Feb '11

i used to do this | myRepo myRepoDir | myRepoDir := FileDirectory on:'/home/vonbecmann/repo'. myRepo := MCDirectoryRepository new directory: myRepoDir. MCRepositoryGroup default addRepository: myRepo. in order to add my directory repository. Regards On Sun, Feb 20, 2011 at 5:50 PM, Ken G. Brown <kbrown(a)mac.com> wrote: > Is there a way to add repositories to Monticello by script so you don't > have to use the +Repository button multiple times? > > Thx for any tips. > Ken G. Brown > >

2 1

FFI issue in Squeak 4.2 ?
by mkobetic＠gmail.com 21 Feb '11

21 Feb '11

I'm struggling to load Xtreams-Xtras into the new release of Squeak. I sprinkled all the classes with allowUnderscoreSelectors (true) and allowUnderscoreAssignments (false), made sure I don't have any underscores on class side, made sure none of the classes have underscores in their names, but it still seems that unless i explicitly turn off allowUnderscoreAssignments in global preferences it won't compile the instance side methods with underscore selectors. Then even when I get past it with the help of the global preference, I still get the following syntax error which doesn't make any sense to me: HMAC_CTX_cleanup: ctx <cdecl: void 'HMAC_CTX_cleanup' (HMACCTX*Matching number of arguments expected ->) module: 'libcrypto'> ^self externalCallFailed HMACCTX is a subclass of ExternalStructure. This all seems to be fine on Pharo side and I would swear I could load it into an earlier Squeak version, but I don't remember the details anymore. I even made sure I'm using the exact same versions of FFI packages as I do in Pharo (the configuration from MetacelloRepository that I normally load in Pharo doesn't seem to be quite up to date), but that didn't help either. Any suggestions ? How should one go about writing portable FFI code (I mean portable between Pharo and Squeak)? Any chance that FFI support would be in the base image one day so that one didn't have to worry about where to get it and which one ? Thanks, Martin

2 1

Re: [squeak-dev] The Trunk: Compiler-nice.192.mcz
by Levente Uzonyi 21 Feb '11

21 Feb '11

On Sun, 20 Feb 2011, commits(a)source.squeak.org wrote: > Nicolas Cellier uploaded a new version of Compiler to project The Trunk: > http://source.squeak.org/trunk/Compiler-nice.192.mcz > > ==================== Summary ==================== > > Name: Compiler-nice.192 > Author: nice > Time: 20 February 2011, 5:12:00.371 pm > UUID: 3be37582-d3a2-4825-8210-073dd0af3f61 > Ancestors: Compiler-ul.191 > > Let #caseOf: accept any ParseNode argument, not just BraceNode and VariableNode. > Remove usage of canBeSpecialArgument which is now unsent. You were a bit faster again, so I pushed my version to the Inbox. Should we deprecate #canBeSpecialArgument implementations? Levente > > =============== Diff against Compiler-ul.191 =============== > > Item was changed: > ----- Method: MessageNode>>checkBlock:as:from:maxArgs: (in category 'private') ----- > checkBlock: node as: nodeName from: encoder maxArgs: maxArgs > + "Answer true if node is a BlockNode with at most maxArgs arguments. > + This check is required in order to inline some special messages. > + Notify some undue usage of these special messages." > - "vb: #canBeSpecialArgument for blocks hardcodes 0 arguments as the requirement for special blocks. We work around that here by further checking the number of arguments for blocks.." > > + node isBlockNode > - node canBeSpecialArgument ifTrue: > - [^node isBlockNode]. > - ^node isBlockNode > ifTrue: > [node numberOfArguments <= maxArgs > + ifTrue: [^true] > - ifTrue: [true] > ifFalse: [encoder notify: '<- ', nodeName , ' of ' , > + (MacroSelectors at: special) , ' has too many arguments']]. > + ^false! > - (MacroSelectors at: special) , ' has too many arguments']] > - ifFalse: > - [false]! > > Item was changed: > ----- Method: MessageNode>>transformCase: (in category 'macro transformations') ----- > transformCase: encoder > > | caseNode | > caseNode := arguments first. > (caseNode isMemberOf: BraceNode) ifTrue: > [((caseNode blockAssociationCheck: encoder) > and: [arguments size = 1 > or: [self checkBlock: arguments last as: 'otherwise arg' from: encoder]]) ifFalse: > [^false]. > caseNode elements do: > [:messageNode| > messageNode receiver noteOptimizedIn: self. > messageNode arguments first noteOptimizedIn: self]. > arguments size = 2 ifTrue: > [arguments last noteOptimizedIn: self]. > ^true]. > + ^false! > - (caseNode canBeSpecialArgument and: [(caseNode isMemberOf: BlockNode) not]) ifTrue: > - [^false]. "caseOf: variable" > - ^encoder notify: 'caseOf: argument must be a brace construct or a variable'! > > >

2 2

Daily Commit Log
by commits＠source.squeak.org 21 Feb '11

21 Feb '11

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2011-February/004300.h… Name: Compiler-nice.192 Ancestors: Compiler-ul.191 Let #caseOf: accept any ParseNode argument, not just BraceNode and VariableNode. Remove usage of canBeSpecialArgument which is now unsent. =============================================

1 0

Re: [squeak-dev] add repositories to Monticello by script?
by Chris Muller 21 Feb '11

21 Feb '11

Hi Ken. Pretty much anything can be done "by script" in Smalltalk. The +Repository button just executes a chunk of Smalltalk code. Here's how I answer this sort of question. Just type the text ("+Repository") of the menu item or button you want in to any workspace, then press Command+Shift+e. This shows all methods with a literal string containing that as a sub-string. >From there you can trace the code of how repositories are added to the list. I recommend turning on "traceMessages" preference to make this and overall Smalltalk development much easier. HTH, Chris On Sun, Feb 20, 2011 at 2:50 PM, Ken G. Brown <kbrown(a)mac.com> wrote: > Is there a way to add repositories to Monticello by script so you don't have to use the +Repository button multiple times? > > Thx for any tips. > Ken G. Brown > >

1 0

MessageNodes are modified when printed
by Levente Uzonyi 20 Feb '11

20 Feb '11

Hi, I was looking for loop patterns that can be rewritten to use #repeat:, because it became an inlined message (thanks Nicolas). I decided to use ParseNodeEnumerator, the swiss army knife, suitable for these kind of tasks. As a first step I tried to find method with the following pattern: [ ... true ] whileTrue. To my surprise, my code didn't find any methods with it. Since I knew that there are methods with this pattern, I created the following "test case" which shows the problem: | shouldSelect visitor | shouldSelect := false. visitor := ParseNodeEnumerator ofBlock: [ :node | shouldSelect := shouldSelect or: [ node isMessageNode and: [ node selector key == #whileTrue and: [ node receiver isBlockNode and: [ node receiver statements last isVariableNode and: [ node receiver statements last key = 'true' ] ] ] ] ] ]. shouldSelect := false. [ [ true ] whileTrue ] decompile accept: visitor. shouldSelect. It should return true, but it returns false. What's even worse is that if you insert a #halt, like in the following example and press proceed when the debugger shows up, then the result will be true. ... node isMessageNode and: [ self halt. node selector key == #whileTrue and: [ ... The cause of the problem is that the decompiler creates the MessageNode with #whileTrue: as selector instead of #whileTrue, but MessageNode >> #printWhileOn:indent: or MessageNode >> #printWithClosureAnalysisWhileOn:indent: replaces the selector to #whileTrue. Since the debugger triggers one of these methods, the code will pass in the second case (#halt). The same happens if you open an explorer on the MessageNode. Shouldn't the change be done by the decompiler, instead of some method used for printing? Cheers, Levente P.S.: I finished the script and rewrote most methods with these patterns in the Trunk. I'll push them soon. Here's the final snippet in case you would like to check your own code: | shouldSelect | shouldSelect := false. visitor := ParseNodeEnumerator ofBlock: [ :node | shouldSelect := shouldSelect or: [ node isMessageNode and: [ (#(whileTrue whileTrue: whileFalse whileFalse:) instVarsInclude: node selector key) and: [ | receiver | (receiver := node receiver) isBlockNode and: [ | lastStatement | (lastStatement := receiver statements last) isVariableNode and: [ #('true' 'false') includes: lastStatement key ] ] ] ] ] ]. SystemNavigation default browseAllSelect: [ :method | shouldSelect := false. method decompile accept: visitor. shouldSelect ]

2 1

add repositories to Monticello by script?
by Ken G. Brown 20 Feb '11

20 Feb '11

Is there a way to add repositories to Monticello by script so you don't have to use the +Repository button multiple times? Thx for any tips. Ken G. Brown

1 0

The Inbox: Compiler-ul.193.mcz
by commits＠source.squeak.org 20 Feb '11

20 Feb '11

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-ul.193.mcz ==================== Summary ==================== Name: Compiler-ul.193 Author: ul Time: 20 February 2011, 5:23:51.585 pm UUID: 59f8e102-e41a-7547-abe7-a210bcbe4b74 Ancestors: Compiler-nice.192 - simplified MessageNode >> #checkBlock:as:from:maxArgs: and MessageNode >> #transformCase: - deprecated all implementors of #canBeSpecialArgument, because it has no senders =============== Diff against Compiler-nice.192 =============== Item was changed: ----- Method: BlockNode>>canBeSpecialArgument (in category 'testing') ----- canBeSpecialArgument "Can I be an argument of (e.g.) ifTrue:?" + self deprecated: 'Anything can be argument of inlined messages'. ^arguments size = 0! Item was changed: ----- Method: MessageNode>>checkBlock:as:from:maxArgs: (in category 'private') ----- checkBlock: node as: nodeName from: encoder maxArgs: maxArgs "Answer true if node is a BlockNode with at most maxArgs arguments. This check is required in order to inline some special messages. Notify some undue usage of these special messages." + node isBlockNode ifFalse: [ ^false ]. + node numberOfArguments <= maxArgs ifTrue: [ ^true ]. + ^encoder notify: '<- ', nodeName , ' of ' , (MacroSelectors at: special) , ' has too many arguments'! - node isBlockNode - ifTrue: - [node numberOfArguments <= maxArgs - ifTrue: [^true] - ifFalse: [encoder notify: '<- ', nodeName , ' of ' , - (MacroSelectors at: special) , ' has too many arguments']]. - ^false! Item was changed: ----- Method: MessageNode>>transformCase: (in category 'macro transformations') ----- transformCase: encoder | caseNode | caseNode := arguments first. + (caseNode isMemberOf: BraceNode) ifFalse: [ ^false ]. + ((caseNode blockAssociationCheck: encoder) + and: [arguments size = 1 + or: [self checkBlock: arguments last as: 'otherwise arg' from: encoder]]) ifFalse: + [^false]. + caseNode elements do: + [:messageNode| + messageNode receiver noteOptimizedIn: self. + messageNode arguments first noteOptimizedIn: self]. + arguments size = 2 ifTrue: + [arguments last noteOptimizedIn: self]. + ^true! - (caseNode isMemberOf: BraceNode) ifTrue: - [((caseNode blockAssociationCheck: encoder) - and: [arguments size = 1 - or: [self checkBlock: arguments last as: 'otherwise arg' from: encoder]]) ifFalse: - [^false]. - caseNode elements do: - [:messageNode| - messageNode receiver noteOptimizedIn: self. - messageNode arguments first noteOptimizedIn: self]. - arguments size = 2 ifTrue: - [arguments last noteOptimizedIn: self]. - ^true]. - ^false! Item was changed: ----- Method: ParseNode>>canBeSpecialArgument (in category 'testing') ----- canBeSpecialArgument "Can I be an argument of (e.g.) ifTrue:?" + self deprecated: 'Anything can be argument of inlined messages'. ^false! Item was changed: ----- Method: VariableNode>>canBeSpecialArgument (in category 'testing') ----- canBeSpecialArgument "Can I be an argument of (e.g.) ifTrue:?" + self deprecated: 'Anything can be argument of inlined messages'. ^code < LdNil!

1 0

Re: [squeak-dev] The Trunk: Compiler-ul.191.mcz
by Nicolas Cellier 20 Feb '11

20 Feb '11

Most probably my mistake because I played with simplifying handling of #caseOf:, allowing arbitrary arguments. Apologizes. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2011-February/157222… Current Compiler only accepts a BraceNode and a VariableNode but not a MessageNode, an AssignmentNode or any other ValueNode. IMO, this limitation is arbitrary. Compiler shall accept any form, send the message without inlining if not a Block and let execution raise an Error in caseOf: invalid argument Anyway, testing for code < LdNil is somehow deficient (try 'false caseOf: true'), the comment is a bit misleading. Would #caseOf: be simplified that canBeSpecialArgument could be eliminated and replaced by isBlockNode + numArg check. I guess that complexifying the Compiler was intended to help the user guessing correct usage of #caseOf:... Then one probably did need to pass a VariableNode one day and put a Compiler hack. Maybe another guru needing to pass the result of concatenating two arrays, will put another one MessageNode>>canBeSpecialArgument ^selector == #',' Unless the next best thing to do would be to remove some intentions from Compiler and just let it compile dumbly. I think I'll finish the work. Nicolas 2011/2/19 <commits(a)source.squeak.org>: > Levente Uzonyi uploaded a new version of Compiler to project The Trunk: > http://source.squeak.org/trunk/Compiler-ul.191.mcz > > ==================== Summary ==================== > > Name: Compiler-ul.191 > Author: ul > Time: 19 February 2011, 10:02:37.736 pm > UUID: a7628e80-ae41-e348-b9b0-6b5f475cd90b > Ancestors: Compiler-ul.190 > > Restored VariableNode >> #canBeSpecialArgument, which got lost with Compiler-nice.188 for some unknown reason. It is required to compile #caseOf: with non-brace array arguments. > > =============== Diff against Compiler-ul.190 =============== > > Item was added: > + ----- Method: VariableNode>>canBeSpecialArgument (in category 'testing') ----- > + canBeSpecialArgument > + "Can I be an argument of (e.g.) ifTrue:?" > + > + ^code < LdNil! > > >

2 1

The Trunk: Compiler-nice.192.mcz
by commits＠source.squeak.org 20 Feb '11

20 Feb '11

Nicolas Cellier uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-nice.192.mcz ==================== Summary ==================== Name: Compiler-nice.192 Author: nice Time: 20 February 2011, 5:12:00.371 pm UUID: 3be37582-d3a2-4825-8210-073dd0af3f61 Ancestors: Compiler-ul.191 Let #caseOf: accept any ParseNode argument, not just BraceNode and VariableNode. Remove usage of canBeSpecialArgument which is now unsent. =============== Diff against Compiler-ul.191 =============== Item was changed: ----- Method: MessageNode>>checkBlock:as:from:maxArgs: (in category 'private') ----- checkBlock: node as: nodeName from: encoder maxArgs: maxArgs + "Answer true if node is a BlockNode with at most maxArgs arguments. + This check is required in order to inline some special messages. + Notify some undue usage of these special messages." - "vb: #canBeSpecialArgument for blocks hardcodes 0 arguments as the requirement for special blocks. We work around that here by further checking the number of arguments for blocks.." + node isBlockNode - node canBeSpecialArgument ifTrue: - [^node isBlockNode]. - ^node isBlockNode ifTrue: [node numberOfArguments <= maxArgs + ifTrue: [^true] - ifTrue: [true] ifFalse: [encoder notify: '<- ', nodeName , ' of ' , + (MacroSelectors at: special) , ' has too many arguments']]. + ^false! - (MacroSelectors at: special) , ' has too many arguments']] - ifFalse: - [false]! Item was changed: ----- Method: MessageNode>>transformCase: (in category 'macro transformations') ----- transformCase: encoder | caseNode | caseNode := arguments first. (caseNode isMemberOf: BraceNode) ifTrue: [((caseNode blockAssociationCheck: encoder) and: [arguments size = 1 or: [self checkBlock: arguments last as: 'otherwise arg' from: encoder]]) ifFalse: [^false]. caseNode elements do: [:messageNode| messageNode receiver noteOptimizedIn: self. messageNode arguments first noteOptimizedIn: self]. arguments size = 2 ifTrue: [arguments last noteOptimizedIn: self]. ^true]. + ^false! - (caseNode canBeSpecialArgument and: [(caseNode isMemberOf: BlockNode) not]) ifTrue: - [^false]. "caseOf: variable" - ^encoder notify: 'caseOf: argument must be a brace construct or a variable'!

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
30
Older →

Jump to page: