Squeak-dev May 2013

squeak-dev@lists.squeakfoundation.org

59 participants
334 discussions

DictionaryIntegrityTest >> #testDictionaries failure
by Frank Shearar 24 May '13

24 May '13

This test fails because, as far as I can tell, SystemChangeFileTest >> #testClassRenamed breaks the integrity of an IdentityDictionary. This IdentityDictionary (call it dict) reports having a key in #keysAndValuesDo: such that dict at: key raises a KeyNotFound. Inspecting dict verifies this weirdness, even though you can see the key in the inspector's right hand pane. Ideas? The diff in the manifests between the last version where this test didn't fail and where it did looks like this: $ diff /home/frank/Downloads/TrunkImage.313.manifest /home/frank/Downloads/TrunkImage.314.manifest 22c22 < Monticello (bf.541) --- > Monticello (bf.542) 26c26 < MorphicTests (ar.18) --- > MorphicTests (fbs.20) 49c49 < Tests (fbs.207) --- > * Tests (fbs.212) 62,63d61 Not terribly enlightening... frank

3 9

Cmd-0 discussion (not for voting)
by Chris Muller 24 May '13

24 May '13

> And just for a nit - lines can have all kinds of attributes besides > colour - thickness (i.e. bold), solid/dotted (i.e. italic), wavy (i.e. > font face), tapered (i.e. slant), etc. I really don't think colour > should be considered a special attribute just because it can apply to > things besides text. > > Of course, but we're not voting about those semantics. We're voting about the *degree of control* we want to have via the UI's input capability. Your vote advocates that, for one case, the radiance-adjusting controls should be commingled with the shape-adjusting controls.

1 0

Forgetting classes in an Environment
by Frank Shearar 24 May '13

24 May '13

http://build.squeak.org/job/SqueakTrunk/338/testReport/KernelTests.Methods/… shows a test failure because the test asserts that a CompiledMethod can still reference its class after a class has been removed. However, Environments-cwp.25 explicitly nils out the value of the ClassBinding in the Environment's undeclared. If this is correct behaviour, then CompiledMethod needs adjusting. #methodClass assumes that it can look up this binding, whether Undeclared or not, by inspecting its literals. frank

1 0

Daily Commit Log
by commits＠source.squeak.org 24 May '13

24 May '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-May/005979.html Name: GetText-fbs.33 Ancestors: GetText-fbs.32 Update GetText to use UIManager default instead of FillInTheBlank. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-May/005980.html Name: Multilingual-nice.160 Ancestors: Multilingual-tpr.159 Let MC encode source in UTF-8 STEP 1: create an InvalidUTF8 Error which we can later recover from for handling legacy non UTF-8 source =============================================

1 0

Re: [squeak-dev] The Trunk: Multilingual-nice.160.mcz
by Nicolas Cellier 23 May '13

23 May '13

This rather was for inbox, but it should be both harmless and useful in trunk 2013/5/23 <commits(a)source.squeak.org> > Nicolas Cellier uploaded a new version of Multilingual to project The > Trunk: > http://source.squeak.org/trunk/Multilingual-nice.160.mcz > > ==================== Summary ==================== > > Name: Multilingual-nice.160 > Author: nice > Time: 23 May 2013, 10:56:03.76 pm > UUID: 8b1dfd64-8d3c-414d-9431-8a6c93a02b26 > Ancestors: Multilingual-tpr.159 > > Let MC encode source in UTF-8 > STEP 1: create an InvalidUTF8 Error which we can later recover from for > handling legacy non UTF-8 source > > =============== Diff against Multilingual-tpr.159 =============== > > Item was added: > + Error subclass: #InvalidUTF8 > + instanceVariableNames: 'string' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'Multilingual-TextConversion'! > + > + !InvalidUTF8 commentStamp: 'nice 5/23/2013 22:43' prior: 0! > + An InvalidUTF8 is an Exception that is raised when attempting to decode > an invalid UTF-8 Sequence > + > + Instance Variables > + string: <String> > + > + string > + - the string that were decoded > + ! > > Item was added: > + ----- Method: InvalidUTF8>>isResumable (in category 'private') ----- > + isResumable > + ^true! > > Item was added: > + ----- Method: InvalidUTF8>>messageText (in category 'private') ----- > + messageText > + "Return a textual description of the exception." > + ^messageText ifNil: [string > + ifNil: ['Invalid UTF8'] > + ifNotNil: ['Invalid utf8: ', string]]! > > Item was added: > + ----- Method: InvalidUTF8>>string: (in category 'private') ----- > + string: aString > + string := aString! > > Item was changed: > ----- Method: UTF8TextConverter class>>errorMalformedInput: (in category > 'utilities') ----- > errorMalformedInput: aString > "Invalid UTF-8 input has been detected in the given string. > Raise an error if strict conversions are enabled, otherwise allow > the original string to be returned." > > self strictUtf8Conversions ifTrue:[ > + (InvalidUTF8 new string: aString) signal. > - self error: 'Invalid utf8: ', aString > ]. > > ^aString! > > >

2 1

The Inbox: System-nice.539.mcz
by commits＠source.squeak.org 23 May '13

23 May '13

Nicolas Cellier uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-nice.539.mcz ==================== Summary ==================== Name: System-nice.539 Author: nice Time: 23 May 2013, 11:03:57.126 pm UUID: 3e2a5ca7-1e7b-439a-a025-3460fc8b2a24 Ancestors: System-fbs.538 Name: Monticello-nice.545 Author: nice Time: 23 May 2013, 11:00:14.509 pm UUID: 83c3e004-45ee-4976-b80e-de52f74691c5 Ancestors: Monticello-fbs.544 Let MC encode source in UTF-8 STEP 3: let MczInstaller decode. Legacy code is handled in InvalidUTF8 exception handling. =============== Diff against System-fbs.538 =============== Item was changed: ----- Method: MczInstaller>>installMember: (in category 'installation') ----- installMember: member self useNewChangeSetDuring: + [[ | str | str := member contentStream text. + str converter: UTF8TextConverter new. + str fileInAnnouncing: 'loading ', member fileName] on: InvalidUTF8 do: + [:exc | + "Retry without UTF8 Converter" + | str | str := member contentStream text. + str fileInAnnouncing: 'loading ', member fileName]]! - [ | str |str := member contentStream text. - str setConverterForCode. - str fileInAnnouncing: 'loading ', member fileName]!

1 0

The Inbox: Monticello-nice.545.mcz
by commits＠source.squeak.org 23 May '13

23 May '13

Nicolas Cellier uploaded a new version of Monticello to project The Inbox: http://source.squeak.org/inbox/Monticello-nice.545.mcz ==================== Summary ==================== Name: Monticello-nice.545 Author: nice Time: 23 May 2013, 11:00:14.509 pm UUID: 83c3e004-45ee-4976-b80e-de52f74691c5 Ancestors: Monticello-fbs.544 Let MC encode source in UTF-8 STEP 2: let MCStWriter encode and MCStReader decode. Note 1: no BOM is used in this version, and legacy code is handled in InvalidUTF8 exception handling. Note 2: MCStReader is not used. =============== Diff against Monticello-fbs.544 =============== Item was changed: ----- Method: MCMczWriter>>serializeDefinitions: (in category 'serializing') ----- serializeDefinitions: aCollection | writer s | + s := String new writeStream. - s := RWBinaryOrTextStream on: String new. writer := self snapshotWriterClass on: s. writer writeDefinitions: aCollection. ^ s contents! Item was changed: ----- Method: MCStReader>>readStream (in category 'evaluating') ----- readStream + | contents | + contents := stream contents. ^ ('!!!! + ', ([contents utf8ToSqueak] on: InvalidUTF8 do: [:exc | exc return: contents])) readStream! - ', stream contents) readStream! Item was changed: ----- Method: MCStWriter>>writeDefinitions: (in category 'writing') ----- writeDefinitions: aCollection "initStream is an ugly hack until we have proper init defs" initStream := String new writeStream. (MCDependencySorter sortItems: aCollection) do: [:ea | ea accept: self] displayingProgress: 'Writing definitions...'. + stream nextPutAll: initStream contents squeakToUtf8.! - stream nextPutAll: initStream contents.!

1 0

The Trunk: Multilingual-nice.160.mcz
by commits＠source.squeak.org 23 May '13

23 May '13

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.160.mcz ==================== Summary ==================== Name: Multilingual-nice.160 Author: nice Time: 23 May 2013, 10:56:03.76 pm UUID: 8b1dfd64-8d3c-414d-9431-8a6c93a02b26 Ancestors: Multilingual-tpr.159 Let MC encode source in UTF-8 STEP 1: create an InvalidUTF8 Error which we can later recover from for handling legacy non UTF-8 source =============== Diff against Multilingual-tpr.159 =============== Item was added: + Error subclass: #InvalidUTF8 + instanceVariableNames: 'string' + classVariableNames: '' + poolDictionaries: '' + category: 'Multilingual-TextConversion'! + + !InvalidUTF8 commentStamp: 'nice 5/23/2013 22:43' prior: 0! + An InvalidUTF8 is an Exception that is raised when attempting to decode an invalid UTF-8 Sequence + + Instance Variables + string: <String> + + string + - the string that were decoded + ! Item was added: + ----- Method: InvalidUTF8>>isResumable (in category 'private') ----- + isResumable + ^true! Item was added: + ----- Method: InvalidUTF8>>messageText (in category 'private') ----- + messageText + "Return a textual description of the exception." + ^messageText ifNil: [string + ifNil: ['Invalid UTF8'] + ifNotNil: ['Invalid utf8: ', string]]! Item was added: + ----- Method: InvalidUTF8>>string: (in category 'private') ----- + string: aString + string := aString! Item was changed: ----- Method: UTF8TextConverter class>>errorMalformedInput: (in category 'utilities') ----- errorMalformedInput: aString "Invalid UTF-8 input has been detected in the given string. Raise an error if strict conversions are enabled, otherwise allow the original string to be returned." self strictUtf8Conversions ifTrue:[ + (InvalidUTF8 new string: aString) signal. - self error: 'Invalid utf8: ', aString ]. ^aString!

1 0

The Inbox: Kernel-fbs.760.mcz
by commits＠source.squeak.org 23 May '13

23 May '13

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-fbs.760.mcz ==================== Summary ==================== Name: Kernel-fbs.760 Author: fbs Time: 23 May 2013, 8:48:40.24 pm UUID: 75bf5248-3ed6-4176-a46a-810b486a0ac4 Ancestors: Kernel-fbs.759 Object >> #localeChanged moved to System-Localization because it's a localisation thing, and because I'd rather have System depend on Kernel than Kernel depend on System. =============== Diff against Kernel-fbs.759 =============== Item was changed: ----- Method: Class class>>rootsOfTheWorld (in category 'inquiries') ----- rootsOfTheWorld "return a collection of classes which have a nil superclass" + ^(Smalltalk globals select: [:each | each isBehavior and: [each superclass isNil]]) asOrderedCollection! - ^ Smalltalk globals rootClasses! Item was changed: ----- Method: Class>>rename: (in category 'class name') ----- rename: aString "The new name of the receiver is the argument, aString." | oldName newName | (newName := aString asSymbol) = (oldName := self name) ifTrue: [^ self]. (self environment includesKey: newName) ifTrue: [^ self error: newName , ' already exists']. (environment undeclared includesKey: newName) + ifTrue: [self inform: 'There are references to ' , aString printString , ' - ifTrue: [self inform: 'There are references to, ' , aString printString , ' from Undeclared. Check them after this change.']. name := newName. self environment renameClass: self from: oldName! Item was removed: - ----- Method: Object>>localeChanged (in category 'locales') ----- - localeChanged - self shouldBeImplemented!

1 0

The Inbox: System-fbs.539.mcz
by commits＠source.squeak.org 23 May '13

23 May '13

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-fbs.539.mcz ==================== Summary ==================== Name: System-fbs.539 Author: fbs Time: 23 May 2013, 8:47:52.922 pm UUID: 7e9cd549-a808-4169-886c-144b7757e25b Ancestors: System-fbs.538 PartsBin and friends already have #localeChanged implementations. I don't know if "self class environment" is the right thing here. I don't want to use Smalltalk globals. Perhaps the right thing is to say "self environment" where #environment may be set, or defaults to Smalltalk globals. Object >> #localeChanged moved here because it's a localisation thing, and because I'd rather have System depend on Kernel than Kernel depend on System. =============== Diff against System-fbs.538 =============== Item was changed: ----- Method: Locale class>>localeChanged (in category 'notification') ----- localeChanged + self class environment allBehaviorsDo: [:b | b localeChanged].! - - #(#ParagraphEditor #BitEditor #FormEditor #StandardSystemController ) - do: [:key | Smalltalk - at: key - ifPresent: [:class | class initialize]]. - PartsBin localeChanged. - Project localeChanged. - PaintBoxMorph localeChanged. - ColorPickerMorph localeChanged. - Preferences localeChanged! Item was changed: ----- Method: Locale class>>localeChangedGently (in category 'notification') ----- localeChangedGently + self class environment allBehaviorsDo: [:b | b localeChangedGently].! - - #(#ParagraphEditor #BitEditor #FormEditor #StandardSystemController ) - do: [:key | Smalltalk - at: key - ifPresent: [:class | class initialize]]. - PartsBin localeChangedGently. - Project localeChangedGently. - PaintBoxMorph localeChangedGently. - ColorPickerMorph localeChangedGently. - Preferences localeChangedGently. - ! Item was added: + ----- Method: Object>>localeChanged (in category '*System-Localization-locales') ----- + localeChanged + self shouldBeImplemented! Item was added: + ----- Method: Object>>localeChangedGently (in category '*System-Localization-locales') ----- + localeChangedGently + self localeChanged.!

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
34
Older →

Jump to page: