Squeak-dev May 2013

squeak-dev@lists.squeakfoundation.org

59 participants
334 discussions

Daily Commit Log
by commits＠source.squeak.org 26 May '13

26 May '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-May/005983.html Name: Files-cmm.120 Ancestors: Files-cmm.119 - Add efficient directory-tree enumeration capability to FileDirectory. - Make #asBytesDescription more terse, and sans any decimal points. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-May/005984.html Name: Files-cmm.121 Ancestors: Files-cmm.120 - Correct version of asBytesDescription. =============================================

1 0

Re: [squeak-dev] what is Smalltalk?
by Casimiro de Almeida Barreto 26 May '13

26 May '13

On 19-05-2013 17:36, Jecel Assumpcao Jr. wrote: > Frank, > >> Well, OK. It depends on what exactly you mean by "Smalltalk". If you >> mean Smalltalk-80, then definitely not. If you mean ANSI Smalltalk, >> then probably not. I don't see much value in sticking to "standards" >> 15 years and older. > While to many people "Smalltalk" is the same as "Smalltalk-80", I prefer > a definition what includes Smalltalk-72 as a Smalltalk. Any such > definition would most certainly include Self and Slate as Smalltalks > too. > > Sort of like the confusion about "Free Software", I got tired of > explaining my viewpoint regarding my Self/R design and simply renamed it > to Neo Smalltalk instead. > > I do note that none of the various SqueakFests were about Squeak but > rather about Etoys. So I agree that "Squeak Smalltalk" (which happens to > be the term I use in all my papers) makes exactly what we are talking > about very clear without restricting any future options. > > There was a time when the term "Smalltalk" caused very negative > reactions and several projects tried to distance themselves from it. But > that was when Java was new and needed agressive marketing. I feel that > the current situation is entirely different. > > -- Jecel > > > I tend to agree with Frank about adherence to old standards & with all arguments presented by Jecel. One fact about smalltalk is that it was plagued by fragmentation. The lack of a mainstream favored the appearance of several "smalltalk idioms" that quite don't talk among themselves. That reduced applicability and made disrupting advancements hard to achieve. So, currently we have some commercial idioms that are simply too proprietary & expensive for general use and some free software implementations that are becoming too widely fragmented to allow coherent evolution. Squeak is a really great platform. But currently is supported by a small community and important issues just cannot be covered. After the schism, at least two other versions of "baby squeaks" appeared. One is dealt by a single developer. I hope him the best luck in the world. The other is supported by some academic researchers that decided to reinvent the wheel while designing the next thing in OOL and the result is something that is just not stable and consistent in one hand and don't touch important things already achieved by other OOLs in the other hand. So, IMHO, current state of affairs is bleak at best. Just to be synced with current hardware and OS technologies, one important thing would be having squeak working fully 64bits and multithreaded. It happens that cog is not 64 bits and it seems it cannot be easily made so. The standard VM can be compiled 64 bits (64bit VM) but image is still 32bit. Worse than that, multithreading is hard to achieve. And simply there are not enough people to take care of these issues. Supposing multithreading could be achieved, then distributed objects (objects running in loosely coupled computer architectures) would become important. But IMHO it is just centuries ahead of what can be done today. Best regards, CdAB

4 6

The Trunk: Files-cmm.121.mcz
by commits＠source.squeak.org 25 May '13

25 May '13

Chris Muller uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-cmm.121.mcz ==================== Summary ==================== Name: Files-cmm.121 Author: cmm Time: 25 May 2013, 3:54:51.614 pm UUID: cf0d0529-17d0-4e0a-9c42-c004bd6cf67d Ancestors: Files-cmm.120 - Correct version of asBytesDescription. =============== Diff against Files-cmm.120 =============== Item was changed: ----- Method: Integer>>asBytesDescription (in category '*files') ----- asBytesDescription + "Answer a terse, easily-readable representation of this Integer as a number of bytes. Useful for file-browsers." - "Answer a terse, easily-readable representation of this Integer reprsenting a number of bytes. Useful for file-browsers." | suffixes | + self isZero ifTrue: [ ^ '0' ]. suffixes := { 'k'"ilobytes". 'M'"egabytes". 'G'"igabytes". 'T'"erabytes". 'P'"etabytes". 'E'"xabytes". 'Z'"ettabytes". 'Y'"ottabytes"}. suffixes size to: 1 by: -1 do: + [ : index | | units rounded | - [ : index | | units | units := 1000 raisedTo: index. + rounded := ((self/units) rounded)*units. + (rounded/self between: 0.95 and: 1.05) ifTrue: [ ^ ((self / units) rounded) asString, (suffixes at: index) ] ]. - self > (units-1) ifTrue: [ ^ ((self / units) rounded) asString, (suffixes at: index) ] ]. ^ self asString!

1 0

The Trunk: Files-cmm.120.mcz
by commits＠source.squeak.org 25 May '13

25 May '13

Chris Muller uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-cmm.120.mcz ==================== Summary ==================== Name: Files-cmm.120 Author: cmm Time: 25 May 2013, 3:25:56.71 pm UUID: 2a18aec4-5bc9-4523-9e23-084753c4a722 Ancestors: Files-cmm.119 - Add efficient directory-tree enumeration capability to FileDirectory. - Make #asBytesDescription more terse, and sans any decimal points. =============== Diff against Files-cmm.119 =============== Item was added: + ----- Method: FileDirectory>>directoryTreeDo: (in category 'enumeration') ----- + directoryTreeDo: oneArgBlock + "For each file and directory in my tree, value oneArgBlock with an OrderedCollection of the path of DirectoryEntry's leading to the current node. The first element in the collection will be the DirectoryEntryDirectory for myself, the last is the currentNode (a DirectoryEntry)." + |myEntry| + myEntry := OrderedCollection with: self directoryEntry. + oneArgBlock value: myEntry. + self + directoryTreeDo: oneArgBlock + entries: myEntry! Item was added: + ----- Method: FileDirectory>>directoryTreeDo:entries: (in category 'enumeration') ----- + directoryTreeDo: oneArgBlock entries: entriesCollection + "Value oneArgBlock with the path (an OrderedCollection of FileDirectory's) to each DirectoryEntry and the DirectoryEntry itself." + self entries do: + [ : each | + entriesCollection add: each. + oneArgBlock value: entriesCollection. + each isDirectory ifTrue: + [ | subdir | + subdir := each asFileDirectory. + subdir + directoryTreeDo: oneArgBlock + entries: entriesCollection ]. + entriesCollection removeLast ]! Item was changed: ----- Method: Integer>>asBytesDescription (in category '*files') ----- asBytesDescription "Answer a terse, easily-readable representation of this Integer reprsenting a number of bytes. Useful for file-browsers." | suffixes | suffixes := { 'k'"ilobytes". 'M'"egabytes". 'G'"igabytes". 'T'"erabytes". 'P'"etabytes". 'E'"xabytes". 'Z'"ettabytes". 'Y'"ottabytes"}. suffixes size to: 1 by: -1 do: [ : index | | units | units := 1000 raisedTo: index. + self > (units-1) ifTrue: [ ^ ((self / units) rounded) asString, (suffixes at: index) ] ]. - self > units ifTrue: [ ^ ((self / units) asFloat roundTo: 0.01) asString, (suffixes at: index) ] ]. ^ self asString!

1 0

Daily Commit Log
by commits＠source.squeak.org 25 May '13

25 May '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-May/005981.html Name: Monticello-kb.545 Ancestors: Monticello-fbs.544 MCHttpRepository displays a progress bar, when downloading files from the internet. Before this change the progressbar only appeard after the response started to arrive. Setting the progressbar value to 0 before executing the workBlock displays it immediately, providing better feedback to the user. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-May/005982.html Name: Morphic-kb.652 Ancestors: Morphic-fbs.651 Implementation of pre selection highlight in PluggableListMorph. See the discussion here: http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-May/171143.html =============================================

1 0

MCSaveVersionDialog >> #accept has a strongly Morphic flavour
by Frank Shearar 24 May '13

24 May '13

It calls #findTextMorph: to determine the version and log message. Now these values are usually stored in two instvars, name and message. Except that for these variables to be set properly, you'd need to accept both text panes. So #accept instead pulls the information right out of the UI by walking the dialog's UI's submorphs and finding the right morph. I'd really like to remove this, because it's a lingering dependency from MCTool to Morphic. (Otherwise, MCTool is a valuable ToolBuilder helper for the MC browsers.) Any thoughts? frank

1 0

Pi performance fun
by tim Rowledge 24 May '13

24 May '13

A Raspberry Pi is not a terribly fast machine; after all, it's only 700MHz with a fairly slow memory system. It's only $35 for ghu's sake. Still, it turns out that with some work you can make it do things reasonably quickly. I've been working on getting the stack vm running as a precursor to a full Cogit and the results are quite pleasing so far; it's around 50% faster than the plain interpreter. That's not a huge change but one must remember that the stack vm is really just a way of introducing the new stack and object memory underpinnings - the interpreter is barely changed. As part of the benchmarking for this work and some exciting changes to BitBLT for ARMs I resurrected the ancient PARC benchmark code we used to use in the days of striving for Dorado equivalent performance. They're not really useful for much more than historical (an romantic) comparison but the cool thing is that a) in a modern image that show that indeed the stack vm is 50% faster, agreeing with much bigger benchmarks b) using a very old image that I used to benchmark changes to the 2.8 era VMs, we see that the Pi running the plain interpreter scores about the same as a 600MHz pentium 3 did in '00. It's about the same as my old Iyonix ARM machin, too - that was a 600MHz intel(!)StrongARM 80321 with a very fast (for the time) memory and a fast (for the time) graphics card. Either machine cost around 100 times as much as the Pi does now; add inflation. This old image cannot run on the stackvm due to the Great Image Shift. The BitBLT work is quite interesting since it involves usurping the normal generated plugin to redirect to some very carefully written assembler code. You can do quite amazing things with the latest ARM graphics systems and knowledge of how to preload lines for the cache and interleave processing with the load queue and all without sacrificing too many virgins. Whether it will provide any useful lessons for other platforms is an open question; after all, we probably ought to be moving away from relying on bitblts and towards more modern vector libraries etc. If any of you have Pi's and want to help with testing etc, let me know. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim If a train station is where the train stops, what is a work station?

4 5

The Inbox: Monticello-fbs.545.mcz
by commits＠source.squeak.org 24 May '13

24 May '13

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-fbs.545.mcz ==================== Summary ==================== Name: Monticello-fbs.545 Author: fbs Time: 24 May 2013, 10:40:40.385 pm UUID: 0666ec56-f995-476a-9b08-59043e96402d Ancestors: Monticello-fbs.544 Rip out the Morphic UI building logic: it's no longer needed. #workingCopy(List|Tree)Morph have no senders, so they go too. =============== Diff against Monticello-fbs.544 =============== Item was changed: + ----- Method: MCTool>>buildWindow (in category 'toolbuilder') ----- - ----- Method: MCTool>>buildWindow (in category 'morphic ui') ----- buildWindow + ^ ToolBuilder build: self! - | window | - Smalltalk at: #ToolBuilder ifPresent: [:tb | ^tb build: self]. - window := SystemWindow labelled: self label. - window model: self. - self widgetSpecs do: [:spec | - | send fractions offsets | - send := spec first. - fractions := spec at: 2 ifAbsent: [#(0 0 1 1)]. - offsets := spec at: 3 ifAbsent: [#(0 0 0 0)]. - window - addMorph: (self perform: send first withArguments: send allButFirst) - fullFrame: - (LayoutFrame - fractions: - ((fractions first)@(fractions second) corner: - (fractions third)@(fractions fourth)) - offsets: - ((offsets first)@(offsets second) corner: - (offsets third)@(offsets fourth)))]. - ^ window! Item was changed: + ----- Method: MCTool>>buildWith: (in category 'toolbuilder') ----- - ----- Method: MCTool>>buildWith: (in category 'morphic ui') ----- buildWith: builder | windowBuilder | windowBuilder := MCToolWindowBuilder builder: builder tool: self. self widgetSpecs do: [:spec | | send fractions offsets | send := spec first. fractions := spec at: 2 ifAbsent: [#(0 0 1 1)]. offsets := spec at: 3 ifAbsent: [#(0 0 0 0)]. windowBuilder frame: (LayoutFrame fractions: (fractions first @ fractions second corner: fractions third @ fractions fourth) offsets: (offsets first @ offsets second corner: offsets third @ offsets fourth)). windowBuilder perform: send first withArguments: send allButFirst]. ^ windowBuilder build ! Item was removed: - ----- Method: MCTool>>buttonRow (in category 'morphic ui') ----- - buttonRow - ^ self buttonRow: self buttonSpecs! Item was removed: - ----- Method: MCTool>>buttonRow: (in category 'morphic ui') ----- - buttonRow: specArray - | aRow | - aRow := AlignmentMorph newRow. - aRow - color: (Display depth <= 8 ifTrue: [Color transparent] ifFalse: [Color gray alpha: 0.2]); - borderWidth: 0. - - aRow hResizing: #spaceFill; vResizing: #spaceFill; rubberBandCells: true. - aRow clipSubmorphs: true. - aRow layoutInset:2@2; cellInset: 1; color: Color white. - aRow wrapCentering: #center; cellPositioning: #leftCenter. - specArray do: - [:triplet | | aButton state | - state := triplet at: 4 ifAbsent: [#buttonState]. - aButton := PluggableButtonMorph - on: self - getState: state - action: #performButtonAction:enabled:. - aButton - hResizing: #spaceFill; - vResizing: #spaceFill; - label: triplet first asString; - arguments: (Array with: triplet second with: state); - onColor: Color white offColor: Color white. - aRow addMorphBack: aButton. - aButton setBalloonText: triplet third]. - - ^ aRow! Item was removed: - ----- Method: MCTool>>codePane: (in category 'morphic ui') ----- - codePane: aSymbol - - | textMorph | - textMorph := PluggableTextMorphPlus - on: self - text: aSymbol - accept: (aSymbol, ':') asSymbol. - textMorph useDefaultStyler. - ^textMorph! Item was removed: - ----- Method: MCTool>>listMorph: (in category 'morphic ui') ----- - listMorph: listSymbol - ^ self - listMorph: (listSymbol, 'List') asSymbol - selection: (listSymbol, 'Selection') asSymbol - menu: (listSymbol, 'ListMenu:') asSymbol! Item was removed: - ----- Method: MCTool>>listMorph:keystroke: (in category 'morphic ui') ----- - listMorph: listSymbol keystroke: keystrokeSymbol - ^ (self - listMorph: (listSymbol, 'List') asSymbol - selection: (listSymbol, 'Selection') asSymbol - menu: (listSymbol, 'ListMenu:') asSymbol) - keystrokeActionSelector: keystrokeSymbol; - yourself! Item was removed: - ----- Method: MCTool>>listMorph:selection: (in category 'morphic ui') ----- - listMorph: listSymbol selection: selectionSymbol - ^ PluggableListMorph - on: self - list: listSymbol - selected: selectionSymbol - changeSelected: (selectionSymbol, ':') asSymbol! Item was removed: - ----- Method: MCTool>>listMorph:selection:menu: (in category 'morphic ui') ----- - listMorph: listSymbol selection: selectionSymbol menu: menuSymbol - ^ PluggableListMorph - on: self - list: listSymbol - selected: selectionSymbol - changeSelected: (selectionSymbol, ':') asSymbol - menu: menuSymbol! Item was removed: - ----- Method: MCTool>>listMorph:selection:menu:keystroke: (in category 'morphic ui') ----- - listMorph: listSymbol selection: selectionSymbol menu: menuSymbol keystroke: keystrokeSymbol - ^ (PluggableListMorph - on: self - list: listSymbol - selected: selectionSymbol - changeSelected: (selectionSymbol, ':') asSymbol - menu: menuSymbol) - keystrokeActionSelector: keystrokeSymbol; - yourself! Item was removed: - ----- Method: MCTool>>multiListMorph:selection:listSelection:menu: (in category 'morphic ui') ----- - multiListMorph: listSymbol selection: selectionSymbol listSelection: listSelectionSymbol menu: menuSymbol - ^ PluggableListMorphOfMany - on: self - list: listSymbol - primarySelection: selectionSymbol - changePrimarySelection: (selectionSymbol, ':') asSymbol - listSelection: listSelectionSymbol - changeListSelection: (listSelectionSymbol, 'put:') asSymbol - menu: menuSymbol! Item was removed: - ----- Method: MCTool>>textMorph: (in category 'morphic ui') ----- - textMorph: aSymbol - ^ PluggableTextMorph on: self text: aSymbol accept: (aSymbol, ':') asSymbol! Item was removed: - ----- Method: MCTool>>treeMorph: (in category 'morphic ui') ----- - treeMorph: listSymbol - ^ self - treeMorph: (listSymbol, 'Tree') asSymbol - selection: (listSymbol, 'SelectionWrapper') asSymbol - menu: (listSymbol, 'TreeMenu:') asSymbol! Item was removed: - ----- Method: MCTool>>treeMorph:selection:menu: (in category 'morphic ui') ----- - treeMorph: listSymbol selection: selectionSymbol menu: menuSymbol - ^ SimpleHierarchicalListMorph - on: self - list: listSymbol - selected: selectionSymbol - changeSelected: (selectionSymbol, ':') asSymbol - menu: menuSymbol - keystroke: nil! Item was removed: - ----- Method: MCTool>>treeOrListMorph: (in category 'morphic ui') ----- - treeOrListMorph: aSymbol - ^ self treeMorph: aSymbol! Item was removed: - ----- Method: MCWorkingCopyBrowser>>workingCopyListMorph (in category 'morphic ui') ----- - workingCopyListMorph - ^ PluggableMultiColumnListMorph - on: self - list: #workingCopyList - selected: #workingCopySelection - changeSelected: #workingCopySelection: - menu: #workingCopyListMenu:! Item was removed: - ----- Method: MCWorkingCopyBrowser>>workingCopyTreeMorph (in category 'morphic ui') ----- - workingCopyTreeMorph - ^ SimpleHierarchicalListMorph - on: self - list: #workingCopyTree - selected: #workingCopyWrapper - changeSelected: #workingCopyWrapper: - menu: #workingCopyListMenu:!

1 0

The Trunk: Morphic-kb.652.mcz
by commits＠source.squeak.org 24 May '13

24 May '13

Balázs Kósi uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kb.652.mcz ==================== Summary ==================== Name: Morphic-kb.652 Author: kb Time: 22 May 2013, 4:50:12.27 pm UUID: 73334963-ccc3-4f41-8fec-fc64d40db333 Ancestors: Morphic-fbs.651 Implementation of pre selection highlight in PluggableListMorph. See the discussion here: http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-May/171143.html =============== Diff against Morphic-fbs.651 =============== Item was changed: Morph subclass: #LazyListMorph + instanceVariableNames: 'listItems listIcons font selectedRow selectedRows preSelectedRow listSource maxWidth' + classVariableNames: 'ListPreSelectionColor ListSelectionColor ListSelectionTextColor' - instanceVariableNames: 'listItems listIcons font selectedRow selectedRows listSource maxWidth' - classVariableNames: 'ListSelectionColor ListSelectionTextColor' poolDictionaries: '' category: 'Morphic-Widgets'! !LazyListMorph commentStamp: 'efc 8/6/2005 11:34' prior: 0! The morph that displays the list in a PluggableListMorph. It is "lazy" because it will only request the list items that it actually needs to display. I will cache the maximum width of my items in maxWidth to avoid this potentially expensive and frequent computation.! Item was added: + ----- Method: LazyListMorph class>>listPreSelectionColor (in category 'preferences') ----- + listPreSelectionColor + <preference: 'List Pre Selection Color' + category: 'colors' + description: 'Governs the color of pre selection highlight in lists' + type: #Color> + ^ ListPreSelectionColor ifNil: [Color r: 0.9 g: 0.9 b: 0.9]! Item was changed: ----- Method: LazyListMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas | | listItems size = 0 ifTrue: [ ^self ]. + self + drawPreSelectionOn: aCanvas; + drawSelectionOn: aCanvas. - self drawSelectionOn: aCanvas. (self topVisibleRowForCanvas: aCanvas) to: (self bottomVisibleRowForCanvas: aCanvas) do: [ :row | (listSource itemSelectedAmongMultiple: row) ifTrue: [ self drawBackgroundForMulti: row on: aCanvas. ]. self display: (self item: row) atRow: row on: aCanvas. ]. listSource potentialDropRow > 0 ifTrue: [ self highlightPotentialDropRow: listSource potentialDropRow on: aCanvas ].! Item was added: + ----- Method: LazyListMorph>>drawPreSelectionOn: (in category 'drawing') ----- + drawPreSelectionOn: aCanvas + + self + drawSelectionFor: preSelectedRow + withColor: self class listPreSelectionColor + on: aCanvas! Item was added: + ----- Method: LazyListMorph>>drawSelectionFor:withColor:on: (in category 'drawing') ----- + drawSelectionFor: index withColor: color on: aCanvas + + | selectionDrawBounds | + index ifNil: [ ^self ]. + index = 0 ifTrue: [ ^self ]. + selectionDrawBounds := self drawBoundsForRow: index. + selectionDrawBounds := selectionDrawBounds intersect: self bounds. + aCanvas fillRectangle: selectionDrawBounds color: color.! Item was changed: ----- Method: LazyListMorph>>drawSelectionOn: (in category 'drawing') ----- drawSelectionOn: aCanvas + self + drawSelectionFor: selectedRow + withColor: self class listSelectionColor + on: aCanvas! - | selectionDrawBounds | - selectedRow ifNil: [ ^self ]. - selectedRow = 0 ifTrue: [ ^self ]. - selectionDrawBounds := self drawBoundsForRow: selectedRow. - selectionDrawBounds := selectionDrawBounds intersect: self bounds. - aCanvas fillRectangle: selectionDrawBounds color: self class listSelectionColor.! Item was changed: ----- Method: LazyListMorph>>initialize (in category 'initialization') ----- initialize super initialize. self color: Color black. font := Preferences standardListFont. listItems := #(). listIcons := #(). selectedRow := nil. selectedRows := PluggableSet integerSet. + preSelectedRow := nil. self adjustHeight.! Item was changed: ----- Method: LazyListMorph>>listChanged (in category 'list management') ----- listChanged "set newList to be the list of strings to display" | size | size := self getListSize. listItems := Array new: size withAll: nil. listIcons := Array new: size withAll: nil. maxWidth := nil. selectedRow := nil. selectedRows := PluggableSet integerSet. + preSelectedRow := nil. self adjustHeight. self adjustWidth. self changed. ! Item was added: + ----- Method: LazyListMorph>>preSelectedRow: (in category 'list management') ----- + preSelectedRow: index + " Show the user which row is about to become selected, thus providing feedback if there is a delay between the selection gesture and the actual selection of the row. " + + preSelectedRow := index. + self changed.! Item was changed: ----- Method: LazyListMorph>>selectRow: (in category 'list management') ----- selectRow: index + " Select the index-th row. Clear the pre selection highlight. " - "select the index-th row" selectedRows add: index. + preSelectedRow := nil. self changed.! Item was changed: ----- Method: LazyListMorph>>selectedRow: (in category 'list management') ----- selectedRow: index + " Select the index-th row. Clear the pre selection highlight. If nil, remove the current selection. " - "select the index-th row. if nil, remove the current selection" selectedRow := index. + preSelectedRow := nil. self changed.! Item was changed: ----- Method: LazyListMorph>>unselectRow: (in category 'list management') ----- unselectRow: index "unselect the index-th row" selectedRows remove: index ifAbsent: []. + preSelectedRow := nil. self changed.! Item was changed: ----- Method: PluggableListMorph>>changeModelSelection: (in category 'model access') ----- changeModelSelection: anInteger + " Change the model's selected item index to be anInteger. Enable the pre selection highlight. Deferring the model's selection action, to let the pre selection highlight take effect. " - "Change the model's selected item index to be anInteger." + self rowAboutToBecomeSelected: (self uiIndexFor: anInteger). + setIndexSelector ifNotNil: [ + ([ model perform: setIndexSelector with: anInteger ] future: 1) value ].! - setIndexSelector ifNotNil: - [model perform: setIndexSelector with: anInteger].! Item was added: + ----- Method: PluggableListMorph>>rowAboutToBecomeSelected: (in category 'selection') ----- + rowAboutToBecomeSelected: anInteger + + self listMorph preSelectedRow: anInteger!

1 0

The Trunk: Monticello-kb.545.mcz
by commits＠source.squeak.org 24 May '13

24 May '13

Balázs Kósi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-kb.545.mcz ==================== Summary ==================== Name: Monticello-kb.545 Author: kb Time: 24 May 2013, 8:33:43.455 pm UUID: 81e08811-7e69-44b9-841d-280d241aa01d Ancestors: Monticello-fbs.544 MCHttpRepository displays a progress bar, when downloading files from the internet. Before this change the progressbar only appeard after the response started to arrive. Setting the progressbar value to 0 before executing the workBlock displays it immediately, providing better feedback to the user. =============== Diff against Monticello-fbs.544 =============== Item was changed: ----- Method: MCHttpRepository>>displayProgress:during: (in category 'required') ----- displayProgress: label during: workBlock | nextUpdateTime | nextUpdateTime := 0. ^label displayProgressFrom: 0.0 to: 1.0 during:[:bar| + bar value: 0.0. + workBlock on: HTTPProgress do:[:ex| + (ex total == nil or:[ex amount == nil]) ifFalse:[ + (nextUpdateTime < Time millisecondClockValue + or:[ex total = ex amount]) ifTrue:[ + bar value: ex amount asFloat / ex total asFloat. + nextUpdateTime := Time millisecondClockValue + 100. - workBlock on: HTTPProgress do:[:ex| - (ex total == nil or:[ex amount == nil]) ifFalse:[ - (nextUpdateTime < Time millisecondClockValue - or:[ex total = ex amount]) ifTrue:[ - bar value: ex amount asFloat / ex total asFloat. - nextUpdateTime := Time millisecondClockValue + 100. - ]. ]. + ]. + ex resume. + ] + ]. - ex resume. - ] - ]. !

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
34
Older →

Jump to page: