Squeak-dev May 2014

squeak-dev@lists.squeakfoundation.org

43 participants
219 discussions

The Trunk: Multilingual-nice.198.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.198.mcz ==================== Summary ==================== Name: Multilingual-nice.198 Author: nice Time: 29 May 2014, 4:56:27.693 pm UUID: 1229d8e0-8203-43a9-bea1-c7f155db6d21 Ancestors: Multilingual-nice.197 Oops, correct my very fresh bug in convertToUnicode: =============== Diff against Multilingual-nice.197 =============== Item was changed: ----- Method: EncodedCharSet class>>convertToUnicode: (in category 'class methods') ----- convertToUnicode: aCode "Translate aCode in our encoding, into equivalent unicode encoding" | table v | (table := self ucsTable) ifNil: [^ 16rFFFD]. + (v := table at: 1 + aCode) = -1 ifTrue: [^ 16rFFFD]. - (v := table at: 1 + self charCode) = -1 ifTrue: [^ 16rFFFD]. ^ v!

1 0

Resolving Environment test failure MCEnvironmentLoadTest>>#testLoadIntoEnvironment
by Nicolas Cellier 29 May '14

29 May '14

The test was failing because a pool dictionary (MCMockAPoolDictionary) is not in the mockPackage. So I used the ability to import this one from Smalltalk globals into the Environment named: 'MCEnvironmentLoadTest'. But it's not enough, the test is still failing. This is because Class>>sharing: is using environment at:ifAbsent: But at:ifAbsent: is using the declarations (that is the classes attached to this environment) not the bindings (the classes visible from this environment). I could change it to use valueOf:ifAbsent: eventually But there is a single sender, so I just wonder... And it also would mean we can't revert Environment as easily if ever we start using environment specific messages. I also wonder if some of the emulation messages should not inquire the bindings rather than the declarations? But what if an environment does not importSelf? For example, how to define a class A, and a subclass B of A in an environment which does not import self if we use the bindings? (I mean we can't reference A, can we?) Can we have an example when not importing self really makes sense? Thoughts?

1 0

The Trunk: Multilingual-nice.197.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.197.mcz ==================== Summary ==================== Name: Multilingual-nice.197 Author: nice Time: 29 May 2014, 3:42:06.965 pm UUID: bfac7dc8-5362-4332-876f-39a24924c19e Ancestors: Multilingual-nice.196 Cleanup: - Remove now unused isCharset. Anyway, the meaning was strange (more like isEastAsianCharset). - Simplify CompoundTextConverter>>toUnicode: to use new convertToUnicode: rather than duplicate the job. - Add possibly missing EncodedCharSet class>>unicodeLeadingChar. - Provides a fast Latin1 class>>charFromUnicode:. =============== Diff against Multilingual-nice.196 =============== Item was changed: ----- Method: CompoundTextConverter>>toUnicode: (in category 'private') ----- toUnicode: aChar + | charset v | - | table charset v | aChar leadingChar = 0 ifTrue: [^ aChar]. + charset := (EncodedCharSet charsetAt: aChar leadingChar) charsetClass. + v := charset convertToUnicode: aChar charCode. + ^ Character leadingChar: charset unicodeLeadingChar code: v! - charset := EncodedCharSet charsetAt: aChar leadingChar. - charset isCharset ifFalse: [^ aChar]. - table := charset ucsTable. - table isNil ifTrue: [^ Character value: 16rFFFD]. - - v := table at: aChar charCode + 1. - v = -1 ifTrue: [^ Character value: 16rFFFD]. - - ^ Character leadingChar: charset unicodeLeadingChar code: v.! Item was removed: - ----- Method: EncodedCharSet class>>isCharset (in category 'class methods') ----- - isCharset - - ^ true. - ! Item was added: + ----- Method: EncodedCharSet class>>unicodeLeadingChar (in category 'class methods') ----- + unicodeLeadingChar + ^Unicode leadingChar! Item was removed: - ----- Method: LanguageEnvironment class>>isCharset (in category 'accessing') ----- - isCharset - - ^ false. - ! Item was added: + ----- Method: Latin1 class>>charFromUnicode: (in category 'class methods') ----- + charFromUnicode: uniCode + + ^ Character leadingChar: self leadingChar code: uniCode! Item was removed: - ----- Method: Unicode class>>isCharset (in category 'class methods') ----- - isCharset - - ^ false. - !

1 0

The Trunk: Collections-nice.572.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.572.mcz ==================== Summary ==================== Name: Collections-nice.572 Author: nice Time: 29 May 2014, 3:09:56.261 pm UUID: 387e24c8-d4ec-4a93-8bbd-cb72a293fb0b Ancestors: Collections-eem.571 Let asUppercase and asLowercase use the unicode tables for wide strings/characters. Care is also taken to correctly handle characters with east asian encoding, but I'm not sure how healthy is this support in trunk... Remove Character>>basicSqueakToIso which is totally obsolete (does not the right thing) and is not sent. =============== Diff against Collections-eem.571 =============== Item was changed: ----- Method: Character>>asLowercase (in category 'converting') ----- asLowercase "If the receiver is uppercase, answer its matching lowercase Character." "A tentative implementation. Eventually this should consult the Unicode table." | v | v := self charCode. (((8r101 <= v and: [v <= 8r132]) or: [16rC0 <= v and: [v <= 16rD6]]) or: [16rD8 <= v and: [v <= 16rDE]]) + ifTrue: [^ Character value: v + 8r40]. + v < 256 ifTrue: [^self]. + ^self class value: ((value < 16r400000 + ifTrue: [Unicode] + ifFalse: [(EncodedCharSet charsetAt: self leadingChar) charsetClass]) + toLowercaseCode: v)! - ifTrue: [^ Character value: value + 8r40] - ifFalse: [^ self]! Item was changed: ----- Method: Character>>asUnicode (in category 'converting') ----- asUnicode + "Answer the unicode encoding of the receiver" - | table charset v | self leadingChar = 0 ifTrue: [^ value]. + ^(EncodedCharSet charsetAt: self leadingChar) charsetClass convertToUnicode: self charCode - (charset := EncodedCharSet charsetAt: self leadingChar) - isCharset ifFalse: [^ self charCode]. - (table := charset ucsTable) - ifNil: [^ 16rFFFD]. - (v := table at: 1 + self charCode) - = -1 ifTrue: [^ 16rFFFD]. - ^ v. ! Item was changed: ----- Method: Character>>asUppercase (in category 'converting') ----- asUppercase "If the receiver is lowercase, answer its matching uppercase Character." "A tentative implementation. Eventually this should consult the Unicode table." | v | v := self charCode. (((8r141 <= v and: [v <= 8r172]) or: [16rE0 <= v and: [v <= 16rF6]]) or: [16rF8 <= v and: [v <= 16rFE]]) + ifTrue: [^ Character value: v - 8r40]. + v < 256 ifTrue: [^self]. + ^self class value: ((value < 16r400000 + ifTrue: [Unicode] + ifFalse: [(EncodedCharSet charsetAt: self leadingChar) charsetClass]) + toUppercaseCode: v)! - ifTrue: [^ Character value: value - 8r40] - ifFalse: [^ self] - ! Item was removed: - ----- Method: Character>>basicSqueakToIso (in category 'converting') ----- - basicSqueakToIso - | asciiValue | - - value < 128 ifTrue: [^ self]. - value > 255 ifTrue: [^ self]. - asciiValue := #(196 197 199 201 209 214 220 225 224 226 228 227 229 231 233 232 234 235 237 236 238 239 241 243 242 244 246 245 250 249 251 252 134 176 162 163 167 149 182 223 174 169 153 180 168 128 198 216 129 177 138 141 165 181 142 143 144 154 157 170 186 158 230 248 191 161 172 166 131 173 178 171 187 133 160 192 195 213 140 156 150 151 147 148 145 146 247 179 253 159 185 164 139 155 188 189 135 183 130 132 137 194 202 193 203 200 205 206 207 204 211 212 190 210 218 219 217 208 136 152 175 215 221 222 184 240 254 255 256 ) at: self asciiValue - 127. - ^ Character value: asciiValue. - ! Item was added: + ----- Method: WideString>>asLowercase (in category 'converting') ----- + asLowercase + ^self collect: [:e | e asLowercase]! Item was added: + ----- Method: WideString>>asUppercase (in category 'converting') ----- + asUppercase + ^self collect: [:e | e asUppercase]!

1 0

The Trunk: Multilingual-nice.196.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.196.mcz ==================== Summary ==================== Name: Multilingual-nice.196 Author: nice Time: 29 May 2014, 2:59:48.329 pm UUID: 07f39804-8e14-49be-a55f-e8d2b809fddd Ancestors: Multilingual-nice.195 Generalized what I did to Unicode: provide an API dealing with codes Add charsetClass conveniency for this reason: (EncodedCharSet charsetAt: leadingChar) is not always a charset, it can also be a LanguageEnvironment. (EncodedCharSet charsetAt: leadingChar) charsetClass will always be a charset (an EncodedCharSet subclass) =============== Diff against Multilingual-nice.195 =============== Item was added: + ----- Method: EncodedCharSet class>>charsetClass (in category 'class methods') ----- + charsetClass + ^self! Item was added: + ----- Method: EncodedCharSet class>>convertToUnicode: (in category 'class methods') ----- + convertToUnicode: aCode + "Translate aCode in our encoding, into equivalent unicode encoding" + | table v | + (table := self ucsTable) ifNil: [^ 16rFFFD]. + (v := table at: 1 + self charCode) = -1 ifTrue: [^ 16rFFFD]. + ^ v! Item was changed: ----- Method: EncodedCharSet class>>isDigit: (in category 'character classification') ----- isDigit: char + "Answer whether char has the code of a digit in this encoding." + ^self isDigitCode: char charCode - "Answer whether the receiver is a digit." - - | value | - value := char asciiValue. - ^ value >= 48 and: [value <= 57]. ! Item was added: + ----- Method: EncodedCharSet class>>isDigitCode: (in category 'character classification') ----- + isDigitCode: anInteger + "Answer whether anInteger is the code of a digit." + + ^ anInteger >= 48 and: [anInteger <= 57]. + ! Item was changed: ----- Method: EncodedCharSet class>>isLetter: (in category 'character classification') ----- + isLetter: char + "Answer whether char has the code of a letter in this encoding." + ^self isLetterCode: char charCode! - isLetter: char - "Answer whether the receiver is a letter." - - | value | - value := char asciiValue. - ^ (8r141 <= value and: [value <= 8r172]) or: [8r101 <= value and: [value <= 8r132]]. - ! Item was added: + ----- Method: EncodedCharSet class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: anInteger + "Answer whether anInteger is the code of a letter." + + ^ (8r141 <= anInteger and: [anInteger <= 8r172]) or: [8r101 <= anInteger and: [anInteger <= 8r132]]. + ! Item was changed: ----- Method: EncodedCharSet class>>isLowercase: (in category 'character classification') ----- + isLowercase: char + "Answer whether char has the code of a lowercase letter in this encoding." + ^self isLowercaseCode: char charCode! - isLowercase: char - "Answer whether the receiver is a lowercase letter. - (The old implementation answered whether the receiver is not an uppercase letter.)" - - | value | - value := char asciiValue. - ^ 8r141 <= value and: [value <= 8r172]. - ! Item was added: + ----- Method: EncodedCharSet class>>isLowercaseCode: (in category 'character classification') ----- + isLowercaseCode: anInteger + "Answer whether anInteger is the code of a lowercase letter." + + ^ 8r141 <= anInteger and: [anInteger <= 8r172]. + ! Item was changed: ----- Method: EncodedCharSet class>>isUppercase: (in category 'character classification') ----- + isUppercase: char + "Answer whether char has the code of an uppercase letter in this encoding." + ^self isUppercaseCode: char charCode! - isUppercase: char - "Answer whether the receiver is an uppercase letter. - (The old implementation answered whether the receiver is not a lowercase letter.)" - - | value | - value := char asciiValue. - ^ 8r101 <= value and: [value <= 8r132]. - ! Item was added: + ----- Method: EncodedCharSet class>>isUppercaseCode: (in category 'character classification') ----- + isUppercaseCode: anInteger + "Answer whether anInteger is the code of an uppercase letter." + + ^ 8r101 <= anInteger and: [anInteger <= 8r132]. + ! Item was removed: - ----- Method: GB2312 class>>isLetter: (in category 'character classification') ----- - isLetter: char - - | value leading | - - leading := char leadingChar. - value := char charCode. - - leading = 0 ifTrue: [^ super isLetter: char]. - - value := value // 94 + 1. - ^ 1 <= value and: [value < 84]. - ! Item was added: + ----- Method: GB2312 class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: anInteger + | value | + value := anInteger // 94 + 1. + ^ 1 <= value and: [value < 84]. + ! Item was removed: - ----- Method: JISX0208 class>>isLetter: (in category 'character classification') ----- - isLetter: char - - | value leading | - - leading := char leadingChar. - value := char charCode. - - leading = 0 ifTrue: [^ super isLetter: char]. - - value := value // 94 + 1. - ^ 1 <= value and: [value < 84]. - ! Item was added: + ----- Method: JISX0208 class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: anInteger + | value | + value := anInteger // 94 + 1. + ^ 1 <= value and: [value < 84]. + ! Item was removed: - ----- Method: KSX1001 class>>isLetter: (in category 'character classification') ----- - isLetter: char - - | value leading | - - leading := char leadingChar. - value := char charCode. - - leading = 0 ifTrue: [^ super isLetter: char]. - - value := value // 94 + 1. - ^ 1 <= value and: [value < 84]. - ! Item was added: + ----- Method: KSX1001 class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: anInteger + | value | + value := anInteger // 94 + 1. + ^ 1 <= value and: [value < 84]. + ! Item was added: + ----- Method: LanguageEnvironment class>>charsetClass (in category 'accessing') ----- + charsetClass + ^Unicode! Item was changed: ----- Method: LanguageEnvironment class>>digitValueOf: (in category 'accessing') ----- digitValueOf: char "Answer 0-9 if the receiver is $0-$9, 10-35 if it is $A-$Z, and < 0 otherwise. This is used to parse literal numbers of radix 2-36." + ^ self charsetClass digitValueOf: char. - ^ Unicode digitValueOf: char. ! Item was changed: ----- Method: LanguageEnvironment class>>isDigit: (in category 'accessing') ----- isDigit: char + ^ self charsetClass isDigit: char. - ^ Unicode isDigit: char. ! Item was changed: ----- Method: LanguageEnvironment class>>isLetter: (in category 'accessing') ----- isLetter: char + ^ self charsetClass isLetter: char. - ^ Unicode isLetter: char. ! Item was changed: ----- Method: LanguageEnvironment class>>isLowercase: (in category 'accessing') ----- isLowercase: char + ^ self charsetClass isLowercase: char. - ^ Unicode isLowercase: char. ! Item was changed: ----- Method: LanguageEnvironment class>>isUppercase: (in category 'accessing') ----- isUppercase: char + ^ self charsetClass isUppercase: char. - ^ Unicode isUppercase: char. ! Item was added: + ----- Method: Latin1 class>>convertToUnicode: (in category 'class methods') ----- + convertToUnicode: aCode + ^aCode! Item was removed: - ----- Method: Latin1 class>>isLetter: (in category 'character classification') ----- - isLetter: char - "Answer whether the receiver is a letter." - - ^ Unicode isLetter: char. - - ! Item was added: + ----- Method: Latin1 class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: anInteger + ^ Unicode isLetterCode: anInteger + + ! Item was added: + ----- Method: Unicode class>>convertToUnicode: (in category 'class methods') ----- + convertToUnicode: aCode + ^aCode! Item was removed: - ----- Method: Unicode class>>isDigit: (in category 'character classification') ----- - isDigit: char - ^self isDigitCode: char charCode! Item was removed: - ----- Method: Unicode class>>isLetter: (in category 'character classification') ----- - isLetter: char - ^self isLetterCode: char charCode! Item was removed: - ----- Method: Unicode class>>isLowercase: (in category 'character classification') ----- - isLowercase: char - ^self isLowercaseCode: char charCode! Item was removed: - ----- Method: Unicode class>>isUppercase: (in category 'character classification') ----- - isUppercase: char - ^self isUppercaseCode: char charCode!

1 0

The Trunk: Tests-nice.299.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.299.mcz ==================== Summary ==================== Name: Tests-nice.299 Author: nice Time: 29 May 2014, 7:40:08.496 am UUID: 638a5f11-86a1-4dc6-a72d-9b4750f3a22e Ancestors: Tests-nice.298 No use to test isDoIt in the selectors, DoIt are not installed in MethodDictionary anymore. =============== Diff against Tests-nice.298 =============== Item was changed: ----- Method: PCCByCompilation>>methodsWithDisabledCall (in category 'ui querying') ----- methodsWithDisabledCall "Answer a SortedCollection of all the methods that contain, in source code, the substring indicating a disabled prim." "The alternative implementation ^ SystemNavigation new allMethodsWithSourceString: self disabledPrimStartString matchCase: true also searches in class comments." | list string | string := self disabledPrimStartString. list := Set new. 'Searching all method source code...' displayProgressFrom: 0 to: Smalltalk classNames size * 2 "classes with their metaclasses" during: [:bar | | classCount | classCount := 0. SystemNavigation default allBehaviorsDo: [:class | bar value: (classCount := classCount + 1). class selectorsDo: [:sel | | src | "higher priority to avoid source file accessing errors" src := [class sourceCodeAt: sel] valueAt: self higherPriority. (src findString: string startingAt: 1 caseSensitive: true) > 0 + ifTrue: [list add: (MethodReference class: class selector: sel)]]]]. - ifTrue: [sel isDoIt ifFalse: [ - list add: (MethodReference class: class selector: sel)]]]]]. ^ list asSortedCollection!

1 0

The Trunk: Multilingual-nice.195.mcz
by commits＠source.squeak.org 29 May '14

29 May '14

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.195.mcz ==================== Summary ==================== Name: Multilingual-nice.195 Author: nice Time: 29 May 2014, 7:22:08.663 am UUID: 49e73ca2-cd51-45e8-b2c9-7836d3ebb0bc Ancestors: Multilingual-fbs.194 Micro-simplify scanKernableMultibyteCharactersFrom:to:in:rightX: (one less temp var floatDestX, the flow was a bit too nested) Protect charsetAt: against out of bounds encoding Add an API to Unicode for handling codes (it's most of its job to handle codes as the name tells). =============== Diff against Multilingual-fbs.194 =============== Item was changed: ----- Method: CharacterScanner>>scanKernableMultibyteCharactersFrom:to:in:rightX: (in category '*Multilingual-Display') ----- scanKernableMultibyteCharactersFrom: startIndex to: stopIndex in: sourceString rightX: rightX "this is a scanning method for multibyte characters in a WideString a font that does do character-pair kerning via widthAndKernedWidthOfLeft:right:into:" + | ascii encoding nextDestX startEncoding widthAndKernedWidth nextChar atEndOfRun char | - | ascii encoding nextDestX startEncoding floatDestX widthAndKernedWidth nextChar atEndOfRun char | lastIndex := startIndex. lastIndex > stopIndex ifTrue: [^self handleEndOfRunAt: stopIndex]. startEncoding := (sourceString at: startIndex) leadingChar. - floatDestX := destX. widthAndKernedWidth := Array new: 2. atEndOfRun := false. [lastIndex <= stopIndex] whileTrue: [ char := sourceString at: lastIndex. encoding := char leadingChar. encoding ~= startEncoding ifTrue: [lastIndex := lastIndex - 1. ^#endOfRun]. ascii := char charCode. (ascii < 256 and: [(stopConditions at: ascii + 1) ~~ nil]) ifTrue: [^ stopConditions at: ascii + 1]. nextChar := (lastIndex + 1 <= stopIndex) ifTrue:[sourceString at: lastIndex + 1] ifFalse:[ atEndOfRun := true. "if there is a next char in sourceString, then get the kern and store it in pendingKernX" lastIndex + 1 <= sourceString size ifTrue:[sourceString at: lastIndex + 1] ifFalse:[ nil]]. font widthAndKernedWidthOfLeft: char right: nextChar into: widthAndKernedWidth. + nextDestX := destX + (widthAndKernedWidth at: 1). - nextDestX := floatDestX + (widthAndKernedWidth at: 1). nextDestX > rightX ifTrue: [^#crossedX]. + destX := atEndOfRun + ifTrue: [pendingKernX := (widthAndKernedWidth at: 2) + - (widthAndKernedWidth at: 1). + nextDestX + kern] + ifFalse: [destX + kern + (widthAndKernedWidth at: 2)]. - floatDestX := floatDestX + kern + (widthAndKernedWidth at: 2). - atEndOfRun - ifTrue:[ - pendingKernX := (widthAndKernedWidth at: 2) - (widthAndKernedWidth at: 1). - floatDestX := floatDestX - pendingKernX]. - destX := floatDestX . lastIndex := lastIndex + 1. ]. ^self handleEndOfRunAt: stopIndex! Item was changed: ----- Method: EncodedCharSet class>>charsetAt: (in category 'class methods') ----- charsetAt: encoding "Find the char set encoding that matches 'encoding'; return a decent default rather than nil" + ^ (EncodedCharSets at: encoding + 1 ifAbsent: [nil]) ifNil: [Unicode].! - ^ (EncodedCharSets at: encoding + 1) ifNil: [EncodedCharSets at: 1]. - ! Item was changed: ----- Method: Unicode class>>isDigit: (in category 'character classification') ----- isDigit: char + ^self isDigitCode: char charCode! - | value | - value := char charCode. - value > (GeneralCategory size - 1) - ifTrue: [^ false]. - ^ (GeneralCategory at: value + 1) - = Nd! Item was added: + ----- Method: Unicode class>>isDigitCode: (in category 'character classification') ----- + isDigitCode: charCode + charCode > (GeneralCategory size - 1) + ifTrue: [^ false]. + ^ (GeneralCategory at: charCode + 1) + = Nd! Item was changed: ----- Method: Unicode class>>isLetter: (in category 'character classification') ----- isLetter: char + ^self isLetterCode: char charCode! - | value codeCat | - value := char charCode. - value > (GeneralCategory size - 1) - ifTrue: [^ false]. - ^ (codeCat := GeneralCategory at: value + 1) >= Ll - and: [codeCat <= Lu]! Item was added: + ----- Method: Unicode class>>isLetterCode: (in category 'character classification') ----- + isLetterCode: charCode + | codeCat | + charCode > (GeneralCategory size - 1) + ifTrue: [^ false]. + ^ (codeCat := GeneralCategory at: charCode + 1) >= Ll + and: [codeCat <= Lu]! Item was changed: ----- Method: Unicode class>>isLowercase: (in category 'character classification') ----- isLowercase: char + ^self isLowercaseCode: char charCode! - | value | - value := char charCode. - value > (GeneralCategory size - 1) - ifTrue: [^ false]. - ^ (GeneralCategory at: value + 1) - = Ll! Item was added: + ----- Method: Unicode class>>isLowercaseCode: (in category 'character classification') ----- + isLowercaseCode: charCode + charCode > (GeneralCategory size - 1) + ifTrue: [^ false]. + ^ (GeneralCategory at: charCode + 1) + = Ll! Item was changed: ----- Method: Unicode class>>isUppercase: (in category 'character classification') ----- isUppercase: char + ^self isUppercaseCode: char charCode! - | value | - value := char charCode. - value > (GeneralCategory size - 1) - ifTrue: [^ false]. - ^ (GeneralCategory at: value + 1) - = Lu! Item was added: + ----- Method: Unicode class>>isUppercaseCode: (in category 'character classification') ----- + isUppercaseCode: charCode + charCode > (GeneralCategory size - 1) + ifTrue: [^ false]. + ^ (GeneralCategory at: charCode + 1) + = Lu! Item was changed: ----- Method: Unicode class>>parseCaseMappingFrom: (in category 'casing') ----- parseCaseMappingFrom: stream "Parse the Unicode casing mappings from the given stream. Handle only the simple mappings" " Unicode initializeCaseMappings. " ToCasefold := IdentityDictionary new: 2048. ToUpper := IdentityDictionary new: 2048. ToLower := IdentityDictionary new: 2048. [stream atEnd] whileFalse:[ | fields line srcCode dstCode | line := stream nextLine copyUpTo: $#. fields := line withBlanksTrimmed findTokens: $;. (fields size > 2 and: [#('C' 'S') includes: (fields at: 2) withBlanksTrimmed]) ifTrue:[ srcCode := Integer readFrom: (fields at: 1) withBlanksTrimmed base: 16. dstCode := Integer readFrom: (fields at: 3) withBlanksTrimmed base: 16. ToCasefold at: srcCode put: dstCode. ]. ]. ToCasefold keysAndValuesDo: [:k :v | + (self isUppercaseCode: k) - (self isUppercase: (self value: k)) ifTrue: ["In most cases, uppercase letter are folded to lower case" ToUpper at: v put: k. ToLower at: k put: v]. + (self isLowercaseCode: k) - (self isLowercase: (self value: k)) ifTrue: + ["In a few cases, two upper case letters are folded to the same lower case. - ["In a few cases, two lower case letters are folded to the same lower case. We must find an upper case letter folded to the same letter" | up | + up := ToCasefold keys detect: [:e | (self isUppercaseCode: e) and: [(ToCasefold at: e) = v]] ifNone: [nil]. - up := ToCasefold keys detect: [:e | (self isUppercase: (self value: e)) and: [(ToCasefold at: e) = v]] ifNone: [nil]. up ifNotNil: [ToUpper at: k put: up]]].! Item was added: + ----- Method: Unicode class>>toLowercaseCode: (in category 'casing') ----- + toLowercaseCode: anInteger + "Answer corresponding lower case code for a Character code. + This does not handle special cases where several codes would be required." + + ^ToLower at: anInteger ifAbsent: [anInteger]! Item was added: + ----- Method: Unicode class>>toUppercaseCode: (in category 'casing') ----- + toUppercaseCode: anInteger + "Answer corresponding upper case code for a Character code. + This does not handle special cases where several codes would be required." + + ^ToUpper at: anInteger ifAbsent: [anInteger]!

1 0

Re: [Pharo-dev] String >> #=
by Eliot Miranda 28 May '14

28 May '14

Hi Phillipe, On Mon, May 26, 2014 at 12:51 AM, Philippe Marschall < philippe.marschall(a)netcetera.ch> wrote: > Hi > > I have been investigating why Dictionary look up performance with String > keys is not as good as I would expected. Something I noted is that String > >> #= is implemented in terms of #compare:with:collated:. There is no short > circuit if Strings are not the same size. In my case some Strings have the > same prefix but a different length eg 'Content-Type' and 'Content-Length'. > In that case a #compare:with:collated: is performed even though we know in > advance the answer will be false because they have different sizes. > Why not rewrite String>>= aString "Answer whether the receiver sorts equally as aString. The collation order is simple ascii (with case differences)." aString isString ifFalse: [ ^ false ]. ^ (self compare: self with: aString collated: AsciiOrder) = 2 as String>>= aString "Answer whether the receiver sorts equally as aString. The collation order is simple ascii (with case differences)." (aString isString and: [self size = aString size]) ifFalse: [^false]. ^ (self compare: self withSize: with: aString collated: AsciiOrder) = 2 ? One /could/ add a replacement compare:with:collated: primitive primitiveCompareString which took the sizes as arguments to avoid asking twice. But it wouldn't be safe. One could abuse the primitive and lie about the size. So I suspect it is best to add the size check to String>>#= and accept the duplication of the primitive finding the sizes of the two strings. The cost in the primitive is minimal. A WideString version of the primitive might pay its way, but if Spur and Sista arrive soon the primitive shouldn't be faster than the optimised Smalltalk code. -- best, Eliot

6 8

Re: [squeak-dev] Re: [Pharo-dev] String >> #=
by Yoshiki Ohshima 28 May '14

28 May '14

Hmm, why? At Tue, 27 May 2014 21:15:55 -0700, Andres Valloud wrote: > > Ok, so I suppose the next step would be to put something like "Smalltalk > strings do not support Unicode" in writing? > > On 5/27/14 19:50 , Yoshiki Ohshima wrote: > > At Tue, 27 May 2014 19:23:09 -0700, > > Andres Valloud wrote: > >> > >> String encoding is perpendicular to my point. I'm referring to > >> canonical equivalence as defined in section 1.1 of the document > >> referenced by the URL I sent. For instance, the Hangul example in the > >> first table shows that a combination of two characters (regardless of > >> encoding) is to be considered canonically equivalent to a single > >> character. From the document (which claims to be Unicode Standard Annex > >> #15), > >> > >> "Canonical equivalence is a fundamental equivalency between characters > >> or sequences of characters that represent the same abstract character, > >> and when correctly displayed should always have the same visual > >> appearance and behavior." > >> > >> How do you propose that a size check is appropriate in the presence of > >> canonical equivalence? What is string equivalence supposed to mean? I > >> think more attention should be given to those questions. > > > > I think that the single equal message (=) in the Smalltalk language > > should not really worry about canonical equvalence. For those who > > need it, it'd be fine to define a new selector and does the real > > stuff, and such method could track the Unicode standard revisions and > > do the right thing. But something as fundamental as String>>#= does > > not have to have dependency to the external standard. > > > > -- Yoshiki > > > > . > >

1 0

Squeak and SSL
by Fabio Niephaus 28 May '14

28 May '14

Hi all, SqueakSSL does not work on current linux distributions, because it requires libssl.so.0.9.8 which is outdated. I could think of three ways how to deal with this: 1. Add a note in the documentation that SqueakSSL requires libssl.so.0.9.8 2. Link libssl.so.0.9.8 statically into the SqueakSSL plugin 3. Rework the SqueakSSL plugin to support current versions of OpenSSL What would be the best way to proceed? And who is maintaining the OpenSSL-related code? Regards, -- Fabio Niephaus IT-Systems Engineering Student Hasso-Plattner-Institut für Softwaresystemtechnik GmbH, Potsdam Prof.-Dr.-Helmert-Str. 2-3 D-14482 Potsdam www.hpi-web.de Amtsgericht Potsdam, HRB 12184 Geschäftsführung: Prof. Dr. Christoph Meinel

2 1

← Newer
1
2
3
4
5
6
7
...
22
Older →

Jump to page: