Squeak-dev June 2017

squeak-dev@lists.squeakfoundation.org

36 participants
130 discussions

Nuking VM ImageSegment support (was Re: [squeak-dev] Daily Commit Log; System-bf.916)
by Eliot Miranda 05 Jul '17

05 Jul '17

Hi Bert, Hi All, On Thu, Sep 15, 2016 at 2:55 PM, <commits(a)source.squeak.org> wrote: [snip] > http://lists.squeakfoundation.org/pipermail/packages/2016- > September/068930.html > > Name: System-bf.916 > Ancestors: System-bf.915 > > Replace VM-level ImageSegment loading with a Smalltalk implementation for > old (interpreter-era) projects. > > Also removes support for writing segments. > > This overrides the Spur support introduced in System-eem.758. > So one question is should we delete VM support for ImageSegment from the Spur VM? There's at least 1.5k of generated source for the Spur ImageSegment load and save support, some 2% of the interpreter/primitives source code. That's a lot, and the code is complex and ugly. If it never really worked before IMO we should nuke it asap. If it worked in some fashion perhaps we can schedule its demise for the 6.0 release's VM. What do others think? _,,,^..^,,,_ best, Eliot

9 17

The Trunk: Morphic-eem.1344.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1344.mcz ==================== Summary ==================== Name: Morphic-eem.1344 Author: eem Time: 30 June 2017, 11:43:57.311016 am UUID: 67654d61-5234-4c97-9379-1aa00811c8f6 Ancestors: Morphic-mt.1343 Make browseIt (Apple/Alt-b) work for class and pool variables. =============== Diff against Morphic-mt.1343 =============== Item was changed: ----- Method: TextEditor>>browseIt (in category 'menu messages') ----- browseIt "Launch a browser for the current selection, if appropriate" | aSymbol anEntry brow maybeBrowseInstVar | Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt]. self lineSelectAndEmptyCheck: [^ self]. maybeBrowseInstVar := [| selectionString | selectionString := self selection asString. ([model selectedClass] on: Error do: [:ex|]) ifNotNil: [:class| (class allInstVarNames includes: selectionString) ifTrue: [self systemNavigation browseAllAccessesTo: selectionString from: (class classThatDefinesInstanceVariable: selectionString). ^nil]]]. (aSymbol := self selectedSymbol) ifNil: [maybeBrowseInstVar value. ^morph flash]. aSymbol first isUppercase ifTrue: [anEntry := (model environment valueOf: aSymbol ifAbsent: + [ ([model selectedClass] on: Error do: [:ex|]) ifNotNil: + [:class| + (class bindingOf: aSymbol) ifNotNil: "e.g. a class var" + [:binding| + self systemNavigation browseAllCallsOn: binding. + ^ nil]]. + self systemNavigation browseAllImplementorsOf: aSymbol. - [ self systemNavigation browseAllImplementorsOf: aSymbol. ^ nil]). anEntry ifNil: [^ morph flash]. (anEntry isBehavior and: [anEntry name == aSymbol]) ifFalse: "When is this ever false?" [anEntry := anEntry class]. brow := SystemBrowser default new. brow setClass: anEntry selector: nil. brow class openBrowserView: (brow openEditString: nil) label: 'System Browser'] ifFalse: [self systemNavigation browseAllImplementorsOf: aSymbol. maybeBrowseInstVar value]!

1 0

Float printing significant digits
by Eliot Miranda 30 Jun '17

30 Jun '17

Hi All, an observation, a question and a suggestion. First I hate seeing reports like this: #55 0.33333298563957214 ratio of growth and image size at or above which a GC will be performed post scavenge It's far preferable to see something like #55 0.333333 ratio of growth and image size at or above which a GC will be performed post scavenge but the Float printing facilities, , lose significant digits when the value is less than zero: (-10 to: 10) collect: [:i| | v | v := (10 raisedTo: i) asFloat / 3. v printShowingMaxDecimalPlaces: 6] #('0' '0' '0' '0' '0' '0.000003' '0.000033' '0.000333' '0.003333' '0.033333' '0.333333' '3.333333' '33.333333' '333.333333' '3333.333333' '33333.333333' '333333.333333' '3333333.333333' '33333333.333333' '333333333.333333' '3333333333.333333') (-10 to: 10) collect: [:i| | v | v := (10 raisedTo: i) asFloat / 3. v printShowingDecimalPlaces: 6] #('0.000000' '0.000000' '0.000000' '0.000000' '0.000000' '0.000003' '0.000033' '0.000333' '0.003333' '0.033333' '0.333333' '3.333333' '33.333333' '333.333333' '3333.333333' '33333.333333' '333333.333333' '3333333.333333' '33333333.333333' '333333333.333333' '3333333333.333333') So the question is, are there facilities I'm missing? My suggestion is to add something like print:showingSignificantPlaces:, e.g. (-10 to: 10) collect: [:i| | v | v := (10 raisedTo: i) asFloat / 3. (v >= 1 or: [v = 0 or: [v isFinite not]]) ifTrue: [v printShowingMaxDecimalPlaces: 6] ifFalse: [v printShowingMaxDecimalPlaces: 6 - v fractionPart log rounded]] #('0.0000000000333333' '0.000000000333333' '0.00000000333333' '0.0000000333333' '0.000000333333' '0.00000333333' '0.0000333333' '0.000333333' '0.00333333' '0.0333333' '0.333333' '3.333333' '33.333333' '333.333333' '3333.333333' '33333.333333' '333333.333333' '3333333.333333' '33333333.333333' '333333333.333333' '3333333333.333333') (e.g. 0.000333333333 fractionPart log = -3.477121255153956) If I'm not missing an obvious solution are there any objections to adding this? _,,,^..^,,,_ best, Eliot

1 0

The Trunk: Graphics-eem.380.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Eliot Miranda uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-eem.380.mcz ==================== Summary ==================== Name: Graphics-eem.380 Author: eem Time: 30 June 2017, 10:58:57.420462 am UUID: 2d63e219-e81d-4f2d-be24-39cc148d9203 Ancestors: Graphics-mt.379 Trim Dispplay flash: aRectangle time to 50ms =============== Diff against Graphics-mt.379 =============== Item was changed: ----- Method: DisplayScreen>>flash: (in category 'displaying') ----- flash: aRectangle "Flash the area of the screen defined by the given rectangle." self reverse: aRectangle. self forceDisplayUpdate. + (Delay forMilliseconds: 50) wait. - (Delay forMilliseconds: 100) wait. self reverse: aRectangle. self forceDisplayUpdate. !

1 0

Shortening flash: time to 50 ms
by Eliot Miranda 30 Jun '17

30 Jun '17

Hi All, would anyone object if I set the DisplayScreen>>#flash: time to 50ms, down from 100ms? I find the 100ms noticeably slow, and I'm getting on in years, so I feel that its unnecessarily slow for many others too. So as I asked, any objections? _,,,^..^,,,_ best, Eliot

2 2

Monticello's Package Loading Strategy (Bug)
by Eliot Miranda 30 Jun '17

30 Jun '17

Hi All, Hi Bert, Hi Colin, today I was working with Ron Teitelbaum on porting the Terf client to Squeak 6.x. The bootstrap builder creates some base MCConfigurations and then updates them from the various repositories, hence downloading the latest versions of certain packages into the package cache. Some of the downloaded packages are for Tweak, and Tweak classes include field definitions which require special Monticello support to manage. The special handling is provided by the TweakMC package. Here are some of the relevant definitions: MCStWriter>>visitTweakFieldDefinition: definition self writeTweakFieldDefinition: definition MCStWriter>>writeTweakFieldDefinition: definition self chunkContents: [:s | definition printDefinitionOn: stream] which produces output like the following in the snapshot.st file: CCostumeGrid defineFields: '<?xml version="1.0" ?> <fields> <field toGet="origin" toSet="origin:" changeEvent="originChanged">origin</field> <field toGet="extent" toSet="extent:" changeEvent="extentChanged">extent</field> <field toGet="enabled" toSet="enabled:" changeEvent="enabledChanged">enabled</field> <field toGet="visible" toSet="visible:" changeEvent="visibleChanged">visible</field> <field toGet="color" toSet="color:" changeEvent="colorChanged">color</field> </fields>'! Note that no special support is needed for producing the snapshot.bin because that can save arbitrary objects. So, (I think) because we were loading packages saved by Squeak V3 into a Squeak Spur image the binary isn't loaded and instead the source is compiled. (Am I right?) If the update happens *before* TweakMC has been loaded then the packages that get installed into package-cache are missing all the field definitions because the support to produce them is missing. This was exactly our situation; we're freshly bootstrapping a Terf image, which includes adding support for Tweak, and TweakMC is loaded by the bootstrap /after/ the configurations have been updated, and hence the Tweak packages in the package-cache are corrupted. We fixed our issue by modifying the bootstrap to load TweakMC up front. But IMO *this shouldn't be necessary*. Why, when Monticello downloads a package from a repository, does it rewrite that package to install it in the package-cache directory? Surely it has *no business* rewriting the contents of the package and could simply copy the file itself. If it does the rewrite, as it is doing now, it opens up the transcription to all sorts of errors, the above being one. Not only is the approach slow, and error prone, it is unnecessary. The file could be copied quite simply. Is this easy to fix? I think it's a really bad design flaw. _,,,^..^,,,_ best, Eliot

4 6

The Trunk: Morphic-mt.1343.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1343.mcz ==================== Summary ==================== Name: Morphic-mt.1343 Author: mt Time: 30 June 2017, 2:05:06.118892 pm UUID: c3749c89-0329-0843-ac12-7c6f3aba1dc1 Ancestors: Morphic-mt.1342 Small fix for showing a morph's halo directly after its world's halo got activated. =============== Diff against Morphic-mt.1342 =============== Item was changed: ----- Method: SimpleHaloMorph>>transferHalo:from: (in category 'halos and balloon help') ----- transferHalo: event from: formerHaloOwner + "If my world tries to open on me, pass it on to the next sibling after me." + + formerHaloOwner == self world ifTrue: [ + self world submorphsDo: [:m | + (m ~~ self and: [m fullContainsPoint: event position]) ifTrue: [ + m comeToFront. + ^ m transferHalo: event from: formerHaloOwner]]].! - "Ignore. No halo for halo."!

1 0

The Trunk: Tools-pre.764.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.764.mcz ==================== Summary ==================== Name: Tools-pre.764 Author: pre Time: 30 June 2017, 11:42:44.352092 am UUID: 49cb3bb0-4920-9347-aea3-a70c15bca6a5 Ancestors: Tools-nice.763 Minor refactoring by topa of a menuPragma method. =============== Diff against Tools-nice.763 =============== Item was changed: ----- Method: Model>>menuPragmasFor:in: (in category '*Tools-pluggable menus') ----- menuPragmasFor: aMenuSymbolOrCollection in: aClass + ^ aMenuSymbolOrCollection isSymbol + ifFalse: [aMenuSymbolOrCollection gather: [:aMenuSymbol | - ^ aMenuSymbolOrCollection isCollection - ifTrue: [aMenuSymbolOrCollection gather: [:aMenuSymbol | Pragma allNamed: aMenuSymbol from: aClass to: Object]] + ifTrue: [Pragma allNamed: aMenuSymbolOrCollection from: aClass to: Object]! - ifFalse: [Pragma allNamed: aMenuSymbolOrCollection from: aClass to: Object]!

1 0

The Trunk: Collections-pre.759.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.759.mcz ==================== Summary ==================== Name: Collections-pre.759 Author: pre Time: 30 June 2017, 11:39:43.025092 am UUID: 730c33f1-c2a6-a246-9795-6d2c28af6005 Ancestors: Collections-eem.758 OrderedDictionary was missing the simple last selector. =============== Diff against Collections-eem.758 =============== Item was added: + ----- Method: OrderedDictionary>>last (in category 'accessing') ----- + last + "Answer the last element of the receiver" + + ^ self atIndex: self size!

1 0

The Trunk: EToys-mt.302.mcz
by commits＠source.squeak.org 30 Jun '17

30 Jun '17

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.302.mcz ==================== Summary ==================== Name: EToys-mt.302 Author: mt Time: 30 June 2017, 9:29:22.319527 am UUID: f34a4a94-d4da-f84f-9557-0e94c5b9507c Ancestors: EToys-mt.301 Companion for Morphic-mt.1342. =============== Diff against EToys-mt.301 =============== Item was removed: - ----- Method: EventRecordingSpace>>blueButtonDown: (in category 'events-processing') ----- - blueButtonDown: anEvent - "Special gestures (cmd-mouse on the Macintosh; Alt-mouse on Windows and Unix) allow a mouse-sensitive morph to be moved or bring up a halo for the morph." - - (eventRecorder userStopReplayMaybe: anEvent) ifTrue: [^ self stopPlayback]. - super blueButtonDown: anEvent. - ! Item was added: + ----- Method: EventRecordingSpace>>invokeHaloOrMove: (in category 'events-processing') ----- + invokeHaloOrMove: anEvent + + (eventRecorder userStopReplayMaybe: anEvent) ifTrue: [^ self stopPlayback]. + super invokeHaloOrMove: anEvent. + ! Item was changed: ----- Method: HaloMorph>>addSmallHandle:on:send:to: (in category '*Etoys-Squeakland-private') ----- addSmallHandle: handleSpec on: eventName send: selector to: recipient "Add a handle within the halo box as per the haloSpec, and set it up to respond to the given event by sending the given selector to the given recipient. Return the handle. This is the 5/17/04 version of HaloMorph>>addHandle:on:send:to:" | handle aPoint iconName colorToUse | aPoint := self positionIn: haloBox horizontalPlacement: handleSpec horizontalPlacement verticalPlacement: handleSpec verticalPlacement. handle := EllipseMorph newBounds: (Rectangle center: aPoint extent: self handleSize asPoint) color: (colorToUse := Color colorFrom: handleSpec color). handle borderColor: colorToUse muchDarker. self addMorph: handle. (iconName := handleSpec iconSymbol) ifNotNil: [ | form | form := ScriptingSystem formAtKey: iconName. form ifNotNil: [handle addMorphCentered: (ImageMorph new image: form; color: colorToUse makeForegroundColor; lock)]]. + handle on: #mouseUp send: #endInteraction: to: self. - handle on: #mouseUp send: #endInteraction to: self. handle on: eventName send: selector to: recipient. self isMagicHalo ifTrue:[ handle on: #mouseEnter send: #handleEntered to: self. handle on: #mouseLeave send: #handleLeft to: self]. handle setBalloonText: (target balloonHelpTextForHandle: handle) translated. ^ handle ! Item was removed: - ----- Method: Morph>>wantsTransfarHaloFromClick (in category '*Etoys-Squeakland-halos and balloon help') ----- - wantsTransfarHaloFromClick - "If true, I want a halo when you click blue button at second" - ^ self wantsHaloFromClick! Item was removed: - ----- Method: PasteUpMorph>>wantsTransfarHaloFromClick (in category '*Etoys-Squeakland-halos and balloon help') ----- - wantsTransfarHaloFromClick - "Answer whether I would feel strongly about acquiring the halo for a click on a subobject within me." - - ^ (owner notNil and: [owner encouragesHaloTransferToEnclosedPasteUpMorph])!

1 0