Squeak-dev March 2018

squeak-dev@lists.squeakfoundation.org

53 participants
146 discussions

The Inbox: Kernel-fn.1151.mcz
by commits＠source.squeak.org 22 Mar '18

22 Mar '18

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-fn.1151.mcz ==================== Summary ==================== Name: Kernel-fn.1151 Author: fn Time: 9 February 2018, 12:32:25.516883 pm UUID: 9fb7df4b-6bf4-4af8-9c75-7496c2f0b517 Ancestors: Kernel-tonyg.1150 For consistency: allow blocks to be passed into #xor: (see #or: and #and:). =============== Diff against Kernel-tonyg.1150 =============== Item was changed: ----- Method: False>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value! - ^aBoolean! Item was changed: ----- Method: True>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value not! - ^aBoolean not!

11 25

The Inbox: Monticello-ul.678.mcz
by commits＠source.squeak.org 21 Mar '18

21 Mar '18

Levente Uzonyi uploaded a new version of Monticello to project The Inbox: http://source.squeak.org/inbox/Monticello-ul.678.mcz ==================== Summary ==================== Name: Monticello-ul.678 Author: ul Time: 19 March 2018, 1:03:18.137853 am UUID: 4d47635e-aa48-43cc-99bb-b8d2f1a5a51f Ancestors: Monticello-cmm.677 Store and reuse a shared WebClient instance for each MCHttpRepository. This makes it possible to speed up downloads by reusing TCP connections. Disabled by default. Enable it by evaluating [MCHttpRepository useSharedWebClientInstance: true] =============== Diff against Monticello-cmm.677 =============== Item was changed: MCFileBasedRepository subclass: #MCHttpRepository + instanceVariableNames: 'location user password readerCache indexed webClient' + classVariableNames: 'UseSharedWebClientInstance' - instanceVariableNames: 'location user password readerCache indexed' - classVariableNames: '' poolDictionaries: '' category: 'Monticello-Repositories'! Item was added: + ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- + useSharedWebClientInstance + + <preference: 'Use shared WebClient instance' + category: 'Monticello' + description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' + type: #Boolean> + ^UseSharedWebClientInstance ifNil: [ false ]! Item was added: + ----- Method: MCHttpRepository class>>useSharedWebClientInstance: (in category 'preferences') ----- + useSharedWebClientInstance: aBoolean + + UseSharedWebClientInstance := aBoolean! Item was changed: ----- Method: MCHttpRepository>>allFileNames (in category 'overriding') ----- allFileNames + | index | + index := self displayProgress: 'Updating ', self description during: [ + self httpGet: self locationWithTrailingSlash, '?C=M;O=D' arguments: nil ]. + ^index ifNotNil: [ self parseFileNamesFromStream: index ]! - self displayProgress: 'Updating ', self description during:[ - index := HTTPSocket httpGet: self locationWithTrailingSlash, '?C=M;O=D' args: nil user: self user passwd: self password. - ]. - index isString ifTrue: [NetworkError signal: 'Could not access ', location]. - ^ self parseFileNamesFromStream: index ! Item was added: + ----- Method: MCHttpRepository>>httpGet:arguments: (in category 'private') ----- + httpGet: url arguments: arguments + + | progress urlString client response result | + self class useSharedWebClientInstance ifFalse: [ + ^HTTPSocket httpGet: url args: arguments user: self user passwd: self password ]. + progress := [ :total :amount | + HTTPProgress new + total: total; + amount: amount; + signal: 'Downloading...' ]. + urlString := arguments + ifNil: [ url ] + ifNotNil: [ + | queryString | + queryString := (Smalltalk classNamed: #WebUtils) encodeUrlEncodedForm: arguments. + (url includes: $?) + ifTrue: [ url, '&', queryString ] + ifFalse: [ url, '?', queryString ] ]. + "Acquire webClient by atomically storing it in the client variable and setting its value to nil." + client := webClient. + webClient := nil. + client ifNil: [ client := (Smalltalk classNamed: #WebClient) new ]. + response := client + username: self user; + password: self password; + httpGet: urlString do: [ :request | + request + headerAt: 'Authorization' put: 'Basic ', (self user, ':', self password) base64Encoded; + headerAt: 'Connection' put: 'Keep-Alive'; + headerAt: 'Accept' put: '*/*' ]. + result := (response code between: 200 and: 299) + ifFalse: [ + response content. "Make sure content is read." + nil ] + ifTrue: [ (RWBinaryOrTextStream with: (response contentWithProgress: progress)) reset ]. + "Save the WebClient instance for reuse, but only if there is no client cached." + webClient + ifNil: [ webClient := client ] + ifNotNil: [ client close ]. + ^result ifNil: [ + NetworkError signal: 'Could not access ', location. + nil ]! Item was changed: ----- Method: MCHttpRepository>>readStreamForFileNamed:do: (in category 'private') ----- readStreamForFileNamed: aString do: aBlock + | contents | + contents := self displayProgress: 'Downloading ', aString during: [ + self httpGet: (self urlForFileNamed: aString) arguments: nil ]. + ^contents ifNotNil: [ aBlock value: contents ]! - self displayProgress: 'Downloading ', aString during:[ - contents := HTTPSocket httpGet: (self urlForFileNamed: aString) args: nil user: self user passwd: self password. - ]. - ^ contents isString ifFalse: [aBlock value: contents]!

5 7

The Trunk: Compiler-eem.379.mcz
by commits＠source.squeak.org 20 Mar '18

20 Mar '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.379.mcz ==================== Summary ==================== Name: Compiler-eem.379 Author: eem Time: 20 March 2018, 3:27:27.12646 pm UUID: b3856f24-9d98-478a-936f-c6d24d667be4 Ancestors: Compiler-eem.378 Add initialization of the Undeclared variable addedExtraLiterals which is soon to be a replacement for Encoder's addedSelectorAndMethodClassLiterals, a name which is now misleading given the new full block support. By adding the initialization of the Undeclared variable the compiler is not broken as the instance variable is renamed and Encoder's methods are recompiled. =============== Diff against Compiler-eem.378 =============== Item was changed: ----- Method: BytecodeEncoder>>resetForFullBlockGeneration (in category 'code generation') ----- resetForFullBlockGeneration literalStream := WriteStream on: (Array new: 8). + addedSelectorAndMethodClassLiterals := addedExtraLiterals := false. - addedSelectorAndMethodClassLiterals := false. optimizedSelectors := Set new! Item was changed: ----- Method: BytecodeEncoder>>resetLiteralStreamForFullBlock (in category 'code generation') ----- resetLiteralStreamForFullBlock literalStream := WriteStream on: (Array new: 32). + addedSelectorAndMethodClassLiterals := addedExtraLiterals := false. - addedSelectorAndMethodClassLiterals := false. optimizedSelectors := Set new! Item was changed: ----- Method: Encoder>>initScopeAndLiteralTables (in category 'initialize-release') ----- initScopeAndLiteralTables scopeTable := StdVariables copy. litSet := StdLiterals copy. "comments can be left hanging on nodes from previous compilations. probably better than this hack fix is to create the nodes afresh on each compilation." scopeTable do: [:varNode| varNode comment: nil]. litSet do: [:varNode| varNode comment: nil]. selectorSet := StdSelectors copy. litIndSet := Dictionary new: 16. literalStream := WriteStream on: (Array new: 32). + addedSelectorAndMethodClassLiterals := addedExtraLiterals := false. - addedSelectorAndMethodClassLiterals := false. optimizedSelectors := Set new!

1 0

VM crash upgrading via trunk from 5.1-17325 (420->421)
by Tim Johnson 20 Mar '18

20 Mar '18

Hi all, I was able to upgrade a 5.1 image all the way to update #420 (17325), thanks to the helpful new-ish methods in MCMcmUpdater. Should I be able to upgrade beyond that? When I try to apply #421, I get a friendly offer to drop into an emergency evaluator. One time a dialog box appeared, informing me that the VM has crashed. I thought I grabbed a screenshot of the VM crash dialog, but I guess I didn't. I do have a crash.dmp file. System details: 32-bit Windows 7 32-bit image, starting with 5.1 and upgraded via trunk through update-420 VMs tried: squeakcog.spur_win32x86_201803080952 and cog_win32x86_squeak.cog.spur_201608171728 Updates being applied at time of crash: update-mt.421.mcm System-mt.963 (I was also unable to update a 5.1 image via trunk past some point on OS X without a crash. It might have been this update there too, but I don't have the details to confirm for now.) Thanks, Tim

5 10

CompiledMethod>>#valueWithReceiver:arguments:
by Tim Johnson 19 Mar '18

19 Mar '18

Hi all, Browsing through a 5.1+ image today, I noticed that CompiledMethod>>#valueWithReceiver:arguments: reads as follows. Does this method indeed need to be changed? valueWithReceiver: aReceiver arguments: anArray "This should be changed after the release of Squeak 4.3 to ^self class receiver: aReceiver withArguments: anArray executeMethod: self" ^ aReceiver withArgs: anArray executeMethod: self Thanks, Tim

3 2

Re: [squeak-dev] [squeakland] Question about Audio Buffer/Timing
by karl ramberg 18 Mar '18

18 Mar '18

Hi, ScorePlayerMorph is the class that has best support for making music.( FM synthesizer) Try this do it: | n score | n := 3. score := (MIDIScore new tracks: ((1 to: n) collect: [:i | Array new]); trackInfo: ((1 to: n) collect: [:i | 'Instrument' , i printString]); tempoMap: nil; ticksPerQuarterNote: 96). ScorePlayerMorph openOn: score title: 'empty score' In the opened ScorePlayerMorph click on PianoRoll. Right click on the opened PianoRollScore and select 'add keyboard' in the menu. When you click on the opened keyboard it records to the PianoRollScore You can select different instuments in the ScorePlayerMorph. Muting the different instruments in ScorePlayerMorph to add/edit the PianoRollScore¨ Clicking on 'oboe1' you get a meny to select different FM synth premade instruments. The bottom of that menu give you 'edit oboe1' Selecting this will give you a DNU because the image does not have class ScaleMorph anymore. It can be found in old images and filed out. There where some licensing issues and I think maybe the author passed away before the class could be re licensed. Anyway, enjoy :-) These tools funktion but have MANY rough edges and a lot can be done to improve them. Best, Karl On Sat, Feb 24, 2018 at 5:56 PM, Jeremy Landry <hakyoku(a)gmail.com> wrote: > What can I do to make new music in Etoys, then? According to FLOSS > manual, there's nothing for recording...? The purpose of the sequencer was > to generate new music...this is basically the goal here...and to do so > without using an a MIDI instrument (well, a physical one, anyway...a > simulated one is fine!) > > On Sat, Feb 24, 2018 at 2:27 AM, karl ramberg <karlramberg(a)gmail.com> > wrote: > >> Etoys ticking is not precise enough to do music timing. >> Ticking might be offset by other task the system is doing. >> You should use the ScorePlayerMorph for music. >> >> Best, >> Karl >> >> On Thu, Feb 22, 2018 at 9:55 PM, Jeremy Landry <hakyoku(a)gmail.com> wrote: >> >>> Maybe clicking the sequencer squares to look like this will make more >>> sense when you play it back: >>> https://imgur.com/a/ZHsaS >>> >>> Setting the script to tick should be obvious what the problem is: not >>> only is the playback not timed at the same interval as the script >>> tick-rate, but it will 'skip' sometimes and omit playback. What you should >>> hear is nonstop, fairly consistent drum smacks, like a drum roll. Instead, >>> you'll hear it roll a little, stop quickly, then start rolling again, stop >>> quickly, and almost at random. Does this help open up the problem? It's >>> not really about music here, just about timing and consistency of >>> triggering sounds on a timer...sometimes they do sound off, sometimes they >>> dont, sometimes they're in-time, sometimes they're not. If you speed up >>> the ticks per second, you can hear that 'invisible metronome' I mentioned >>> earlier, there seems to be an 'always running' object that only looks for >>> new sounds to play at a regular interval, if the trigger doesn't make that >>> window, then it gets dropped seemingly...it's like it's aliasing the >>> instructions or something... >>> >>> Hope this helps, and I appreciate you helping looking into it! >>> >>> >>> On Thu, Feb 22, 2018 at 12:03 PM, Bob Arning <arning315(a)comcast.net> >>> wrote: >>> >>>> I'm not enough of a musician to really know if it's behaving or not. >>>> These are drums, so it's not a continuous sound. When I set the script to >>>> ticking, I do hear an occasional glitch that my well be due to garbage >>>> collection -- it's possible that tweaking some gc parameters might reduce >>>> this. Perhaps a youtube posting with the sound you are hearing would let me >>>> compare it to what I'm hearing. >>>> >>>> On 2/22/18 2:33 PM, Jeremy Landry wrote: >>>> >>>> https://www.youtube.com/watch?v=_JlCCtHLHDk I forgot to post this in >>>> the last message showing the more stable timing done with 'pure' squeak >>>> classes/methods. >>>> >>>> On Thu, Feb 22, 2018 at 11:32 AM, Jeremy Landry <hakyoku(a)gmail.com> >>>> wrote: >>>> >>>>> https://drive.google.com/file/d/1nJlQ4huXcKZmTm6GADl40ZrWAEd >>>>> 7Kv97/view?usp=sharing >>>>> >>>>> This is a demo of the problem for ETOYS 5 (along with some other stuff >>>>> there that shows what I've looked into, to some degree). Hitting play on >>>>> the scriptor, you will hear a sequence that has awful timing. I don't >>>>> expect 'sample perfect', zero latency or anything spectacular, but it would >>>>> seem that if there's timers in the system, everything should adhere to it, >>>>> or else not be called timers and something like, >>>>> 'when-we-get-around-to-its'. This video here demonstrates that Squeak, at >>>>> least, can do timing just fine and older versions have midi demos, but >>>>> again, I'm using Etoys for a specific reason, so it's confusing me as to >>>>> why the delays happen... >>>>> >>>>> Both sequencers are mouse interactive and playing with the script >>>>> timer and setting blocks on/off can reveal this hidden metronome...maybe >>>>> that IS the buffer? I'm not sure...what's most puzzling is that sometimes >>>>> it will sound right, and sometimes it won't...even if it wasn't correct, >>>>> I'd probably be okay if it was consistently incorrect because I can >>>>> actually work with consistency, so I guess if nothing else, that's what I'm >>>>> trying to figure out how to get without making tile usage unavailable for a >>>>> sequencer built on etoys tiles... >>>>> >>>>> Thanks for all the efforts so far...I did notice some changing in the >>>>> timing when I checked the preference there but also unchecked the >>>>> preference of stopSoundsWhenDone, just in case it was hiccuping by shutting >>>>> down the sound stream then making a new one. It didn't help, but I had >>>>> forgotten about these preferences. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Thu, Feb 22, 2018 at 10:57 AM, Bob Arning <arning315(a)comcast.net> >>>>> wrote: >>>>> >>>>>> There do seem to be some platform issues as to whether this will >>>>>> really work. Some things you could do: >>>>>> >>>>>> - check the value of the Preference for #soundQuickStart -- make it >>>>>> true if not already >>>>>> >>>>>> - put some code into the SoundPlayer method to tell you if quickStart >>>>>> is being requested and if not honored, why >>>>>> >>>>>> On 2/22/18 1:22 PM, Jeremy Landry wrote: >>>>>> >>>>>> Thanks for the crossover. I am subscribed, but generally shy away >>>>>> from posting there as it seems out of my league and my main interest is in >>>>>> Etoys since, well, again, leagues and all that. I know just enough ST to >>>>>> break things, not build them! :) >>>>>> >>>>>> So using the code from this message from Bob Arning: >>>>>> *Bob Arning* arning315 at comcast.net >>>>>> <squeak-dev%40lists.squeakfoundation.org?Subject=Re%3A%20%5Bsqueak-dev%5D%20%5Bsqueakland%5D%20Question%20about%20Audio%20Buffer/Timing&In-Reply-To=%3C269cdd30-7c77-6cab-22aa-591eee543b21%40comcast.net%3E> >>>>>> *Thu Feb 22 15:49:07 UTC 2018* >>>>>> >>>>>> - Previous message: [squeak-dev] [squeakland] Question about >>>>>> Audio Buffer/Timing >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/197505…> >>>>>> - Next message: [squeak-dev] [squeakland] Question about Audio >>>>>> Buffer/Timing >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/197509…> >>>>>> - *Messages sorted by:* [ date ] >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/date.h…> >>>>>> [ thread ] >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/thread…> >>>>>> [ subject ] >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/subjec…> >>>>>> [ author ] >>>>>> <http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-February/author…> >>>>>> >>>>>> ------------------------------ >>>>>> >>>>>> SoundPlayer class gives a clue: >>>>>> >>>>>> resumePlaying: aSound quickStart: quickStart >>>>>> "Start playing the given sound without resetting it; it will resume >>>>>> playing from where it last stopped. If quickStart is true, then try to >>>>>> start playing the given sound immediately." >>>>>> >>>>>> >>>>>> Just looking at it and taking a guess, it doesn't seem to be *quite* >>>>>> the thing I was looking for. I was thinking there's a method/class >>>>>> variable with a value that could be changed to affect the system, rather >>>>>> than 'poking in' every thing I want to play when I want to play it >>>>>> individually because the ultimate effect is that Etoys PLAYSOUND:SOUND tile >>>>>> will work as normal and this seems that it would have to be used instead of >>>>>> the tiles...I have no idea if this is possible, but I'll also dig around >>>>>> the class browser in Etoys, maybe I'll stumble into something, but so far, >>>>>> as I noted, I only found the sound-buffer and sample rates, not the imposed >>>>>> delay method that I remember reading about. I remember the reasoning it >>>>>> was put in was to prevent accidental playing of sounds inside of a >>>>>> single-frame repeat-tile...i.e. a repeat tile with any value other than 1 >>>>>> and inside of it having a playsound:sound tile would overload the speakers >>>>>> and make nasty noises because so many things are playing on top of each >>>>>> other. I actually WANT this. Based on how sound plays now, you can hear an >>>>>> 'invisible' metronome that makes sure all sounds are separated and equally >>>>>> spaced apart and in the case of repeat tiles, only seems to accept the last >>>>>> sound as valid/playable. >>>>>> >>>>>> Thanks for the help so far! I'm not expecting a solution because I >>>>>> don't know if one exists, but my thought is 'if it was done, it can be >>>>>> undone'...and just looking at how to undo it! :p >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Feb 22, 2018 at 9:59 AM, David T. Lewis <lewis(a)mail.msen.com> >>>>>> wrote: >>>>>> >>>>>>> There is some follow up discussion happening on the squeak-dev list. >>>>>>> I don't >>>>>>> know if it helps, but you can read the posts here if you are not >>>>>>> subscribed to >>>>>>> that list: >>>>>>> >>>>>>> http://lists.squeakfoundation.org/pipermail/squeak-dev/2018- >>>>>>> February/197508.html >>>>>>> >>>>>>> HTH, >>>>>>> Dave >>>>>>> >>>>>>> On Thu, Feb 22, 2018 at 10:27:18AM -0500, David T. Lewis wrote: >>>>>>> > Hi Jeremy, >>>>>>> > >>>>>>> > I am copying this to the squeak-dev list in case someone there can >>>>>>> offer >>>>>>> > some guidance. >>>>>>> > >>>>>>> > Dave >>>>>>> > >>>>>>> > >>>>>>> > On Wed, Feb 21, 2018 at 02:44:21PM -0800, Jeremy Landry wrote: >>>>>>> > > Hi, I made a quick audio sequencer test in Etoys and found that >>>>>>> there's a >>>>>>> > > hidden 'timer' that limits the responsiveness of new sounds that >>>>>>> go into >>>>>>> > > the playback buffer (terminology isn't accurate, but hopefully >>>>>>> it makes >>>>>>> > > sense to people). >>>>>>> > > >>>>>>> > > I found the sound buffer setting, but was wondering if there's >>>>>>> something >>>>>>> > > else that limits how fast new sounds get added to the playback >>>>>>> stream? I >>>>>>> > > read somewhere (old-man-aphasia here) that some code was added >>>>>>> to prevent >>>>>>> > > overloading the buffer so surely there's a snippet of code I >>>>>>> could add to a >>>>>>> > > project to reverse this, if it's what is causing the delay? >>>>>>> > > >>>>>>> > > Thanks for any help finding the solution. >>>>>>> > >>>>>>> > > _______________________________________________ >>>>>>> > > squeakland mailing list >>>>>>> > > squeakland(a)lists.squeakland.org >>>>>>> > > http://lists.squeakland.org/mailman/listinfo/squeakland >>>>>>> > >>>>>>> > _______________________________________________ >>>>>>> > squeakland mailing list >>>>>>> > squeakland(a)lists.squeakland.org >>>>>>> > http://lists.squeakland.org/mailman/listinfo/squeakland >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> squeakland mailing listsqueakland@lists.squeakland.orghttp://lists.squeakland.org/mailman/listinfo/squeakland >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> squeakland mailing list >>>>>> squeakland(a)lists.squeakland.org >>>>>> http://lists.squeakland.org/mailman/listinfo/squeakland >>>>>> >>>>>> >>>>> >>>> >>>> >>> >>> _______________________________________________ >>> squeakland mailing list >>> squeakland(a)lists.squeakland.org >>> http://lists.squeakland.org/mailman/listinfo/squeakland >>> >>> >> >

3 3

The Trunk: Kernel-dtl.1162.mcz
by commits＠source.squeak.org 17 Mar '18

17 Mar '18

David T. Lewis uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-dtl.1162.mcz ==================== Summary ==================== Name: Kernel-dtl.1162 Author: dtl Time: 17 March 2018, 3:11:04.807847 pm UUID: 46f46dde-06c6-4189-a8e6-4a07eda959bf Ancestors: Kernel-eem.1161 Use #rootClasses introduced in Environments-fbs.27 =============== Diff against Kernel-eem.1161 =============== Item was changed: ----- Method: Class class>>rootsOfTheWorld (in category 'inquiries') ----- rootsOfTheWorld "return a collection of classes which have a nil superclass" + ^Smalltalk globals rootClasses! - ^(Smalltalk globals select: [:each | each isBehavior and: [each superclass isNil]]) asOrderedCollection!

1 0

The Trunk: Environments-fbs.27.mcz
by commits＠source.squeak.org 17 Mar '18

17 Mar '18

David T. Lewis uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-fbs.27.mcz ==================== Summary ==================== Name: Environments-fbs.27 Author: fbs Time: 9 May 2013, 10:39:28.736 pm UUID: 8fe75259-bf86-4dfd-82f5-e57c4fbbca68 Ancestors: Environments-fbs.26 Like what Class rootsOfTheWorld does, only just for one Environment. =============== Diff against Environments-fbs.26 =============== Item was added: + ----- Method: Environment>>rootClasses (in category 'accessing') ----- + rootClasses + "return a collection of classes which have a nil superclass" + ^ (self select: [:each | each isBehavior and: [each superclass isNil]]) asOrderedCollection.!

1 0

The Trunk: MorphicExtras-kfr.225.mcz
by commits＠source.squeak.org 17 Mar '18

17 Mar '18

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.225.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.225 Author: kfr Time: 17 March 2018, 5:17:23.487749 pm UUID: 78480405-7131-4243-8b61-5dbe706cfb8c Ancestors: MorphicExtras-topa.224 Fix for EnvelopeEditorMorph so it can open =============== Diff against MorphicExtras-topa.224 =============== Item was changed: ----- Method: EnvelopeEditorMorph>>buildScalesIn: (in category 'editing') ----- buildScalesIn: frame | env | env := envelope. pixPerTick := graphArea width // (self maxTime//10) max: 1. "hminortick := ( 1 + ( self maxTime // 800 ) ) * 10. hmajortick := ( 1 + ( self maxTime // 800 ) ) * 100." hScale := (Morph newBounds: ((graphArea left)@(frame top) corner: (self xFromMs: self maxTime)@(graphArea top - 1))) color: Color lightGreen. " hScale := (ScaleMorph newBounds: ((graphArea left)@(frame top) corner: (self xFromMs: self maxTime)@(graphArea top - 1))) start: 0 stop: self maxTime minorTick: hminortick minorTickLength: 3 majorTick: hmajortick majorTickLength: 10 caption: 'milliseconds' tickPrintBlock: [:v | v printString]. " self addMorph: hScale. vScale := (Morph newBounds: (0@0 extent: (graphArea height)@(graphArea left - frame left))) color: Color lightGreen. "vScale := ScaleMorph newBounds: (0@0 extent: (graphArea height)@(graphArea left - frame left))." + "env name = 'pitch' - env name = 'pitch' ifTrue: [env scale >= 2.0 ifTrue: [vScale start: 0 stop: env scale minorTick: env scale / 24 minorTickLength: 3 majorTick: env scale / 2.0 majorTickLength: 10 caption: 'pitch (octaves)' tickPrintBlock: [:v | (v-(env scale/2)) asInteger printString]] ifFalse: [vScale start: 0 stop: env scale minorTick: 1.0/48.0 minorTickLength: 3 majorTick: 1.0/12.0 majorTickLength: 10 caption: 'pitch (half-steps)' tickPrintBlock: [:v | (v-(env scale/2)*12) rounded printString]]] ifFalse: [ env name = 'random pitch:' ifTrue: [ vScale start: 0.9 stop: 1.1 minorTick: 0.2 / 50.0 minorTickLength: 3 majorTick: 0.2 / 5.0 majorTickLength: 10 caption: env name tickPrintBlock: [:v | v printString]] ifFalse: [ vScale start: 0 stop: env scale minorTick: env scale / 50.0 minorTickLength: 3 majorTick: env scale / 5.0 majorTickLength: 10 caption: env name tickPrintBlock: [:v | v printString]]. + ]." - ]. vScale := TransformationMorph new asFlexOf: vScale. vScale angle: Float pi / 2.0. self addMorph: vScale. vScale position: (frame left)@(graphArea top-1) - (3@1). !

1 0

Method Finder and deprecated method(s)
by Tim Johnson 17 Mar '18

17 Mar '18

Hi all, I seem to have stumbled into a few issues, and am taking the bold step of including them all in a single email. My apologies. Tested/explored in 6.0a-#17799. Issues: [1] The deprecation of SequenceableCollection>>#upTo: [2] Removing deprecated #defaultBackgroundColor from MethodFinder [3] MethodFinder class variable Dangerous and MethodFinder>>#organizationFiltered: So: [1] The deprecation of SequenceableCollection>>#upTo: means Method Finder (a.k.a. Selector Browser) now pops up two modal dialogs if one enters something like: 'deprecated '. 'method'. 'deprecated method' ...into its code entry pane and hits 'save'. This appears to be due to the inclusion of #upTo: in MethodFinder>>#initialize2 as a method which would be sent to a PositionableStream... which seems reasonable. According to ReadStream>>#readStream, a ReadStream is intended to be polymorphic with SequencableCollection. So, then, if #upTo: is an intrinsic method of a Stream, does this mean it must be retained in SequencableCollection? E.g. should it become undeprecated? Though never until now have I thought about what it would take to use Method Finder on a stream! So I tried something similar to (but not exactly) the following in a Workspace: MethodFinder methodFor: { { 'deprecated' readStream . $c }. 'depre' } "changed to protect the innocent user who put array braces in the wrong place on his first attempt" [2] ...and /another/ deprecation warning popped up: "Object>>#defaultBackgroundColor has been deprecated. Implement #uniformWindowColor and #customWindowColor in your model." ...#defaultBackgroundColor appears in method source 23 times, so there are probably still a number of places where this deprecated method needs to be engineered around :) However, the place where it's probably causing trouble in this case is in MethodFinder>>#initialize. Attached is a change set to remove it from that method. [3] However, there is another problem with MethodFinder>>#initialize and #initialize2. They both include comments at their respective ends which call MethodFinder>>#organizationFiltered:, but that method fails due to the class variable Dangerous being uninitialized. The method which initializes Dangerous, MethodFinder>>#noteDangerous, looks to be unsent. If I add "self noteDangerous" to one of the #initialize methods (I added it to #initialize3 to test), this makes #organizationFiltered: work again (after initializing MethodFinder). Note that Dangerous is not mentioned in the MethodFinder class comment, but other class variables are. I didn't do any research for how Dangerous is intended to be useful. Thanks for reading. Best, Tim

6 11

← Newer
1
...
5
6
7
8
9
10
11
...
15
Older →

Jump to page: