Squeak-dev May 2019

squeak-dev@lists.squeakfoundation.org

36 participants
153 discussions

The Trunk: Kernel-fn.1223.mcz
by commits＠source.squeak.org 23 Jul '19

23 Jul '19

Fabio Niephaus uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fn.1223.mcz ==================== Summary ==================== Name: Kernel-fn.1223 Author: fn Time: 29 April 2019, 12:52:13.424813 pm UUID: 910aa151-72fe-4f6c-9645-fa735fb17f63 Ancestors: Kernel-nice.1222 SmallInteger and SmallFloat64 shouldNotImplement postCopy. =============== Diff against Kernel-nice.1222 =============== Item was added: + ----- Method: SmallFloat64>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement! Item was added: + ----- Method: SmallInteger>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement!

5 5

The Inbox: ShoutCore-nice.63.mcz
by commits＠source.squeak.org 19 Jul '19

19 Jul '19

Nicolas Cellier uploaded a new version of ShoutCore to project The Inbox: http://source.squeak.org/inbox/ShoutCore-nice.63.mcz ==================== Summary ==================== Name: ShoutCore-nice.63 Author: nice Time: 7 April 2019, 3:24:31.721529 pm UUID: 7440b898-b497-493b-adfa-67aef04e0980 Ancestors: ShoutCore-eem.62 Attempt to fix highlighting of 1to:-1 I don't see the point of testing the presence of a binary selector character after a colon $:, except maybe the case of assignment :=, so only test that case. =============== Diff against ShoutCore-eem.62 =============== Item was changed: ----- Method: SHParserST80>>scanIdentifier (in category 'scan') ----- scanIdentifier | c start | start := sourcePosition. [ (c := self nextChar) isAlphaNumeric or: [ allowUnderscoreSelectors and: [ c == $_ ] ] ] whileTrue. + (c == $: and: [ self peekChar ~= $= ]) - (c == $: and: [ (self isSelectorCharacter: self peekChar) not ]) ifTrue: [ self nextChar ]. currentToken := source copyFrom: start to: sourcePosition - 1. currentTokenSourcePosition := start!

3 3

[Please Review] Refactoring for #literalsDo: etc.
by Marcel Taeumel 05 Jul '19

05 Jul '19

Hi, there. Please find attached a change set that (tries to) clean up everything related to enumerating or testing literals in CompiledCode, CompiledMethod, and CompiledBlock. I have three important questions: - The purpose of #hasLiteralThorough is not needed anymore because we enumerate and test always in a "thorough" way? - Are the enumeration boundaries in CompiledCode, CompiledMethod, CompiledBlock in #literalsDo: correct? - What is a literal as expected in #hasLiteral: etc. to answer true? Just symbols or also bindings (symbol-to-class) and classes themselves? Try exploring this result: "(Morph >> #fullDrawOn:) literals" or similar. Best, Marcel

4 10

Re: [squeak-dev] Proposal: Morphs in Text
by Nicolas Cellier 24 Jun '19

24 Jun '19

Hi Patrick, i did not have time to inquire about the .cs but I can partially answer Le mar. 28 mai 2019 à 18:27, <patrick.rein(a)hpi.uni-potsdam.de> a écrit : > Hi everyone, > > please find attached a change set which includes: > 1.) Some fixes to the Scanner infrastructure to support Morphs in Text > better > 2.) Improvements to describe how a Morph should be aligned with regard to > the text. Relevant methods on Morph are: > #textAnchorVerticalAlignment: > #textAnchorPadding: > #textAnchorConsumesHorizontalSpace: > > You can see an example by executing the body of the test: > TextAnchorTest>>#testHavingAnAnchorCanBeAlignedDifferently > > !Warning: As this touches Scanner code a lot, loading this change set > might make your image unresponsive! > > I would like to point out that the test cases are preliminary and a few of > the methods still require polishing. Nevertheless, I would like to ask for > comments on the change set, in particular regarding: > 1.) Should the alignment information be stored in the Morph or the > TextAnchorAttribute? Currently the information is stored in the Morph which > parallels LayoutProperties. > I think it should be in Morph, because Morph can have its own notion of baseline etc... (imagine for example that I want to render a FractionMathMorph 1/(1/x+1), then I want the main (upper) fraction bar to be somehow aligned with the text baseline) If Morph does not carry such information, then we can wrap in another Morph that does (but I'm not sure that's how Morph works currently...) > 2.) Is using caseOf: in Scanner code fine? I suspect it to be quite > expensive which is probably not a good thing in Scanners? > unless you have thousands of Morphs, you won't be able to measure any difference 3.) Should the cursor allow users to navigate (or select?) the "start of > header" character that is used to denote the text anchor placement? > If Morph is aligned with text (renderd as if a single character), then i would expect so (so as to be able to copy/paste for example) 4.) Does anyone remember / know what the textAnchorType was intended for? > The previous implementation largely ignored it and this one does so too. > I guess it could be like classical editors: Morph aligned with text (as a single character) or super-imposed over text, or text wraps around the morph, or ... > Thanks and best wishes, > Patrick >

4 8

FFI lookup of modules
by patrick.rein＠hpi.uni-potsdam.de 07 Jun '19

07 Jun '19

Hi everyone, due to some student projects I came to notice an issue with FFI for which I wanted to ask whether anyone knows anything about it (in order to avoid tackling a solved / impossible issue). The problem manifests when trying to load a library which is not the system library and not the FFIPlugin on a 64bit Windows (and one other platform which I currently do not remember, I think it was MacOS). The main problem is that the external module is not found, although it is at a location in which it should be found. This happens on a variety of VMs. You can reproduce this by installing the latest FFI from source.squeak.org and then copying SqueakFFIPrims.dll to SqueakFFIPrims2.dll, changing a few of the FFITestLibrary cdecls to point to the copied dll, and then run the tests. The system32 and user32 libraries and the ordinary SqueakFFIPlugin code is running just fine, so I get the impression that I am missing something basic here. I am grateful for any insights on this. Otherwise my next step would be to create a debug build and dive into the inner workings of the FFI plugin :) Bests Patrick

2 1

The Inbox: Collections-ct.827.mcz
by commits＠source.squeak.org 05 Jun '19

05 Jun '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.827.mcz ==================== Summary ==================== Name: Collections-ct.827 Author: ct Time: 31 May 2019, 1:49:32.006053 pm UUID: fe89c3e0-5003-aa40-8f1f-cd356ae17716 Ancestors: Collections-cmm.826 Add convenience method for joining strings (Collection>>asStringByDelimiter:) =============== Diff against Collections-cmm.826 =============== Item was added: + ----- Method: Collection>>asStringByDelimiter: (in category 'printing') ----- + asStringByDelimiter: aDelimiter + + ^String streamContents: [:s | self asStringOn: s delimiter: aDelimiter]!

10 18

Attempting to use git Browser to view https://github.com/LabWare/MQTT-broker
by tim Rowledge 01 Jun '19

01 Jun '19

I wanted to take a look at the code John McI recently announced that built on my MQTT client. It's on a github server, in that not-very-comprehendable format. I had noticed the 'Git Browser' entry in the Tools menu so I thought that might help with viewing the code. Well... it took around ten minutes to install, added around 2Mb to my change log, added what looks like 50+ categories to the browser category list and has no readily findable doc. Oh and a trivial point/bug, the progress bar kept leaping around from screen centre to centred on the mouse pointer - a small but very visually irritating point. Once loaded and a Git Browser opened I was all at sea. As mentioned, no readily apparent doc, and the vast list of added categories didn't exactly help in trying to find a relevant seeming class to look at any class comments. Some googling found the 2018 HPI paper on the system which at least has some small explanation of the UI, but nothing to help me start using it. I eventually found the 'clone project' menu entry and recalled from my *extremely* tiny familiarity that this might well be important. I pasted the URL from the github page 'Clone or download' widget in and thing whirred and clanked a bit. My problem now is that I still see nothing that appears to have any connection to actual visible code. This is what I see - Where might I find useful information on what to do next? Is this even supposed to work? It may well be broken since the related 'Metacello' Tools menu entry fails in Installer class>ensureRecentMetacello since there is a logic bug that leaves the temp 'metacello' nil if Metacello is already installed. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: PHP: Put Hackers into Privileged mode

5 8

The Inbox: SUnitGUI-ct.70.mcz
by commits＠source.squeak.org 31 May '19

31 May '19

A new version of SUnitGUI was added to project The Inbox: http://source.squeak.org/inbox/SUnitGUI-ct.70.mcz ==================== Summary ==================== Name: SUnitGUI-ct.70 Author: ct Time: 31 May 2019, 2:15:26.862053 pm UUID: 44154dfb-d0a5-e841-9b8e-826248842855 Ancestors: SUnitGUI-tpr.69 Add convenience method (#newForSuite:) for instance creation of TestRunner. =============== Diff against SUnitGUI-tpr.69 =============== Item was added: + ----- Method: TestRunner class>>newForSuite: (in category 'instance-creation') ----- + newForSuite: aSuite + + | runner classes categories | + runner := TestRunner new. + classes := aSuite tests asSet collect: #class. + categories := classes collect: #category. + ^ runner + filterCategoriesBy: ((categories collect: #asString) asStringByDelimiter: $;); + filterClassesBy: ((classes collect: #asString) asStringByDelimiter: $;); + yourself! Item was changed: ----- Method: TestRunner>>filterCategories (in category 'accessing-categories') ----- filterCategories | pattern | pattern := UIManager default request: 'Pattern(s) to select categories:\ (separate patterns with '';'')' withCRs initialAnswer: (categoryPattern ifNil: ['*']). (pattern isNil or: [pattern isEmpty]) ifTrue: [^self]. + self filterCategoriesBy: pattern! - categoriesSelected := ((categoryPattern := pattern) subStrings: ';') - inject: Set new - into: [:matches :subPattern| - matches - addAll: (categories select: [ :each | subPattern match: each]); - yourself]. - self changed: #allSelections; changed: #categorySelected; updateClasses! Item was added: + ----- Method: TestRunner>>filterCategoriesBy: (in category 'accessing-categories') ----- + filterCategoriesBy: aPattern + categoriesSelected := ((categoryPattern := aPattern) subStrings: ';') + inject: Set new + into: [:matches :subPattern| + matches + addAll: (categories select: [ :each | subPattern match: each]); + yourself]. + self changed: #allSelections; changed: #categorySelected; updateClasses! Item was changed: ----- Method: TestRunner>>filterClasses (in category 'accessing-classes') ----- filterClasses | pattern | pattern := UIManager default request: 'Pattern(s) to select tests:\ (separate patterns with '';'')' withCRs initialAnswer: (classPattern ifNil: '*'). (pattern isNil or: [pattern isEmpty]) ifTrue: [^self]. + self filterClassesBy: pattern! - classesSelected := ((classPattern := pattern) subStrings: ';') - inject: Set new - into: [:matches :subPattern| - matches - addAll: (classes select: [ :each | subPattern match: each name]); - yourself]. - self - changed: #allSelections; - changed: #classSelected; - changed: #hasRunnable! Item was added: + ----- Method: TestRunner>>filterClassesBy: (in category 'accessing-classes') ----- + filterClassesBy: aPattern + classesSelected := ((classPattern := aPattern) subStrings: ';') + inject: Set new + into: [:matches :subPattern| + matches + addAll: (classes select: [ :each | subPattern match: each name]); + yourself]. + self + changed: #allSelections; + changed: #classSelected; + changed: #hasRunnable!

1 0

The Inbox: CollectionsTests-ct.298.mcz
by commits＠source.squeak.org 31 May '19

31 May '19

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-ct.298.mcz ==================== Summary ==================== Name: CollectionsTests-ct.298 Author: ct Time: 31 May 2019, 1:52:34.276053 pm UUID: 717b8c7c-d8cb-4541-9d60-3cb8814d4097 Ancestors: CollectionsTests-ul.297 Test Collection>>asStringByDelimiter (cf. Collections, ct.827) =============== Diff against CollectionsTests-ul.297 =============== Item was added: + ----- Method: CollectionTest>>testAsStringByDelimiter (in category 'testing') ----- + testAsStringByDelimiter + | delimiter | + delimiter := ' +++ '. + {OrderedCollection new. Set new.} do: + [ :coll | + self assert: (coll asStringByDelimiter: delimiter) = ''. + + coll add: 1. + self assert: (coll asStringByDelimiter: delimiter) = '1'. + + coll add: 2; add: 3. + self assert: (coll asStringByDelimiter: delimiter) = '1 +++ 2 +++ 3'].!

1 0

The Trunk: KernelTests-mt.365.mcz
by commits＠source.squeak.org 31 May '19

31 May '19

Marcel Taeumel uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-mt.365.mcz ==================== Summary ==================== Name: KernelTests-mt.365 Author: mt Time: 31 May 2019, 11:49:30.444936 am UUID: 4087706d-1610-504e-9930-d0ab9de30dd5 Ancestors: KernelTests-nice.364, KernelTests-cmfcmf.357 merge cmfcmf.357 =============== Diff against KernelTests-nice.364 =============== Item was added: + ----- Method: RandomTest>>testRoll (in category 'tests') ----- + testRoll + + | random result | + random := Random seed: 14482. + + "Roll the default die (d6)" + 100 timesRepeat: [ + result := random roll: 'd'. + self assert: result >= 1 description: [ 'Rolled value ', result asString, ' should be 1 or more.' ]. + self assert: result <= 6 description: [ 'Rolled value ', result asString, ' should be 6 or less.' ] ]. + 100 timesRepeat: [ + result := random roll: '1d'. + self assert: result >= 1 description: [ 'Rolled value ', result asString, ' should be 1 or more.' ]. + self assert: result <= 6 description: [ 'Rolled value ', result asString, ' should be 6 or less.' ] ]. + + "Roll a d20" + 100 timesRepeat: [ + result := random roll: '1d20'. + self assert: result >= 1 description: [ 'Rolled value ', result asString, ' should be 1 or more.' ]. + self assert: result <= 20 description: [ 'Rolled value ', result asString, ' should be 20 or less.' ] ]. + + "Roll a d% (d100)" + 1000 timesRepeat: [ + result := random roll: '1d%'. + self assert: result >= 1 description: [ 'Rolled value ', result asString, ' should be 1 or more.' ]. + self assert: result <= 100 description: [ 'Rolled value ', result asString, ' should be 100 or less.' ] ]. + 1000 timesRepeat: [ + result := random roll: 'd%'. + self assert: result >= 1 description: [ 'Rolled value ', result asString, ' should be 1 or more.' ]. + self assert: result <= 100 description: [ 'Rolled value ', result asString, ' should be 100 or less.' ] ]. + + "Roll multiple dice" + 100 timesRepeat: [ + result := random roll: '2d2'. + self assert: result >= 2 description: [ 'Rolled value ', result asString, ' should be 2 or more.' ]. + self assert: result <= 4 description: [ 'Rolled value ', result asString, ' should be 4 or less.' ] ]. + 100 timesRepeat: [ + result := random roll: '1d2+1d2'. + self assert: result >= 2 description: [ 'Rolled value ', result asString, ' should be 2 or more.' ]. + self assert: result <= 4 description: [ 'Rolled value ', result asString, ' should be 4 or less.' ] ]. + + "Roll some d1s" + result := random roll: '10d1'. + self assert: result = 10 description: [ 'Rolled value ', result asString, 'should be 10.' ]. + result := random roll: '10d1-5d1'. + self assert: result = 5 description: [ 'Rolled value ', result asString, 'should be 5.' ]. + + "Roll a constant value" + result := random roll: '5'. + self assert: result = 5 description: [ 'Rolled value ', result asString, 'should be 5.' ]. + result := random roll: '5+3+2'. + self assert: result = 10 description: [ 'Rolled value ', result asString, 'should be 10.' ]. + + "Roll die and add constant value" + result := random roll: '1d1+3'. + self assert: result = 4 description: [ 'Rolled value ', result asString, 'should be 4.' ].!

1 0

Jump to page: