Squeak-dev May 2019

squeak-dev@lists.squeakfoundation.org

36 participants
153 discussions

The Trunk: Kernel-nice.1235.mcz
by commits＠source.squeak.org 23 May '19

23 May '19

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1235.mcz ==================== Summary ==================== Name: Kernel-nice.1235 Author: nice Time: 16 May 2019, 12:08:27.320094 am UUID: dd74b668-0767-441e-a952-5c73af6327be Ancestors: Kernel-nice.1234 Round accelerated arithmetic chunks to upper multiple of 4 bytes rather than to lower. I believe that this marginally improves the performance because it's a tiny bit better to recompose a longer least significant chunk with a shorter most significant chunk. If someone wants to confirm... It's better to tune the threshold before benchmarking. See LargeArithmeticBench from http://www.squeaksource.com/STEM.html and http://smallissimo.blogspot.com/2019/05 blog for details. =============== Diff against Kernel-nice.1234 =============== Item was changed: ----- Method: LargePositiveInteger>>digitDiv21: (in category 'private') ----- digitDiv21: anInteger "This is part of the recursive division algorithm from Burnikel - Ziegler Divide a two limbs receiver by 1 limb dividend Each limb is decomposed in two halves of p bytes (8*p bits) so as to continue the recursion" | p qr1 qr2 | + "split in two parts, rounded to upper multiple of 4" + p := (anInteger digitLength + 7 bitShift: -3) bitShift: 2. - p := (anInteger digitLength + 1 bitShift: -1) bitClear: 2r11. p < self class thresholdForDiv21 ifTrue: [^(self digitDiv: anInteger neg: false) collect: #normalize]. qr1 := (self butLowestNDigits: p) digitDiv32: anInteger. qr2 := (self lowestNDigits: p) + (qr1 last bitShift: 8*p) digitDiv32: anInteger. qr2 at: 1 put: (qr2 at: 1) + ((qr1 at: 1) bitShift: 8*p). ^qr2! Item was changed: ----- Method: LargePositiveInteger>>digitDiv32: (in category 'private') ----- digitDiv32: anInteger "This is part of the recursive division algorithm from Burnikel - Ziegler Divide 3 limb (a2,a1,a0) by 2 limb (b1,b0). Each limb is made of p bytes (8*p bits). This step transforms the division problem into multiplication It must use a fast multiplyByInteger: to be worth the overhead costs." | a2 b1 d p q qr r | + "split in two parts, rounded to upper multiple of 4" + p :=(anInteger digitLength + 7 bitShift: -3) bitShift: 2. - p :=(anInteger digitLength + 1 bitShift: -1) bitClear: 2r11. (a2 := self butLowestNDigits: 2*p) < (b1 := anInteger butLowestNDigits: p) ifTrue: [qr := (self butLowestNDigits: p) digitDiv21: b1. q := qr first. r := qr last] ifFalse: [q := (1 bitShift: 8*p) - 1. r := (self butLowestNDigits: p) - (b1 bitShift: 8*p) + b1]. d := q * (anInteger lowestNDigits: p). r := (self lowestNDigits: p) + (r bitShift: 8*p) - d. [r < 0] whileTrue: [q := q - 1. r := r + anInteger]. ^Array with: q with: r ! Item was changed: ----- Method: LargePositiveInteger>>digitMul22: (in category 'private') ----- digitMul22: anInteger "Multiply after decomposing each operand in two parts, using Karatsuba algorithm. Karatsuba perform only 3 multiplications, leading to a cost O(n^3 log2) asymptotically better than super O(n^2) for large number of digits n. See https://en.wikipedia.org/wiki/Karatsuba_algorithm" | half xLow xHigh yLow yHigh low mid high | + "split each in two parts, rounded to upper multiple of 4" + half := (anInteger digitLength + 7 bitShift: -3) bitShift: 2. - "Divide each integer in two halves" - half := (anInteger digitLength + 1 bitShift: -1) bitClear: 2r11. xLow := self lowestNDigits: half. xHigh := self butLowestNDigits: half. yLow := anInteger lowestNDigits: half. yHigh := anInteger butLowestNDigits: half. "Karatsuba trick: perform with 3 multiplications instead of 4" low := xLow multiplyByInteger: yLow. high := xHigh multiplyByInteger: yHigh. mid := high + low + (xHigh - xLow multiplyByInteger: yLow - yHigh). "Sum the parts of decomposition" ^(high isZero ifTrue: [low] ifFalse: [(high bitShift: 16*half) inplaceAddNonOverlapping: low digitShiftBy: 0]) + (mid bitShift: 8*half)! Item was changed: ----- Method: LargePositiveInteger>>digitMul23: (in category 'private') ----- digitMul23: anInteger "Multiply after decomposing the receiver in 2 parts, and multiplicand in 3 parts. Only invoke when anInteger digitLength between: 3/2 and 5/2 self digitLength. This is a variant of Toom-Cook algorithm (see digitMul33:)" | half x1 x0 y2 y1 y0 y20 z3 z2 z1 z0 | + "divide self in 2 and operand in 3 parts, rounded to upper multiple of 4" + half := ( self digitLength + 7 bitShift: -3) bitShift: 2. - "divide self in 2 and operand in 3 parts" - half := ( self digitLength + 1 bitShift: -1) bitClear: 2r11. x1 := self butLowestNDigits: half. x0 := self lowestNDigits: half. y2 := anInteger butLowestNDigits: half * 2. y1 := anInteger copyDigitsFrom: half + 1 to: half * 2. y0 := anInteger lowestNDigits: half. "Toom trick: 4 multiplications instead of 6" y20 := y2 + y0. z3 := x1 multiplyByInteger: y2. z2 := x0 - x1 multiplyByInteger: y20 - y1. z1 := x0 + x1 multiplyByInteger: y20 + y1. z0 := x0 multiplyByInteger: y0. "Sum the parts of decomposition" ^z0 + ((z1 - z2 bitShift: -1) - z3 bitShift: 8*half) + (((z1 + z2 bitShift: -1) - z0) + (z3 bitShift: 8*half) bitShift: 16 * half)! Item was changed: ----- Method: LargePositiveInteger>>digitMul33: (in category 'private') ----- digitMul33: anInteger "Multiply after decomposing each operand in 3 parts, using a Toom-Cooke algorithm. Toom-Cooke is a generalization of Karatsuba divide and conquer algorithm. See https://en.wikipedia.org/wiki/Toom%E2%80%93Cook_multiplication Use a Bodrato-Zanoni variant for the choice of interpolation points and matrix inversion See What about Toom-Cook matrices optimality? - Marco Bodrato, Alberto Zanoni - Oct. 2006 http://www.bodrato.it/papers/WhatAboutToomCookMatricesOptimality.pdf" | third x2 x1 x0 y2 y1 y0 y20 z4 z3 z2 z1 z0 x20 | + "divide both operands in 3 parts, rounded to upper multiple of 4" + third := anInteger digitLength + 11 // 12 bitShift: 2. - "divide both operands in 3 parts" - third := anInteger digitLength + 2 // 3 bitClear: 2r11. x2 := self butLowestNDigits: third * 2. x1 := self copyDigitsFrom: third + 1 to: third * 2. x0 := self lowestNDigits: third. y2 := anInteger butLowestNDigits: third * 2. y1 := anInteger copyDigitsFrom: third + 1 to: third * 2. y0 := anInteger lowestNDigits: third. "Toom-3 trick: 5 multiplications instead of 9" z0 := x0 multiplyByInteger: y0. z4 := x2 multiplyByInteger: y2. x20 := x2 + x0. y20 := y2 + y0. z1 := x20 + x1 multiplyByInteger: y20 + y1. x20 := x20 - x1. y20 := y20 - y1. z2 := x20 multiplyByInteger: y20. z3 := (x20 + x2 bitShift: 1) - x0 multiplyByInteger: (y20 + y2 bitShift: 1) - y0. "Sum the parts of decomposition" z3 := z3 - z1 quo: 3. z1 := z1 - z2 bitShift: -1. z2 := z2 - z0. z3 := (z2 - z3 bitShift: -1) + (z4 bitShift: 1). z2 := z2 + z1 - z4. z1 := z1 - z3. ^z0 + (z1 bitShift: 8*third) + (z2 bitShift: 16*third) + (z3 + (z4 bitShift: 8*third) bitShift: 24*third)! Item was changed: ----- Method: LargePositiveInteger>>digitMulSplit: (in category 'private') ----- digitMulSplit: anInteger "multiply digits when self and anInteger have not well balanced digitlength. in this case, it is better to split the largest (anInteger) in several parts and recompose" | xLen yLen split q r high mid low sizes | yLen := anInteger digitLength. xLen := self digitLength. + "divide in about 1.5 xLen, rounded to upper multiple of 4" + split := (xLen * 3 + 7 bitShift: -3) bitShift: 2. - split := (xLen * 3 + 2 bitShift: -1) bitClear: 2r11. "Arrange to sum non overlapping parts" q := yLen // split. q < 3 ifTrue: [^(0 to: yLen - 1 by: split) detectSum: [:yShift | (self multiplyByInteger: (anInteger copyDigitsFrom: yShift + 1 to: yShift + split)) bitShift: 8 * yShift]]. r := yLen \\ split. "allocate enough bytes, but not too much, in order to minimise normalize cost; we could allocate xLen + yLen for each one as well" sizes := {q-1*split. q*split. q*split+r}. low := Integer new: (sizes atWrap: 0 - (q\\3)) + xLen neg: self negative ~~ anInteger negative. mid := Integer new: (sizes atWrap: 1 - (q\\3)) + xLen neg: self negative ~~ anInteger negative. high := Integer new: (sizes atWrap: 2 - (q\\3)) + xLen neg: self negative ~~ anInteger negative. 0 to: yLen - 1 by: 3 * split do: [:yShift | low inplaceAddNonOverlapping: (self multiplyByInteger: (anInteger copyDigitsFrom: yShift + 1 to: yShift + split)) digitShiftBy: yShift]. split to: yLen - 1 by: 3 * split do: [:yShift | mid inplaceAddNonOverlapping: (self multiplyByInteger: (anInteger copyDigitsFrom: yShift + 1 to: yShift + split)) digitShiftBy: yShift]. split * 2 to: yLen - 1 by: 3 * split do: [:yShift | high inplaceAddNonOverlapping: (self multiplyByInteger: (anInteger copyDigitsFrom: yShift + 1 to: yShift + split)) digitShiftBy: yShift]. ^high normalize + mid normalize + low normalize! Item was changed: ----- Method: LargePositiveInteger>>squaredByFourth (in category 'private') ----- squaredByFourth "Use a 4-way Toom-Cook divide and conquer algorithm to perform the multiplication. See Asymmetric Squaring Formulae Jaewook Chung and M. Anwar Hasan https://www.lirmm.fr/arith18/papers/Chung-Squaring.pdf" | p a0 a1 a2 a3 a02 a13 s0 s1 s2 s3 s4 s5 s6 t2 t3 | + "divide in 4 parts, rounded to upper multiple of 4" + p := (self digitLength + 15 bitShift: -4) bitShift: 2. - "divide in 4 parts" - p := (self digitLength + 3 bitShift: -2) bitClear: 2r11. a3 := self butLowestNDigits: p * 3. a2 := self copyDigitsFrom: p * 2 + 1 to: p * 3. a1 := self copyDigitsFrom: p + 1 to: p * 2. a0 := self lowestNDigits: p. "Toom-4 trick: 7 multiplications instead of 16" a02 := a0 - a2. a13 := a1 - a3. s0 := a0 squared. s1 := (a0 * a1) bitShift: 1. s2 := (a02 + a13) * (a02 - a13). s3 := ((a0 + a1) + (a2 + a3)) squared. s4 := (a02 * a13) bitShift: 1. s5 := (a3 * a2) bitShift: 1. s6 := a3 squared. "Interpolation" t2 := s1 + s5. t3 := (s2 + s3 + s4 bitShift: -1) - t2. s3 := t2 - s4. s4 := t3 - s0. s2 := t3 - s2 - s6. "Sum the parts of decomposition" ^s0 + (s1 bitShift: 8*p) + (s2 + (s3 bitShift: 8*p) bitShift: 16*p) +(s4 + (s5 bitShift: 8*p) + (s6 bitShift: 16*p) bitShift: 32*p) " | a | a := 770 factorial-1. a digitLength. [a * a - a squaredToom4 = 0] assert. [Smalltalk garbageCollect. [1000 timesRepeat: [a squaredToom4]] timeToRun] value / [Smalltalk garbageCollect. [1000 timesRepeat: [a squaredKaratsuba]] timeToRun] value asFloat "! Item was changed: ----- Method: LargePositiveInteger>>squaredByHalf (in category 'private') ----- squaredByHalf "Use a divide and conquer algorithm to perform the multiplication. Split in two parts like Karatsuba, but economize 2 additions by using asymetrical product." | half xHigh xLow low high mid | + "Divide digits in two halves rounded tp upper multiple of 4" + half := (self digitLength + 1 bitShift: -3) bitShift: 2. - "Divide digits in two halves" - half := self digitLength + 1 // 2 bitClear: 2r11. xLow := self lowestNDigits: half. xHigh := self butLowestNDigits: half. "eventually use karatsuba" low := xLow squared. high := xHigh squared. mid := xLow multiplyByInteger: xHigh. "Sum the parts of decomposition" ^(high bitShift: 16*half) inplaceAddNonOverlapping: low digitShiftBy: 0; + (mid bitShift: 8*half+1) " | a | a := 440 factorial-1. a digitLength. self assert: a * a - a squaredKaratsuba = 0. [Smalltalk garbageCollect. [2000 timesRepeat: [a squaredKaratsuba]] timeToRun] value / [Smalltalk garbageCollect. [2000 timesRepeat: [a * a]] timeToRun] value asFloat "! Item was changed: ----- Method: LargePositiveInteger>>squaredByThird (in category 'private') ----- squaredByThird "Use a 3-way Toom-Cook divide and conquer algorithm to perform the multiplication" | third x0 x1 x2 x20 z0 z1 z2 z3 z4 | + "divide in 3 parts, rounded to upper multiple of 4" + third := self digitLength + 11 // 3 bitShift: 2. - "divide in 3 parts" - third := self digitLength + 2 // 3 bitClear: 2r11. x2 := self butLowestNDigits: third * 2. x1 := self copyDigitsFrom: third + 1 to: third * 2. x0 := self lowestNDigits: third. "Toom-3 trick: 5 multiplications instead of 9" z0 := x0 squared. z4 := x2 squared. x20 := x2 + x0. z1 := (x20 + x1) squared. x20 := x20 - x1. z2 := x20 squared. z3 := ((x20 + x2 bitShift: 1) - x0) squared. "Sum the parts of decomposition" z3 := z3 - z1 quo: 3. z1 := z1 - z2 bitShift: -1. z2 := z2 - z0. z3 := (z2 - z3 bitShift: -1) + (z4 bitShift: 1). z2 := z2 + z1 - z4. z1 := z1 - z3. ^z0 + (z1 bitShift: 8*third) + (z2 bitShift: 16*third) + (z3 + (z4 bitShift: 8*third) bitShift: 24*third) " | a | a := 1400 factorial-1. a digitLength. self assert: a * a - a squaredToom3 = 0. [Smalltalk garbageCollect. [1000 timesRepeat: [a squaredToom3]] timeToRun] value / [Smalltalk garbageCollect. [1000 timesRepeat: [a squaredKaratsuba]] timeToRun] value asFloat "!

1 0

visibility of our site
by Nicolas Cellier 23 May '19

23 May '19

I find our https://squeak.org squeak site very good! But for loading a 5.2 image, I just googled "squeak smalltalk download", and were offered the possibility to download 3.8, 3.7 or all sorts of outdated stuff, but I didn't see our site anywhere near the top answers... Isn't there something we can do to improve that? Nicolas

5 7

Re: [squeak-dev] [Squeak-Dev] Trunk builds on smalltalkCI broken
by David T. Lewis 23 May '19

23 May '19

Thanks Hans, CC to the list so that your message gets through. Dave On Thu, May 23, 2019 at 08:08:20AM +0000, Baveco, Hans wrote: > And realize now that it probably works only for absolute paths.... :-( > Hans > > From: Baveco, Hans > Sent: donderdag 23 mei 2019 9:56 > To: 'lewis(a)mail.msen.com' <lewis(a)mail.msen.com> > Subject: [Squeak-Dev] Trunk builds on smalltalkCI broken > > Hi Dave > Somehow I can't post anymore to the squeak-dev list, therefore directly to you: > > In ProjectLauncher>>startUpAfterLogin > > If you use > scriptName := (FileDirectory urlForFileNamed: encodedPath ) asString > > instead of your > scriptName := (FileDirectory default asUrl newFromRelativeText: encodedPath) asString > > > it should work again. At least for me it does - though I haven't tested it thoroughly. > > Best regards, > > Hans > >

2 1

Trunk builds on smalltalkCI broken
by Jakob Reschke 23 May '19

23 May '19

Hello friends of automated builds and testing, My Squeak-trunk builds have been broken for about two weeks. Seems like the CodeLoader does not get what it needs when smalltalkCI shall be loaded after the image updated itself from trunk. The script argument passed to the image is an absolute file path. It gets converted to a file URL in ProjectLauncher>>startUpAfterLogin, but then it contains the path twice: file:///home/jakob/.../home/jakob/... Looks like the regression was introduced in System-dtl.1064 (13 May 2019): "Use Url rather than deprecated URI in ProjectLauncher>>startUpAfterLogin.This prevents command line startup scripts from failing due to a deprecation warning.Also fix a comment typo." - scriptName := (FileDirectory default uri resolveRelativeURI: encodedPath) asString + scriptName := (FileDirectory default asUrl newFromRelativeText: encodedPath) asString]]] #resolveRelativeURI: has a guard for absolute URI arguments, which newFromRelativeText: does not have. Best regards, Jakob Error: No content to install 22 May 2019 9:16:19.528929 pm VM: unix - Smalltalk Image: Squeak5.3alpha [latest update: #18590] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/jakob/smalltalkCI/_builds/2019_05_22_21_14_48 Trusted Dir /home/jakob/smalltalkCI/_builds/2019_05_22_21_14_48/secure Untrusted Dir /home/jakob/smalltalkCI/_builds/2019_05_22_21_14_48/My Squeak CodeLoader(Object)>>error: Receiver: a CodeLoader Arguments and temporary variables: aString: 'No content to install' Receiver's instance variables: baseURL: '' sourceFiles: {a HTTPDownloadRequest} segments: nil publicKey: nil CodeLoader>>installSourceFile: Receiver: a CodeLoader Arguments and temporary variables: aStream: nil contents: nil trusted: nil Receiver's instance variables: baseURL: '' sourceFiles: {a HTTPDownloadRequest} segments: nil publicKey: nil [] in CodeLoader>>installSourceFiles Receiver: a CodeLoader Arguments and temporary variables: req: a HTTPDownloadRequest Receiver's instance variables: baseURL: '' sourceFiles: {a HTTPDownloadRequest} segments: nil publicKey: nil Array(SequenceableCollection)>>do: Receiver: {a HTTPDownloadRequest} Arguments and temporary variables: aBlock: [closure] in CodeLoader>>installSourceFiles index: 1 indexLimiT: 1 Receiver's instance variables: {a HTTPDownloadRequest} CodeLoader>>installSourceFiles Receiver: a CodeLoader Arguments and temporary variables: Receiver's instance variables: baseURL: '' sourceFiles: {a HTTPDownloadRequest} segments: nil publicKey: nil ProjectLauncher>>startUpAfterLogin Receiver: a ProjectLauncher Arguments and temporary variables: scriptName: 'file:///home/jakob/smalltalkCI/_builds/2019_05_22_21_14_48/home/ja...etc... loader: a CodeLoader isUrl: false encodedPath: '/home/jakob/smalltalkCI/_builds/2019_05_22_21_14_48/load.st' pathTokens: #('' 'home' 'jakob' 'smalltalkCI' '_builds' '2019_05_22_21_14_48' '...etc... Receiver's instance variables: parameters: a Dictionary() showSplash: true splashURL: nil whichFlaps: nil eToyAuthentificationServer: nil ProjectLauncher>>startUp Receiver: a ProjectLauncher Arguments and temporary variables: Receiver's instance variables: parameters: a Dictionary() showSplash: true splashURL: nil whichFlaps: nil eToyAuthentificationServer: nil [] in [] in AutoStart class>>startUp: Receiver: AutoStart Arguments and temporary variables: <<error during printing> Receiver's instance variables: superclass: Object methodDict: a MethodDictionary() format: 65537 instanceVariables: #('parameters') organization: ('as yet unclassified') subclasses: nil name: #AutoStart classPool: a Dictionary(#Active->true #InstalledLaunchers->an OrderedCollection...etc... sharedPools: nil environment: Smalltalk category: #'System-Support' WorldState>>runStepMethodsIn: Receiver: a WorldState Arguments and temporary variables: aWorld: a PasteUpMorph(2434915) [world] queue: a SharedQueue(1) msg: [closure] in [] in AutoStart class>>startUp: limit: 200 stamp: 3736005379526 Receiver's instance variables: hands: {a HandMorph(20417)} activeHand: a HandMorph(20417) viewBox: 0@0 corner: 1024@768 canvas: a FormCanvas on: DisplayScreen(1024x768x32) damageRecorder: a DamageRecorder stepList: a Heap(StepMessage(#stepAt: -> a ClockMorph(3418298)'21:16:19')(a ClockMorph...etc... lastStepTime: 3736005379523 lastStepMessage: nil lastCycleTime: 3736005379526 commandHistory: a CommandHistory alarms: a MorphicAlarmQueue lastAlarmTime: 3736005379523 remoteServer: nil multiCanvas: nil interCycleDelay: a Delay(20 msecs) PasteUpMorph>>runStepMethods Receiver: a PasteUpMorph(2434915) [world] Arguments and temporary variables: Receiver's instance variables: bounds: 0@0 corner: 1024@768 owner: nil submorphs: {a DockingBarMorph(1961294) . a PluggableSystemWindow<Transcript>(25...etc... fullBounds: 0@0 corner: 1024@768 color: (Color r: 0.251 g: 0.259 b: 0.267) extension: a MorphExtension (3136713) [eventHandler = an EventHandler] [other:...etc... borderWidth: 0 borderColor: (Color r: 0.515 g: 0.181 b: 0.263) presenter: an EtoysPresenter (536818) model: a MorphicModel(360625) cursor: 1 padding: 3 backgroundMorph: nil turtleTrailsForm: nil turtlePen: nil lastTurtlePositions: nil isPartsBin: nil indicateCursor: nil wantsMouseOverHalos: nil worldState: a WorldState griddingOn: nil WorldState>>doOneCycleNowFor: Receiver: a WorldState Arguments and temporary variables: aWorld: a PasteUpMorph(2434915) [world] capturingGesture: #(false) Receiver's instance variables: hands: {a HandMorph(20417)} activeHand: a HandMorph(20417) viewBox: 0@0 corner: 1024@768 canvas: a FormCanvas on: DisplayScreen(1024x768x32) damageRecorder: a DamageRecorder stepList: a Heap(StepMessage(#stepAt: -> a ClockMorph(3418298)'21:16:19')(a ClockMorph...etc... lastStepTime: 3736005379523 lastStepMessage: nil lastCycleTime: 3736005379526 commandHistory: a CommandHistory alarms: a MorphicAlarmQueue lastAlarmTime: 3736005379523 remoteServer: nil multiCanvas: nil interCycleDelay: a Delay(20 msecs) WorldState>>doOneCycleFor: Receiver: a WorldState Arguments and temporary variables: aWorld: a PasteUpMorph(2434915) [world] Receiver's instance variables: hands: {a HandMorph(20417)} activeHand: a HandMorph(20417) viewBox: 0@0 corner: 1024@768 canvas: a FormCanvas on: DisplayScreen(1024x768x32) damageRecorder: a DamageRecorder stepList: a Heap(StepMessage(#stepAt: -> a ClockMorph(3418298)'21:16:19')(a ClockMorph...etc... lastStepTime: 3736005379523 lastStepMessage: nil lastCycleTime: 3736005379526 commandHistory: a CommandHistory alarms: a MorphicAlarmQueue lastAlarmTime: 3736005379523 remoteServer: nil multiCanvas: nil interCycleDelay: a Delay(20 msecs) PasteUpMorph>>doOneCycle Receiver: a PasteUpMorph(2434915) [world] Arguments and temporary variables: Receiver's instance variables: bounds: 0@0 corner: 1024@768 owner: nil submorphs: {a DockingBarMorph(1961294) . a PluggableSystemWindow<Transcript>(25...etc... fullBounds: 0@0 corner: 1024@768 color: (Color r: 0.251 g: 0.259 b: 0.267) extension: a MorphExtension (3136713) [eventHandler = an EventHandler] [other:...etc... borderWidth: 0 borderColor: (Color r: 0.515 g: 0.181 b: 0.263) presenter: an EtoysPresenter (536818) model: a MorphicModel(360625) cursor: 1 padding: 3 backgroundMorph: nil turtleTrailsForm: nil turtlePen: nil lastTurtlePositions: nil isPartsBin: nil indicateCursor: nil wantsMouseOverHalos: nil worldState: a WorldState griddingOn: nil [] in MorphicProject>>spawnNewProcess Receiver: a MorphicProject (Unnamed1) in a PasteUpMorph(2434915) [world] Arguments and temporary variables: <<error during printing> Receiver's instance variables: dependents: nil world: a PasteUpMorph(2434915) [world] uiManager: a MorphicUIManager changeSet: a ChangeSet named Unnamed1 transcript: a TranscriptStream parentProject: a MorphicProject (Unnamed1) in a PasteUpMorph(2434915) [world] previousProject: nil displayDepth: 32 viewSize: 151@132 thumbnail: Form(151x132x32) nextProject: nil projectParameters: an IdentityDictionary(#PrevailingProjectFlags->an IdentityDictionary...etc... version: nil urlList: nil lastDirectory: nil lastSavedAtSeconds: nil projectPreferenceFlagDictionary: an IdentityDictionary(#showSharedFlaps->true #showWorldMainDockingBar...etc... resourceManager: a ResourceManager uiProcess: a Process in nil [] in BlockClosure>>newProcess Receiver: [closure] in MorphicProject>>spawnNewProcess Arguments and temporary variables: <<error during printing> Receiver's instance variables: outerContext: MorphicProject>>spawnNewProcess startpc: 101 numArgs: 0 --- The full stack --- CodeLoader(Object)>>error: CodeLoader>>installSourceFile: [] in CodeLoader>>installSourceFiles Array(SequenceableCollection)>>do: CodeLoader>>installSourceFiles ProjectLauncher>>startUpAfterLogin ProjectLauncher>>startUp [] in [] in AutoStart class>>startUp: WorldState>>runStepMethodsIn: PasteUpMorph>>runStepMethods WorldState>>doOneCycleNowFor: WorldState>>doOneCycleFor: PasteUpMorph>>doOneCycle [] in MorphicProject>>spawnNewProcess [] in BlockClosure>>newProcess

3 4

The Trunk: System-dtl.1064.mcz
by commits＠source.squeak.org 23 May '19

23 May '19

David T. Lewis uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-dtl.1064.mcz ==================== Summary ==================== Name: System-dtl.1064 Author: dtl Time: 13 May 2019, 7:06:32.400119 pm UUID: 66a39f74-a4b5-41d0-8e02-c0d01632080d Ancestors: System-pre.1063 Use Url rather than deprecated URI in ProjectLauncher>>startUpAfterLogin. This prevents command line startup scripts from failing due to a deprecation warning. Also fix a comment typo. =============== Diff against System-pre.1063 =============== Item was changed: ----- Method: CodeLoader>>allButShebangLine: (in category 'private') ----- allButShebangLine: contentsString + "If contentsString begins with '#!!' then assume that it contains a Unix - "If tontentsString begins with '#!!' then assume that it contains a Unix shebang line should be skipped prior to evaluating the contents." (contentsString beginsWith: '#!!') ifTrue: [contentsString lineIndicesDo: [:line :end :endOfLine | ^ contentsString allButFirst: endOfLine ]] ifFalse: [^ contentsString] " CodeLoader new allButShebangLine: '#!!/usr/llocal/bin/squeak -- Transcript cr; show: ''Hello world!!'' ' "! Item was changed: ----- Method: ProjectLauncher>>startUpAfterLogin (in category 'running') ----- startUpAfterLogin | scriptName loader isUrl | self setupFlaps. Preferences readDocumentAtStartup ifTrue: [scriptName := Smalltalk documentPath ifNil: ['']. scriptName := scriptName convertFromSystemString. scriptName isEmpty ifFalse: ["figure out if script name is a URL by itself" isUrl := (scriptName asLowercase beginsWith: 'http://') or: [(scriptName asLowercase beginsWith: 'file://') or: [scriptName asLowercase beginsWith: 'ftp://']]. isUrl ifFalse: [| encodedPath pathTokens | "Allow for ../dir/scriptName arguments" pathTokens := scriptName splitBy: FileDirectory slash. pathTokens := pathTokens collect: [:s | s encodeForHTTP]. encodedPath := pathTokens reduce: [:acc :each | acc , FileDirectory slash , each]. + scriptName := (FileDirectory default asUrl newFromRelativeText: encodedPath) asString]]] - scriptName := (FileDirectory default uri resolveRelativeURI: encodedPath) asString]]] ifFalse: [scriptName := '']. scriptName isEmptyOrNil ifTrue: [^ Preferences eToyFriendly ifTrue: [self currentWorld addGlobalFlaps]]. loader := CodeLoader new. loader loadSourceFiles: (Array with: scriptName). (scriptName asLowercase endsWith: '.pr') ifTrue: [self installProjectFrom: loader] ifFalse: [loader installSourceFiles]!

4 3

The Trunk: System-fn.1066.mcz
by commits＠source.squeak.org 23 May '19

23 May '19

Fabio Niephaus uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-fn.1066.mcz ==================== Summary ==================== Name: System-fn.1066 Author: fn Time: 23 May 2019, 11:50:23.889459 am UUID: 7b0f9a17-bfa5-430b-abb3-5bfffb93d893 Ancestors: System-mt.1065 Partially revert System-dtl.1064 to unblock trunk builds until we come up with a better solution. See http://forum.world.st/The-Trunk-System-dtl-1064-mcz-td5099214.html =============== Diff against System-mt.1065 =============== Item was changed: ----- Method: ProjectLauncher>>startUpAfterLogin (in category 'running') ----- startUpAfterLogin | scriptName loader isUrl | self setupFlaps. Preferences readDocumentAtStartup ifTrue: [scriptName := Smalltalk documentPath ifNil: ['']. scriptName := scriptName convertFromSystemString. scriptName isEmpty ifFalse: ["figure out if script name is a URL by itself" isUrl := (scriptName asLowercase beginsWith: 'http://') or: [(scriptName asLowercase beginsWith: 'file://') or: [scriptName asLowercase beginsWith: 'ftp://']]. isUrl ifFalse: [| encodedPath pathTokens | "Allow for ../dir/scriptName arguments" pathTokens := scriptName splitBy: FileDirectory slash. pathTokens := pathTokens collect: [:s | s encodeForHTTP]. encodedPath := pathTokens reduce: [:acc :each | acc , FileDirectory slash , each]. + scriptName := (FileDirectory default uri resolveRelativeURI: encodedPath) asString]]] - scriptName := (FileDirectory default asUrl newFromRelativeText: encodedPath) asString]]] ifFalse: [scriptName := '']. scriptName isEmptyOrNil ifTrue: [^ Preferences eToyFriendly ifTrue: [self currentWorld addGlobalFlaps]]. loader := CodeLoader new. loader loadSourceFiles: (Array with: scriptName). (scriptName asLowercase endsWith: '.pr') ifTrue: [self installProjectFrom: loader] ifFalse: [loader installSourceFiles]!

1 0

The Trunk: Installer-Core-fn.432.mcz
by commits＠source.squeak.org 23 May '19

23 May '19

Fabio Niephaus uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-fn.432.mcz ==================== Summary ==================== Name: Installer-Core-fn.432 Author: fn Time: 23 May 2019, 11:46:13.072639 am UUID: 6b46a836-777c-4bbc-98b3-994a4b3f2fce Ancestors: Installer-Core-cmm.431 Install Metacello without asking user explicitly for permission, because the user has already requested a working Metacello via a doIt (similar to the explicit click on the `Tools` menu item). This also helps to unblock smalltalkCI builds as they freeze on the confirmation window. Next step: fix the URI bug to unblock trunk builds as well. =============== Diff against Installer-Core-cmm.431 =============== Item was removed: - ----- Method: MetacelloStub class>>confirmMetacello (in category 'overriding') ----- - confirmMetacello - Installer isMetacelloInstalled ifFalse: - [ (UIManager confirm: 'This action requires Metacello, but it''s not installed. Download and install it now?') ifTrue: [ Installer ensureRecentMetacello ] ]! Item was changed: ----- Method: MetacelloStub class>>doesNotUnderstand: (in category 'overriding') ----- doesNotUnderstand: aMessage "Handle any messages sent to Metacello class, too." + Installer ensureRecentMetacello. - self confirmMetacello. ^ aMessage sendTo: (Smalltalk classNamed: #Metacello)! Item was changed: ----- Method: MetacelloStub class>>new (in category 'overriding') ----- new + Installer ensureRecentMetacello. - self confirmMetacello. ^ (Smalltalk at: #Metacello) new!

1 0

The Trunk: MorphicExtras-kfr.255.mcz
by commits＠source.squeak.org 22 May '19

22 May '19

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.255.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.255 Author: kfr Time: 17 May 2019, 11:21:22.449469 pm UUID: c061d985-306a-a842-86cc-dfbcfd880fed Ancestors: MorphicExtras-ms.254 Add input for a selection of chord types possible in KeyboardMorphForInput. =============== Diff against MorphicExtras-ms.254 =============== Item was changed: PianoKeyboardMorph subclass: #KeyboardMorphForInput + instanceVariableNames: 'pianoRoll duration durationModifier articulation buildingChord insertMode prevSelection startOfNextNote chordSemitones chordDictionary' - instanceVariableNames: 'pianoRoll duration durationModifier articulation buildingChord insertMode prevSelection startOfNextNote' classVariableNames: '' poolDictionaries: '' category: 'MorphicExtras-SoundInterface'! !KeyboardMorphForInput commentStamp: 'nice 3/24/2010 07:37' prior: 0! This class adds state and controls to the basic PianoKeyboardMorph so that notes of reliable duration can be keyed into a score without the need for a real keyboard. To try this out, execute... | n score | n := 3. score := (MIDIScore new tracks: ((1 to: n) collect: [:i | Array new]); trackInfo: ((1 to: n) collect: [:i | 'Instrument' , i printString]); tempoMap: nil; ticksPerQuarterNote: 96). ScorePlayerMorph openOn: score title: 'empty score' Then open a pianoRoll and, from that, open a keyboard. The rule is that the keyboard will append after the current selection. If the current selection is muted or nil, then input will go to the end of the first non-muted track.! Item was added: + ----- Method: KeyboardMorphForInput>>addChordControls (in category 'initialization') ----- + addChordControls + | switch chordRow | + chordRow := AlignmentMorph newRow. + chordRow color: color; borderWidth: 0; layoutInset: 0. + chordRow hResizing: #shrinkWrap; vResizing: #shrinkWrap; extent: 5@5. + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'maj' translated; + actionSelector: #chords:onOff:; arguments: #(maj)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'min' translated; + actionSelector: #chords:onOff:; arguments: #(min)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'dim' translated; + actionSelector: #chords:onOff:; arguments: #(dim)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'maj7' translated; + actionSelector: #chords:onOff:; arguments: #(maj7)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'min7' translated; + actionSelector: #chords:onOff:; arguments: #(min7)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'dom7' translated; + actionSelector: #chords:onOff:; arguments: #(dom7)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'sus2' translated; + actionSelector: #chords:onOff:; arguments: #(sus2)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'sus4' translated; + actionSelector: #chords:onOff:; arguments: #(sus4)). + switch := SimpleSwitchMorph new target: self; borderWidth: 2; + offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. + chordRow addMorphBack: (switch label: 'aug' translated; + actionSelector: #chords:onOff:; arguments: #(aug)). + ^chordRow + ! Item was added: + ----- Method: KeyboardMorphForInput>>addNoteEventAt:rootNote: (in category 'simple keyboard') ----- + addNoteEventAt: eventTime rootNote: rootNote + | noteEvent noteEvents semitones | + semitones := chordSemitones. + buildingChord ifFalse:[ semitones := #(0)]. + noteEvents := OrderedCollection new. + semitones do: + [: semitone | noteEvent := NoteEvent new time: eventTime; duration: self noteDuration; + key: rootNote + semitone velocity: self velocity channel: 1. + pianoRoll appendEvent: noteEvent fullDuration: self fullDuration. + noteEvents add: noteEvent]. + ^noteEvents! Item was changed: ----- Method: KeyboardMorphForInput>>addRecordingControls (in category 'initialization') ----- addRecordingControls + | button switch playRow durRow articRow modRow chordRow | - | button switch playRow durRow articRow modRow | "Add chord, rest and delete buttons" playRow := AlignmentMorph newRow. playRow color: color; borderWidth: 0; layoutInset: 0. playRow hResizing: #shrinkWrap; vResizing: #shrinkWrap; extent: 5@5. switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. playRow addMorphBack: (switch label: 'chord' translated; actionSelector: #buildChord:). button := SimpleButtonMorph new target: self; borderStyle: (BorderStyle raised width: 2); color: color. playRow addMorphBack: (button label: ' rest ' translated; actionSelector: #emitRest). button := SimpleButtonMorph new target: self; borderStyle: (BorderStyle raised width: 2); color: color. playRow addMorphBack: (button label: 'del' translated; actionSelector: #deleteNotes). self addMorph: playRow. playRow align: playRow fullBounds topCenter with: self fullBounds bottomCenter. + + chordRow := self addChordControls. + self addMorph: chordRow. + chordRow align: chordRow fullBounds topCenter + with: playRow fullBounds bottomCenter. "Add note duration buttons" durRow := AlignmentMorph newRow. durRow color: color; borderWidth: 0; layoutInset: 0. durRow hResizing: #shrinkWrap; vResizing: #shrinkWrap; extent: 5@5. switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. durRow addMorphBack: (switch label: 'whole' translated; actionSelector: #duration:onOff:; arguments: #(1)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. durRow addMorphBack: (switch label: 'half' translated; actionSelector: #duration:onOff:; arguments: #(2)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. durRow addMorphBack: (switch label: 'quarter' translated; actionSelector: #duration:onOff:; arguments: #(4)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. durRow addMorphBack: (switch label: 'eighth' translated; actionSelector: #duration:onOff:; arguments: #(8)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. durRow addMorphBack: (switch label: 'sixteenth' translated; actionSelector: #duration:onOff:; arguments: #(16)). self addMorph: durRow. durRow align: durRow fullBounds topCenter + with: chordRow fullBounds bottomCenter. - with: playRow fullBounds bottomCenter. "Add note duration modifier buttons" modRow := AlignmentMorph newRow. modRow color: color; borderWidth: 0; layoutInset: 0. modRow hResizing: #shrinkWrap; vResizing: #shrinkWrap; extent: 5@5. switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. modRow addMorphBack: (switch label: 'dotted' translated; actionSelector: #durMod:onOff:; arguments: #(dotted)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. modRow addMorphBack: (switch label: 'normal' translated; actionSelector: #durMod:onOff:; arguments: #(normal)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. modRow addMorphBack: (switch label: 'triplets' translated; actionSelector: #durMod:onOff:; arguments: #(triplets)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. modRow addMorphBack: (switch label: 'quints' translated; actionSelector: #durMod:onOff:; arguments: #(quints)). self addMorph: modRow. modRow align: modRow fullBounds topCenter with: durRow fullBounds bottomCenter. "Add articulation buttons" articRow := AlignmentMorph newRow. articRow color: color; borderWidth: 0; layoutInset: 0. articRow hResizing: #shrinkWrap; vResizing: #shrinkWrap; extent: 5@5. switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. articRow addMorphBack: (switch label: 'legato' translated; actionSelector: #articulation:onOff:; arguments: #(legato)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. articRow addMorphBack: (switch label: 'normal' translated; actionSelector: #articulation:onOff:; arguments: #(normal)). switch := SimpleSwitchMorph new target: self; borderWidth: 2; offColor: color; onColor: (Color r: 1.0 g: 0.6 b: 0.6); setSwitchState: false. articRow addMorphBack: (switch label: 'staccato' translated; actionSelector: #articulation:onOff:; arguments: #(staccato)). self addMorph: articRow. articRow align: articRow fullBounds topCenter with: modRow fullBounds bottomCenter. self bounds: (self fullBounds expandBy: (0@0 extent: 0 @ self borderWidth)) ! Item was changed: ----- Method: KeyboardMorphForInput>>buildChord: (in category 'note controls') ----- + buildChord: onOff + buildingChord := buildingChord not.! - buildChord: onOff! Item was added: + ----- Method: KeyboardMorphForInput>>chords:onOff: (in category 'note controls') ----- + chords: chord onOff: ignored + "Select the semi tones of the chord from the chordDictonary." + + self allMorphsDo: + [:m | ((m isMemberOf: SimpleSwitchMorph) + and: [m actionSelector == #chords:onOff:]) + ifTrue: [m setSwitchState: m arguments first = chord]]. + chordSemitones := chordDictionary at: chord. + ! Item was added: + ----- Method: KeyboardMorphForInput>>initChordDictionary (in category 'initialization') ----- + initChordDictionary + + chordDictionary := + {'maj' -> #(0 4 7). + 'min' -> #(0 3 7). + 'dim' -> #(0 3 6). + 'maj7' -> #(0 4 7 11). + 'min7' -> #(0 3 7 10). + 'dom7' -> #(0 4 7 10). + 'sus2' -> #(0 2 7). + 'sus4' -> #(0 5 7). + 'aug' -> #(0 4 8)} as: Dictionary! Item was changed: ----- Method: KeyboardMorphForInput>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" super initialize. "" buildingChord := false. self addRecordingControls. self duration: 4 onOff: true. self durMod: #normal onOff: true. self articulation: #normal onOff: true. + insertMode := false. + self initChordDictionary! - insertMode := false! Item was changed: ----- Method: KeyboardMorphForInput>>mouseDownPitch:event:noteMorph: (in category 'simple keyboard') ----- mouseDownPitch: midiKey event: event noteMorph: keyMorph + | sel noteEvents | - | sel noteEvent | event hand hasSubmorphs ifTrue: [^ self "no response if drag something over me"]. keyMorph color: playingKeyColor. (sel := pianoRoll selection) ifNil: [^ self]. insertMode ifTrue: [sel := pianoRoll selectionForInsertion. insertMode := false]. sel = prevSelection ifFalse: ["This is a new selection -- need to determine start time" sel third = 0 ifTrue: [startOfNextNote := 0] ifFalse: [startOfNextNote := ((pianoRoll score tracks at: sel first) at: sel third) endTime. startOfNextNote := startOfNextNote + self fullDuration - 1 truncateTo: self fullDuration]]. + noteEvents := self addNoteEventAt:startOfNextNote rootNote: midiKey +23. - noteEvent := NoteEvent new time: startOfNextNote; duration: self noteDuration; - key: midiKey + 23 velocity: self velocity channel: 1. - pianoRoll appendEvent: noteEvent fullDuration: self fullDuration. soundPlaying ifNotNil: [soundPlaying stopGracefully]. + (soundPlaying := self soundForEvent: noteEvents inTrack: sel first) play. - (soundPlaying := self soundForEvent: noteEvent inTrack: sel first) play. prevSelection := pianoRoll selection. startOfNextNote := startOfNextNote + self fullDuration.! Item was changed: ----- Method: KeyboardMorphForInput>>soundForEvent:inTrack: (in category 'events') ----- + soundForEvent: noteEvents inTrack: trackIndex - soundForEvent: noteEvent inTrack: trackIndex | sound player | player := pianoRoll scorePlayer. sound := MixedSound new. + noteEvents do:[: noteEvent| sound add: ((player instrumentForTrack: trackIndex) soundForMidiKey: noteEvent midiKey dur: noteEvent duration / (pianoRoll scorePlayer ticksForMSecs: 1000) loudness: (noteEvent velocity asFloat / 127.0)) pan: (player panForTrack: trackIndex) volume: player overallVolume * + (player volumeForTrack: trackIndex)]. - (player volumeForTrack: trackIndex). ^ sound ! Item was changed: ----- Method: PianoRollScoreMorph>>deleteSelection (in category 'editing') ----- deleteSelection | selMorphs priorEvent x | (selection isNil or: [selection second = 0]) ifTrue: [^self]. score cutSelection: selection. selection second > 1 ifTrue: [selection at: 2 put: selection second - 1. selection at: 3 put: selection second. priorEvent := (score tracks at: selection first) at: selection second. (x := self xForTime: priorEvent time) < (self left + 30) ifTrue: [self autoScrollForX: x - ((30 + self width) // 4)]] ifFalse: [selection := nil]. scorePlayer updateDuration. self rebuildFromScore. selMorphs := self submorphsSatisfying: [:m | (m isKindOf: PianoRollNoteMorph) and: [m selected]]. + selMorphs isEmpty ifFalse: [(selMorphs last soundOfDuration: 0.3) play]! - selMorphs isEmpty ifFalse: [(selMorphs last noteOfDuration: 0.3) play]!

2 1

The Trunk: PreferenceBrowser-mt.85.mcz
by commits＠source.squeak.org 21 May '19

21 May '19

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-mt.85.mcz ==================== Summary ==================== Name: PreferenceBrowser-mt.85 Author: mt Time: 21 May 2019, 11:35:06.795219 am UUID: 6624fa05-6f97-3742-81a5-50c106c92e33 Ancestors: PreferenceBrowser-eem.84 Fixes the visuals for halo-radio buttons in the preference browser. =============== Diff against PreferenceBrowser-eem.84 =============== Item was changed: ----- Method: PBHaloThemePreferenceView>>haloThemeRadioButtons (in category 'user interface') ----- haloThemeRadioButtons "Answer a column of butons representing the choices of halo theme" | buttonColumn | buttonColumn := self verticalPanel. #( (iconicHaloSpecifications iconic iconicHalosInForce 'circular halos with icons inside') (classicHaloSpecs classic classicHalosInForce 'plain circular halos') (simpleFullHaloSpecifications simple simpleHalosInForce 'fewer, larger halos') (customHaloSpecs custom customHalosInForce 'customizable halos')) do: [:quad | + | aRadioButton | - | aRow aRadioButton aLabel | aRadioButton := UpdatingThreePhaseButtonMorph radioButton target: Preferences; setBalloonText: quad fourth; actionSelector: #installHaloTheme:; getSelector: quad third; arguments: (Array with: quad first); + label: quad second asString; yourself. + buttonColumn addMorphBack: aRadioButton]. - aLabel := (StringMorph contents: quad second asString) - setBalloonText: quad fourth; - yourself. - aRow := self horizontalPanel - cellInset: 4; - addMorphBack: aRadioButton; - addMorphBack: aLabel. - buttonColumn addMorphBack: aRow]. ^ buttonColumn "(Preferences preferenceAt: #haloTheme) view tearOffButton"! Item was changed: ----- Method: PBHaloThemePreferenceView>>representativeButtonWithColor:inPanel: (in category 'user interface') ----- representativeButtonWithColor: aColor inPanel: aPreferencesPanel | innerPanel | + innerPanel := self horizontalFiller + addMorphBack: self horizontalFiller; - innerPanel := self horizontalPanel - addMorphBack: (self blankSpaceOf: 10@0); addMorphBack: self haloThemeRadioButtons; yourself. ^self verticalPanel color: aColor; layoutInset: 2; addMorphBack: self morphForName; addMorphBack: innerPanel.!

2 1

The Trunk: Kernel-mt.1235.mcz
by commits＠source.squeak.org 21 May '19

21 May '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1235.mcz ==================== Summary ==================== Name: Kernel-mt.1235 Author: mt Time: 21 May 2019, 10:48:13.016822 am UUID: 2ca86cdb-5328-3a44-aac6-346c8d44d2ca Ancestors: Kernel-nice.1234 Replace the few sends to #valueWithPossibleArgument: with #cull: because there is no need to expect blocks with more than one argument to be filled with nils. =============== Diff against Kernel-nice.1234 =============== Item was changed: ----- Method: Object>>haltIf: (in category 'debugging') ----- haltIf: condition "This is the typical message to use for inserting breakpoints during debugging. Param can be a block or expression, halt if true. If the Block has one arg, the receiver is bound to that. If the condition is a selector, we look up in the callchain. Halt if any method's selector equals selector." | cntxt | condition isSymbol ifTrue:[ "only halt if a method with selector symbol is in callchain" cntxt := thisContext. [cntxt sender isNil] whileFalse: [ cntxt := cntxt sender. (cntxt selector = condition) ifTrue: [Halt signal]. ]. ^self. ]. (condition isBlock + ifTrue: [condition cull: self] - ifTrue: [condition valueWithPossibleArgument: self] ifFalse: [condition] ) ifTrue: [ Halt signal ].! Item was changed: ----- Method: ObjectViewer>>doesNotUnderstand: (in category 'very few messages') ----- doesNotUnderstand: aMessage "Check for change after sending aMessage" | returnValue newValue | recursionFlag ifTrue: [^ aMessage sendTo: tracedObject]. recursionFlag := true. returnValue := aMessage sendTo: tracedObject. + newValue := valueBlock cull: aMessage. - newValue := valueBlock valueWithPossibleArgument: aMessage. newValue = lastValue ifFalse: + [changeBlock cull: aMessage. - [changeBlock valueWithPossibleArgument: aMessage.. lastValue := newValue]. recursionFlag := false. ^ returnValue!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
16
Older →

Jump to page: