Squeak-dev September 2020

squeak-dev@lists.squeakfoundation.org

37 participants
269 discussions

The Inbox: Regex-Core-ct.58.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Christoph Thiede uploaded a new version of Regex-Core to project The Inbox: http://source.squeak.org/inbox/Regex-Core-ct.58.mcz ==================== Summary ==================== Name: Regex-Core-ct.58 Author: ct Time: 8 September 2020, 5:07:32.229336 pm UUID: 66a3d373-fd7a-fc41-ba4f-7233d60a5ec4 Ancestors: Regex-Core-ul.57 Fixes capturing-like behavior of lookaround expressions. Complements Regex-Tests-Core-ct.11. Thanks to Levente (ul) for the bug report! [1] [1] http://forum.world.st/The-Inbox-Regex-Core-ct-56-mcz-tp5113011p5114971.html =============== Diff against Regex-Core-ul.57 =============== Item was added: + ----- Method: RxsLookaround>>isNullable (in category 'testing') ----- + isNullable + + ^ true!

1 0

The Inbox: Regex-Tests-Core-ct.11.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Christoph Thiede uploaded a new version of Regex-Tests-Core to project The Inbox: http://source.squeak.org/inbox/Regex-Tests-Core-ct.11.mcz ==================== Summary ==================== Name: Regex-Tests-Core-ct.11 Author: ct Time: 8 September 2020, 5:06:20.887336 pm UUID: 6d0bb586-18f2-1045-ba9c-6b288515c123 Ancestors: Regex-Tests-Core-nice.10 Adds regression test for capturing-like behavior of lookaround expressions See also: http://forum.world.st/The-Inbox-Regex-Core-ct-56-mcz-tp5113011p5114971.html =============== Diff against Regex-Tests-Core-nice.10 =============== Item was added: + ----- Method: RxParserTest>>testLookaroundNullable (in category 'tests') ----- + testLookaroundNullable + + self should: ['(?<=a)?b' asRegex] raise: RegexSyntaxError.!

1 0

The Trunk: MonticelloConfigurations-mt.160.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz ==================== Summary ==================== Name: MonticelloConfigurations-mt.160 Author: mt Time: 17 April 2020, 5:17:27.82286 pm UUID: 6d32501e-f519-3b4a-ae1a-58b52360a937 Ancestors: MonticelloConfigurations-mt.159 Shows the current CI status in the update dialog. =============== Diff against MonticelloConfigurations-mt.159 =============== Item was changed: ----- Method: MCMcmUpdater>>doUpdate: (in category 'updating') ----- doUpdate: interactive "Update the image by loading all pending updates from the server. If this is the default updater for the system, update the system version when complete. If interteractive use a modal notifier, otherwise only update the transcript. Flush all caches. If a previous download failed this is often helpful" | config previousUpdateLevel ensureTranscriptSetting | previousUpdateLevel := SystemVersion current highestUpdate. MCFileBasedRepository flushAllCaches. ensureTranscriptSetting := MCConfiguration ensureOpenTranscript. [ MCConfiguration ensureOpenTranscript: interactive. config := self updateFromRepository. config ifNil: [ interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. ^ self ]. MCMcmUpdater default == self ifTrue: [ config setSystemVersion. + interactive ifTrue: [ + self inform: (self updateMessageFor: previousUpdateLevel)]. - interactive ifTrue: [ - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url: {4}\Map: ''{5}''{6}' translated withCRs format: { - SystemVersion current version. - SystemVersion current highestUpdate. - previousUpdateLevel = SystemVersion current highestUpdate - ifTrue: [''] - ifFalse: [previousUpdateLevel asString, ' -> ']. - self repository. - MCMcmUpdater updateMapName. - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String cr, String cr, d]})]. Transcript cr; show: '========== Update completed: ' translated; show: previousUpdateLevel; show: ' -> ' ; show: SystemVersion current highestUpdate; show: ' =========='; cr ] ifFalse: [ interactive ifTrue: [ self inform: 'Update completed.' ]. Transcript cr; show: '========== Update completed. ==========' translated; cr ] ] ensure: [ MCConfiguration ensureOpenTranscript: ensureTranscriptSetting]. ! Item was changed: ----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating') ----- doUpdate: interactive upTo: versionNumber "Update the image by loading all pending updates from the server. If this is the default updater for the system, update the system version when complete. If interteractive use a modal notifier, otherwise only update the transcript. Flush all caches. If a previous download failed this is often helpful" | config previousUpdateLevel | previousUpdateLevel := SystemVersion current highestUpdate. MCFileBasedRepository flushAllCaches. config := self updateFromRepositories: { self repository } upTo: versionNumber. config ifNil: [ interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. ^ self ]. MCMcmUpdater default == self ifTrue: [ config setSystemVersion. + interactive ifTrue: [ + self inform: (self updateMessageFor: previousUpdateLevel)]. - interactive ifTrue: [ - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url: {4}\Map: ''{5}''{6}' translated withCRs format: { - SystemVersion current version. - SystemVersion current highestUpdate. - previousUpdateLevel = SystemVersion current highestUpdate - ifTrue: [''] - ifFalse: [previousUpdateLevel asString, ' -> ']. - self repository. - MCMcmUpdater updateMapName. - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String cr, String cr, d]})]. Transcript cr; show: '========== Update completed: ' translated; show: previousUpdateLevel; show: ' -> ' ; show: SystemVersion current highestUpdate; show: ' =========='; cr ] ifFalse: [ interactive ifTrue: [ self inform: 'Update completed.' ]. Transcript cr; show: '========== Update completed. ==========' translated; cr ] ! Item was added: + ----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private') ----- + updateMessageFor: previousUpdateLevel + + ^ ('Update completed. Version: {1} Update: {3}{2} Url: <a href="{4}">{4}</a> Map: ''{5}'' TravisCI status: <a href="{8}"><img src="{7}" /></a>{6}' translated format: { + SystemVersion current version. + SystemVersion current highestUpdate. + previousUpdateLevel = SystemVersion current highestUpdate + ifTrue: [''] + ifFalse: [previousUpdateLevel asString, ' -> ']. + self repository. + MCMcmUpdater updateMapName. + SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | + ' ', (d copyReplaceAll: String cr with: ' ')]. + SystemVersion current ciStatusBadgeUrl. + SystemVersion current ciStatusPageUrl. + }) asTextFromHtml!

7 18

The Inbox: Morphic-ct.1681.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1681.mcz ==================== Summary ==================== Name: Morphic-ct.1681 Author: ct Time: 8 September 2020, 1:48:12.211798 pm UUID: 9e91205a-93e1-c143-ae8f-4aa3428bf197 Ancestors: Morphic-mt.1679 Fixes use of custom attributes in DialogWindows Things like the following did NOT work properly before this patch: self inform: 'normal ' asText , ('red ' asText addAttribute: TextColor red; yourself) , ('font ' asText addAttribute: (TextFontReference toFont: ((TextStyle named: 'BitstreamVeraSansMono') fontOfSize: 20)); yourself) , ('url ' asText addAttribute: TextURL new; yourself) This was because DialogWindow added its own styling attributes on top of all existing attributes. For color, this is not necessary because #textColor: is sufficient. For font size, in theory, TextFontChange should be sufficient, but currently it does not support relative changes to the font size. =============== Diff against Morphic-mt.1679 =============== Item was changed: ----- Method: DialogWindow>>setMessageParameters (in category 'initialization') ----- setMessageParameters + + messageMorph ifNil: [^ self]. + messageMorph + hResizing: #shrinkWrap; + vResizing: #shrinkWrap. + + self userInterfaceTheme textColor ifNotNil: [:color | + messageMorph textColor: color]. + self userInterfaceTheme font ifNotNil: [:font | + self flag: #todo. "ct: Develop a relative text font change attribute. At the moment, all prior font sizes will be overwritten." + messageMorph contents addAttribute: ( + TextFontChange fontNumber: (font textStyle fontIndexOf: font))].! - messageMorph ifNotNil: [ - | fontToUse colorToUse | - fontToUse := self userInterfaceTheme font ifNil: [TextStyle defaultFont]. - colorToUse := self userInterfaceTheme textColor ifNil: [Color black]. - - messageMorph - hResizing: #shrinkWrap; - vResizing: #shrinkWrap. - - messageMorph contents - addAttribute: (TextFontReference toFont: fontToUse); - addAttribute: (TextColor color: colorToUse). - messageMorph textColor: colorToUse].!

1 0

TextMorphs support display of text with emphasis. They also support reasonable text-editing capabilities, as well as embedded HOT LINKS
by gettimothy 08 Sep '20

08 Sep '20

Hi Folks, I searched the web and wiki and did not find any examples of Hot Links or keyboard shortcuts. Editor and its Sub Classes initializeFOOKeyBars does not show anything. Any pointers? Motivation: For Doc, I want to code for links to stuff, similar to what you get in Emacs org-mode https://orgmode.org/manual/Link-Format.html#Link-Format In Emacs, to navigate to the link, I type Ctrl-o to open it . Now, the links do not have to be hypertext to the WWW, links to HelpBrowser on a topic would be useful. I guess I could , upon completion of the search, return DoIts, but hot links bound to a key would fit the idiom better. thank you for your time. P.S. I am inferring that a typical Workspace encapsulates the TextMorph doo-hickey, if it is one of the other editor types, please let me know. thx

6 13

The Inbox: System-ct.1161.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1161.mcz ==================== Summary ==================== Name: System-ct.1161 Author: ct Time: 6 June 2020, 8:19:13.480392 pm UUID: 173a90f3-4bb8-fc46-b5a6-6e4ab74e63ca Ancestors: System-mt.1160 Catch all InvalidDirectoryErrors in GetTextTranslator availableLanguageLocaleIDs. Those exceptions are an implementation detail and may not confuse the caller. Such a confusion happened in connection with Morphic-ct.1638. =============== Diff against System-mt.1160 =============== Item was changed: ----- Method: GetTextTranslator class>>availableLanguageLocaleIDs (in category 'accessing') ----- availableLanguageLocaleIDs "GetTextTranslator availableLanguageLocaleIDs" | ids dirs localeDirForLang directoryNames | ids := Set new. dirs := Set new. dirs addAll: LocaleDirsForDomain values. dirs addAll: self defaultLocaleDirs. + [dirs do: [:dir | - dirs do: [:dir | | localesDir | localesDir := FileDirectory on: dir. + directoryNames := localesDir directoryNames. - directoryNames := [localesDir directoryNames] on: InvalidDirectoryError do: [:e | #()]. directoryNames do: [:langDirName | | localeID | localeID := LocaleID posixName: langDirName. localeDirForLang := localesDir directoryNamed: (self langDirNameForLocaleID: localeID). localeDirForLang ifNotNil: [ (localeDirForLang fileNamesMatching: '*.mo') ifNotEmpty: [ids add: localeID]]. localeID hasParent ifTrue: [ localeDirForLang := localesDir directoryNamed: (self langDirNameForLocaleID: localeID parent). localeDirForLang ifNotNil: [ (localeDirForLang fileNamesMatching: '*.mo') ifNotEmpty: [ids add: localeID parent]]]. ]. + ]] on: InvalidDirectoryError do: [:error | error resumeUnchecked: error defaultAction]. - ]. ^ids!

4 5

Starting an image from SqueakConsole manipulates pwd
by Thiede, Christoph 08 Sep '20

08 Sep '20

Hi all, consider the following terminal session under Windows: ```powershell > cat .\test-output.st FileStream stdout nextPutAll: 'Hello World'; lf ; flush. Smalltalk quitPrimitive. > &"C:\Program Files (x86)\Squeak\SqueakConsole.exe" -headless .\FreshTrunk\FreshTrunk.image .\test-output.st ``` Expected output: Hello Actual output: The VM window opens (first error because I specified the option headless) and shows up a debugger "Error: No content to install". What this error wants to mean is that it could not find the specified file. What I have to do to fix the output is to change the call to the following: > &"C:\Program Files (x86)\Squeak\SqueakConsole.exe" -headless .\FreshTrunk\FreshTrunk.image ..\test-output.st IMO this is a very confusing behavior because it makes it impossible to specify a relative path from the console without thinking "around the corner". If I would run ls ..\test-output.st in the same terminal context, I would get a FileNotFoundException. I never met a comparable situation where starting a script/application from the console manipulated the pwd even before resolving the specified arguments. Is this really desirable? Could we consider this a bug? How is the behavior on other platforms? I cannot test this at the moment because I am getting heartbeat warnings under Linux again. Best, Christoph

6 12

Are we missing some string encoding in SqueakSSL/WebClient?
by Thiede, Christoph 08 Sep '20

08 Sep '20

Hi all, while doing some experiments with WebClient & WebUtils in order to send textual data to a server via HTTP(S), I found out that posting a request containing non-ASCII characters in a multipart/form-data yields a primitive failure from SqueakSSL/primitiveEncrypt (occurs on both Win32 + emulated Linux/Ubuntu). When I converted the text manually using #squeakToUtf8 before putting it into the contents data, everything worked fine and the server receives the correct text without any encoding problems. So for my application, I can manually #squeakToUtf8-convert the request string before posting it, but I wonder whether this should really be the responsibility of every Squeak developer and not rather one of the WebClient? For illustration: If you use normal #htmlSubmit:fields: instead of #httpPost:multipartFields:, WebClient does all necessary conversion (#encodeUrlEncodedForm:, String >> #encodeForHTTP) itself. Anyway, #encodeMultipartForm:boundary: does not care about conversion. I am only a bloody newbie to all this web stuff, so maybe I am missing something important. What do you think? Should we add #squeakToUtf8 conversion in WebUtils class >> #encodeMultipartForm:boundary:, and in the decode message vice versa? Or would this rather be a responsibility of the SqueakSSL protocol? I am looking forward to your help! Best, Christoph

2 3

The Inbox: WebClient-Core-ct.125.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

Christoph Thiede uploaded a new version of WebClient-Core to project The Inbox: http://source.squeak.org/inbox/WebClient-Core-ct.125.mcz ==================== Summary ==================== Name: WebClient-Core-ct.125 Author: ct Time: 8 September 2020, 10:09:01.217336 am UUID: b5a5321e-904d-ca40-aa6a-8ae3236fe629 Ancestors: WebClient-Core-ct.124 Adds UTF-8 conversion to multipart/form-data encoding & decoding in WebUtils. Also includes overall refactoring of the relevant methods. Last but not least, makes the filename parameter optional as specified in RFC7578 Sec. 4.2. NOTE that this is a breaking change for any users of the multipart/form-data protocol provided by the WebClient package! If you manually converted (file)names or plain-text fields to UTF-8 via #squeakToUtf8 before passing them to the WebClient, you should stop doing so now. Vice versa, as a user of WebRequest >> #fields or #multipartFields, you should no longer call #utf8ToSqueak on the output. For more information, please refer to [2]. Thanks to Levente (ul) for the help! Depends indeed on WebClient-Core-ct.124. [1] https://tools.ietf.org/html/rfc7578#section-4.2 [2] http://forum.world.st/Are-we-missing-some-string-encoding-in-SqueakSSL-WebC… =============== Diff against WebClient-Core-ct.124 =============== Item was changed: ----- Method: WebUtils class>>decodeMultipartForm:boundary:do: (in category 'decoding') ----- decodeMultipartForm: aStream boundary: boundary do: aBlock "Parse the contents of a multipart/form-data submission. + + Evaluate aBlock with three parts: The headers, the (parsed) form-data arguments and the (undecoded) contents of the part. The sender is expected to take care of other issues such as content-transfer-encoding and similar headers." - Evaluate aBlock with three parts: The headers, the (parsed) form-data - arguments and the (undecoded) contents of the part. The sender is - expected to take care of other issues such as content-transfer-encoding - and similar headers." - | skip headers content disposition index params | aStream upToAll: '--', boundary. + [aStream atEnd or: [(skip := aStream next: 2) = '--']] whileFalse: [ + self assert: skip = String crlf description: 'Error decoding multipart/form-data fields'. + + headers := Dictionary newFrom: (WebUtils readHeadersFrom: aStream). - [aStream atEnd or:[(skip := aStream next: 2) = '--']] whileFalse:[ - skip = String crlf ifFalse:[self error: 'Error decoding multipart/form-data fields']. - headers := Dictionary new. - (WebUtils readHeadersFrom: aStream) do:[:hdr| headers add: hdr]. - content := aStream upToAll: String crlf, '--', boundary. params := Dictionary new. + content := aStream upToAll: String crlf, '--', boundary. + + disposition := (headers at: 'content-disposition' ifAbsent: ['']) utf8ToSqueak. + self flag: #todo. "Support content-type and charset as described in RFC7578." + #(name filename) do: [:arg | + | len | - disposition := headers at: 'content-disposition' ifAbsent:['']. - #(name filename) do:[:arg| | len val | len := arg size + 2. + index := disposition findString: arg, '='. + index > 0 ifTrue: [ + params at: arg put: (disposition + copyFrom: index + len + to: (disposition indexOf: $" startingAt: index + len) - 1) utf8ToSqueak]]. + aBlock value: headers value: params value: content].! - index := disposition findString: arg,'='. - index > 0 ifTrue:[ - val := disposition copyFrom: index + len to: (disposition indexOf: $" startingAt: index+len) - 1. - params at: arg put: val. - ]. - ]. - aBlock value: headers value: params value: content. - ].! Item was changed: ----- Method: WebUtils class>>encodeMultipartForm:boundary: (in category 'decoding') ----- encodeMultipartForm: fieldMap boundary: boundary + "Encode the fieldMap as multipart/form-data. + + The fieldMap may contain MIMEDocument instances to indicate the presence of a file to upload to the server. If the MIMEDocument is present, its content type and file name will be used for the upload. + + The fieldMap can be EITHER an array of associations OR a Dictionary of key value pairs (the former is useful for providing multiple fields and/or specifying the order of fields)." - "Encodes the fieldMap as multipart/form-data. + ^ String streamContents: [:stream | + (fieldMap as: OrderedDictionary) keysAndValuesDo: [:fieldName :fieldValue | + | fieldContent | - The fieldMap may contain MIMEDocument instances to indicate the presence - of a file to upload to the server. If the MIMEDocument is present, its - content type and file name will be used for the upload. - - The fieldMap can be EITHER an array of associations OR a Dictionary of - key value pairs (the former is useful for providing multiple fields and/or - specifying the order of fields)." - - ^String streamContents:[:stream| - (fieldMap as: Dictionary) keysAndValuesDo:[:fieldName :fieldValue | | fieldContent | "Write multipart boundary and common headers" stream nextPutAll: '--', boundary; crlf. + stream nextPutAll: 'Content-Disposition: form-data; name="' + , fieldName squeakToUtf8 + , '"'. + self flag: #todo. "Support Content-Type and charset as described in RFC7578." + + "Write field content - either a file or a string" + fieldContent := (fieldValue isKindOf: MIMEDocument) + ifTrue: [ + fieldValue url ifNotNil: [:url | + stream nextPutAll: '; filename="', url pathForFile squeakToUtf8, '"']. + stream crlf. + stream + nextPutAll: 'Content-Type: '; + nextPutAll: fieldValue contentType squeakToUtf8. + (fieldValue content ifNil: [ + (FileStream readOnlyFileNamed: fieldValue url pathForFile) contentsOfEntireFile]) asString] + ifFalse: [fieldValue asString squeakToUtf8]. - stream nextPutAll: 'Content-Disposition: form-data; name="', fieldName, '"'. - "Figure out if this is a file upload" - (fieldValue isKindOf: MIMEDocument) ifTrue:[ - stream nextPutAll: '; filename="', fieldValue url pathForFile, '"'; crlf. - stream nextPutAll: 'Content-Type: ', fieldValue contentType. - fieldContent := (fieldValue content ifNil:[ - (FileStream readOnlyFileNamed: fieldValue url pathForFile) contentsOfEntireFile. - ]) asString. - ] ifFalse: [fieldContent := fieldValue]. stream crlf; crlf. + stream nextPutAll: fieldContent. + + stream crlf]. + stream nextPutAll: '--', boundary, '--', String crlf]! - stream nextPutAll: fieldContent asString. - stream crlf. - ]. - stream nextPutAll: '--', boundary, '--', String crlf. - ]. - !

1 0

The Inbox: Monticello-dtl.727.mcz
by commits＠source.squeak.org 08 Sep '20

08 Sep '20

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-dtl.727.mcz ==================== Summary ==================== Name: Monticello-dtl.727 Author: dtl Time: 7 September 2020, 7:48:09.973319 pm UUID: 88de6167-2724-45e3-ae7a-c0e692903f98 Ancestors: Monticello-cmm.726 For MC commit notices, truncate time stamps to whole seconds when printing summaryHeader =============== Diff against Monticello-cmm.726 =============== Item was changed: ----- Method: MCVersionInfo>>summaryHeader (in category 'accessing') ----- summaryHeader ^ String streamContents: [:s | s nextPutAll: 'Name: '; nextPutAll: self name; cr. date ifNotNil: [s nextPutAll: 'Author: '; nextPutAll: author; cr; + nextPutAll: 'Time: '; nextPutAll: date asString, ', '; + nextPutAll: (time ifNotNil: [ :tm | Time fromSeconds: tm asSeconds asInteger]) asString; cr]. - nextPutAll: 'Time: '; nextPutAll: date asString, ', ', time asString; cr]. id ifNotNil: [s nextPutAll: 'UUID: '; nextPutAll: id asString; cr]. s nextPutAll: 'Ancestors: '; nextPutAll: self ancestorString. self stepChildren isEmpty ifFalse: [s cr; nextPutAll: 'Backported From: '; nextPutAll: self stepChildrenString]. ]!

1 0

Jump to page: