Squeak-dev September 2020

squeak-dev@lists.squeakfoundation.org

37 participants
269 discussions

SQUEAK_SPY and -spy option
by stes＠PANDORA.BE 01 Sep '20

01 Sep '20

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 I've already asked this question on vm-dev, with no replies so far. Perhaps someone knows here on this list ... I wonder whether anyone is using the SQUEAK_SPY environment variable, or knows what this is doing. In the VM source code : platforms/unix/vm-display-X11/sqUnixX11.c:int withSpy= 0; platforms/unix/vm-display-X11/sqUnixX11.c: if (getenv("SQUEAK_SPY")) withSpy= 1; platforms/unix/vm/sqUnixMain.c: int withSpy= 0; platforms/unix/vm/sqUnixMain.c: else if (!strcmp(argv[0], VMOPTION("spy"))) { withSpy = 1; return 1; } Also I wonder why both .c files (sqUnixX11.c and sqUnixMain.c) both define the same global variable (they both define withSpy). Maybe the VM -spy option is somehow related to spyOn: and MessageTally ?? http://wiki.squeak.org/squeak/4210 It's just a guess. I don't immediately see any documentation on this on wiki.squeak.org. Perhaps -spy is related to Squeak Performance Tuning ? Is anyone using -spy or SQUEAK_SPY ? David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJfTKHkAAoJEAwpOKXMq1MaHqoH/Ar6sReeDUhwcWDPWCyWupIc 07gQMUEcM2rUa3hZCysoGQGJGPH7ZXNEj8QViW4QIwrAnR0j6GGz9M648rOot9IF 9yH3TEFmPk4hCYq8UADyfxFRpEBs9dOKk3TVE0LLIo1KTWqyo+Fz4SYQQFWQnfZ2 5lXVwbDJlfFyBOvGaNCAzFgoftWSL1KhxEsGuhPKo1b2WO++T9rNVF4eSvlKltJR 5rr/bmuOC0ILYcDBe0+wsYg5O17DdSMPRSeKBgwqlnMS6xquxfS90VS7J1uH6wC3 Qe+fDeaDJxHZ05+aEL8aSAMhKiGfm5oBOc07gVxYO20otmWt9sTgaGhY1+3QEZo= =RR59 -----END PGP SIGNATURE-----

2 2

Issues with SmartRefStream
by Thiede, Christoph 01 Sep '20

01 Sep '20

Hi all, I was just trying to file out a complex Object graph via #saveOnFile and found two problems with the SmartRefStream: First, uniclass instances cannot be written to the stream. In SmartRefStream >> #instVarInfo:, I get an #errorKeyNotFound because the uniclass name is looked up into the SmalltalkImage globals. Minimum example to reproduce: Object newSubclass new saveOnFile. Second, blocks met during the file out process cannot be filed in again. Just try [] saveOnFile to reproduce this. Filein raises newMethodViaNewError. Maybe CompiledBlock should overwrite some streaming method for creating an appropriate disk representation? <http://www.hpi.de/> Just wanted to report these issues. Maybe someone is more experienced with the SmartRefStream architecture and would like to fix these bugs. :-) Best, Christoph

2 4

The Inbox: WebClient-Core-ct.124.mcz
by commits＠source.squeak.org 01 Sep '20

01 Sep '20

Christoph Thiede uploaded a new version of WebClient-Core to project The Inbox: http://source.squeak.org/inbox/WebClient-Core-ct.124.mcz ==================== Summary ==================== Name: WebClient-Core-ct.124 Author: ct Time: 31 August 2020, 1:54:11.685896 am UUID: b0d7790c-c195-6e4d-ad0f-fce8cf8b3b00 Ancestors: WebClient-Core-ul.123 Fixes a syntax error in multipart/form-data encoding Phew! It costed me a few hours to track some higher-level application bug down to this low level code ... =============== Diff against WebClient-Core-ul.123 =============== Item was changed: ----- Method: WebUtils class>>encodeMultipartForm:boundary: (in category 'decoding') ----- encodeMultipartForm: fieldMap boundary: boundary "Encodes the fieldMap as multipart/form-data. The fieldMap may contain MIMEDocument instances to indicate the presence of a file to upload to the server. If the MIMEDocument is present, its content type and file name will be used for the upload. The fieldMap can be EITHER an array of associations OR a Dictionary of key value pairs (the former is useful for providing multiple fields and/or specifying the order of fields)." ^String streamContents:[:stream| (fieldMap as: Dictionary) keysAndValuesDo:[:fieldName :fieldValue | | fieldContent | "Write multipart boundary and common headers" stream nextPutAll: '--', boundary; crlf. stream nextPutAll: 'Content-Disposition: form-data; name="', fieldName, '"'. "Figure out if this is a file upload" (fieldValue isKindOf: MIMEDocument) ifTrue:[ + stream nextPutAll: '; filename="', fieldValue url pathForFile, '"'; crlf. - stream nextPutAll: ' filename="', fieldValue url pathForFile, '"'; crlf. stream nextPutAll: 'Content-Type: ', fieldValue contentType. fieldContent := (fieldValue content ifNil:[ (FileStream readOnlyFileNamed: fieldValue url pathForFile) contentsOfEntireFile. ]) asString. ] ifFalse: [fieldContent := fieldValue]. stream crlf; crlf. stream nextPutAll: fieldContent asString. stream crlf. ]. stream nextPutAll: '--', boundary, '--', String crlf. ]. !

4 3

[CRON] Passed: squeak-smalltalk/squeak-app#1812 (squeak-trunk - 25ebaf1)
by Travis CI 01 Sep '20

01 Sep '20

Build Update for squeak-smalltalk/squeak-app ------------------------------------- Build: #1812 Status: Passed Duration: 19 mins and 55 secs Commit: 25ebaf1 (squeak-trunk) Author: Marcel Taeumel Message: Hi all! The project "squeak-app" is part of the continuous build infrastructure (short: CI) for Squeak's bundles, which you can download at https://files.squeak.org/, followed by the version tag you are looking for. All bundles are updated on a regular basis, which is daily for Trunk (i.e. the current alpha version) and monthly for release versions. Note that there won't be new bundles if Squeak's build number, which reflects in-image code updates, did not change between CI jobs. -- The Squeak Oversight Board [ci skip] View the changeset: https://github.com/squeak-smalltalk/squeak-app/compare/fb55517f583fe544f922… View the full build log and details: https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/723105553?u… -- You can unsubscribe from build emails from the squeak-smalltalk/squeak-app repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8901856&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

The Inbox: 60Deprecated-ct.80.mcz
by commits＠source.squeak.org 01 Sep '20

01 Sep '20

A new version of 60Deprecated was added to project The Inbox: http://source.squeak.org/inbox/60Deprecated-ct.80.mcz ==================== Summary ==================== Name: 60Deprecated-ct.80 Author: ct Time: 20 August 2020, 2:33:32.63864 pm UUID: 1295269c-62ee-5c45-9315-e66ff5eef57a Ancestors: 60Deprecated-mt.79 Finnaly deprecate #doWithIndex: and #collectWithIndex:. Other packages will be patched right now. =============== Diff against 60Deprecated-mt.79 =============== Item was added: + ----- Method: HashedCollection>>doWithIndex: (in category '*60Deprecated-enumerating') ----- + doWithIndex: elementAndIndexBlock + + self deprecated: 'Use #withIndexDo: instead'. + ^ self withIndexDo: elementAndIndexBlock! Item was added: + ----- Method: SequenceableCollection>>collectWithIndex: (in category '*60Deprecated-enumerating') ----- + collectWithIndex: elementAndIndexBlock + + self deprecated: 'Use #withIndexCollect: instead'. + ^ self withIndexCollect: elementAndIndexBlock! Item was added: + ----- Method: SequenceableCollection>>doWithIndex: (in category '*60Deprecated-enumerating') ----- + doWithIndex: elementAndIndexBlock + + self deprecated: 'Use #withIndexDo: instead'. + ^ self withIndexDo: elementAndIndexBlock! Item was changed: ----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') ----- menuSelectionsArray: aDirectory "Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a selector to operate on and the second element of which contains the parameters for that selector." |dirSize| dirSize := aDirectory pathParts size. ^Array streamContents: [:s | canTypeFileName ifTrue: [s nextPut: (StandardFileMenuResult directory: aDirectory name: nil)]. s nextPut: (StandardFileMenuResult directory: (FileDirectory root) name: ''). + aDirectory pathParts withIndexDo: - aDirectory pathParts doWithIndex: [:d :i | s nextPut: (StandardFileMenuResult directory: (self advance: dirSize - i containingDirectoriesFrom: aDirectory) name: '')]. aDirectory directoryNames do: [:dn | s nextPut: (StandardFileMenuResult directory: (FileDirectory on: (aDirectory fullNameFor: dn)) name: '')]. aDirectory fileNames do: [:fn | pattern do: [:pat | (pat match: fn) ifTrue: [ s nextPut: (StandardFileMenuResult directory: aDirectory name: fn)]]]]! Item was changed: ----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') ----- pathPartsString: aDirectory "Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr." ^String streamContents: [:s | s nextPutAll: '[]'; cr. + aDirectory pathParts asArray withIndexDo: - aDirectory pathParts asArray doWithIndex: [:part :i | s next: i put: $ . s nextPutAll: part withBlanksTrimmed; cr]]!

5 7

Thank Eliot Miranda!
by ken.dickey＠whidbey.com 01 Sep '20

01 Sep '20

> Many thanks to those who recently landed the ARMv8 build of Cog. (Per the commit history I think the main person responsible was Ken Dickey? Thanks Ken!) That was 99.997% Eliot. I just got the vm-display-fbdev up with libevdev on Raspi3/4 & LePotato. Great thanks to Eliot !!! -KenD

4 4

The Trunk: Tests-ct.437.mcz
by commits＠source.squeak.org 01 Sep '20

01 Sep '20

David T. Lewis uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ct.437.mcz ==================== Summary ==================== Name: Tests-ct.437 Author: ct Time: 1 September 2020, 2:10:41.85599 am UUID: 88d1330f-334b-a14a-96ca-8ea4a6ab1b52 Ancestors: Tests-pre.436 Adds regression test for bugfix in Sound-ct.71. Should this go into the Tests-Sound or the SoundTests package (both not yet existing)? :-) =============== Diff against Tests-pre.436 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-System-Applications'! SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! SystemOrganization addCategory: #'Tests-MonticelloMocks'! + SystemOrganization addCategory: #'Tests-Sound'! Item was added: + TestCase subclass: #SoundTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Sound'! Item was added: + ----- Method: SoundTest>>testStoreSamples (in category 'tests') ----- + testStoreSamples + + | sound fileName arrayBytes fileBytes | + sound := PluckedSound default. + fileName := 'tempPluck.wav'. + + "Write to file" + fileBytes := [ + sound storeWAVOnFileNamed: fileName. + FileStream oldFileNamed: fileName do: [:stream | + stream binary contents]] ensure: [ + FileDirectory deleteFilePath: fileName]. + + "Write to array" + arrayBytes := ByteArray streamContents: [:stream | + sound storeWAVSamplesOn: stream]. + + "Compare" + self assert: fileBytes equals: arrayBytes.!

1 0

The Inbox: Tests-ct.437.mcz
by commits＠source.squeak.org 01 Sep '20

01 Sep '20

Christoph Thiede uploaded a new version of Tests to project The Inbox: http://source.squeak.org/inbox/Tests-ct.437.mcz ==================== Summary ==================== Name: Tests-ct.437 Author: ct Time: 1 September 2020, 2:10:41.85599 am UUID: 88d1330f-334b-a14a-96ca-8ea4a6ab1b52 Ancestors: Tests-pre.436 Adds regression test for bugfix in Sound-ct.71. Should this go into the Tests-Sound or the SoundTests package (both not yet existing)? :-) =============== Diff against Tests-pre.436 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-System-Applications'! SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! SystemOrganization addCategory: #'Tests-MonticelloMocks'! + SystemOrganization addCategory: #'Tests-Sound'! Item was added: + TestCase subclass: #SoundTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Sound'! Item was added: + ----- Method: SoundTest>>testStoreSamples (in category 'tests') ----- + testStoreSamples + + | sound fileName arrayBytes fileBytes | + sound := PluckedSound default. + fileName := 'tempPluck.wav'. + + "Write to file" + fileBytes := [ + sound storeWAVOnFileNamed: fileName. + FileStream oldFileNamed: fileName do: [:stream | + stream binary contents]] ensure: [ + FileDirectory deleteFilePath: fileName]. + + "Write to array" + arrayBytes := ByteArray streamContents: [:stream | + sound storeWAVSamplesOn: stream]. + + "Compare" + self assert: fileBytes equals: arrayBytes.!

1 0

The Inbox: Sound-ct.71.mcz
by commits＠source.squeak.org 01 Sep '20

01 Sep '20

A new version of Sound was added to project The Inbox: http://source.squeak.org/inbox/Sound-ct.71.mcz ==================== Summary ==================== Name: Sound-ct.71 Author: ct Time: 1 September 2020, 2:07:15.07999 am UUID: 0d91a1bf-41cb-834c-ab0c-fa2ad832e408 Ancestors: Sound-nice.69 Fixes wave sound streaming on non-filestream objects. The endianness was inverted because #int16: already uses Big Endian. This did not sound well - listen yourself in an unpatched image: :-) array := ByteArray streamContents: [:stream | PluckedSound bachFugue storeWAVSamplesOn: stream]. (FileStream fileNamed: 'bachFugue.wav') binary in: [:stream | [array do: [:ea | stream nextPut: ea]] ensure: [stream close]]. (SampledSound fromWaveFileNamed: 'bachFugue.wav') play. Please review in detail as this is one of my first contacts to the Sound system! =============== Diff against Sound-nice.69 =============== Item was changed: ----- Method: AbstractSound>>storeSampleCount:bigEndian:on: (in category 'file i/o') ----- storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files). If self isStereo is true, both channels are stored, creating a stereo file. Otherwise, only the left channel is stored, creating a mono file." + | bufSize stereoBuffer reverseBytes streamDirect | - | bufSize stereoBuffer reverseBytes | self reset. bufSize := (2 * self samplingRate rounded) min: samplesToStore. "two second buffer" stereoBuffer := SoundBuffer newStereoSampleCount: bufSize. + streamDirect := aBinaryStream isKindOf: StandardFileStream. + reverseBytes := (bigEndianFlag xor: Smalltalk isBigEndian) xor: streamDirect not. - reverseBytes := bigEndianFlag ~= (Smalltalk isBigEndian). 'Storing audio...' displayProgressFrom: 0 to: samplesToStore during: [:bar | | remaining out | remaining := samplesToStore. [remaining > 0] whileTrue: [ bar value: samplesToStore - remaining. stereoBuffer primFill: 0. "clear the buffer" self playSampleCount: (bufSize min: remaining) into: stereoBuffer startingAt: 1. out := self isStereo ifTrue: [stereoBuffer] ifFalse: [stereoBuffer extractLeftChannel]. reverseBytes ifTrue: [out reverseEndianness]. + streamDirect - (aBinaryStream isKindOf: StandardFileStream) ifTrue: [ "optimization for files: write sound buffer directly to file" aBinaryStream next: (out size // 2) putAll: out startingAt: 1] "size in words" ifFalse: [ "for non-file streams:" 1 to: out monoSampleCount do: [:i | aBinaryStream int16: (out at: i)]]. + remaining := remaining - bufSize]].! - remaining := remaining - bufSize]]. - !

1 0

Jump to page: