Squeak-dev January 2021

squeak-dev@lists.squeakfoundation.org

38 participants
172 discussions

The Inbox: KernelTests-ct.383.mcz
by commits＠source.squeak.org 24 Jan '21

24 Jan '21

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-ct.383.mcz ==================== Summary ==================== Name: KernelTests-ct.383 Author: ct Time: 24 January 2021, 4:39:37.623504 pm UUID: 27645338-d085-9c45-ae2b-4263aade35b4 Ancestors: KernelTests-ct.382 Removes inappropriate test case for perform primitives with invalid number of arguments. Depends on KernelTests-ct.382. =============== Diff against KernelTests-ct.382 =============== Item was changed: SystemOrganization addCategory: #'KernelTests-Classes'! SystemOrganization addCategory: #'KernelTests-Methods'! SystemOrganization addCategory: #'KernelTests-Numbers'! SystemOrganization addCategory: #'KernelTests-Objects'! SystemOrganization addCategory: #'KernelTests-Processes'! + SystemOrganization addCategory: #'KernelTests-Models'! Item was added: + ----- Method: BlockClosureTest>>return: (in category 'private') ----- + return: something + + ^ something! Item was changed: ----- Method: BlockClosureTest>>testRunSimulated (in category 'tests') ----- testRunSimulated + self assert: Rectangle equals: + (Context runSimulated: aBlockClosure asContext) class. + self assert: 42 equals: + (Context runSimulated: [self return: 42]). + self + should: [Context runSimulated: [self halt]] + raise: Halt.! - self assert: Rectangle equals: (Context runSimulated: aBlockClosure asContext) class! Item was added: + ----- Method: BlockClosureTest>>testRunSimulatedContextAtEachStep (in category 'tests') ----- + testRunSimulatedContextAtEachStep + + | context | + context := aBlockClosure asContext. + self assert: Rectangle equals: (thisContext + runSimulated: context + contextAtEachStep: [:ctxt | self assert: + [ctxt == context or: [ctxt hasSender: context]]]) class.! Item was changed: ----- Method: ContextTest>>testPrimitive100 (in category 'tests') ----- testPrimitive100 { {#isNil. {}. Object}. "valid 0-arg message" {#=. {true}. UndefinedObject}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}. Object}. "valid binary message" - {}. "missing selector" {#isNil}. "missing arguments" {#isNil. 'not an array'}. "invalid arguments" {#isNil. {}}. "missing lookupClass" {#isNil. {'excess arg'}. Object}. "too many arguments" {#=. {}. UndefinedObject}. "missing argument" {#isNil. {}. Boolean}. "lookupClass not in inheritance chain" } do: [:args | self assert: (Context runSimulated: [nil tryPrimitive: 100 withArgs: args]) equals: (nil tryPrimitive: 100 withArgs: args)].! Item was changed: ----- Method: ContextTest>>testPrimitive83 (in category 'tests') ----- testPrimitive83 { {#isNil}. "valid 0-arg message" {#=. true}. "valid unary message" {#ifNil:ifNotNil:. [2]. [:x | x]}. "valid binary message" - {}. "missing selector" {#isNil. 'excess arg'}. "too many arguments" {#=}. "missing argument" } do: [:args | self assert: (Context runSimulated: [nil tryPrimitive: 83 withArgs: args]) equals: (nil tryPrimitive: 83 withArgs: args)].! Item was changed: ----- Method: ContextTest>>testPrimitive84 (in category 'tests') ----- testPrimitive84 { {#isNil. {}}. "valid 0-arg message" {#=. {true}}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" - {}. "missing selector" {#isNil}. "missing arguments" {#isNil. 'not an array'}. "invalid arguments" {#isNil. {'excess arg'}}. "too many arguments" {#=. {}}. "missing argument" } do: [:args | self assert: (Context runSimulated: [nil tryPrimitive: 84 withArgs: args]) equals: (nil tryPrimitive: 84 withArgs: args)].! Item was added: + TestCase subclass: #ModelTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Models'! Item was added: + ----- Method: ModelTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Model new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.! Item was added: + ----- Method: ObjectTest>>testCopyDependents (in category 'tests') ----- + testCopyDependents + + | bar foo | + foo := Object new. + foo addDependent: 42. + self assert: {42} equals: foo dependents asArray. + + bar := foo copy. + self assert: bar dependents isEmpty.! Item was added: + ----- Method: PromiseTest>>testNilErrBlockPropagation (in category 'tests - monad') ----- + testNilErrBlockPropagation + "https://promisesaplus.com section 2.2.7.4" + | p q | + p := Promise new. + q := p then: [:v | self error: 'Shouldn''t call resolvedBlock'] ifRejected: nil. + p rejectWith: 1. + self assert: p isRejected. + self assert: q isRejected. + self assert: p error equals: 1. + self assert: q error equals: 1.! Item was added: + ----- Method: PromiseTest>>testNilResolvedBlockPropagation (in category 'tests - monad') ----- + testNilResolvedBlockPropagation + "https://promisesaplus.com section 2.2.7.3" + | p q | + p := Promise new. + q := p then: nil ifRejected: [:e | self error: 'Shouldn''t call errBlock']. + p resolveWith: 1. + self assert: p isResolved. + self assert: q isResolved. + self assert: p value equals: 1. + self assert: q value equals: 1.!

1 0

The Inbox: System-ct.1208.mcz
by commits＠source.squeak.org 24 Jan '21

24 Jan '21

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1208.mcz ==================== Summary ==================== Name: System-ct.1208 Author: ct Time: 24 January 2021, 3:46:48.741384 pm UUID: d2a952ca-fe5d-0045-b089-f8702dbdbb1e Ancestors: System-eem.1207 Proposal: Adds query & browse selectors for finding certain primitive methods to SystemNavigation. Also excludes quick methods from #allPrimitiveMethods. Usage: self systemNavigation browseAllPrimitiveMethods. self systemNavigation allPrimitiveMethodsFor: 38. self systemNavigation browseAllPrimitiveMethodsFor: 62. self systemNavigation browseAllPrimitiveMethodsFor: 'primitiveFindSubstring'. =============== Diff against System-eem.1207 =============== Item was changed: ----- Method: SystemNavigation>>allPrimitiveMethods (in category 'query') ----- allPrimitiveMethods "Answer a collection of all the methods that are implemented by primitives." | result | result := OrderedCollection new. self allSelectorsAndMethodsDo: [ :behavior :selector :method | + (method isQuick not and: [method primitive ~= 0]) ifTrue: [ - method primitive ~= 0 ifTrue: [ result add: (String streamContents: [ :stream | stream nextPutAll: behavior name; space; nextPutAll: selector; space; print: method primitive ]) ] ]. ^result! Item was added: + ----- Method: SystemNavigation>>allPrimitiveMethodsFor: (in category 'query') ----- + allPrimitiveMethodsFor: primitiveIndexOrName + + ^ self allMethodsSelect: [:method | method primitive = primitiveIndexOrName + or: [method primitive = 117 and: [ | symbols | + symbols := method literalAt: 1. + symbols first = primitiveIndexOrName or: [symbols second = primitiveIndexOrName]]]]! Item was added: + ----- Method: SystemNavigation>>browseAllPrimitiveMethods (in category 'browse') ----- + browseAllPrimitiveMethods + + ^ self + browseMessageList: [self allPrimitiveMethods] + name: ('Primitive methods' translated)! Item was added: + ----- Method: SystemNavigation>>browseAllPrimitiveMethodsFor: (in category 'browse') ----- + browseAllPrimitiveMethodsFor: primitiveIndexOrName + + ^ self + browseMessageList: [self allPrimitiveMethodsFor: primitiveIndexOrName] + name: ('Primitive methods for {1}' translated format: {primitiveIndexOrName}) + autoSelect: primitiveIndexOrName asString!

1 0

The Trunk: SystemReporter-eem.48.mcz
by commits＠source.squeak.org 24 Jan '21

24 Jan '21

Eliot Miranda uploaded a new version of SystemReporter to project The Trunk: http://source.squeak.org/trunk/SystemReporter-eem.48.mcz ==================== Summary ==================== Name: SystemReporter-eem.48 Author: eem Time: 23 January 2021, 6:22:46.831925 pm UUID: ab93c373-d792-4a99-a3b4-9967fdc8a294 Ancestors: SystemReporter-eem.47 Tiny neatening. =============== Diff against SystemReporter-eem.47 =============== Item was changed: ----- Method: SystemReporter>>reportImage: (in category 'reporting') ----- reportImage: aStream self header: 'Image' on: aStream. aStream nextPutAll: Smalltalk image imageName; cr; nextPutAll: SystemVersion current version; cr; nextPutAll: Smalltalk image lastUpdateString; cr; nextPutAll: Smalltalk image currentChangeSetString; cr. + [aStream + nextPutAll: 'Image format '; + print: Smalltalk image imageFormatVersion; - [ | imageFormat bitsPerWord | - imageFormat := Smalltalk image imageFormatVersion. - bitsPerWord := Smalltalk image wordSize * 8. - aStream nextPutAll: 'Image format '; - nextPutAll: imageFormat asString; nextPutAll: ' ('; + print: Smalltalk image wordSize * 8; - nextPutAll: bitsPerWord asString; nextPutAll: ' bit)'; cr] on: Warning + do: ["primitive not present in VM"] + + "self new reportImage: Transcript. Transcript flush"! - do: ["primitive not present in VM"]. - !

1 0

The Trunk: EToys-eem.417.mcz
by commits＠source.squeak.org 24 Jan '21

24 Jan '21

Eliot Miranda uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-eem.417.mcz ==================== Summary ==================== Name: EToys-eem.417 Author: eem Time: 23 January 2021, 6:19:52.973089 pm UUID: 90068d9d-ef84-4cb9-92d2-5bb0ec54994e Ancestors: EToys-mt.416 Move two base system methods to System. =============== Diff against EToys-mt.416 =============== Item was removed: - ----- Method: SystemDictionary>>copyright (in category '*Etoys-Squeakland-sources, change log') ----- - copyright - "The Smalltalk copyright." - - ^'Copyright (c) 1996 Apple Computer, Inc. All Rights Reserved. - Copyright (c) 1996-2009 Viewpoints Research Institute, and Contributors; - Copyright (c) 2010-2012 Squeak Community Contributors'! Item was removed: - ----- Method: SystemDictionary>>currentChangeSetString (in category '*Etoys-Squeakland-sources, change log') ----- - currentChangeSetString - "Smalltalk currentChangeSetString" - ^ 'Current Change Set: ' translated, ChangeSet current name!

1 0

The Trunk: System-eem.1212.mcz
by commits＠source.squeak.org 24 Jan '21

24 Jan '21

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.1212.mcz ==================== Summary ==================== Name: System-eem.1212 Author: eem Time: 23 January 2021, 6:18:33.915831 pm UUID: b4abe320-97d1-4849-87af-51818eddcabe Ancestors: System-eem.1211 There are two instances of the copyright. Make them both consstent and move them out of EToys (helping a tiny bit in EToys unloading). =============== Diff against System-eem.1211 =============== Item was changed: ----- Method: SmalltalkImage>>copyright (in category 'sources, changes log') ----- copyright "The Smalltalk copyright." ^'Copyright © Xerox Corp. 1981, 1982 All rights reserved. + Copyright © Apple Computer, Inc. 1985-1996 All rights reserved. + Copyright © 1996-2009 Viewpoints Research Institute, and Contributors. - Copyright © Apple Computer, Inc. 1985-1996 All rights reserved; Copyright © 2010-2021 Squeak Community Contributors.'! Item was added: + ----- Method: SystemDictionary>>copyright (in category 'sources, change log') ----- + copyright + "The Smalltalk copyright." + + ^'Copyright © Xerox Corp. 1981, 1982 All rights reserved. + Copyright © 1996 Apple Computer, Inc. All Rights Reserved. + Copyright © 1996-2009 Viewpoints Research Institute, and Contributors. + Copyright © 2010-2021 Squeak Community Contributors'! Item was added: + ----- Method: SystemDictionary>>currentChangeSetString (in category 'sources, change log') ----- + currentChangeSetString + "Smalltalk currentChangeSetString" + ^ 'Current Change Set: ' translated, ChangeSet current name!

1 0

The Trunk: Collections-ul.922.mcz
by commits＠source.squeak.org 19 Jan '21

19 Jan '21

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.922.mcz ==================== Summary ==================== Name: Collections-ul.922 Author: ul Time: 19 January 2021, 1:28:51.784086 pm UUID: 7d688371-2966-43d3-9000-3985ae9f6afa Ancestors: Collections-nice.921 Fix off-by-one errors in OrderedCollection's #removeFirst: and #removeLast:. The argument of those methods can be zero. =============== Diff against Collections-nice.921 =============== Item was changed: ----- Method: OrderedCollection>>removeFirst: (in category 'removing') ----- removeFirst: n "Remove the first n objects into an array." | lastIndexToRemove result | + n < 0 ifTrue: [ self errorNoSuchElement ]. - n < 1 ifTrue: [ self errorNoSuchElement ]. lastIndex < (lastIndexToRemove := firstIndex + n - 1) ifTrue: [ self errorNotEnoughElements ]. result := array copyFrom: firstIndex to: lastIndexToRemove. array from: firstIndex to: lastIndexToRemove put: nil. firstIndex := lastIndexToRemove + 1. ^result! Item was changed: ----- Method: OrderedCollection>>removeLast: (in category 'removing') ----- removeLast: n "Remove the last n objects into an array with last in last position." | firstIndexToRemove result | + n < 0 ifTrue: [ self errorNoSuchElement ]. - n < 1 ifTrue: [ self errorNoSuchElement ]. (firstIndexToRemove := lastIndex - n + 1) < firstIndex ifTrue: [ self errorNotEnoughElements ]. result := array copyFrom: firstIndexToRemove to: lastIndex. array from: firstIndexToRemove to: lastIndex put: nil. lastIndex := firstIndexToRemove - 1. ^result!

2 1

The Trunk: CollectionsTests-ul.348.mcz
by commits＠source.squeak.org 19 Jan '21

19 Jan '21

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.348.mcz ==================== Summary ==================== Name: CollectionsTests-ul.348 Author: ul Time: 19 January 2021, 1:29:30.901142 pm UUID: 7a478e2d-0752-43f2-ab4a-4f6aa9f3bbe6 Ancestors: CollectionsTests-nice.347 - improved tests for OrderedCollection's #removeFirst: and #removeLast:. =============== Diff against CollectionsTests-nice.347 =============== Item was changed: ----- Method: OrderedCollectionTest>>testRemoveFirst (in category 'tests - removing') ----- testRemoveFirst "Allows one to remove n element of a collection at the first" "self run:#testRemoveFirst" + | c1 c2 | - | c1 | c1 := #(2 3 4 6) asOrderedCollection. + c2 := c1 copy. + self assert: Array empty equals: (c1 removeFirst: 0). + self assert: c2 equals: c1. + self assert: #(2) equals: (c1 removeFirst: 1). + self assert: #(3 4 6) asOrderedCollection equals: c1. + self assert:#(3 4) equals: (c1 removeFirst: 2). + self assert: #(6) asOrderedCollection equals: c1. - c1 removeFirst: 1. - self assert: (c1 = #(3 4 6) asOrderedCollection). - c1 removeFirst: 2. - self assert: (c1 = #(6) asOrderedCollection). self should: [c1 removeFirst: 10] raise: Error. ! Item was changed: ----- Method: OrderedCollectionTest>>testRemoveLast (in category 'tests - removing') ----- testRemoveLast "Allows one to remove n element of a collection at the end" "self run:#testRemoveLast" + | c1 c2 | - | c1 | c1 := #(2 3 4 6) asOrderedCollection. + c2 := c1 copy. + self assert: Array empty equals: (c1 removeLast: 0). + self assert: c2 equals: c1. + self assert: #(6) equals: (c1 removeLast: 1). + self assert: #(2 3 4) asOrderedCollection equals: c1. + self assert: #(3 4) equals: (c1 removeLast: 2). + self assert: #(2) asOrderedCollection equals: c1. + self should: [c1 removeLast: 10] raise: Error! - c1 removeLast: 1. - self assert: (c1 = #(2 3 4) asOrderedCollection). - c1 removeLast: 2. - self assert: (c1 = #(2) asOrderedCollection). - self should: [c1 removeLast: 10] raise: Error.!

1 0

Unix keyboard events lose track when multiple keys pressed or keys held down
by tim Rowledge 19 Jan '21

19 Jan '21

One of the things I had to make for NuScratch was a keyboardlistener that keeps a bitmap of the keys currently pressed - quite a few Scratch things are state dependent rather than even responsive. It originally worked pretty well as far as anybody could ever see; I had no reports of problems for years. Whilst trying to make a 5.3 version it seems that something is making it much less reliable. It is clear from some tracking code that if one holds down a key, presses and releases another key and then finally releases the initial key, that we are losing the final expected key-up of the held-down key. Which in turn leaves my keyboard listener thinking the key is still pressed. This is a Bad Thing. It causes me to lose games of Asteroid Blaster. I don't like to lose at Asteroid Blaster. Looking at the unix VM keystroke handling code causes migraines. Has anybody got any idea what on earth is going on down there? I'll build a VM with the relevant debug code turned on soon but really... if anyone that knows this part could save some pain it would be very pleasant. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Hmm. That’s the second time today I’ve seen a Word doc eat a man’s soul. Time for a bug report...

7 40

The Inbox: Tests-ct.447.mcz
by commits＠source.squeak.org 18 Jan '21

18 Jan '21

Christoph Thiede uploaded a new version of Tests to project The Inbox: http://source.squeak.org/inbox/Tests-ct.447.mcz ==================== Summary ==================== Name: Tests-ct.447 Author: ct Time: 18 January 2021, 12:55:37.357232 pm UUID: 675252a4-a6d9-d442-b594-3c85592290a4 Ancestors: Tests-dtl.443 Fixes and supplements BecomeTest. - Updated #testBecomeForwardIdentityHash which has been broken since Collections-eem.885. Note that the referenced patch to #becomeForward: was a breaking change which we should make sure to document in the final release notes. - Added #testBecomeForwardIdentityAndHash to have a test for the classical primitiveArrayBecomeOneWay (primitive 72) again. - Added #testBecomeForwardCopyIdentityHash to test both bindings of the copyHash argument indeed. Please review! Fur further reference, see https://github.com/codefrau/SqueakJS/pull/117 where we were discussing the limitations/correctness of the current BecomeTest implementation. =============== Diff against Tests-dtl.443 =============== Item was added: + ----- Method: BecomeTest>>testBecomeForwardCopyIdentityHash (in category 'tests') ----- + testBecomeForwardCopyIdentityHash + "Check that + 1. the argument to becomeForward: is modified to have the receiver's identity hash. + 2. the receiver's identity hash is unchanged." + + | a b ha hb | + a := 'ab' copy. + b := 'cd' copy. + ha := a identityHash. + hb := b identityHash. + + a becomeForward: b copyHash: true. + + self + assert: ha equals: a identityHash; + assert: ha equals: b identityHash.! Item was added: + ----- Method: BecomeTest>>testBecomeForwardIdentityAndHash (in category 'tests') ----- + testBecomeForwardIdentityAndHash + "Check that + 1. the argument to becomeForward: is NOT modified to have the receiver's identity hash. + 2. the receiver's identity hash is unchanged." + + | a b ha | + a := 'ab' copy. + b := 'cd' copy. + ha := a identityHash. + + {a} elementsForwardIdentityAndHashTo: {b}. + + self + assert: ha equals: a identityHash; + assert: ha equals: b identityHash.! Item was changed: ----- Method: BecomeTest>>testBecomeForwardIdentityHash (in category 'tests') ----- testBecomeForwardIdentityHash "Check that + 1. the argument to becomeForward: is NOT modified to have the receiver's identity hash. - 1. the argument to becomeForward: is modified to have the receiver's identity hash. 2. the receiver's identity hash is unchanged." + | a b hb | - | a b ha | - a := 'ab' copy. b := 'cd' copy. + hb := b identityHash. + - ha := a identityHash. - a becomeForward: b. + - self + assert: a identityHash = hb; + assert: b identityHash = hb.! - assert: a identityHash = ha; - assert: b identityHash = ha. - - !

1 0

V3
by Vanessa Freudenberg 15 Jan '21

15 Jan '21

Reading the code I again noticed "Squeak V3" as name for the old bytecode set. Always wanted to know: Where does the "V3" nomenclature come from? What's V1 and V2? And should we consider Sista to be V4, or treat it as completely unrelated? Vanessa

7 18

← Newer
1
...
9
10
11
12
13
14
15
...
18
Older →

Jump to page: