Squeak-dev December 2021

squeak-dev@lists.squeakfoundation.org

30 participants
390 discussions

The Trunk: ToolBuilder-SUnit-mt.20.mcz
by commits＠source.squeak.org 30 Jan '22

30 Jan '22

Marcel Taeumel uploaded a new version of ToolBuilder-SUnit to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-SUnit-mt.20.mcz ==================== Summary ==================== Name: ToolBuilder-SUnit-mt.20 Author: mt Time: 15 November 2019, 4:32:12.21533 pm UUID: 42ab408c-6728-6749-8f5f-2eb2588936ff Ancestors: ToolBuilder-SUnit-fbs.19 Updates widget stubs for tests. =============== Diff against ToolBuilder-SUnit-fbs.19 =============== Item was removed: - SystemOrganization addCategory: #'ToolBuilder-SUnit'! Item was removed: - WidgetStub subclass: #ButtonStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: ButtonStub>>click (in category 'simulating') ----- - click - | action | - action := spec action. - action isSymbol - ifTrue: [self model perform: action] - ifFalse: [action value]! Item was removed: - ----- Method: ButtonStub>>color (in category 'simulating') ----- - color - ^ state at: #color! Item was removed: - ----- Method: ButtonStub>>isEnabled (in category 'simulating') ----- - isEnabled - ^ state at: #enabled! Item was removed: - ----- Method: ButtonStub>>isPressed (in category 'simulating') ----- - isPressed - ^ state at: #state! Item was removed: - ----- Method: ButtonStub>>label (in category 'simulating') ----- - label - ^ state at: #label! Item was removed: - ----- Method: ButtonStub>>stateVariables (in category 'events') ----- - stateVariables - ^ #(label color state enabled)! Item was removed: - WidgetStub subclass: #CompositeStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: CompositeStub>>children (in category 'accessing') ----- - children - ^ state at: #children ifAbsent: [#()]! Item was removed: - ----- Method: CompositeStub>>children: (in category 'accessing') ----- - children: anObject - state at: #children put: anObject! Item was removed: - ----- Method: CompositeStub>>stateVariables (in category 'accessing') ----- - stateVariables - ^ #(children)! Item was removed: - ----- Method: CompositeStub>>widgetNamed: (in category 'accessing') ----- - widgetNamed: aString - self name = aString - ifTrue: [^ self] - ifFalse: [self children do: [:ea | (ea widgetNamed: aString) ifNotNil: [:w | ^ w]]]. - ^ nil! Item was removed: - WidgetStub subclass: #ListStub - instanceVariableNames: 'list index' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: ListStub>>click: (in category 'simulating') ----- - click: aString - self clickItemAt: (self list indexOf: aString)! Item was removed: - ----- Method: ListStub>>clickItemAt: (in category 'simulating') ----- - clickItemAt: anInteger - | selector | - selector := spec setIndex. - selector - ifNil: [self model perform: spec setSelected with: (self list at: anInteger)] - ifNotNil: [self model perform: selector with: anInteger] - ! Item was removed: - ----- Method: ListStub>>list (in category 'simulating') ----- - list - ^ list ifNil: [Array new]! Item was removed: - ----- Method: ListStub>>menu (in category 'simulating') ----- - menu - ^ MenuStub fromSpec: - (self model - perform: spec menu - with: (PluggableMenuSpec withModel: self model))! Item was removed: - ----- Method: ListStub>>refresh (in category 'events') ----- - refresh - self refreshList. - self refreshIndex! Item was removed: - ----- Method: ListStub>>refreshIndex (in category 'events') ----- - refreshIndex - | selector | - selector := spec getIndex. - index := selector - ifNil: [self list indexOf: (self model perform: spec getSelected)] - ifNotNil: [spec model perform: selector] - ! Item was removed: - ----- Method: ListStub>>refreshList (in category 'events') ----- - refreshList - list := self model perform: spec list! Item was removed: - ----- Method: ListStub>>selectedIndex (in category 'simulating') ----- - selectedIndex - ^ index ifNil: [0]! Item was removed: - ----- Method: ListStub>>selectedItem (in category 'simulating') ----- - selectedItem - | items idx | - (items := self list) isEmpty ifTrue: [^ nil]. - (idx := self selectedIndex) = 0 ifTrue: [^ nil]. - ^ items at: idx - ! Item was removed: - ----- Method: ListStub>>update: (in category 'events') ----- - update: aSelector - aSelector = spec list ifTrue: [^ self refreshList]. - aSelector = spec getSelected ifTrue: [^ self refreshIndex]. - aSelector = spec getIndex ifTrue: [^ self refreshIndex]. - ^ super update: aSelector! Item was removed: - WidgetStub subclass: #MenuStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: MenuStub>>click: (in category 'as yet unclassified') ----- - click: aString - | item | - item := self items detect: [:ea | ea label = aString] ifNone: [^ self]. - item action isSymbol - ifTrue: [self model perform: item action] - ifFalse: [item action value]! Item was removed: - ----- Method: MenuStub>>items (in category 'as yet unclassified') ----- - items - ^ spec items! Item was removed: - ----- Method: MenuStub>>labels (in category 'as yet unclassified') ----- - labels - ^ self items keys! Item was removed: - CompositeStub subclass: #PanelStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ToolBuilder subclass: #SUnitToolBuilder - instanceVariableNames: 'widgets' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! - - !SUnitToolBuilder commentStamp: 'cwp 6/7/2005 00:53' prior: 0! - I create a set of "stub" widgets that are useful for testing. Instead of drawing themselves in some GUI, they simulate graphical widgets for testing purposes. Through my widgets, unit tests can simulate user actions and make assertions about the state of the display. - - See TestRunnerPlusTest for examples.! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableButton: (in category 'building') ----- - buildPluggableButton: aSpec - | w | - w := ButtonStub fromSpec: aSpec. - self register: w id: aSpec name. - ^w! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableList: (in category 'building') ----- - buildPluggableList: aSpec - | w | - w := ListStub fromSpec: aSpec. - self register: w id: aSpec name. - ^w! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableMenu: (in category 'building') ----- - buildPluggableMenu: aSpec - ^ MenuStub fromSpec: aSpec! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggablePanel: (in category 'building') ----- - buildPluggablePanel: aSpec - | w | - w := PanelStub fromSpec: aSpec. - self register: w id: aSpec name. - ^w! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableText: (in category 'building') ----- - buildPluggableText: aSpec - | w | - w := TextStub fromSpec: aSpec. - self register: w id: aSpec name. - ^w! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableTree: (in category 'building') ----- - buildPluggableTree: aSpec - | w | - w := TreeStub fromSpec: aSpec. - self register: w id: aSpec name. - ^w! Item was removed: - ----- Method: SUnitToolBuilder>>buildPluggableWindow: (in category 'building') ----- - buildPluggableWindow: aSpec - | window children | - window := WindowStub fromSpec: aSpec. - children := aSpec children. - children isSymbol - ifFalse: [window children: (children collect: [:ea | ea buildWith: self])]. - self register: window id: aSpec name. - ^ window! Item was removed: - ----- Method: SUnitToolBuilder>>close: (in category 'opening') ----- - close: aWidget - aWidget close! Item was removed: - ----- Method: SUnitToolBuilder>>open: (in category 'opening') ----- - open: anObject - ^ self build: anObject! Item was removed: - ----- Method: SUnitToolBuilder>>register:id: (in category 'private') ----- - register: widget id: id - id ifNil:[^self]. - widgets ifNil:[widgets := Dictionary new]. - widgets at: id put: widget.! Item was removed: - ----- Method: SUnitToolBuilder>>widgetAt:ifAbsent: (in category 'private') ----- - widgetAt: id ifAbsent: aBlock - widgets ifNil:[^aBlock value]. - ^widgets at: id ifAbsent: aBlock! Item was removed: - ToolBuilderTests subclass: #SUnitToolBuilderTests - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: SUnitToolBuilderTests>>acceptWidgetText (in category 'support') ----- - acceptWidgetText - widget accept: 'Some text'! Item was removed: - ----- Method: SUnitToolBuilderTests>>buttonWidgetEnabled (in category 'support') ----- - buttonWidgetEnabled - ^ widget isEnabled! Item was removed: - ----- Method: SUnitToolBuilderTests>>changeListWidget (in category 'support') ----- - changeListWidget - widget clickItemAt: widget selectedIndex + 1! Item was removed: - ----- Method: SUnitToolBuilderTests>>fireButtonWidget (in category 'support') ----- - fireButtonWidget - widget click! Item was removed: - ----- Method: SUnitToolBuilderTests>>fireMenuItemWidget (in category 'support') ----- - fireMenuItemWidget - widget click: 'Menu Item'! Item was removed: - ----- Method: SUnitToolBuilderTests>>setUp (in category 'running') ----- - setUp - super setUp. - builder := SUnitToolBuilder new.! Item was removed: - ----- Method: SUnitToolBuilderTests>>testHandlingNotification (in category 'tests') ----- - testHandlingNotification - | receivedSignal resumed | - receivedSignal := resumed := false. - [ | count | - "client-code puts up progress, and signals some notications" - count := 0. - 'doing something' - displayProgressFrom: 0 - to: 10 - during: - [ : bar | 10 timesRepeat: - [ bar value: (count := count + 1). - (Delay forMilliseconds: 200) wait. - Notification signal: 'message'. - resumed := true ] ] ] - on: Notification - do: - [ : noti | receivedSignal := true. - noti resume ]. - self - assert: receivedSignal ; - assert: resumed! Item was removed: - ----- Method: SUnitToolBuilderTests>>testListCached (in category 'tests') ----- - testListCached - - self makeItemList. - queries := Bag new. - self changed: #getList. - widget list. - widget list. - self assert: queries size = 1! Item was removed: - ----- Method: SUnitToolBuilderTests>>testListSelectionCached (in category 'tests') ----- - testListSelectionCached - - self makeItemList. - queries := Bag new. - self changed: #getListSelection. - widget selectedIndex. - widget selectedIndex. - self assert: queries size = 1! Item was removed: - ----- Method: SUnitToolBuilderTests>>testTextCached (in category 'tests') ----- - testTextCached - - self makeText. - queries := Bag new. - self changed: #getText. - widget text. - widget text. - self assert: queries size = 1! Item was removed: - ----- Method: SUnitToolBuilderTests>>widgetColor (in category 'support') ----- - widgetColor - ^ widget color! Item was removed: - WidgetStub subclass: #TextStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: TextStub>>accept: (in category 'simulating') ----- - accept: aString - state at: #getText put: aString. - ^ self model perform: spec setText with: aString asText! Item was removed: - ----- Method: TextStub>>color (in category 'simulating') ----- - color - ^ state at: #color! Item was removed: - ----- Method: TextStub>>stateVariables (in category 'events') ----- - stateVariables - ^ #(color selection getText)! Item was removed: - ----- Method: TextStub>>text (in category 'simulating') ----- - text - ^ state at: #getText! Item was removed: - WidgetStub subclass: #TreeNodeStub - instanceVariableNames: 'item' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: TreeNodeStub class>>fromSpec:item: (in category 'instance creation') ----- - fromSpec: aSpec item: anObject - ^ self new setSpec: aSpec item: anObject! Item was removed: - ----- Method: TreeNodeStub>>children (in category 'simulating') ----- - children - ^ (self model perform: spec getChildren with: item) - collect: [:ea | TreeNodeStub fromSpec: spec item: ea]! Item was removed: - ----- Method: TreeNodeStub>>item (in category 'simulating') ----- - item - ^ item! Item was removed: - ----- Method: TreeNodeStub>>label (in category 'simulating') ----- - label - ^ self model perform: spec label with: item! Item was removed: - ----- Method: TreeNodeStub>>matches: (in category 'private') ----- - matches: aString - ^ self label = aString! Item was removed: - ----- Method: TreeNodeStub>>openPath: (in category 'events') ----- - openPath: anArray - | child | - anArray isEmpty - ifTrue: [self select] - ifFalse: [child := self children - detect: [:ea | ea matches: anArray first] - ifNone: [^ self select]. - child openPath: anArray allButFirst] - ! Item was removed: - ----- Method: TreeNodeStub>>printOn: (in category 'printing') ----- - printOn: aStream - aStream - print: self class; - nextPut: $<; - print: item; - nextPut: $>! Item was removed: - ----- Method: TreeNodeStub>>select (in category 'simulating') ----- - select - self model perform: spec setSelected with: item! Item was removed: - ----- Method: TreeNodeStub>>selectPath: (in category 'private') ----- - selectPath: anArray - | child | - anArray isEmpty ifTrue: [^ self select]. - child := self children detect: [:ea | ea matches: anArray first] ifNone: [^ self select]. - child selectPath: anArray allButFirst.! Item was removed: - ----- Method: TreeNodeStub>>setSpec:item: (in category 'initialize-release') ----- - setSpec: aSpec item: anObject - super setSpec: aSpec. - item := anObject! Item was removed: - WidgetStub subclass: #TreeStub - instanceVariableNames: 'roots' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: TreeStub>>openPath: (in category 'private') ----- - openPath: anArray - | first | - first := roots detect: [:ea | ea matches: anArray first] ifNone: [^ self]. - first openPath: anArray allButFirst! Item was removed: - ----- Method: TreeStub>>roots: (in category 'private') ----- - roots: anArray - roots := anArray collect: [:ea | TreeNodeStub fromSpec: spec item: ea]. - ! Item was removed: - ----- Method: TreeStub>>select: (in category 'simulating') ----- - select: anArray - self openPath: anArray! Item was removed: - ----- Method: TreeStub>>setSpec: (in category 'initialize-release') ----- - setSpec: aSpec - super setSpec: aSpec. - self update: spec roots! Item was removed: - ----- Method: TreeStub>>update: (in category 'events') ----- - update: anObject - anObject == spec roots ifTrue: [^ self updateRoots]. - anObject == spec getSelectedPath ifTrue: [^ self updateSelectedPath]. - (anObject isKindOf: Array) ifTrue: [^ self openPath: anObject allButFirst]. - super update: anObject - ! Item was removed: - ----- Method: TreeStub>>updateRoots (in category 'events') ----- - updateRoots - ^ self roots: (self model perform: spec roots) - ! Item was removed: - ----- Method: TreeStub>>updateSelectedPath (in category 'events') ----- - updateSelectedPath - | path first | - path := self model perform: spec getSelectedPath. - first := roots detect: [:ea | ea item = path first] ifNone: [^ self]. - first selectPath: path allButFirst.! Item was removed: - Object subclass: #WidgetStub - instanceVariableNames: 'spec state' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: WidgetStub class>>fromSpec: (in category 'instance creation') ----- - fromSpec: aSpec - ^ self new setSpec: aSpec! Item was removed: - ----- Method: WidgetStub>>model (in category 'simulating') ----- - model - ^ spec model! Item was removed: - ----- Method: WidgetStub>>name (in category 'accessing') ----- - name - ^ spec name ifNil: [' ']! Item was removed: - ----- Method: WidgetStub>>printOn: (in category 'printing') ----- - printOn: aStream - aStream - print: self class; - nextPut: $<; - nextPutAll: self name; - nextPut: $>! Item was removed: - ----- Method: WidgetStub>>refresh (in category 'events') ----- - refresh - self stateVariables do: [:var | self refresh: var]! Item was removed: - ----- Method: WidgetStub>>refresh: (in category 'events') ----- - refresh: var - | value | - value := spec perform: var. - self refresh: var with: value! Item was removed: - ----- Method: WidgetStub>>refresh:with: (in category 'events') ----- - refresh: var with: value - state - at: var - put: (value isSymbol - ifTrue: [spec model perform: value] - ifFalse: [value])! Item was removed: - ----- Method: WidgetStub>>setSpec: (in category 'initialize-release') ----- - setSpec: aSpec - state := IdentityDictionary new. - spec := aSpec. - spec model addDependent: self. - self refresh.! Item was removed: - ----- Method: WidgetStub>>spec (in category 'accessing') ----- - spec - ^ spec! Item was removed: - ----- Method: WidgetStub>>stateVariables (in category 'events') ----- - stateVariables - ^ #()! Item was removed: - ----- Method: WidgetStub>>update: (in category 'events') ----- - update: aSymbol - - self stateVariables do: - [:var | - (spec perform: var) == aSymbol ifTrue: - [self refresh: var with: aSymbol. - ^ self]]! Item was removed: - ----- Method: WidgetStub>>widgetNamed: (in category 'accessing') ----- - widgetNamed: aString - ^ self name = aString - ifTrue: [self] - ifFalse: [nil]! Item was removed: - CompositeStub subclass: #WindowStub - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'ToolBuilder-SUnit'! Item was removed: - ----- Method: WindowStub>>close (in category 'simulating') ----- - close - spec model perform: spec closeAction! Item was removed: - ----- Method: WindowStub>>stateVariables (in category 'events') ----- - stateVariables - ^ super stateVariables, #(label)!

3 5

The Trunk: System-mt.1018.mcz
by commits＠source.squeak.org 19 Jan '22

19 Jan '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1018.mcz ==================== Summary ==================== Name: System-mt.1018 Author: mt Time: 16 April 2018, 10:31:28.239614 am UUID: e0350560-a5a5-5a40-b31b-d13f55162021 Ancestors: System-mt.1017 #setAuthorInitials: -> #authorInitials: =============== Diff against System-mt.1017 =============== Item was changed: ----- Method: SmalltalkImage>>openSourceFiles (in category 'sources, changes log') ----- openSourceFiles self imageName = LastImageName ifFalse: ["Reset the author initials to blank when the image gets moved" LastImageName := self imageName. + Utilities authorInitials: '']. - Utilities setAuthorInitials: '']. FileDirectory openSources: self sourcesName andChanges: self changesName forImage: LastImageName. SourceFileArray install!

4 4

Please Test | Improvements around display scaling (150%, 200%, 250%, ...)
by Marcel Taeumel 17 Jan '22

17 Jan '22

Hi all -- Yes, the new primitive "primitiveScreenScaleFactor" is not yet functional, but we can do something to at least improve the manual way of scaling fonts (and widgets and tools) so that your favorite high-DPI display can be used in Squeak (i.e. "sharp fonts") without letting the operating system scale (i.e. "blurry fonts"). Here is an older discussion: http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-September/21160… [http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-September/21160…] Please find attached a change set for your to try out. Load it and then click Extras > Scale Factor > 200%. Or do-it in a workspace: "Display scaleFactor: 1.25". Note that 100%, 125%, and 150% will still use our pre-rendered "Bitmap DejaVu Sans" fonts. Other scale factors rely on "BitstreamVeraSans(Mono)". I have still a little bit more testing to do considering the use of FontImporterTool. :-) It's still not perfect. But at least we now have a one-click solution for scale factors bigger than 150%. Best, Marcel

4 19

The Inbox: SUnitTools-jr.5.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

A new version of SUnitTools was added to project The Inbox: http://source.squeak.org/inbox/SUnitTools-jr.5.mcz ==================== Summary ==================== Name: SUnitTools-jr.5 Author: jr Time: 5 March 2020, 9:53:04.92876 pm UUID: 612a0a0e-43fa-de40-8370-f5e90d767232 Ancestors: SUnitTools-tcj.4 Allow to create a new test class immediately if none is found. =============== Diff against SUnitTools-tcj.4 =============== Item was added: + ----- Method: CodeHolder>>testAskToCreateNewTest: (in category '*SUnitTools-running') ----- + testAskToCreateNewTest: className + (self confirm: 'Test class not found. Create one?') ifFalse: [^ false]. + (ClassBuilder new) + name: className asSymbol + inEnvironment: self selectedClass environment + subclassOf: TestCase + type: #normal + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: + ((self selectedClass category includes: $-) + ifTrue: [((self selectedClass category copyUpToLast: $-), '-Tests')] + ifFalse: [(self selectedClass category, 'Tests')]) asSymbol. + ^ true! Item was changed: ----- Method: CodeHolder>>testBrowseClassNamed:possibleMessageNamed: (in category '*SUnitTools-running') ----- testBrowseClassNamed: aClassName possibleMessageNamed: aMessageName | cls selector | + (self class environment hasClassNamed: aClassName) ifFalse: + [(self testAskToCreateNewTest: aClassName) ifFalse: [^ self]]. - (self class environment hasClassNamed: aClassName) ifFalse: ["no dice" ^ self]. cls := self class environment classNamed: aClassName. (aMessageName notNil and: [cls includesLocalSelector: (selector := aMessageName asSymbol)]) ifTrue: [ToolSet browse: cls selector: selector] ifFalse: [ToolSet browseClass: cls].!

5 7

The Inbox: SUnit-ct.130.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.130.mcz ==================== Summary ==================== Name: SUnit-ct.130 Author: ct Time: 24 September 2020, 11:28:31.626426 am UUID: 43df5072-3a69-634c-946a-ec59903c2519 Ancestors: SUnit-pre.122 Deprecates TestResult class >> #error and replaces sends to it with #exError. It is a bad and erroneous practice to override #error in a way that does not signal an error but returns a class object. =============== Diff against SUnit-pre.122 =============== Item was changed: ----- Method: SUnitTest>>testDialectLocalizedException (in category 'tests') ----- testDialectLocalizedException self should: [TestResult signalFailureWith: 'Foo'] raise: TestResult failure. self should: [TestResult signalErrorWith: 'Foo'] + raise: TestResult exError.! - raise: TestResult error. - - ! Item was changed: ----- Method: SUnitTest>>testException (in category 'tests') ----- testException self should: [self error: 'foo'] + raise: TestResult exError! - raise: TestResult error - ! Item was changed: ----- Method: SUnitTest>>testWithExceptionDo (in category 'tests') ----- testWithExceptionDo self should: [self error: 'foo'] + raise: TestResult exError - raise: TestResult error withExceptionDo: [:exception | self assert: (exception description includesSubstring: 'foo') + ]! - ] - ! Item was changed: ----- Method: TestResult class>>error (in category 'exceptions') ----- error + + self deprecated: 'ct: Send #exError to retrieve an exception class or #error: to signal an error, depending on what you need.'. + ^ self exError! - ^self exError - ! Item was changed: ----- Method: TestResult class>>signalErrorWith: (in category 'exceptions') ----- signalErrorWith: aString + ^ self exError signal: aString! - self error signal: aString - !

3 3

Solving multiple termination bugs - summary & proposal
by Jaromir Matas 16 Jan '22

16 Jan '22

Hi All, here's a summary of bugs in the current termination procedure: 1. #isTerminated and #isSuspended fail to report correctly - in [1] 2. active process termination bug causing an image crash - in [2] 3. nested unwind bug: skipping some ensure blocks - in [3] 4. likely a bug: a failure to complete nested unwind blocks halfway thru execution - also in [3] 5. Christoph's discovery: a failure to correctly close the debugger in case of error or non-local return in unwind - in [4] 6. inconsistent semantics of unwinding protected blocks during active vs. suspended process termination (not reported yet - different sets of unwind blocks are executed depending on whether a process terminates itself or whether some other process initiates its termination; the proposed solution unifies active and suspended process termination and is consistent with Visual Works semantics (and goes beyond)) [1] http://forum.world.st/The-Inbox-Kernel-jar-1376-mcz-td5127335.html#a5127336 [2] http://forum.world.st/A-bug-in-active-process-termination-crashing-image-td… [3] http://forum.world.st/Another-bug-in-Process-terminate-in-unwinding-context… [4] http://forum.world.st/Bug-in-Process-gt-gt-terminate-Returning-from-unwind-… I'd like to propose a solution - a rewrite of #terminate - addressing all of the above issues. Main points of the solution are: (i) why differentiate active and suspended process termination? I propose to unify the two: to suspend the active process and terminate it as a suspended process. As a result the semantics/outcome of the unwind algorithm will be the same in both cases. Fixes 2 and 6. (ii) the above leads to a susbstantial simplification of #isTerminated - a process is terminated when at the last instruction of its bottom context. Fixes 1. (iii) unwind algorithm for incomplete unwind blocks is extended to execute the outer-most instead of the inner-most incomplete unwind context. Fixes 3 and 4. (iv) indirect termination via #popTo is replaced with a analogue of #unwindTo: using Eliot's ingenious #runUntilErrorOrReturnFrom: the same way as in (iii). I'd very much appreciate if someone commented this part because I haven't found any clue why the indirect termination has implemented using #popTo and not #runUntilErrorOrReturnFrom. Fixes 5. I enclose a set of examples used to compare the current Squeak semantics with the proposed one (and with VW) that can be used to build test cases. Here's a commented code. I'll be happy to provide detailed step-by-step guidance if you find this whole idea interesting and worth implementing. I'm convinced at least parts of the proposal should be integrated as simple fixes of the current bugs. Thank you for your patience if you're still reading :) Any feedback extremely welcome. A changeset is enclosed for your convenience here: Fix_terminate_v2.cs <http://forum.world.st/file/t372955/Fix_terminate_v2.cs> Process >> terminate "Stop the process that the receiver represents so that it answers true to #isTerminated. Unwind to execute pending and unfinished ensure:/ifCurtailed: blocks before terminating. If the process is in the middle of a critical: critical section, release it properly." | ctxt unwindBlock oldList outerMost | self isActiveProcess ifTrue: [ "If terminating the active process, suspend it first and terminate it as a suspended process. Nested #terminate messages could derail the termination so let's enclose it in #ensure." [[] ensure: [self terminate]] fork. ^self suspend]. "Always suspend the process first so it doesn't accidentally get woken up. N.B. If oldList is a LinkedList then the process is runnable. If it is a Semaphore/Mutex et al then the process is blocked, and if it is nil then the process is already suspended." oldList := self suspend. suspendedContext ifNotNil: ["Release any method marked with the <criticalSection> pragma. The argument is whether the process is runnable." self releaseCriticalSection: (oldList isNil or: [oldList class == LinkedList]). "If terminating a process halfways through an unwind, try to complete that unwind block first; if there are multiple such nested unwind blocks, try to complete the outer-most one; the inner blocks will be completed in the process." ctxt := suspendedContext. [(ctxt := ctxt findNextUnwindContextUpTo: nil) isNil] whileFalse: "Contexts under evaluation have already set their complete (tempAt: 2) to true." [(ctxt tempAt:2) ifNotNil: [outerMost := ctxt]]. outerMost ifNotNil: [ "This is the outer-most unwind context currently under evaluation; let's find an inner context executing outerMost's argument block (tempAt: 1)" (suspendedContext findContextSuchThat: [:ctx | ctx closure == (outerMost tempAt: 1)]) ifNotNil: [:inner | "Let's finish the unfinished unwind context only (i.e. up to inner) and return here" suspendedContext runUntilErrorOrReturnFrom: inner. "Update the receiver's suspendedContext (the previous step reset its sender to nil)" suspendedContext := outerMost]]. "Now all unwind blocks caught halfway through have been completed; let's execute the ones still pending. Note: #findNextUnwindContextUpTo: starts searching from the receiver's sender but the receiver itself may be an unwind context." ctxt := suspendedContext. ctxt isUnwindContext ifFalse: [ctxt := ctxt findNextUnwindContextUpTo: nil]. [ctxt isNil] whileFalse: [ (ctxt tempAt: 2) ifNil: [ ctxt tempAt: 2 put: true. unwindBlock := ctxt tempAt: 1. "Create a context for the unwind block and execute it on the unwind block's stack. Note: using #value instead of #runUntilErrorOrReturnFrom: would lead to executing the unwind on the wrong stack preventing the correct execution of non-local returns." suspendedContext := unwindBlock asContextWithSender: ctxt. suspendedContext runUntilErrorOrReturnFrom: suspendedContext]. ctxt := ctxt findNextUnwindContextUpTo: nil]. "Set the context to its endPC and its sender to nil for the benefit of isTerminated." ctxt := suspendedContext. ctxt terminateTo: nil. ctxt pc: ctxt endPC] Process >> isTerminated "Answer if the receiver is terminated. A process is considered terminated if the suspendedContext is the bottomContext and the pc is at the endPC" self isActiveProcess ifTrue: [^ false]. ^suspendedContext isNil or: [ suspendedContext isBottomContext and: [ suspendedContext isDead or: [suspendedContext atEnd]]] Process >> isSuspended "A process is suspended if it has non-nil suspendedContext (e.g. new or previously suspended with the suspend primitive) and is not terminated or waiting in a scheduler or a semaphore queue (i.e. is not runnable or blocked)." ^myList isNil and: [suspendedContext notNil and: [self isTerminated not]] Debugger >> windowIsClosing "My window is being closed; clean up. Restart the low space watcher. If the debugged process is a do-it, it may do a non-local return escaping termination so we need to insert a #terminate context under the do-it to make sure the debugged UI process will terminate." | doItContext terminateContext | (interruptedProcess == nil or: [interruptedProcess suspendedContext isNil]) ifTrue: [^ self]. "find a do-it context; answer nil if it doesn't exist in the sender chain" doItContext := interruptedProcess suspendedContext findContextSuchThat: [:ctx | ctx methodClass = UndefinedObject and: [ ctx selector = #DoIt and: [ ctx closure isNil]]]. doItContext ifNotNil: [ "it exists so let's insert a #terminate context" terminateContext := Context sender: doItContext sender receiver: interruptedProcess method: (Process>>#terminate) arguments: {}. doItContext privSender: terminateContext ]. interruptedProcess terminate. interruptedProcess := nil. contextStack := nil. receiverInspector := nil. contextVariablesInspector := nil. Smalltalk installLowSpaceWatcher. "restart low space handler" A few examples to illustrate the idea (many more enclosed here Some_examples_to_examine_terminate_bugs.txt <http://forum.world.st/file/t372955/Some_examples_to_examine_terminate_bugs.…> ): Ex. 1: | p | "Suspend process inside ensure block and make sure x1 x2 and x3 are printed. Currently only x1 is printed." p := [ [ [ ] ensure: [ [ ] ensure: [ Processor activeProcess suspend. Transcript show: 'x1']. Transcript show: 'x2'] ] ensure: [ Transcript show: 'x3'] ] fork. Processor yield. p terminate ---> x1 (instead of x1 x2 x3) Ex. 2: | p | Currently only x3 is printed." p := [ [ [ ] ensure: [ [ ] ensure: [ Processor activeProcess terminate. Transcript show: 'x1']. "terminate active process inside ensure block and make sure x1 x2 and x3 are printed. Transcript show: 'x2'] ] ensure: [ Transcript show: 'x3'] ] fork. Processor yield ---> x3 (instead of x1 x2 x3) Ex. 3: "unwind after error inside ensure block and make sure x1 x2 and x3 are printed. [ [ ] ensure: [ [ ] ensure: [ self error. Transcript show: 'x1']. Transcript show: 'x2'] ] ensure: [ ^Transcript show: 'x3'] ---> x3 (instead of x1 x2 x3) Note: nested errors during unwind follow #runUntilErrorOrReturnFrom: logic, i.e. return exception and let user decide... ----- ^[^ Jaromir -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

6 30

The Inbox: SUnit-ct.124.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.124.mcz ==================== Summary ==================== Name: SUnit-ct.124 Author: ct Time: 20 March 2020, 8:01:47.398237 pm UUID: d936b6a0-e7c7-2742-a817-35fa6511a15a Ancestors: SUnit-mt.121 Proposal for discussion: Adds assertion message #should:raise:then: to allow for interactively working with expected exceptions. If you like, we could also talk about #should:raise:that: (however, I still like BlockClosure >> #handles:*). Examples: TestCase new in: [:test | test should: [ test should: [self error: #foo] raise: Error then: #pass] raise: UnhandledError. test should: [self error: #foo] raise: Error then: [:ex | test assert: #foo equals: ex messageText]. ] * See exception patterns: http://forum.world.st/The-Inbox-Kernel-ct-1292-mcz-tp5109282p5109284.html =============== Diff against SUnit-mt.121 =============== Item was added: + ----- Method: TestCase>>should:raise:then: (in category 'accessing') ----- + should: aBlock raise: anExceptionalEvent then: aHandlerBlock + + | raised result | + raised := false. + result := aBlock + on: anExceptionalEvent + do: [:ex | + raised := true. + aHandlerBlock cull: ex]. + self assert: raised. + ^ result!

2 1

The Inbox: SUnit-ct.129.mcz
by commits＠source.squeak.org 11 Jan '22

11 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.129.mcz ==================== Summary ==================== Name: SUnit-ct.129 Author: ct Time: 24 September 2020, 10:42:52.868426 am UUID: 92e68d23-8472-5d48-96d3-8435bd56ac14 Ancestors: SUnit-pre.122 Proposal: Catch warnings and halts in test case execution as well as Errors. Catching (Error, Warning, Halt) is a common pattern to be (relatively) sure that no debugger will occur during an operation. For related usages, see Morph >> #fullBounds, WorldState >> #displayWorldSafely:, and many other places. IMO it is no desired behavior that the whole test execution, i.e. in a TestRunner, is interrupted because any method under test contains a halt or raises a DeprecationWarning, for example. Instead, the test should be listed as red. For a similar discussion, see https://github.com/hpi-swa/smalltalkCI/issues/470. I believe we already had talked about this on squeak-dev, but if I remember correctly, I cannot find the thread again. =============== Diff against SUnit-pre.122 =============== Item was changed: ----- Method: TestCase>>timeout:after: (in category 'private') ----- timeout: aBlock after: seconds "Evaluate the argument block. Time out if the evaluation is not complete after the given number of seconds. Handle the situation that a timeout may occur after a failure (during debug)" | theProcess delay watchdog | "the block will be executed in the current process" theProcess := Processor activeProcess. delay := Delay forSeconds: seconds. "make a watchdog process" watchdog := [ delay wait. "wait for timeout or completion" theProcess ifNotNil:[ theProcess signalException: (TestFailure new messageText: 'Test timed out') ] ] newProcess. "Watchdog needs to run at high priority to do its job (but not at timing priority)" watchdog priority: Processor timingPriority-1. "catch the timeout signal" watchdog resume. "start up the watchdog" + ^[aBlock on: TestFailure, (Error, Warning, Halt) do: [:ex| - ^[aBlock on: TestFailure, Error, Halt do:[:ex| theProcess := nil. ex pass. ]] ensure:[ "evaluate the receiver" theProcess := nil. "it has completed, so ..." delay delaySemaphore signal. "arrange for the watchdog to exit" ]! Item was added: + ----- Method: TestResult class>>exAllErrors (in category 'exceptions') ----- + exAllErrors + ^ self exError, Warning, Halt + ! Item was changed: ----- Method: TestResult>>runCase: (in category 'running') ----- runCase: aTestCase | testCasePassed timeToRun | testCasePassed := true. [timeToRun := [aTestCase runCase] timeToRunWithoutGC] on: self class failure do: [:signal | failures add: aTestCase. testCasePassed := false. signal return: false] + on: self class exAllErrors - on: self class error do: [:signal | errors add: aTestCase. testCasePassed := false. signal return: false]. testCasePassed ifTrue: [passed add: aTestCase]. self durations at: aTestCase put: timeToRun.!

5 4

The Trunk: Kernel-mt.1437.mcz
by commits＠source.squeak.org 11 Jan '22

11 Jan '22

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1437.mcz ==================== Summary ==================== Name: Kernel-mt.1437 Author: mt Time: 26 December 2021, 8:21:42.050619 am UUID: 28086a0b-8543-4f44-9c9f-7e63d3028f7f Ancestors: Kernel-ct.1436 Makes #acceptsLoggingOfCompilation a preference that can be disabled. See commentary #logCompiledSources. Classes can still override this preference but should follow a "super acceptsLoggingOfCompilation and: [...]" pattern. Thanks to Tim (tpr) for figuring out the mechanics and testing it throughout the year! =============== Diff against Kernel-ct.1436 =============== Item was changed: Behavior subclass: #ClassDescription instanceVariableNames: 'instanceVariables organization' + classVariableNames: 'AcceptsLoggingOfCompilation TraitImpl' - classVariableNames: 'TraitImpl' poolDictionaries: '' category: 'Kernel-Classes'! !ClassDescription commentStamp: '<historical>' prior: 0! I add a number of facilities to basic Behaviors: Named instance variables Category organization for methods The notion of a name of this class (implemented as subclass responsibility) The maintenance of a ChangeSet, and logging changes on a file Most of the mechanism for fileOut. I am an abstract class, in particular, my facilities are intended for inheritance by two subclasses, Class and Metaclass. The slots 'organization' and 'methodDict' should ONLY be accessed by message in order for things to work during ImageSegment>>discoverActiveClasses (q.v.).! Item was added: + ----- Method: ClassDescription class>>logCompiledSources (in category 'compiling') ----- + logCompiledSources + <preference: 'Log compilations to changes file' + category: 'general' + description: 'If enabled, the code being compiled will get logged to the changes file. Disabling allows loading code with no changes file in use. See also #warnIfNoChangesFile and #warnIfNoSourcesFile and #readDocumentAtStartup. You can configure a silent image/DoItFirst for, e.g., server environments.' + type: #Boolean> + + ^ AcceptsLoggingOfCompilation ifNil: [true]! Item was added: + ----- Method: ClassDescription class>>logCompiledSources: (in category 'compiling') ----- + logCompiledSources: aBoolean + ^ AcceptsLoggingOfCompilation := aBoolean! Item was changed: ----- Method: ClassDescription>>acceptsLoggingOfCompilation (in category 'compiling') ----- acceptsLoggingOfCompilation "weird name is so that it will come lexically before #compile, so that a clean build can make it through. 7/7/96 sw" + ^AcceptsLoggingOfCompilation ifNil: [true]! - ^ true!

5 6

The Trunk: Morphic-mt.1812.mcz
by commits＠source.squeak.org 11 Jan '22

11 Jan '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1812.mcz ==================== Summary ==================== Name: Morphic-mt.1812 Author: mt Time: 4 December 2021, 12:26:07.860493 pm UUID: 89876df1-baaa-314b-9274-bc585d62f388 Ancestors: Morphic-mt.1811 Removes US-layout specific keyboard shortcuts for 'Enclose selection' in favor of the cross-platform compatible preference 'Enclose selection with brackets'. Just type the bracket character like you would in normal text editing. No extra shortcut to remember. Note that the "replace expression" operation needs an extra Del/Backspace hit if "Enclose selection with brackets" is enabled (by default). Note that dead keys might be an issue when the second key press yields two characters, which effectively toggles the brackets around the selection twice. I did observe that with the single-quote/double-quote key in an US-layout on Windows 10. =============== Diff against Morphic-mt.1811 =============== Item was changed: ----- Method: TextEditor class>>encloseSelection (in category 'preferences') ----- encloseSelection <preference: 'Enclose selection with brackets () {} [] '''' "" || <>' categoryList: #('Morphic' 'editing') description: 'When true, selecting text and typing an opening parenthesis, bracket, square-bracket, single quote, or double quote will add corresponding character around the selection without requiring a cmd key.' type: #Boolean> + ^ EncloseSelection ifNil: [ true ]! - ^ EncloseSelection ifNil: [ false ]! Item was changed: ----- Method: TextEditor class>>initializeCmdKeyShortcuts (in category 'keyboard shortcut tables') ----- initializeCmdKeyShortcuts "Initialize the (unshifted) command-key (or alt-key) shortcut table." "NOTE: if you don't know what your keyboard generates, use Sensor kbdTest" "TextEditor initialize" | cmdMap cmds | cmdMap := Array new: 256 withAll: #noop:. "use temp in case of a crash" cmdMap at: 1 + 1 put: #cursorHome:. "home key" cmdMap at: 4 + 1 put: #cursorEnd:. "end key" cmdMap at: 8 + 1 put: #backspace:. "ctrl-H or delete key" cmdMap at: 11 + 1 put: #cursorPageUp:. "page up key" cmdMap at: 12 + 1 put: #cursorPageDown:. "page down key" cmdMap at: 13 + 1 put: #crWithIndent:. "cmd-Return" cmdMap at: 27 + 1 put: #offerMenuFromEsc:. "escape key" cmdMap at: 28 + 1 put: #cursorLeft:. "left arrow key" cmdMap at: 29 + 1 put: #cursorRight:. "right arrow key" cmdMap at: 30 + 1 put: #cursorUp:. "up arrow key" cmdMap at: 31 + 1 put: #cursorDown:. "down arrow key" cmdMap at: 32 + 1 put: #selectWord:. "space bar key" cmdMap at: 127 + 1 put: #forwardDelete:. "del key" '0123456789-=' do: [:char | cmdMap at: char asciiValue + 1 put: #changeEmphasis:]. - - '([<{|"''' do: [:char | cmdMap at: char asciiValue + 1 put: #enclose:]. cmds := #($a #selectAll: $c #copySelection: $e #exchange: $f #find: $g #findAgain: $j #doAgain: $k #offerFontMenu: $u #align: $v #paste: $w #backWord: $x #cut: $y #swapChars: $z #undo:). 1 to: cmds size by: 2 do: [:i | cmdMap at: (cmds at: i) asciiValue + 1 put: (cmds at: i + 1)]. cmdActions := cmdMap! Item was changed: ----- Method: TextEditor class>>initializeShiftCmdKeyShortcuts (in category 'keyboard shortcut tables') ----- initializeShiftCmdKeyShortcuts "Initialize the shift-command-key (or control-key) shortcut table." "NOTE: if you don't know what your keyboard generates, use Sensor kbdTest" "wod 11/3/1998: Fix setting of cmdMap for shifted keys to actually use the capitalized versions of the letters. TPR 2/18/99: add the plain ascii values back in for those VMs that don't return the shifted values." "TextEditor initialize" | cmdMap cmds | "shift-command and control shortcuts" cmdMap := Array new: 256 withAll: #noop:. "use temp in case of a crash" cmdMap at: ( 1 + 1) put: #cursorHome:. "home key" cmdMap at: ( 4 + 1) put: #cursorEnd:. "end key" cmdMap at: ( 8 + 1) put: #forwardDelete:. "ctrl-H or delete key" cmdMap at: (11 + 1) put: #cursorPageUp:. "page up key" cmdMap at: (12 + 1) put: #cursorPageDown:. "page down key" cmdMap at: (13 + 1) put: #crWithIndent:. "ctrl-Return" cmdMap at: (27 + 1) put: #offerMenuFromEsc:. "escape key" cmdMap at: (28 + 1) put: #cursorLeft:. "left arrow key" cmdMap at: (29 + 1) put: #cursorRight:. "right arrow key" cmdMap at: (30 + 1) put: #cursorUp:. "up arrow key" cmdMap at: (31 + 1) put: #cursorDown:. "down arrow key" cmdMap at: (32 + 1) put: #selectWord:. "space bar key" cmdMap at: (45 + 1) put: #changeEmphasis:. "cmd-sh-minus" cmdMap at: (61 + 1) put: #changeEmphasis:. "cmd-sh-plus" cmdMap at: (127 + 1) put: #forwardDelete:. "del key" - "On some keyboards, these characters require a shift" - '([<{|"''9' do: [:char | cmdMap at: char asciiValue + 1 put: #enclose:]. - - "NB: sw 12/9/2001 commented out the idiosyncratic line just below, which was grabbing shift-esc in the text editor and hence which argued with the wish to have shift-esc be a universal gesture for escaping the local context and calling up the desktop menu." - "cmdMap at: (27 + 1) put: #shiftEnclose:." "ctrl-[" - - "'""''(' do: [ :char | cmdMap at: (char asciiValue + 1) put: #enclose:]." - cmds := #( $c compareToClipboard: $h cursorTopHome: $j doAgainUpToEnd: $k changeStyle: $m selectCurrentTypeIn: $s findAgain: $u changeLfToCr: $x makeLowercase: $y makeUppercase: $z redo: "makeCapitalized:" ). 1 to: cmds size by: 2 do: [ :i | cmdMap at: ((cmds at: i) asciiValue + 1) put: (cmds at: i + 1). "plain keys" cmdMap at: ((cmds at: i) asciiValue - 32 + 1) put: (cmds at: i + 1). "shifted keys" cmdMap at: ((cmds at: i) asciiValue - 96 + 1) put: (cmds at: i + 1). "ctrl keys" ]. shiftCmdActions := cmdMap! Item was changed: ----- Method: TextEditor>>enclose: (in category 'editing keys') ----- enclose: aKeyboardEvent "Insert or remove bracket characters around the current selection." | character left right startIndex stopIndex oldSelection which t | + character := aKeyboardEvent keyCharacter. - character := aKeyboardEvent shiftPressed - ifTrue: ['{}|"<>' at: ('[]\'',.' indexOf: aKeyboardEvent keyCharacter) ifAbsent: [aKeyboardEvent keyCharacter]] - ifFalse: [aKeyboardEvent keyCharacter]. self closeTypeIn. startIndex := self startIndex. stopIndex := self stopIndex. oldSelection := self selection. + which := '([<{|"''' indexOf: character ifAbsent: [ ^ false ]. + left := '([<{|"''' at: which. + right := ')]>}|"''' at: which. - which := '([<{|"''9' indexOf: character ifAbsent: [ ^ false ]. - "Allow Control key in lieu of Alt+Shift for (, {, and double-quote." - left := ((Preferences cmdKeysInText and: [ aKeyboardEvent controlKeyPressed ]) - ifTrue: [ '({<{|""(' ] - ifFalse: ['([<{|"''(']) at: which. - right := ((Preferences cmdKeysInText and: [ aKeyboardEvent controlKeyPressed ]) - ifTrue: [ ')}>}|"")' ] - ifFalse: [')]>}|"'')']) at: which. t := self text. ((startIndex > 1 and: [stopIndex <= t size]) and: [ (t at: startIndex-1) = left and: [(t at: stopIndex) = right]]) ifTrue: ["already enclosed; strip off brackets" self selectFrom: startIndex-1 to: stopIndex. self replaceSelectionWith: oldSelection] ifFalse: ["not enclosed; enclose by matching brackets" self replaceSelectionWith: (Text string: (String with: left), oldSelection string, (String with: right) attributes: emphasisHere). self selectFrom: startIndex+1 to: stopIndex]. ^true! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'Editor initialize. "Removes US-layout specific keyboard shortcuts for ''Enclose selection'' in favor of the cross-platform compatible preference ''Enclose selection with brackets''."'! - (PackageInfo named: 'Morphic') postscript: 'SystemProgressMorph reset. "New layer number" - - "Morphic-ct.1796 - Inverts the preference ''halo encloses full bounds'' by pressing the control key while invocating a halo." - (Preferences preferenceAt: #haloEnclosesFullBounds) instVarNamed: ''helpString'' put: ''If enabled, halos will enclose the full bounds of the target morph, rather than just the bounds. You can also invert this behavior temporarily by holding down Ctrl while invoking a halo on a morph.''.'!

5 7

← Newer
1
...
4
5
6
7
8
9
10
...
39
Older →

Jump to page: