Squeak-dev February 2021

squeak-dev@lists.squeakfoundation.org

33 participants
196 discussions

The Trunk: Compiler-ct.449.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.449.mcz ==================== Summary ==================== Name: Compiler-ct.449 Author: ct Time: 24 October 2020, 12:12:47.879256 am UUID: f4dcd413-ed53-bf47-8762-a0e1c23f7a7f Ancestors: Compiler-tobe.448 Redesigns SyntaxErrorNotification to hold a CompilationCue instead of 'inClass' and 'code', in orderto allow for recompilation of syntax errors where other compilation parameters have been specified, e.g. context or environment. For example, the following syntax error could not be resolved before this patch: Compiler new evaluate: 'aCue yourself:' in: thisContext sender to: thisContext sender receiver. =============== Diff against Compiler-tobe.448 =============== Item was added: + ----- Method: CompilationCue>>source: (in category 'accessing') ----- + source: aString + + source := aString. + sourceStream := source readStream.! Item was changed: ----- Method: Parser>>notify:at: (in category 'error handling') ----- notify: string at: location | messageText | messageText := '"' , string , ' ->"'. cue requestor isNil ifTrue: [ | notification | (encoder == self or: [encoder isNil]) ifTrue: [^ self fail "failure setting up syntax error"]. (notification := SyntaxErrorNotification + cue: (cue copy + source: (source contents asText + copyReplaceFrom: location + to: location - 1 + with: messageText); + yourself) - inClass: encoder classEncoding - withCode: (source contents asText - copyReplaceFrom: location - to: location - 1 - with: messageText) doitFlag: doitFlag errorMessage: string location: location) signal. notification tryNewSourceIfAvailable] ifFalse: [cue requestor notify: messageText at: location in: source]. ^ self fail! Item was changed: Error subclass: #SyntaxErrorNotification + instanceVariableNames: 'cue doitFlag errorMessage location newSource' - instanceVariableNames: 'inClass code doitFlag errorMessage location newSource' classVariableNames: '' poolDictionaries: '' category: 'Compiler-Exceptions'! + !SyntaxErrorNotification commentStamp: 'ct 10/24/2020 00:01' prior: 0! - !SyntaxErrorNotification commentStamp: 'nice 9/18/2013 22:16' prior: 0! A SyntaxErrorNotification is an Exception occuring when compiling a Smalltalk source code with incorrect syntax. Note that in interactive mode, this exception is not raised because the Compiler will interact directly with source code editor. The defaultAction is to raise a SyntaxError pop up window so as to enable interactive handling even in non interactive mode. Instance Variables + cue: <CompilationCue> - category: <String | nil> - code: <String | Text | Stream> doitFlag: <Boolean> errorMessage: <String> - inClass: <Behavior> location: <Integer> newSource: <String | Text | Stream | nil> + cue + - the cue for compilation, including receiver class, optional context, and original source code - category - - the category in which the method will be classified - code - - the source code to be compiled or evaluated - doitFlag - true if this is a doIt (code to evaluate), false if this is a method (code of a method to be compiled) errorMessage - contains information about the syntax error - inClass - - target class in which to compile the method - location - position in the source code where the syntax error occured newSource + - eventually hold a source code replacement typically passed by the SyntaxError window! - - eventually hold a source code replacement typically passed by the SyntaxError window - ! Item was added: + ----- Method: SyntaxErrorNotification class>>cue:doitFlag:errorMessage:location: (in category 'instance creation') ----- + cue: aCue doitFlag: doitFlag errorMessage: errorString location: location + + ^ self new + setCue: aCue + doitFlag: doitFlag + errorMessage: errorString + location: location! Item was changed: + ----- Method: SyntaxErrorNotification class>>inClass:withCode:doitFlag:errorMessage:location: (in category 'instance creation') ----- - ----- Method: SyntaxErrorNotification class>>inClass:withCode:doitFlag:errorMessage:location: (in category 'exceptionInstantiator') ----- inClass: aClass withCode: codeString doitFlag: doitFlag errorMessage: errorString location: location + + self deprecated: 'ct: Use #cue:doitFlag:errorMessage:location:'. + ^ self + cue: (CompilationCue source: codeString class: aClass requestor: nil) - ^self new - setClass: aClass - code: codeString doitFlag: doitFlag errorMessage: errorString location: location! Item was added: + ----- Method: SyntaxErrorNotification>>context (in category 'accessing') ----- + context + + ^ cue context! Item was changed: ----- Method: SyntaxErrorNotification>>errorClass (in category 'accessing') ----- errorClass + + ^ cue getClass! - ^inClass! Item was changed: ----- Method: SyntaxErrorNotification>>errorCode (in category 'accessing') ----- errorCode + + ^ cue source! - ^code! Item was changed: ----- Method: SyntaxErrorNotification>>messageText (in category 'accessing') ----- messageText ^ super messageText + ifEmpty: [messageText := self errorCode]! - ifEmpty: [messageText := code]! Item was changed: ----- Method: SyntaxErrorNotification>>reparse:notifying:ifFail: (in category 'accessing') ----- reparse: aString notifying: aController ifFail: failBlock "Try to parse if aString has correct syntax, but do not evaluate/install any code. In case of incorrect syntax, execute failBlock and let a Compiler interact with the requestor. In case of correct syntax, set newSource." + + (doitFlag ifTrue: [nil class] ifFalse: [self errorClass]) newCompiler + compileCue: (cue copy + source: aString; + requestor: aController; + yourself) + noPattern: doitFlag + ifFail: failBlock. + newSource := aString.! - doitFlag - ifTrue: [nil class newCompiler compileNoPattern: aString in: nil class notifying: aController ifFail: failBlock] - ifFalse: [inClass newCompiler compile: aString in: inClass notifying: aController ifFail: failBlock]. - newSource := aString! Item was removed: - ----- Method: SyntaxErrorNotification>>setClass:code:doitFlag:errorMessage:location: (in category 'accessing') ----- - setClass: aClass code: codeString doitFlag: aBoolean errorMessage: errorString location: anInteger - inClass := aClass. - code := codeString. - doitFlag := aBoolean. - errorMessage := errorString. - location := anInteger! Item was added: + ----- Method: SyntaxErrorNotification>>setCue:doitFlag:errorMessage:location: (in category 'initialize-release') ----- + setCue: aCue doitFlag: aBoolean errorMessage: errorString location: anInteger + + cue := aCue. + doitFlag := aBoolean. + errorMessage := errorString. + location := anInteger!

2 1

The Trunk: Compiler-ct.424.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.424.mcz ==================== Summary ==================== Name: Compiler-ct.424 Author: ct Time: 26 March 2020, 5:19:54.71456 pm UUID: 10f4405b-896c-3149-b76b-b9cd45ca5734 Ancestors: Compiler-nice.420 Fixes a bug regarding decompilation of FullBlockClosures Sample to reproduce: [^ true] decompile should NOT return {[]}! =============== Diff against Compiler-nice.420 =============== Item was changed: ----- Method: Decompiler>>blockTo: (in category 'control') ----- blockTo: end + "Decompile a range of code as in statementsTo:, but return a block node. NB: end is an exclusive index." - "Decompile a range of code as in statementsTo:, but return a block node." | exprs block oldBase lastStatementOfBlockIsNil | oldBase := blockStackBase. blockStackBase := stack size. exprs := self statementsTo: end. lastStatementOfBlockIsNil := pc < method endPC and: [exprs notEmpty and: [exprs last == (constTable at: 4)]]. lastStatementOfBlockIsNil ifTrue: [exprs := exprs allButLast]. block := constructor codeBlock: exprs returns: lastReturnPc = lastPc. blockStackBase := oldBase. lastReturnPc := -1. "So as not to mislead outer calls" ^block! Item was changed: ----- Method: Decompiler>>doClosureCopy:copiedValues: (in category 'control') ----- doClosureCopy: aCompiledBlock copiedValues: blockCopiedValues "implementation note: must be invoked on a copy because it modifies states" | savedPC blockArgs blockTemps blockTempsOffset block mark | numLocalTemps := aCompiledBlock numTemps - aCompiledBlock numArgs - blockCopiedValues size. blockTempsOffset := aCompiledBlock numArgs + blockCopiedValues size. (blockStartsToTempVars notNil "implies we were intialized with temp names." and: [blockStartsToTempVars includesKey: aCompiledBlock]) ifTrue: [tempVars := blockStartsToTempVars at: aCompiledBlock] ifFalse: [blockArgs := (1 to: aCompiledBlock numArgs) collect: [:i| (constructor codeTemp: i - 1 named: 't', (tempVarCount + i) printString) beBlockArg]. blockTemps := (1 to: numLocalTemps) collect: [:i| constructor codeTemp: i + blockTempsOffset - 1 named: 't', (tempVarCount + i + aCompiledBlock numArgs) printString]. tempVars := blockArgs, blockCopiedValues, blockTemps]. tempVarCount := tempVarCount + aCompiledBlock numArgs + numLocalTemps. lastJumpIfPcStack := OrderedCollection new. caseExits := OrderedCollection new. statements := OrderedCollection new: 20. savedPC := pc. self method: (method := aCompiledBlock) pc: aCompiledBlock initialPC. mark := stack size. + block := self blockTo: aCompiledBlock endPC + 1. - block := self blockTo: aCompiledBlock endPC. mark = stack size ifFalse: [self error: 'block did alter the stack']. ^((constructor codeArguments: (tempVars copyFrom: 1 to: aCompiledBlock numArgs) temps: (tempVars copyFrom: blockTempsOffset + 1 to: blockTempsOffset + numLocalTemps) block: block) pc: aCompiledBlock -> savedPC; "c.f. BytecodeEncoder>>pc" yourself).!

1 0

The Trunk: Compiler-ct.426.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.426.mcz ==================== Summary ==================== Name: Compiler-ct.426 Author: ct Time: 28 March 2020, 1:22:49.51256 am UUID: 761924e9-77a0-1144-9533-8a7c22c03332 Ancestors: Compiler-ct.424 Fixes a bug regarding decompilation of special selectors. The following did not work before: (OrderedCollection >> #asArray) decompile generate valueWithReceiver: {42} asOrderedCollection arguments: #(). "MessageNotUnderstood: OrderedCollection>>#Array=>Array" See also this thread: http://forum.world.st/The-Inbox-EToys-ct-367-mcz-tp5105507p5114020.html =============== Diff against Compiler-ct.424 =============== Item was changed: ----- Method: DecompilerConstructor>>codeAnySelector: (in category 'constructor') ----- codeAnySelector: selector ^SelectorNode new key: selector + index: nil - index: 0 type: SendType!

1 0

The Trunk: Compiler-ct.450.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.450.mcz ==================== Summary ==================== Name: Compiler-ct.450 Author: ct Time: 24 October 2020, 12:16:36.359256 am UUID: ea5bdd56-7ceb-ae4f-a2d7-1b9d11cda893 Ancestors: Compiler-ct.449 Implements #environment on SyntaxErrorNotification. Sorry I hit the Accept button to soon... =============== Diff against Compiler-tobe.448 =============== Item was added: + ----- Method: CompilationCue>>source: (in category 'accessing') ----- + source: aString + + source := aString. + sourceStream := source readStream.! Item was changed: ----- Method: Parser>>notify:at: (in category 'error handling') ----- notify: string at: location | messageText | messageText := '"' , string , ' ->"'. cue requestor isNil ifTrue: [ | notification | (encoder == self or: [encoder isNil]) ifTrue: [^ self fail "failure setting up syntax error"]. (notification := SyntaxErrorNotification + cue: (cue copy + source: (source contents asText + copyReplaceFrom: location + to: location - 1 + with: messageText); + yourself) - inClass: encoder classEncoding - withCode: (source contents asText - copyReplaceFrom: location - to: location - 1 - with: messageText) doitFlag: doitFlag errorMessage: string location: location) signal. notification tryNewSourceIfAvailable] ifFalse: [cue requestor notify: messageText at: location in: source]. ^ self fail! Item was changed: Error subclass: #SyntaxErrorNotification + instanceVariableNames: 'cue doitFlag errorMessage location newSource' - instanceVariableNames: 'inClass code doitFlag errorMessage location newSource' classVariableNames: '' poolDictionaries: '' category: 'Compiler-Exceptions'! + !SyntaxErrorNotification commentStamp: 'ct 10/24/2020 00:01' prior: 0! - !SyntaxErrorNotification commentStamp: 'nice 9/18/2013 22:16' prior: 0! A SyntaxErrorNotification is an Exception occuring when compiling a Smalltalk source code with incorrect syntax. Note that in interactive mode, this exception is not raised because the Compiler will interact directly with source code editor. The defaultAction is to raise a SyntaxError pop up window so as to enable interactive handling even in non interactive mode. Instance Variables + cue: <CompilationCue> - category: <String | nil> - code: <String | Text | Stream> doitFlag: <Boolean> errorMessage: <String> - inClass: <Behavior> location: <Integer> newSource: <String | Text | Stream | nil> + cue + - the cue for compilation, including receiver class, optional context, and original source code - category - - the category in which the method will be classified - code - - the source code to be compiled or evaluated - doitFlag - true if this is a doIt (code to evaluate), false if this is a method (code of a method to be compiled) errorMessage - contains information about the syntax error - inClass - - target class in which to compile the method - location - position in the source code where the syntax error occured newSource + - eventually hold a source code replacement typically passed by the SyntaxError window! - - eventually hold a source code replacement typically passed by the SyntaxError window - ! Item was added: + ----- Method: SyntaxErrorNotification class>>cue:doitFlag:errorMessage:location: (in category 'instance creation') ----- + cue: aCue doitFlag: doitFlag errorMessage: errorString location: location + + ^ self new + setCue: aCue + doitFlag: doitFlag + errorMessage: errorString + location: location! Item was changed: + ----- Method: SyntaxErrorNotification class>>inClass:withCode:doitFlag:errorMessage:location: (in category 'instance creation') ----- - ----- Method: SyntaxErrorNotification class>>inClass:withCode:doitFlag:errorMessage:location: (in category 'exceptionInstantiator') ----- inClass: aClass withCode: codeString doitFlag: doitFlag errorMessage: errorString location: location + + self deprecated: 'ct: Use #cue:doitFlag:errorMessage:location:'. + ^ self + cue: (CompilationCue source: codeString class: aClass requestor: nil) - ^self new - setClass: aClass - code: codeString doitFlag: doitFlag errorMessage: errorString location: location! Item was added: + ----- Method: SyntaxErrorNotification>>context (in category 'accessing') ----- + context + + ^ cue context! Item was added: + ----- Method: SyntaxErrorNotification>>environment (in category 'accessing') ----- + environment + + ^ cue environment! Item was changed: ----- Method: SyntaxErrorNotification>>errorClass (in category 'accessing') ----- errorClass + + ^ cue getClass! - ^inClass! Item was changed: ----- Method: SyntaxErrorNotification>>errorCode (in category 'accessing') ----- errorCode + + ^ cue source! - ^code! Item was changed: ----- Method: SyntaxErrorNotification>>messageText (in category 'accessing') ----- messageText ^ super messageText + ifEmpty: [messageText := self errorCode]! - ifEmpty: [messageText := code]! Item was changed: ----- Method: SyntaxErrorNotification>>reparse:notifying:ifFail: (in category 'accessing') ----- reparse: aString notifying: aController ifFail: failBlock "Try to parse if aString has correct syntax, but do not evaluate/install any code. In case of incorrect syntax, execute failBlock and let a Compiler interact with the requestor. In case of correct syntax, set newSource." + + (doitFlag ifTrue: [nil class] ifFalse: [self errorClass]) newCompiler + compileCue: (cue copy + source: aString; + requestor: aController; + yourself) + noPattern: doitFlag + ifFail: failBlock. + newSource := aString.! - doitFlag - ifTrue: [nil class newCompiler compileNoPattern: aString in: nil class notifying: aController ifFail: failBlock] - ifFalse: [inClass newCompiler compile: aString in: inClass notifying: aController ifFail: failBlock]. - newSource := aString! Item was removed: - ----- Method: SyntaxErrorNotification>>setClass:code:doitFlag:errorMessage:location: (in category 'accessing') ----- - setClass: aClass code: codeString doitFlag: aBoolean errorMessage: errorString location: anInteger - inClass := aClass. - code := codeString. - doitFlag := aBoolean. - errorMessage := errorString. - location := anInteger! Item was added: + ----- Method: SyntaxErrorNotification>>setCue:doitFlag:errorMessage:location: (in category 'initialize-release') ----- + setCue: aCue doitFlag: aBoolean errorMessage: errorString location: anInteger + + cue := aCue. + doitFlag := aBoolean. + errorMessage := errorString. + location := anInteger!

1 0

The Trunk: EToys-ct.408.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.408.mcz ==================== Summary ==================== Name: EToys-ct.408 Author: ct Time: 17 September 2020, 12:48:54.350813 pm UUID: c530407c-bee4-a54c-8781-1ba7af10c1c1 Ancestors: EToys-eem.400 Improves MovingEyeMorph support for custom colors. =============== Diff against EToys-eem.400 =============== Item was added: + ----- Method: MovingEyeMorph class>>color:irisColor: (in category 'instance creation') ----- + color: aColor irisColor: anotherColor + + ^ self new color: aColor irisColor: anotherColor! Item was changed: ----- Method: MovingEyeMorph>>color: (in category 'accessing') ----- color: aColor super color: aColor. "Migrate old instances." inner color: Color transparent. + self keepIrisVisible.! - "Keep iris visible." - aColor = iris color - ifTrue: [iris borderWidth: 1; borderColor: aColor negated] - ifFalse: [iris borderWidth: 0].! Item was added: + ----- Method: MovingEyeMorph>>color:irisColor: (in category 'accessing') ----- + color: aColor irisColor: anotherColor + + self color: aColor. + self irisColor: anotherColor.! Item was added: + ----- Method: MovingEyeMorph>>defaultBorderWidth (in category 'accessing') ----- + defaultBorderWidth + + ^ 0! Item was changed: ----- Method: MovingEyeMorph>>irisColor: (in category 'accessing') ----- irisColor: aColor iris color: aColor. + self keepIrisVisible.! - "Keep iris visible." - aColor = self color - ifTrue: [iris borderWidth: 1; borderColor: aColor negated] - ifFalse: [iris borderWidth: 0].! Item was added: + ----- Method: MovingEyeMorph>>keepIrisVisible (in category 'private') ----- + keepIrisVisible + + self color = self irisColor + ifTrue: [ + iris borderWidth: 1; + borderColor: self color makeForegroundColor] + ifFalse: [ + iris borderWidth: 0].!

1 0

The Trunk: EToys-ct.407.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.407.mcz ==================== Summary ==================== Name: EToys-ct.407 Author: ct Time: 17 September 2020, 12:38:51.188813 pm UUID: 1ba5c4b2-8ee7-dd46-9d86-5a7526c91629 Ancestors: EToys-eem.400 Activates Shout styling in EToys MethodMorph. Also includes recategorization of some selectors. Is the reference from EToys to ToolBuilder-Morphic okay? The dependency already existed before. =============== Diff against EToys-eem.400 =============== Item was changed: + PluggableTextMorphPlus subclass: #MethodMorph - PluggableTextMorph subclass: #MethodMorph instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Etoys-Scripting'! Item was changed: + ----- Method: MethodMorph class>>defaultNameStemForInstances (in category 'constants') ----- - ----- Method: MethodMorph class>>defaultNameStemForInstances (in category 'as yet unclassified') ----- defaultNameStemForInstances ^ 'Method' translatedNoop! Item was changed: ----- Method: MethodMorph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" super initialize. + self useDefaultStyler.! - ! Item was changed: + ----- Method: MethodMorph>>installRollBackButtons: (in category 'initialization') ----- - ----- Method: MethodMorph>>installRollBackButtons: (in category 'as yet unclassified') ----- installRollBackButtons: target | mine | "If I don't already have such a button, put one in at the upper right. Set its target to the furtherest enclosing book. Send chooseAndRevertToVersion when clicked. Stay in place via scrollBar install." mine := self submorphNamed: #chooseAndRevertToVersion ifNone: [nil]. mine ifNil: [mine := SimpleButtonMorph new. "mine height: mine height - 2." mine label: 'Roll Back'; cornerStyle: #square. mine color: Color white; borderColor: Color black. mine actionSelector: #chooseAndRevertToVersion. mine align: mine topRight with: (self findA: ScrollBar) topLeft +(1@1). self addMorphFront: mine. mine height: mine height - 5 "14"]. mine target: target.! Item was added: + ----- Method: MethodMorph>>okToStyle (in category 'testing') ----- + okToStyle + + styler ifNil: [^ false]. + styler + classOrMetaClass: self model selectedClassOrMetaClass; + environment: self model environment. + ^ true!

1 0

The Trunk: EToys-ct.406.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.406.mcz ==================== Summary ==================== Name: EToys-ct.406 Author: ct Time: 17 September 2020, 12:23:18.233813 pm UUID: 0b76e3b6-1567-c542-8350-de5b7a28fcf2 Ancestors: EToys-eem.400 Minor Tetris refactorings. Expose action selectors for game control as part of the public Tetris protocol. This will be used to play/pause a tetris game from the outside. Recategorize some methods. This commit is part of reconstruction of Objectland (also known as "The Worlds of Squeak"). For more information, see: http://forum.world.st/The-Inbox-MorphicExtras-ct-267-mcz-td5104764.html =============== Diff against EToys-eem.400 =============== Item was changed: + ----- Method: Tetris class>>colors (in category 'constants') ----- - ----- Method: Tetris class>>colors (in category 'as yet unclassified') ----- colors ^{ Color r: 0.5 g: 0 b: 0. Color r: 0 g: 0.5 b: 0. Color r: 0 g: 0 b: 0.5. Color r: 0.5 g: 0.5 b: 0. Color r: 0.5 g: 0 b: 0.5. Color r: 0 g: 0.5 b: 0.5 } ! Item was changed: ----- Method: Tetris>>makeGameControls (in category 'initialization') ----- makeGameControls ^ self rowForButtons addMorph: (self buildButtonTarget: self label: 'Quit' translated selector: #delete help: 'quit' translated); addMorph: (self + buildButtonTarget: self - buildButtonTarget: board label: 'Pause' translated selector: #pause help: 'pause' translated); addMorph: (self + buildButtonTarget: self - buildButtonTarget: board label: 'New game' translated selector: #newGame help: 'new game' translated)! Item was added: + ----- Method: Tetris>>newGame (in category 'actions') ----- + newGame + + board newGame.! Item was added: + ----- Method: Tetris>>pause (in category 'actions') ----- + pause + + board pause.! Item was changed: + ----- Method: TetrisBlock class>>flipShapes: (in category 'support') ----- - ----- Method: TetrisBlock class>>flipShapes: (in category 'as yet unclassified') ----- flipShapes: anArray ^OrderedCollection new add: anArray; add: (anArray collect: [ :each | each y negated @ each x]); add: (anArray collect: [ :each | each x negated @ each y negated]); add: (anArray collect: [ :each | each y @ each x negated]); yourself ! Item was changed: + ----- Method: TetrisBlock class>>shapeChoices (in category 'constants') ----- - ----- Method: TetrisBlock class>>shapeChoices (in category 'as yet unclassified') ----- shapeChoices ^ ShapeChoices ifNil: [ ShapeChoices := { { { 0 @ 0 . 1 @ 0 . 0 @ 1 . 1 @ 1 } }. "square - one is sufficient here" self flipShapes: { 0 @ 0 . -1 @ 0 . 1 @ 0 . 0 @ -1 }. "T" { { 0 @ 0 . -1 @ 0 . 1 @ 0 . 2 @ 0 }. { 0 @ 0 . 0 @ -1 . 0 @ 1 . 0 @ 2 } "long - two are sufficient here" }. self flipShapes: { 0 @ 0 . 0 @ -1 . 0 @ 1 . 1 @ 1 }. "L" self flipShapes: { 0 @ 0 . 0 @ -1 . 0 @ 1 . -1 @ 1 }. "inverted L" self flipShapes: { 0 @ 0 . -1 @ 0 . 0 @ -1 . 1 @ -1 }. "S" self flipShapes: { 0 @ 0 . 1 @ 0 . 0 @ -1 . -1 @ -1 } "Z" }. ] ! Item was changed: + ----- Method: TetrisBoard>>cellSize (in category 'accessing') ----- - ----- Method: TetrisBoard>>cellSize (in category 'as yet unclassified') ----- cellSize ^12@12! Item was changed: + ----- Method: TetrisBoard>>originForCell: (in category 'accessing') ----- - ----- Method: TetrisBoard>>originForCell: (in category 'as yet unclassified') ----- originForCell: aPoint ^aPoint - (1@1) * self cellSize + self position !

1 0

The Trunk: EToys-ct.405.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.405.mcz ==================== Summary ==================== Name: EToys-ct.405 Author: ct Time: 17 September 2020, 12:12:06.449813 pm UUID: db0ca850-9a21-1849-b3e2-bd9ce983b266 Ancestors: EToys-eem.400 Adds WatchMorph example method. This commit is part of reconstruction of Objectland (also known as "The Worlds of Squeak"). For more information, see: http://forum.world.st/The-Inbox-MorphicExtras-ct-267-mcz-td5104764.html =============== Diff against EToys-eem.400 =============== Item was added: + ----- Method: WatchMorph class>>example (in category 'examples') ----- + example + "WatchMorph example openInWorld" + + ^ (WatchMorph + fontName: #BitstreamVeraSerif + bgColor: Color lightGray + centerColor: Color red paler) + handsColor: Color grape; + toggleRoman; + yourself!

1 0

The Trunk: EToys-ct.403.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.403.mcz ==================== Summary ==================== Name: EToys-ct.403 Author: ct Time: 16 September 2020, 9:28:21.732871 pm UUID: da566a07-8012-ee4b-88d6-58f224234d76 Ancestors: EToys-eem.400 Fixes an AssertionFailure concerning #doLayoutAgain when a particular arrangement of EToys tiles is laid out. TileMorph wants to change its owner's layout policy if that is a TilePadMorph as soon as it is embedded into that. However, the wrong hook was chosen for this. #ownerChanged is signaled whenever the owner has changed its layout. Instead, #noteNewOner: is signaled whenever the receiver is embedded into a new owner. Note that this practice of lazy layout modification is still suspect from my perspective, but at least it works again. Pooh, this one was really hard to find. Thanks a lot to Marcel (mt) and the MessageSendRecorder for their important help! ;-) =============== Diff against EToys-eem.400 =============== Item was added: + ----- Method: TileMorph>>noteNewOwner: (in category 'change reporting') ----- + noteNewOwner: ownerMorph + + super noteNewOwner: ownerMorph. + + ((ownerMorph isKindOf: TilePadMorph) + and: [ownerMorph layoutPolicy isNil]) + ifTrue: [ + ownerMorph + layoutPolicy: TableLayout new; + hResizing: #shrinkWrap; + vResizing: #spaceFill].! Item was removed: - ----- Method: TileMorph>>ownerChanged (in category 'change reporting') ----- - ownerChanged - super ownerChanged. - (owner class == TilePadMorph and:[owner layoutPolicy isNil]) ifTrue:[ - owner layoutPolicy: TableLayout new. - owner hResizing: #shrinkWrap. - owner vResizing: #spaceFill ].!

1 0

The Trunk: EToys-ct.402.mcz
by commits＠source.squeak.org 18 Feb '21

18 Feb '21

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.402.mcz ==================== Summary ==================== Name: EToys-ct.402 Author: ct Time: 24 August 2020, 8:22:21.479269 pm UUID: 8b6598bf-158f-a74f-a399-f82c39269bdc Ancestors: EToys-eem.400 Fixes EToys fences for players within flexshells by subtracting transformations. =============== Diff against EToys-eem.400 =============== Item was changed: ----- Method: Player>>forward: (in category 'scripts-standard') ----- forward: dist "Move forward (viz. in the direction of my heading) by the given amount" | rho radians delta didStray p aCostume aPlayfield | (aCostume := self costume) isInWorld ifFalse: [^ self]. aCostume isWorldOrHandMorph ifTrue: [^ self]. aCostume owner isHandMorph ifTrue: [^ self]. + - rho := (aCostume asNumber: dist) asFloat. + radians := (self getHeadingUnrounded asFloat - 90) degreesToRadians. - radians := (self getHeadingUnrounded asFloat - 90.0) degreesToRadians. delta := (radians cos @ radians sin) * rho. + + (aPlayfield := aCostume pasteUpMorph) fenceEnabled ifTrue: [ + | playfieldBounds costumeBounds | + playfieldBounds := aPlayfield boundsInWorld. + costumeBounds := aCostume boundsInWorld. + (playfieldBounds containsRect: costumeBounds) ifFalse: [ + "If I stray out of the bounds of my playfield, pull me back, but without changing my heading as bounce would. Do nothing if bounce has already corrected the direction." - - (aPlayfield := aCostume pasteUpMorph) fenceEnabled ifTrue: - [(aPlayfield bounds containsRect: aCostume bounds) ifFalse: - ["If I stray out of the bounds of my playfield, pull me back, but - without changing my heading as bounce would. Do nothing if - bounce has already corrected the direction." didStray := false. + ((costumeBounds left < playfieldBounds left and: [delta x < 0]) + or: [costumeBounds right > playfieldBounds right and: [delta x > 0]]) + ifTrue: [ + delta := delta x negated @ delta y. + didStray := true]. + ((costumeBounds top < playfieldBounds top and: [delta y < 0]) + or: [costumeBounds bottom > playfieldBounds bottom and: [delta y > 0]]) + ifTrue: [ + delta := delta x @ delta y negated. + didStray := true]. + (didStray and: [Preferences fenceSoundEnabled]) ifTrue: [ + aCostume makeFenceSound]]]. + - ((aCostume left < aPlayfield left and: [delta x < 0]) or: - [aCostume right > aPlayfield right and: [delta x > 0]]) ifTrue: - [delta := delta x negated @ delta y. - didStray := true]. - ((aCostume top < aPlayfield top and: [delta y < 0]) or: - [aCostume bottom > aPlayfield bottom and: [delta y > 0]]) ifTrue: - [delta := delta x @ delta y negated. - didStray := true]. - (didStray and: [Preferences fenceSoundEnabled]) ifTrue: [aCostume makeFenceSound]]]. - "use and record the fractional position" p := aCostume referencePosition + delta. + aCostume referencePosition: p.! - aCostume referencePosition: p!

1 0

← Newer
1
...
12
13
14
15
16
17
18
19
20
Older →

Jump to page: