Squeak-dev February 2021

squeak-dev@lists.squeakfoundation.org

33 participants
196 discussions

The Trunk: CollectionsTests-jar.349.mcz
by commits＠source.squeak.org 13 Feb '21

13 Feb '21

David T. Lewis uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-jar.349.mcz ==================== Summary ==================== Name: CollectionsTests-jar.349 Author: jar Time: 8 February 2021, 8:25:19.407373 pm UUID: f484ba2b-2035-b046-9222-c3e4e42a7ad4 Ancestors: CollectionsTests-ul.348 Test to show differing SharedQueue and SharedQueue2 semantics =============== Diff against CollectionsTests-ul.348 =============== Item was added: + ----- Method: AbstractSharedQueueTest>>testContention2 (in category 'tests') ----- + testContention2 + "and here's a test case that distunguishes SharedQueue from SharedQueue2 semantics: + SharedQueue2 produces a sequence #(5 10 15) while SharedQueue produces #(5 15 10)" + + | q r1 r2 r3 | + q := self queueClass new. + + [ r1 := q next. q nextPut: 15. r3 := q next ] fork. + [ r2 := q next ] fork. + + Processor yield. "let the above two threads block" + + q nextPut: 5. + Processor yield. "let the first thread above proceed" + + q nextPut: 10. + Processor yield. "let the unfinished thread above finish" + + q class = SharedQueue2 ifTrue: [ + self assert: 5 equals: r1. + self assert: 10 equals: r2. + self assert: 15 equals: r3. + self assert: nil equals: q nextOrNil ]. + + q class = SharedQueue ifTrue: [ + self assert: 5 equals: r1. + self assert: 15 equals: r2. + self assert: 10 equals: r3. + self assert: nil equals: q nextOrNil ]. + + "SharedQueue2 implementation using a Monitor checks the queue for available data while + the SharedQueue implementation based on a Semaphore checks for excessSignals > 0, + which results in these two different outcomes"!

3 2

#ifCurtailed - why the "complete := true" line?
by Jaromir 13 Feb '21

13 Feb '21

Hi, I can't figure this one out - is the value of /complete / in #ifCurtailed method used somewhere? Very confusing ;) Thanks a lot! Jaromir ifCurtailed: aBlock | complete result | <primitive: 198> result := self valueNoContextSwitch. complete := true. ^result -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

2 2

The Trunk: Collections-jar.924.mcz
by commits＠source.squeak.org 13 Feb '21

13 Feb '21

David T. Lewis uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-jar.924.mcz ==================== Summary ==================== Name: Collections-jar.924 Author: jar Time: 7 February 2021, 9:42:07.649004 am UUID: 073b26bc-8e5e-ba41-9aac-9d424bbe6848 Ancestors: Collections-dtl.923 Fixes SharedQueue >> nextOrNilSuchThat bug to pass the existing test =============== Diff against Collections-dtl.923 =============== Item was changed: ----- Method: SharedQueue>>nextOrNilSuchThat: (in category 'accessing') ----- nextOrNilSuchThat: aBlock "Answer the next object that satisfies aBlock, skipping any intermediate objects. If no object has been sent, answer <nil> and leave me intact. NOTA BENE: aBlock MUST NOT contain a non-local return (^)." ^accessProtect critical: [ | value readPos | value := nil. readPos := readPosition. [ readPos < writePosition and: [ value isNil ] ] whileTrue: [ value := contentsArray at: readPos. readPos := readPos + 1. (aBlock value: value) ifFalse: [ value := nil ] ifTrue: [ readSynch waitIfLocked: [ ^nil ]. "We found the value, but someone else booked it." + readPos-1 to: readPosition+1 by: -1 do: [ :j | contentsArray at: j put: (contentsArray at: j-1) ]. + contentsArray at: readPosition put: nil. + readPosition := readPosition+1 ] ]. - readPosition to: readPos - 1 do: [ :j | contentsArray at: j put: nil ]. - readPosition := readPos ] ]. value ]. "=== q := SharedQueue new. 1 to: 10 do: [ :i | q nextPut: i]. c := OrderedCollection new. [ v := q nextOrNilSuchThat: [ :e | e odd]. v notNil ] whileTrue: [ c add: {v. q size} ]. {c. q} explore ==="!

1 0

The Trunk: Kernel-dtl.1369.mcz
by commits＠source.squeak.org 13 Feb '21

13 Feb '21

David T. Lewis uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-dtl.1369.mcz ==================== Summary ==================== Name: Kernel-dtl.1369 Author: dtl Time: 12 February 2021, 6:32:35.918542 pm UUID: 3968e898-9e0c-4f26-a331-74c2353b7e99 Ancestors: Kernel-nice.1368, Kernel-ct.1368 merge Kernel-ct.1368 =============== Diff against Kernel-nice.1368 =============== Item was changed: ----- Method: Process>>longPrintOn: (in category 'printing') ----- longPrintOn: stream | ctxt | super printOn: stream. + stream + nextPut: $(; + nextPutAll: self name; + nextPut: $). stream cr. ctxt := self suspendedContext. [ctxt == nil] whileFalse: [ stream space. ctxt printOn: stream. stream cr. ctxt := ctxt sender. ]. ! Item was changed: ----- Method: Process>>printOn: (in category 'printing') ----- printOn: aStream super printOn: aStream. + aStream + nextPut: $(; + nextPutAll: self name; + nextPut: $). aStream nextPutAll: ' in '. suspendedContext printOn: aStream!

1 0

correct form for Problem With Blocks
by gettimothy 11 Feb '21

11 Feb '21

Hi Folks, I am importing my grammar/xtreams parsing work into its own image so that I can change my system fonts without making my other projects look funky with the chages. The base image is: Image ----- /home/wm/usr/src/smalltalk/squeak6.0alpha/shared/Squeak6.0alpha-19802-64bit.image Squeak6.0alpha latest update: #20147 to the latest: /home/wm/Squeak/images/WikitextParser/WikitextParser.image Squeak6.0alpha latest update: #20188 During the import of my work, I ran into this issue regarding Store Into in a block: http://forum.world.st/Cuis-problem-with-blocks-td1047783.html#a1049556 The parser is looking for patterns of (10e2)e2....i.e. exponential notation of unknown length, i.e. per the comment on Collection inject: into: accumulate a running value... Per the email chain referenced, the "Allow block argument assignment" is allowed in the former, and not allowed in the latest, which is cool with me, but... My question is "what is the generic form" that I can use to duplicate the behaviour I want? Here is the original method with the bad store into: Float: first exponent: pairs <action: 'Float' arguments:#(1 2)> "Float <- ( Number / Group / Function ) (''e'' ( Number / Group / Function ))+" |result| result := pairs inject: first into: [ :base :pair | (pair first = 'e') ifTrue: [ (pair last abs > 1) ifTrue:[ base := Float readFrom: ((base asString) , 'e', (pair last asString))] ifFalse:[ base := (base * (10 raisedTo:(pair last) ))]]]. transcripton ifTrue:[Transcript show:'Float ' , (result asFloat); cr. ]. ^ result asFloat Here is my "hack" to fix it , (I create a tmp variable outside the block to use in place of the "base"): Float: first exponent: pairs <action: 'Float' arguments:#(1 2)> "Float <- ( Number / Group / Function ) (''e'' ( Number / Group / Function ))+" |result tmp| result := pairs inject: first into: [ :base :pair | (pair first = 'e') ifTrue: [ (pair last abs > 1) ifTrue:[tmp := base. tmp := Float readFrom: ((tmp asString) , 'e', (pair last asString))] tmp := Float readFrom: ((tmp asString) , 'e', (pair last asString)). tmp] ifFalse:[tmp := base. tmp := (tmp * (10 raisedTo:(pair last) ))]]]. tmp := (tmp * (10 raisedTo:(pair last) )). tmp]]]. transcripton ifTrue:[Transcript show:'Float ' , (result asFloat); cr. ]. ^ result asFloat I got a bad feeling about this one. Is there a general form for this ? My brain is a bit foggy from working the graveyard shift so what would be obvious while in normal conditions , is not obvious today. Thanks for you time.

2 1

The Trunk: Kernel-nice.1368.mcz
by commits＠source.squeak.org 11 Feb '21

11 Feb '21

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1368.mcz ==================== Summary ==================== Name: Kernel-nice.1368 Author: nice Time: 11 February 2021, 9:30:07.084854 am UUID: b086833d-ece4-4372-b252-87d2caa59193 Ancestors: Kernel-eem.1367 Rescue setting of Processor highestPriority: anInteger There was a double problem: 1) if reducing the priority, then anyProcessesAbove: did behave as noProcessAbove: because (select:) isEmpty <=> noneSatisfy: It should have been (reject:) empty or (select:) notEmpty, but we have anySatisfy: for expressing this intention 2) if increasing the priority, then the loop did overwrite the last LinkedList in the quiescentProcessLists Those LinkedList are mostly empty in my own image, and we never change the highestPriority, so the bug was probably benign... =============== Diff against Kernel-eem.1367 =============== Item was changed: ----- Method: ProcessorScheduler>>anyProcessesAbove: (in category 'private') ----- anyProcessesAbove: highestPriority + "Do any (sub) instances of Process exist with higher priorities?" - "Do any instances of Process exist with higher priorities?" + ^(Process allSubInstances anySatisfy: [:aProcess | + aProcess priority > highestPriority])! - ^(Process allSubInstances select: [:aProcess | - aProcess priority > highestPriority]) isEmpty - "If anyone ever makes a subclass of Process, be sure to use allSubInstances."! Item was changed: ----- Method: ProcessorScheduler>>highestPriority: (in category 'accessing') ----- highestPriority: newHighestPriority "Change the number of priority levels currently available for use." | newProcessLists | (quiescentProcessLists size > newHighestPriority and: [self anyProcessesAbove: newHighestPriority]) ifTrue: [self error: 'There are processes with priority higher than ' ,newHighestPriority printString]. newProcessLists := Array new: newHighestPriority. + 1 to: (quiescentProcessLists size min: newProcessLists size) do: - 1 to: ((quiescentProcessLists size) min: (newProcessLists size)) do: [:priority | newProcessLists at: priority put: (quiescentProcessLists at: priority)]. + quiescentProcessLists size + 1 to: newProcessLists size do: - (quiescentProcessLists size max: 1) to: newProcessLists size do: [:priority | newProcessLists at: priority put: LinkedList new]. quiescentProcessLists := newProcessLists!

1 0

The Trunk: SUnit-nice.124.mcz
by commits＠source.squeak.org 11 Feb '21

11 Feb '21

Nicolas Cellier uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-nice.124.mcz ==================== Summary ==================== Name: SUnit-nice.124 Author: nice Time: 11 February 2021, 9:14:06.179764 am UUID: f1c47b72-13f3-4690-86c9-b76f3cae6e04 Ancestors: SUnit-pre.123 Use lines rather than subStrings: {Character cr} This is what lines is made for; it is fast and also work whatever CRLF zoo. =============== Diff against SUnit-pre.123 =============== Item was changed: ----- Method: SUnitExtensionsTest>>testAutoAssertFalse (in category 'tests') ----- testAutoAssertFalse | booleanCondition | self assert: self isLogging. self should: [ self assert: 1 = 2 description: 'self assert: 1 = 2' ] raise: TestResult failure. + booleanCondition := (self stream contents lines) last = 'self assert: 1 = 2'. - booleanCondition := (self stream contents subStrings: {Character cr}) last = 'self assert: 1 = 2'. self assert: booleanCondition! Item was changed: ----- Method: SUnitExtensionsTest>>testAutoDenyFalse (in category 'tests') ----- testAutoDenyFalse | booleanCondition | self assert: self isLogging. self should: [ self deny: 1 = 1 description: 'self deny: 1 = 1'.] raise: TestResult failure. + booleanCondition := (self stream contents lines) last = 'self deny: 1 = 1'. - booleanCondition := (self stream contents subStrings: {Character cr}) last = 'self deny: 1 = 1'. self assert: booleanCondition!

1 0

The Inbox: Collections-jar.924.mcz
by commits＠source.squeak.org 10 Feb '21

10 Feb '21

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-jar.924.mcz ==================== Summary ==================== Name: Collections-jar.924 Author: jar Time: 7 February 2021, 9:42:07.649004 am UUID: 073b26bc-8e5e-ba41-9aac-9d424bbe6848 Ancestors: Collections-dtl.923 Fixes SharedQueue >> nextOrNilSuchThat bug to pass the existing test =============== Diff against Collections-dtl.923 =============== Item was changed: ----- Method: SharedQueue>>nextOrNilSuchThat: (in category 'accessing') ----- nextOrNilSuchThat: aBlock "Answer the next object that satisfies aBlock, skipping any intermediate objects. If no object has been sent, answer <nil> and leave me intact. NOTA BENE: aBlock MUST NOT contain a non-local return (^)." ^accessProtect critical: [ | value readPos | value := nil. readPos := readPosition. [ readPos < writePosition and: [ value isNil ] ] whileTrue: [ value := contentsArray at: readPos. readPos := readPos + 1. (aBlock value: value) ifFalse: [ value := nil ] ifTrue: [ readSynch waitIfLocked: [ ^nil ]. "We found the value, but someone else booked it." + readPos-1 to: readPosition+1 by: -1 do: [ :j | contentsArray at: j put: (contentsArray at: j-1) ]. + contentsArray at: readPosition put: nil. + readPosition := readPosition+1 ] ]. - readPosition to: readPos - 1 do: [ :j | contentsArray at: j put: nil ]. - readPosition := readPos ] ]. value ]. "=== q := SharedQueue new. 1 to: 10 do: [ :i | q nextPut: i]. c := OrderedCollection new. [ v := q nextOrNilSuchThat: [ :e | e odd]. v notNil ] whileTrue: [ c add: {v. q size} ]. {c. q} explore ==="!

3 3

The Inbox: KernelTests-jar.393.mcz
by commits＠source.squeak.org 08 Feb '21

08 Feb '21

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.393.mcz ==================== Summary ==================== Name: KernelTests-jar.393 Author: jar Time: 8 February 2021, 10:06:09.126403 pm UUID: af94938b-d43a-b94c-b306-922ab65afb78 Ancestors: KernelTests-eem.392 Test for Process>>priority: related to fix Kernel-jar.1368 =============== Diff against KernelTests-eem.392 =============== Item was added: + ----- Method: ProcessTest>>testPriority (in category 'tests') ----- + testPriority + "test whether #priority: preempts active process to allow higher priority processes run" + + | val oldPriority | + val := nil. + oldPriority := Processor activePriority. + Processor activeProcess priority: oldPriority + 2. + [ val := false ] forkAt: oldPriority + 1. + [ val := true ] forkAt: oldPriority. + Processor activeProcess priority: oldPriority. + self assert: val equals: Smalltalk vm processPreemptionYields!

1 0

The Inbox: CollectionsTests-jar.349.mcz
by commits＠source.squeak.org 08 Feb '21

08 Feb '21

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-jar.349.mcz ==================== Summary ==================== Name: CollectionsTests-jar.349 Author: jar Time: 8 February 2021, 8:25:19.407373 pm UUID: f484ba2b-2035-b046-9222-c3e4e42a7ad4 Ancestors: CollectionsTests-ul.348 Test to show differing SharedQueue and SharedQueue2 semantics =============== Diff against CollectionsTests-ul.348 =============== Item was added: + ----- Method: AbstractSharedQueueTest>>testContention2 (in category 'tests') ----- + testContention2 + "and here's a test case that distunguishes SharedQueue from SharedQueue2 semantics: + SharedQueue2 produces a sequence #(5 10 15) while SharedQueue produces #(5 15 10)" + + | q r1 r2 r3 | + q := self queueClass new. + + [ r1 := q next. q nextPut: 15. r3 := q next ] fork. + [ r2 := q next ] fork. + + Processor yield. "let the above two threads block" + + q nextPut: 5. + Processor yield. "let the first thread above proceed" + + q nextPut: 10. + Processor yield. "let the unfinished thread above finish" + + q class = SharedQueue2 ifTrue: [ + self assert: 5 equals: r1. + self assert: 10 equals: r2. + self assert: 15 equals: r3. + self assert: nil equals: q nextOrNil ]. + + q class = SharedQueue ifTrue: [ + self assert: 5 equals: r1. + self assert: 15 equals: r2. + self assert: 10 equals: r3. + self assert: nil equals: q nextOrNil ]. + + "SharedQueue2 implementation using a Monitor checks the queue for available data while + the SharedQueue implementation based on a Semaphore checks for excessSignals > 0, + which results in these two different outcomes"!

2 1

Jump to page: