Squeak-dev January 2022

squeak-dev@lists.squeakfoundation.org

33 participants
361 discussions

The Inbox: Collections-ct.877.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.877.mcz ==================== Summary ==================== Name: Collections-ct.877 Author: ct Time: 17 February 2020, 8:57:49.278239 pm UUID: bf652ba0-43cc-734d-ac03-7a226cc80463 Ancestors: Collections-ul.875 Extends and realigns version of #findFirst: and #findLast:. Second, optimized version after many helpful comments by Levente (ul). Thank you! Replaces Collections-ct.875. --- Performance analysis: #findFirst: - '238 per second. 4.2 milliseconds per run. 0.73956 % GC time.' #findFirst:startingAt: - '1,510 per second. 660 microseconds per run. 1.56 % GC time.' #findFirst:startingAt:ifNone: - '1,210 per second. 828 microseconds per run. 2.06 % GC time.' #findFirst:ifNone: - '214 per second. 4.68 milliseconds per run. 0.65987 % GC time.' #findLast: - '210 per second. 4.76 milliseconds per run. 0.66 % GC time.' #findLast:startingAt: - '1,380 per second. 724 microseconds per run. 1.72 % GC time.' #findLast:startingAt:ifNone: - '1,130 per second. 887 microseconds per run. 2 % GC time.' #findLast:ifNone: - '206 per second. 4.86 milliseconds per run. 0.81967 % GC time.' Comparing to previous version: #findFirst: - '193 per second. 5.19 milliseconds per run. 0.5994 % GC time.' (NOW 23.3% faster) #findLast: - '213 per second. 4.69 milliseconds per run. 0.71986 % GC time.' (NOW 1.4% slower) #findLast:startingAt: - '1,360 per second. 736 microseconds per run. 1.72 % GC time.' (NOW 1.4% faster) Measurements code: random := Random new. range := 1 to: 256. array := (1 to: 128) collect: [:i | range atRandom: random]. values := (1 to: 4096) collect: [:i | range atRandom: random]. ({ #findFirst: -> [ values do: [:x | array findFirst: [:y | x = y]]]. #findFirst:startingAt: -> [ values pairsDo: [:x :s | array findFirst: [:y | x = y] startingAt: s]]. #findFirst:ifNone: -> [ values do: [:x | array findFirst: [:y | x = y] ifNone: [123456789 sqrt]]]. #findFirst:startingAt:ifNone: -> [ values pairsDo: [:x :s | array findFirst: [:y | x = y] startingAt: s ifNone: [123456789 sqrt]]]. #findLast: -> [ values do: [:x | array findLast: [:y | x = y]]]. #findLast:startingAt: -> [ values pairsDo: [:x :s | array findLast: [:y | x = y] startingAt: s]]. #findLast:ifNone: -> [ values do: [:x | array findLast: [:y | x = y] ifNone: [123456789 sqrt]]]. #findLast:startingAt:ifNone: -> [ values pairsDo: [:x :s | array findLast: [:y | x = y] startingAt: s ifNone: [123456789 sqrt]]]. } select: [:assoc | array respondsTo: assoc key]) collect: [:assoc | assoc key -> assoc value bench] as: Dictionary =============== Diff against Collections-ul.875 =============== Item was changed: ----- Method: SequenceableCollection>>findFirst: (in category 'enumerating') ----- findFirst: aBlock "Return the index of my first element for which aBlock evaluates as true." + ^ self findFirst: aBlock startingAt: 1! - | index | - index := 0. - [(index := index + 1) <= self size] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:ifNone: (in category 'enumerating') ----- + findFirst: aBlock ifNone: anotherBlock + "Return the index of my first element for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findFirst: aBlock) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true." + + minIndex to: self size do: [:index | + (aBlock value: (self at: index)) ifTrue: [^index]]. + ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt:ifNone: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findFirst: aBlock startingAt: minIndex) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was changed: ----- Method: SequenceableCollection>>findLast: (in category 'enumerating') ----- findLast: aBlock "Return the index of my last element for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: 1! - | index | - index := self size + 1. - [(index := index - 1) >= 1] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:ifNone: (in category 'enumerating') ----- + findLast: aBlock ifNone: anotherBlock + "Return the index of my last element for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findLast: aBlock) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was changed: ----- Method: SequenceableCollection>>findLast:startingAt: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true." - findLast: aBlock startingAt: i - "Return the index of my last element with index >= i for which aBlock evaluates as true." + self size to: minIndex by: -1 do: [:index | + (aBlock value: (self at: index)) ifTrue: [^index]]. - | index | - index := self size + 1. - [(index := index - 1) >= i] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:startingAt:ifNone: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findLast: aBlock startingAt: minIndex) = 0 + ifTrue: [^ anotherBlock value]. + ^ index!

3 2

PositionableStream >> #peekBack behavior
by Eric Gade 04 May '22

04 May '22

Hello, What is the expected behavior for a stream that is at position 1 when you send #peekBack? Intuitively I'd expect to get the first element of the underlying collection as a response. But instead I am getting nil. Here is an example that is failing: ``` elem := #(1 2 3 4). stream := ReadStream on: elem. first := stream next. first = 1. back := stream peekBack. back = first. ``` The last message is currently responding false. In Pharo this returns true, so there are differences. The currently implementation of PositionableStream >> #peekBack is: ``` peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." | element | self position = 0 ifTrue: [self errorCantGoBack]. self position = 1 ifTrue: [self position: 0. ^ nil]. self skip: -2. element := self next. self skip: 1. ^ element ``` I can see the nil being returned there explicitly, so that's "where it's happening." Should this be the case though? Thanks -- Eric

5 7

Date today versus DateAndTime today
by Bernhard Pieber 25 Apr '22

25 Apr '22

Hi everyone, I am quite puzzled that the following answers false: DateAndTime today asDate = Date today. The reason seems to be the localOffsetSeconds. While DateAndTime today asDate has a local timezone, Date today has not. Shouldn’t this be consistent? The following answers false as well: Date today start = DateAndTime today I assume it is for the same reason. I suppose this is a feature, not a bug, but what is the reason for this behaviour? Cheers, Bernhard

6 6

Squeak 6.0 | Release Planning
by Marcel Taeumel 25 Apr '22

25 Apr '22

Hi all -- I suppose that many readers have noticed by now that we are currently preparing the next Squeak release. A few weeks ago, I volunteered for being the next release manager. Until now, I have been rather reluctant to make any concrete remarks on when the release will happen. Let me use the following lines to give you a brief update. The OpenSmalltalk VM looks good. We have our second release candidate and will hopefully make a third one soon. Our daily Trunk bundles include that OSVM RC2 already: - http://files.squeak.org/trunk/ - https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202112201228 - http://lists.squeakfoundation.org/pipermail/vm-dev/2022-January/037533.html The Trunk image is doing well. Maybe we can do our traditional "Feature Freeze" in the beginning of February. Before proposing a concrete schedule, I want to finish assessing a few higher-effort things including: - Objectland (http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-October/204437.…) - Localization (English, German, French, ...) - Jaromir's latest efforts around process scheduling - Eric's latest efforts around GIFReadWriter - Current state of ClipboardExtendedPlugin - Current state of IPv6 Other than that, I plan for announcing the upcoming "Feature Freeze" about 2 weeks in advance. Then we enter our beta-testing phase, in which I will make our latest "60Deprecated" package opt-in instead of opt-out (using the preference wizard). Then, about 1-2 weeks later if all goes well, I will update the .sources file of our final release candidate to SqueakV60.sources, package the release and open the Trunk for features again. :-) Next Trunk version will be 6.1alpha (using 61Deprecated for new deprecations). Let us all work together to make Squeak 6.0 being worth its increased major version number: - Report issues - Fix failing tests - Make you favorite projects compatible Thanks! :-) Happy squeaking! Best, Marcel

6 11

Re: [squeak-dev] Next Release Candidate?
by Marcel Taeumel 19 Apr '22

19 Apr '22

Hi all -- Please test this VM version: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202112022203 [https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202112022203] Choose your preferred platform. Focus on cog.spur flavors for 64-bit machines. Best, Marcel Am 01.12.2021 10:38:47 schrieb Marcel Taeumel <marcel.taeumel(a)hpi.de>: Hi all -- What's you overall feeling of having a new release candidate of the OSVM? Overall pace has been decreasing during the last weeks. Maybe this is a good time then? Latest commit was about 10 hours ago. So, wait for 2-3 days and then tag that version, produce binaries and test those? Best, Marcel

9 27

Default preferences
by christoph.thiede＠student.hpi.uni-potsdam.de 08 Apr '22

08 Apr '22

Hi all! Yeah, this topic again, but before we release the next version of Squeak, I thought we maybe could slightly round off our list of preferences in order to improve the initial experience for new Squeakers even more! I have went through the entire list of preferences and identified several regressions and dead preferences (you may have noticed a number of other recent contributions by me regarding this topic), but I also made a list of default preference values with which I personally do not really agree, so I thought we could discuss them here. I'm trying to be brief: 1. Windowing Personally, the first thing I do in every new image is to enable these prefs: "mouse over for keyboard focus", "open tools attached to mouse cursor", "windows' contents are always active". Do I belong to a minority of Squeakers or could we satisfy a majority of Squeakers by turning on these prefs by default? 2. Tools Very brief suggestions: - TextDiffBuilder ignoreLineEndings -> true - Show annotation pane in the debugger -> true - Extra debugger buttons -> true - Show stack variables in debugger -> maybe? I like it, does it harm? - Stack Size in Notifier/Full Debugger -> increase by factor 2 or more, should not be a performance issue nowadays, but increases convenience 3. Morphs - Wrapped tree navigation -> true (just consistent to lists) - Use the new color-picker -> true (c'mon, this tool is already >11 years old! :p) 4. Editing - Auto enclose brackets -> #beforeSpaces (see [1], pending. Inserting a bracket pair () right before a character just feels pretty useless to me.) - Enclose selection with brackets -> true Please give feedback or discuss! You could opt en block or leave more detailed feedback to the single proposals. Looking forward to a productive debate! :-) Best, Christoph [1] autoEncloseBeforeSpace.cs: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-November/216871… --- Sent from Squeak Inbox Talk

11 67

The Inbox: Collections-ct.949.mcz
by commits＠source.squeak.org 08 Apr '22

08 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.949.mcz ==================== Summary ==================== Name: Collections-ct.949 Author: ct Time: 30 June 2021, 12:40:15.630133 am UUID: af0bb5dc-fd59-5c46-805b-f923e93cdaf2 Ancestors: Collections-mt.945 Adds basic support for data URIs to HtmlReadWriter. Usage: 'Hello <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAIBAMAAAA2IaO4AAAAMFBMVEUAAACAAAAAgACAgAAAAICAAIAAgICAgIC/v7//AAAA/wD//wAAAP//AP8A//////94imqWAAAAEHRSTlP/////////////////////zSGylAAAAChJREFUeF5j+P///3+G/7t3/2f4zb1hP8Pv3bv3Q1kbuPdDJIAq/gMA/8wZcBN9r58AAAAASUVORK5CYII=" />' asTextFromHtml edit =============== Diff against Collections-mt.945 =============== Item was changed: ----- Method: HtmlReadWriter>>httpGetImage: (in category 'private') ----- httpGetImage: url "To not add a direct dependency to WebClient, provide this hook for getting am image from an HTTP url. Maybe we can have this via an AppRegistry at some point. Maybe extend WebBrowser." + - (url beginsWith: 'code://') ifTrue: [ "Same support for Smalltalk expressions as in TextURL >> #actOnClickFor:." ^ ([Compiler evaluate: (url allButFirst: 7)] ifError: [nil]) ifNotNil: [:object | object isForm ifTrue: [object] ifFalse: [nil]]]. + (url beginsWith: 'data:') ifTrue: [ | data mediaType separator | + separator := url indexOf: $, ifAbsent: [^ nil]. + mediaType := url copyFrom: 6 to: separator - 1. + data := url allButFirst: separator. + data := (mediaType endsWith: ';base64') + ifTrue: [ + mediaType := mediaType allButLast: 7. + [Base64MimeConverter mimeDecodeToBytes: data readStream] ifError: [nil]] + ifFalse: [data asByteArray readStream]. + ^ [ImageReadWriter formFromStream: data] ifError: [nil]]. + ^ (Smalltalk classNamed: 'WebClient') ifNotNil: [:client | ([client httpGet: url] ifError: [nil]) ifNotNil: [:response | response code = 200 ifFalse: [nil] ifTrue: [ [Form fromBinaryStream: response content asByteArray readStream] ifError: [nil]]]]!

3 2

The Inbox: Collections-ct.860.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.860.mcz ==================== Summary ==================== Name: Collections-ct.860 Author: ct Time: 15 November 2019, 1:58:56.418005 pm UUID: f6364e7f-08c8-694a-9060-21bc0a0c28d4 Ancestors: Collections-pre.857 Add convenience constructor for Dictionary Dictionary fromKeys: 'wasd' values: '8426' =============== Diff against Collections-pre.857 =============== Item was added: + ----- Method: Dictionary class>>fromKeys:values: (in category 'instance creation') ----- + fromKeys: keys values: values + + | dictionary | + self assert: [keys size = values size]. + dictionary := self new: keys size. + keys with: values do: [:key :value | + dictionary add: key -> value]. + ^ dictionary!

7 7

The Inbox: Collections-ct.920.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.920.mcz ==================== Summary ==================== Name: Collections-ct.920 Author: ct Time: 4 November 2020, 8:02:08.093134 pm UUID: f516a6ba-d9ee-0944-be9b-ad4093133c08 Ancestors: Collections-ct.920 Proposal: Honor scaleFactor for default spacings in text constants. With this change, tabs in every text editor are finally displayed hi-dpi-sensitive. Note that I found this method rather by incident than by expertise! I strongly advise against merging this into the Trunk without prior review by someone who has a bit more knowledge of this domain than me. ;-) Is this the right place for such a change, or should we patch the senders of every constant instead? Requires System-ct.1188. =============== Diff against Collections-ct.920 ===============

2 1

The Inbox: Collections-ct.875.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.875.mcz ==================== Summary ==================== Name: Collections-ct.875 Author: ct Time: 16 February 2020, 3:32:23.116 pm UUID: 61ea773b-1408-c040-a712-09238ee6fe2f Ancestors: Collections-topa.873 Extends and realigns version of #findFirst: and #findLast:. =============== Diff against Collections-topa.873 =============== Item was changed: ----- Method: SequenceableCollection>>findFirst: (in category 'enumerating') ----- findFirst: aBlock - "Return the index of my first element for which aBlock evaluates as true." + ^ self findFirst: aBlock startingAt: 1! - | index | - index := 0. - [(index := index + 1) <= self size] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:ifNone: (in category 'enumerating') ----- + findFirst: aBlock ifNone: anotherBlock + + ^ self findFirst: aBlock startingAt: 1 ifNone: anotherBlock! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex + + ^ self findFirst: aBlock startingAt: minIndex ifNone: [0]! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt:ifNone: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := minIndex - 1. + [(index := index + 1) <= self size] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value! Item was changed: ----- Method: SequenceableCollection>>findLast: (in category 'enumerating') ----- findLast: aBlock - "Return the index of my last element for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: 1! - | index | - index := self size + 1. - [(index := index - 1) >= 1] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:ifNone: (in category 'enumerating') ----- + findLast: aBlock ifNone: anotherBlock + + ^ self findLast: aBlock startingAt: 1 ifNone: anotherBlock! Item was changed: ----- Method: SequenceableCollection>>findLast:startingAt: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex - findLast: aBlock startingAt: i - "Return the index of my last element with index >= i for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: minIndex ifNone: [0]! - | index | - index := self size + 1. - [(index := index - 1) >= i] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:startingAt:ifNone: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := self size + 1. + [(index := index - 1) >= minIndex] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value!

6 12

← Newer
1
2
3
4
5
6
7
8
9
...
37
Older →

Jump to page: