Squeak-dev January 2022

squeak-dev@lists.squeakfoundation.org

33 participants
361 discussions

The Inbox: Collections-ct.871.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.871.mcz ==================== Summary ==================== Name: Collections-ct.871 Author: ct Time: 30 December 2019, 3:06:02.364602 pm UUID: 235b9546-6ad3-b547-8661-38c5f2a98374 Ancestors: Collections-nice.868 Refactor CharacterClass >> #constantNames: Use reflection instead of hardcoding all names. With this change, further characters such as Character arrowLeft are printed legibly. =============== Diff against Collections-nice.868 =============== Item was changed: ----- Method: Character class>>constantNames (in category 'private') ----- constantNames + ^ self class methodsInCategory: #'accessing untypeable characters'! - ^ #( backspace cr delete escape lf null newPage space tab ).!

2 1

The Trunk: Tools-mt.1102.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1102.mcz ==================== Summary ==================== Name: Tools-mt.1102 Author: mt Time: 11 January 2022, 10:58:04.097851 am UUID: 1b324423-7076-45b9-898d-9c282b430fc6 Ancestors: Tools-mt.1101 Fixes regression in ChangeSorter, which got visible MVC but not Morphic. Somebody added #buildWith: to Morph ... not sure why. =============== Diff against Tools-mt.1101 =============== Item was changed: ----- Method: ChangeSorter>>buildWith: (in category 'toolbuilder') ----- buildWith: builder + ^ self + buildWith: builder + in: (self buildWindowWith: builder) + rect: (0@0 extent: 1@1)! - ^ builder build: - (self - buildWith: builder - in: (self buildWindowWith: builder) - rect: (0@0 extent: 1@1))!

3 2

The Trunk: Tools-ct.1091.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1091.mcz ==================== Summary ==================== Name: Tools-ct.1091 Author: ct Time: 15 December 2021, 8:01:22.087022 pm UUID: 5b6f6413-b247-5642-8890-68b2ccfacbdc Ancestors: Tools-ct.1089 Fixes a slip introduced with BlockClosureInspector. Make sure to reset the styler's workspace variable after switching to a different kind of inspector (i.e., in the context of a debugger). Otherwise, you might see error messages such as "MessageNotUnderstood: Inspector>>hasBindingOf:". :-) =============== Diff against Tools-ct.1089 =============== Item was changed: ----- Method: Inspector>>updateStyler:requestor: (in category 'user interface - styling') ----- updateStyler: aStyler requestor: anObject "Use this method to update our fieldListStyler and all view stylers." aStyler environment: self environment; classOrMetaClass: (self doItReceiver perform: #class "do not inline send of #class, receiver could be a proxy"); context: self doItContext; + parseAMethod: false; + workspace: nil "Normally we don't need this, but probably a workspace has been specified when the receiver was belonging to another class. See #inspect: and BlockClosureInspector >> #updateStyler:requestor:.".! - parseAMethod: false.!

3 3

The Inbox: SUnit-ct.137.mcz
by commits＠source.squeak.org 25 Mar '22

25 Mar '22

A new version of SUnit was added to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.137.mcz ==================== Summary ==================== Name: SUnit-ct.137 Author: ct Time: 19 January 2022, 11:54:53.214828 pm UUID: dd617d36-ff31-f143-932d-09d1c332f5dc Ancestors: SUnit-ct.136 Revises exception choice in TestCase >> #shouldFix:. It is a bad practice to handle, or even to search for arbitary Exceptions. Many mechanisms signal possibly unhandled "harmless" exceptions and rely on their #defaultAction. This includes accesses to the source files, debugging operations, and many others. The assertion in its current form makes little sense. =============== Diff against SUnit-ct.136 =============== Item was changed: ----- Method: TestCase>>shouldFix: (in category 'asserting - extensions') ----- shouldFix: aBlock + ^self should: aBlock raise: TestResult exError! - ^self should: aBlock raise: Exception!

2 3

The Trunk: Graphics-mt.466.mcz
by commits＠source.squeak.org 25 Mar '22

25 Mar '22

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.466.mcz ==================== Summary ==================== Name: Graphics-mt.466 Author: mt Time: 24 January 2022, 11:24:34.965852 am UUID: d9911a4f-0e24-cc42-9144-457e9ff9960e Ancestors: Graphics-mt.465 Adds a query to check whether a font has fixed-width glyphs. User terminology similar to TextStyle class >> #defaultFixed. =============== Diff against Graphics-mt.465 =============== Item was added: + ----- Method: AbstractFont>>hasFixedWidth (in category 'testing') ----- + hasFixedWidth + "Answer whether the receiver is a monospaced/fixed-width/non-proportional font. See TextStyle class >> #defaultFixed." + + ^ (self widthOf: $.) = (self widthOf: $w)!

3 3

Slightly incorrect implementation of #resignalAs: ??
by mail＠jaromir.net 09 Mar '22

09 Mar '22

Hi all, I think Squeak's implementation of #resignalAs: is not following the ANSI specification precisely. Currently it reads: resignalAs: replacementException signalContext resumeEvaluating: [replacementException signal] ANSI says: " The active exception action is aborted and the exception environment *and the evaluation context* are restored to the same states that were in effect when the receiver was originally signaled. This message (i.e. resignalAs:) causes the replacementException to be treated as if it had been originally signaled instead of the receiver. " This is very similar to #retry (or #retryUsing:) specification so I'd suggest the following implementation: resignalAs: replacementException signalContext restartWithNewReceiver: replacementException The current implementation leads to building the new resignaled contexts on top of the previous signal contexts (and the resignalAs context itself) instead of simply *restarting* the previous signal context with the replacement exception as the new receiver. In my opinion the suggested implementation precisely follows the ANSI specification, and is consistent with current #retry and #retryUsing: implementation - compare: retryUsing: alternativeBlock "Abort an exception handler and evaluate a new block in place of the handler's protected block." handlerContext restartWithNewReceiver: alternativeBlock Other dialects: Pharo and Cuis copied Squeak's but VW implemented resignalAs: to comply with ANSI precisely. One consideration: the current implementation allows "exception resignalAs: Error", i.e. allows Exception class as an argument but ANSI's version requires "exception resignalAs: Error new". All senders (there are just a few) in the base image seem use "Error new" anyway. My arguments for are: consistency, readability and less complexity (especially while debugging) What do you think? Inbox it? best, ~~~ ^[^ Jaromir Sent from Squeak Inbox Talk

4 6

MCMergeBrowser has broken diffs
by Eliot Miranda 28 Feb '22

28 Feb '22

Hi, I'm merging a VMMaker.oscog commit into an image with an experiment in progress. Two methods are hence in conflict. In the MCMergeBrowser these two methods show only the in-image variant, not the diff of the in-image and incoming methods, as was previously (and must be) the case. This is after ========== Update of trunk completed: 21017 -> 21069 ========== _,,,^..^,,,_ best, Eliot

2 4

The Trunk: Collections-ct.972.mcz
by commits＠source.squeak.org 27 Feb '22

27 Feb '22

Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.972.mcz ==================== Summary ==================== Name: Collections-ct.972 Author: ct Time: 27 December 2021, 1:19:57.212181 am UUID: f740e1ad-4410-0745-b615-2986366b7e75 Ancestors: Collections-tonyg.971 Adds PluggableWeakKeyDictionary, the logical combination of PluggableDictionary and WeakKeyDictionary. All methods are copied literally from PluggableDictionary, but the class inherits from WeakKeyDictionary rather than from Dictionary. I do not like all the duplication myself but cannot think of a better solution without using composition (slow, breaking design change) or traits (breaking design change). =============== Diff against Collections-tonyg.971 =============== Item was added: + WeakKeyDictionary subclass: #PluggableWeakKeyDictionary + instanceVariableNames: 'hashBlock equalBlock' + classVariableNames: '' + poolDictionaries: '' + category: 'Collections-Weak'! + + !PluggableWeakKeyDictionary commentStamp: 'ct 12/27/2021 01:07' prior: 0! + I combine the features of PluggableDictionary and WeakKeyDictionary, i.e., clients can supply custom blocks for comparing and hasing my keys, and I hold weakly on my keys.! Item was added: + ----- Method: PluggableWeakKeyDictionary class>>integerDictionary (in category 'instance creation') ----- + integerDictionary + ^ self new hashBlock: [:integer | integer hash \\ 1064164 * 1009]! Item was added: + ----- Method: PluggableWeakKeyDictionary>>= (in category 'comparing') ----- + = anObject + "Two dictionaries are equal if + (a) they are the same 'kind' of thing. + (b) they have the same set of keys. + (c) for each (common) key, they have the same value" + + self == anObject ifTrue: [ ^true ]. + self species == anObject species ifFalse: [ ^false ]. + hashBlock = anObject hashBlock ifFalse: [ ^false ]. + equalBlock = anObject equalBlock ifFalse: [ ^false ]. + self size = anObject size ifFalse: [ ^false ]. + self associationsDo: [ :association | + (anObject at: association key ifAbsent: [ ^false ]) = association value + ifFalse: [ ^false ] ]. + ^true! Item was added: + ----- Method: PluggableWeakKeyDictionary>>collect: (in category 'enumerating') ----- + collect: aBlock + "Evaluate aBlock with each of my values as the argument. Collect the resulting values into a collection that is like me. Answer with the new collection." + + | newCollection | + newCollection := (self species new: self size) + hashBlock: hashBlock; + equalBlock: equalBlock; + yourself. + self associationsDo: [ :each | + newCollection at: each key put: (aBlock value: each value) ]. + ^newCollection + + ! Item was added: + ----- Method: PluggableWeakKeyDictionary>>copyEmpty (in category 'copying') ----- + copyEmpty + + ^super copyEmpty + hashBlock: hashBlock; + equalBlock: equalBlock; + yourself! Item was added: + ----- Method: PluggableWeakKeyDictionary>>equalBlock (in category 'accessing') ----- + equalBlock + "Return the block used for comparing the elements in the receiver." + ^equalBlock! Item was added: + ----- Method: PluggableWeakKeyDictionary>>equalBlock: (in category 'accessing') ----- + equalBlock: aBlock + "Set a new equality block. The block must accept two arguments and return true if the argumets are considered to be equal, false otherwise" + equalBlock := aBlock.! Item was added: + ----- Method: PluggableWeakKeyDictionary>>hashBlock (in category 'accessing') ----- + hashBlock + "Return the block used for hashing the elements in the receiver." + ^hashBlock! Item was added: + ----- Method: PluggableWeakKeyDictionary>>hashBlock: (in category 'accessing') ----- + hashBlock: aBlock + "Set a new hash block. The block must accept one argument and must return the hash value of the given argument." + hashBlock := aBlock.! Item was added: + ----- Method: PluggableWeakKeyDictionary>>scanFor: (in category 'private') ----- + scanFor: anObject + "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + + | index start size | + index := start := (hashBlock + ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. + [ + | element | + ((element := array at: index) == nil or: [ + equalBlock + ifNil: [ element key = anObject ] + ifNotNil: [ equalBlock value: element key value: anObject ] ]) + ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. + self errorNoFreeSpace! Item was added: + ----- Method: PluggableWeakKeyDictionary>>scanForEmptySlotFor: (in category 'private') ----- + scanForEmptySlotFor: anObject + "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + + | index start size | + index := start := (hashBlock + ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. + [ + (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. + self errorNoFreeSpace!

7 12

JSON into Trunk? =)
by Marcel Taeumel 16 Feb '22

16 Feb '22

Hi all! I think it would be nice to have JSON as part of Squeak Trunk. This would make parsing the content of web requests easier. Recently, I got lucky to find the last-modified date in the HTTP header for the public TravisCI badge. But usually, one would have to query the official endpoint/API to then get XML or JSON content. http://www.squeaksource.com/JSON What do you think? The project is + Self-contained + Stable since 2016 + Not that big o Adding the extension #jsonWriteOn: to the system Latest maintainers seem to be: Hannes Hirzel (hjh, 2010) Levente Uzonyi (ul, 2010) Tony Garnock-Jones (tonyg, 2016) Fabio Niephaus (FabN, 2016) Best, Marcel

10 19

The Trunk: Morphic-mt.1860.mcz
by commits＠source.squeak.org 07 Feb '22

07 Feb '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1860.mcz ==================== Summary ==================== Name: Morphic-mt.1860 Author: mt Time: 27 January 2022, 12:08:10.671541 pm UUID: 1e06e708-c328-da42-9f3d-a8cbc99ea089 Ancestors: Morphic-mt.1859 Tweaks Morphic-mt.1859 a little bit more to preserve *all* custom window titles when changing UI themes or scale factors. =============== Diff against Morphic-mt.1859 =============== Item was changed: ----- Method: StringMorph>>acceptContents (in category 'editing') ----- acceptContents "The message is sent when the user hits enter or Cmd-S. Accept the current contents and end editing. This default implementation updates the model's known window title for pluggable windows." self containingWindow ifNotNil: [:wnd | + wnd setLabel: self contents. "Needed for models that do not accept changes." (wnd respondsTo: #getLabelSelector) ifTrue: [ wnd getLabelSelector ifNotNil: [:selector | | mutator | mutator := selector asSimpleSetter. (wnd model respondsTo: mutator) ifTrue: [ wnd model perform: mutator with: self contents]]]]! Item was changed: + (PackageInfo named: 'Morphic') postscript: '"Fixes custom edits that were not propagated properly to pluggable windows." + StringMorph allInstances do: [:ea | ea acceptContents].'! - (PackageInfo named: 'Morphic') postscript: '"Fix missing command key shortcuts such as [cmd]+[+/-] for scale changes." - Project allMorphicProjects do: [:p | p world initializeDesktopCommandKeySelectors]. - - "New ''scale factor'' menu" - TheWorldMainDockingBar updateInstances. - - "Enable ''Enclose selection with brackets'' by default (Morphic-mt.1812)" - TextEditor encloseSelection: true.'!

4 3

← Newer
1
...
4
5
6
7
8
9
10
...
37
Older →

Jump to page: