Squeak-dev June 2022

squeak-dev@lists.squeakfoundation.org

30 participants
310 discussions

The Trunk: ShoutCore-mt.93.mcz
by commits＠source.squeak.org 09 Jun '22

09 Jun '22

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-mt.93.mcz ==================== Summary ==================== Name: ShoutCore-mt.93 Author: mt Time: 9 June 2022, 9:34:19.330903 am UUID: 725e14cd-29ba-5e44-8900-9adde5eba497 Ancestors: ShoutCore-mt.92 Fixes preferences for Shout assignment conversion. You can only enable one or the other. =============== Diff against ShoutCore-mt.92 =============== Item was changed: ----- Method: SHTextStylerST80 class>>syntaxHighlightingAsYouTypeAnsiAssignment: (in category 'preferences') ----- + syntaxHighlightingAsYouTypeAnsiAssignment: aBooleanOrNil + + SyntaxHighlightingAsYouTypeAnsiAssignment := aBooleanOrNil. + + aBooleanOrNil == true + ifTrue: [SyntaxHighlightingAsYouTypeLeftArrowAssignment := false].! - syntaxHighlightingAsYouTypeAnsiAssignment: aBoolean - SyntaxHighlightingAsYouTypeAnsiAssignment := aBoolean.! Item was changed: ----- Method: SHTextStylerST80 class>>syntaxHighlightingAsYouTypeLeftArrowAssignment (in category 'preferences') ----- syntaxHighlightingAsYouTypeLeftArrowAssignment <preference: 'syntaxHighlightingAsYouTypeLeftArrowAssignment' category: 'browsing' description: 'If true, and syntaxHighlightingAsYouType is enabled, all ANSI format assignments ( := ) will be converted to left arrows ( _ ) when a method is selected in a Browser. Whilst editing a method, this setting has no effect - both the left arrow and the ansi format may be used.' type: #Boolean> + ^SyntaxHighlightingAsYouTypeLeftArrowAssignment ifNil: [false]! - ^SyntaxHighlightingAsYouTypeLeftArrowAssignment ifNil: [true]! Item was changed: ----- Method: SHTextStylerST80 class>>syntaxHighlightingAsYouTypeLeftArrowAssignment: (in category 'preferences') ----- + syntaxHighlightingAsYouTypeLeftArrowAssignment: aBooleanOrNil + + SyntaxHighlightingAsYouTypeLeftArrowAssignment := aBooleanOrNil. + + aBooleanOrNil == true + ifTrue: [SyntaxHighlightingAsYouTypeAnsiAssignment := false].! - syntaxHighlightingAsYouTypeLeftArrowAssignment: aBoolean - SyntaxHighlightingAsYouTypeLeftArrowAssignment := aBoolean.!

1 0

The Trunk: MorphicTests-mt.87.mcz
by commits＠source.squeak.org 09 Jun '22

09 Jun '22

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.87.mcz ==================== Summary ==================== Name: MorphicTests-mt.87 Author: mt Time: 8 June 2022, 3:02:18.474335 pm UUID: 4c18dae8-f267-4c41-a3d4-7027c7a964cd Ancestors: MorphicTests-mt.86 Fixes several tests that only fail if the system uses (pre-rendered) StrikeFonts, which is 100%, 125%, or 150% scale factor in a clean image. =============== Diff against MorphicTests-mt.86 =============== Item was changed: ----- Method: TextAnchorTest>>testHavingAnAnchorInTheCenter (in category 'tests') ----- testHavingAnAnchorInTheCenter self assert: (anchoredMorph ownerChain includes: textMorph); + assert: anchoredMorph topLeft >= textMorph topLeft! - assert: anchoredMorph topLeft > textMorph topLeft! Item was changed: ----- Method: TextAnchorTest>>testHavingAnAnchorInTheCenterWithHorizontalPadding (in category 'tests') ----- testHavingAnAnchorInTheCenterWithHorizontalPadding anchoredMorph textAnchorProperties padding. 30@0. self assert: (anchoredMorph ownerChain includes: textMorph); + assert: (anchoredMorph topLeft >= textMorph topLeft)! - assert: (anchoredMorph topLeft > textMorph topLeft)! Item was changed: ----- Method: TextAnchorTest>>testLayoutingSetsTheMorphPosition (in category 'tests') ----- testLayoutingSetsTheMorphPosition anchoredMorph := Morph new. anchoredMorph textAnchorProperties anchorLayout: #inline. anchorAttribute anchoredMorph: anchoredMorph. self prepareTextMorph. textMorph position: 100@100. + self assert: anchoredMorph position >= (100@100).! - self assert: anchoredMorph position > (100@100).!

3 2

a Pages template in Blue Book style?
by Craig Latta 09 Jun '22

09 Jun '22

Hi all-- Does anyone happen to have a macOS Pages template that emulates the layout style of the Blue Book? I'm writing a chapter on Epigram, a parser framework I wrote, and I think it'd be cute to make it look like a Blue Book chapter. thanks! -C -- Craig Latta :: research computer scientist Black Page Digital :: Berkeley, California 663137D7940BF5C0AFC :: 1349FB2ADA32C4D5314CE

1 0

Fixing a terminate bug
by Jaromir Matas 08 Jun '22

08 Jun '22

Hi Marcel, Could you please merge Kernel-jar.1478 fixing a silly bug I missed; while searching for a context that cannot return (to avoid the VM crash after BCR error) I forgot to limit the search to the relevant part of the stack only (i.e. search only between the contexts to be executed). As a result the following example currently fails to unwind: p := [[[^2] on: BlockCannotReturn do: [Semaphore new wait]] ensure: [Transcript show: 'been here ']] fork. Processor yield. [p terminate] fork Plus a minor change to allow unwinding even in this case (starts searching again right below the cannot return context in case one is found): p := [[] ensure: [[[^2] on: BlockCannotReturn do: [Semaphore new wait]] ensure: [Transcript show: 'been here ']]] fork. Processor yield. [p terminate] fork Thanks very much. best, Jaromir -- Jaromír Matas mail(a)jaromir.net

1 0

The Inbox: Kernel-jar.1478.mcz
by commits＠source.squeak.org 08 Jun '22

08 Jun '22

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-jar.1478.mcz ==================== Summary ==================== Name: Kernel-jar.1478 Author: jar Time: 8 June 2022, 11:16:07.949882 pm UUID: f5720d99-9ce2-374c-adb0-811c23b2cfe5 Ancestors: Kernel-jar.1477 Fix a bug in #runUntilReturnFrom:: while searching for a context that cannot return (to avoid the VM crash) I forgot to limit the search to the relevant part of the stack only (i.e. search only *between* the contexts to be executed). As a result the following example currently fails to unwind: p := [[[^2] on: BlockCannotReturn do: [Semaphore new wait]] ensure: [Transcript show: 'been here ']] fork. Processor yield. [p terminate] fork Plus a minor change to allow unwinding even in this case: p := [[] ensure: [[[^2] on: BlockCannotReturn do: [Semaphore new wait]] ensure: [Transcript show: 'been here ']]] fork. Processor yield. [p terminate] fork A test will follow later. =============== Diff against Kernel-jar.1477 =============== Item was changed: ----- Method: Context>>runUntilReturnFrom: (in category 'private-exceptions') ----- runUntilReturnFrom: aContext "Run the receiver (which must be its stack top context) until aContext returns. Avoid a context that cannot return. Note: to avoid infinite recursion of MNU error inside unwind blocks, implement e.g. a wrapper around the message sentTo: receiver in #doesNotUnderstand:. Note: This method is a trivialized version of #runUntilErrorOrReturnFrom: and was intended to be used by #unwindTo as a helper method to unwind non-local returns inside unwind blocks." | here unwindBottom newTop | here := thisContext. + "Avoid a context that cannot return between self and aContext (see Note 1 below)." + unwindBottom := self findContextSuchThat: [:ctx | ctx == aContext or: [ctx selector = #cannotReturn:]]. + newTop := unwindBottom sender. - "Avoid a context that cannot return (see Note 1 below)" - unwindBottom := (self findContextSuchThat: [:ctx | ctx selector = #cannotReturn:]) ifNil: [aContext]. - newTop := aContext sender. "Insert ensure context under unwindBottom in self's stack (see Note 2 below)" unwindBottom insertSender: (Context contextEnsure: [here jump]). self jump. "Control jumps to the receiver's stack (see Note 2 below)" "Control resumes here once the above inserted ensure block is executed (see #jump comments)" ^newTop "Return the new top context (see Note 3 below)" "Note 1: returning from #cannotReturn's sender would crash the VM so we install a guard ensure context right above it; after returning here the unwind will continue safely. Try running and debugging this example (avoid Proceeding the BCR error though; it may indeed crash the image): [[[] ensure: [^2]] ensure: [^42]] fork" "Note 2: the receiver (self) is run by jumping directly to it (the active process abandons thisContext and executes self on its own stack; self must be its top context). However, before jumping to self we insert an ensure block under unwindBottom context that will execute a jump back to thisContext when evaluated. The inserted guard ensure context is removed once control jumps back to thisContext." "Note 3: it doesn't matter newTop is not a proper stack top context because #unwindTo will only use it as a starting point in the search for the next unwind context and the computation will never return here. We could make newTop a proper top context by pushing nil to its stack (^newTop push: nil) if need be (see #jump comments). Cf. the pattern in #runUntilErrorOrReturnFrom:: removing the inserted ensure context by stepping until popped when executing non-local returns wouldn't work here and would fail tests testTerminateInNestedEnsureWithReturn1 through 4."!

1 0

Cmd-Shift-9 not working on macOS, in 6.0alpha or 6.0beta
by Tim Johnson 08 Jun '22

08 Jun '22

Hi all, (starting a new thread on this topic) Cmd-Shift-9 used to work on macOS (as recently as 5.3 and possibly as early as Mac 68k VMs?) to enclose the selection in parentheses. I cannot get it to work in 6.0alpha or 6.0beta on macOS under any circumstance. Here is a video of this happening, with "legacy keyboard shortcuts" enabled in the startup configuration wizard: https://youtu.be/BpHonqv3THM The video shows an M1 Mac running macOS 12.4. I can also reproduce this on a Core i5 MacBook Air running 10.13.6. Note that I cannot get Cmd-Shift-9 to work with 'legacy keyboard shortcuts' enabled /or/ disabled. In other words: Cmd-Shift-9 doesn't work if I skip the configuration wizard (accepting defaults), nor does it work if I explicitly enable 'legacy keyboard shortcuts' in the configuration wizard. I am on a US keyboard. Perhaps related: another difference between 5.3 and 6.0beta is in Cmd-9 (without Shift held). On 5.3, Cmd-9 seems to decrease the font kerning so the letters become closer together. On 6.0beta, Cmd-9 underlines text. Is it possible that this change is related to Cmd-Shift-9 no longer working? (Was there some brave & necessary unraveling & reimagining of various layers of keyboard shortcuts over the 6.0 development cycle...?) Thanks, Tim J PS — I bring this up because no one has explicitly said that Cmd-Shift-9 is gone forever. Sounds like it is expected to still be possible to use this shortcut...? But if it is gone and won't come back, please, tell me, and I will light a candle for it. I may find it challenging to adapt to the new mechanism, because pressing a visible character, with no modifiers held, while text is selected, has a long history of replacing the selected text. But challenges make us stronger, and Squeak is the most flexible system...

3 7

The Trunk: SUnitGUI-ct.92.mcz
by commits＠source.squeak.org 08 Jun '22

08 Jun '22

Christoph Thiede uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-ct.92.mcz ==================== Summary ==================== Name: SUnitGUI-ct.92 Author: ct Time: 8 June 2022, 4:45:47.033837 pm UUID: 860f8009-e951-3b4d-bdc6-4968e88dc980 Ancestors: SUnitGUI-mt.91 Avoids redundant information ('No methods found for coverage analysis.') when canceling the package selection dialog in the TestRunner after pressing "Run Coverage". Also improves multilingual support and migrates to new UIManager entrypoint. =============== Diff against SUnitGUI-mt.91 =============== Item was changed: ----- Method: TestRunner>>promptForPackages (in category 'actions') ----- promptForPackages + | packages selectedPackage | - | packages | packages := (PackageOrganizer default packages reject: [:package | (package packageName beginsWith: 'Kernel') or: [(package packageName beginsWith: 'Collections') or: [(package packageName beginsWith: 'Exceptions') or: [(package packageName beginsWith: 'SUnit') or: [(package packageName beginsWith: 'System') or: [package packageName includesSubstring: 'Test' caseSensitive: false]]]]]]) sort: [:a :b | a packageName < b packageName]. + selectedPackage := Project uiManager + chooseFrom: (packages collect: [:package | package packageName]) + values: packages + title: 'Select Package' translated. + selectedPackage ifNil: [^ nil]. + packages := Array with: selectedPackage. - packages := Array - with: (UIManager default - chooseFrom: (packages - collect: [:package | package packageName]) - values: packages - title: 'Select Package'). ^ packages! Item was changed: ----- Method: TestRunner>>runCoverage (in category 'actions') ----- runCoverage | packages methods | packages := Set new. self addDeclaredPackagesUnderTestTo: packages. packages isEmpty ifTrue: + [ packages := self promptForPackages ifNil: [^ self] ]. - [ packages := self promptForPackages ]. methods := OrderedCollection new. self addMethodsUnderTestIn: packages to: methods. self excludeClassesNotUnderTestFrom: methods. methods isEmpty ifTrue: + [ ^ Project uiManager inform: 'No methods found for coverage analysis.' translated ]. + self collectCoverageFor: methods.! - [ ^ UIManager default inform: 'No methods found for coverage analysis.' ]. - self collectCoverageFor: methods - !

1 0

The Inbox: Kernel-ct.1473.mcz
by commits＠source.squeak.org 08 Jun '22

08 Jun '22

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1473.mcz ==================== Summary ==================== Name: Kernel-ct.1473 Author: ct Time: 8 June 2022, 4:39:38.360847 pm UUID: 57a482be-2fe9-6348-afd2-7419546cebe5 Ancestors: Kernel-mt.1472 Aligns error code of simulated primitive 100 (primitivePerformInSuperclass) to the behavior of the latest released VM (2022.06). Fixes ContextTest>>#testPrimitive100. Inbox because I do not know whether the change on the VM side was intentional. =============== Diff against Kernel-mt.1472 =============== Item was changed: ----- Method: Context>>doPrimitive:method:receiver:args: (in category 'private') ----- doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and arguments are given as arguments to this message. If successful, push result and return resuming context, else ^ {errCode, PrimitiveFailToken}. Any primitive which provokes execution needs to be intercepted and simulated to avoid execution running away." | value | "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. Hence use primitive 19 with care :-)" "SystemNavigation new browseAllSelect: [:m| m primitive = 19]" primitiveIndex = 19 ifTrue: [ [self notify: ('The code being simulated is trying to control a process ({1}). Process controlling cannot be simulated. If you proceed, things may happen outside the observable area of the simulator.' translated format: {meth reference})] ifCurtailed: [self push: nil "Cheap fix of the context's internal state"]]. ((primitiveIndex between: 201 and: 222) and: [(self objectClass: receiver) includesBehavior: BlockClosure]) ifTrue: [(primitiveIndex = 206 or: [primitiveIndex = 208]) ifTrue: "[Full]BlockClosure>>valueWithArguments:" [^receiver simulateValueWithArguments: arguments first caller: self]. ((primitiveIndex between: 201 and: 209) "[Full]BlockClosure>>value[:value:...]" or: [primitiveIndex between: 221 and: 222]) ifTrue: "[Full]BlockClosure>>valueNoContextSwitch[:]" [^receiver simulateValueWithArguments: arguments caller: self]]. primitiveIndex = 83 ifTrue: "afr 9/11/1998 19:50" "Object>>perform:[with:...]" [| selector | selector := arguments at: 1 ifAbsent: [^ self class primitiveFailTokenFor: #'bad argument']. arguments size - 1 = selector numArgs ifFalse: [^ self class primitiveFailTokenFor: #'bad number of arguments']. ^self send: selector to: receiver with: arguments allButFirst]. primitiveIndex = 84 ifTrue: "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:" [| selector args | arguments size = 2 ifFalse: [^ self class primitiveFailTokenFor: #'bad argument']. selector := arguments first. args := arguments second. args isArray ifFalse: [^ self class primitiveFailTokenFor: #'bad argument']. args size = selector numArgs ifFalse: [^ self class primitiveFailTokenFor: #'bad number of arguments']. ^self send: selector to: receiver with: args]. primitiveIndex = 100 ifTrue: "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:" [| rcvr selector args superclass | arguments size caseOf: { [3] -> [ rcvr := receiver. selector := arguments first. args := arguments second. superclass := arguments third]. [4] -> ["mirror primitive" rcvr := arguments first. selector := arguments second. args := arguments third. superclass := arguments fourth] } + otherwise: [^ self class primitiveFailTokenFor: #'bad number of arguments']. - otherwise: [^ self class primitiveFailTokenFor: #'bad argument']. args isArray ifFalse: [^ self class primitiveFailTokenFor: #'bad argument']. args size = selector numArgs ifFalse: [^ self class primitiveFailTokenFor: #'bad number of arguments']. ((self objectClass: rcvr) includesBehavior: superclass) ifFalse: [^ self class primitiveFailTokenFor: #'bad argument']. ^self send: selector to: rcvr with: args lookupIn: superclass]. "Mutex>>primitiveEnterCriticalSection Mutex>>primitiveTestAndSetOwnershipOfCriticalSection" (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue: [| effective | effective := Processor activeProcess effectiveProcess. "active == effective" value := primitiveIndex = 186 ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective] ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]]. primitiveIndex = 188 ifTrue: "Object>>withArgs:executeMethod: CompiledMethod class>>receiver:withArguments:executeMethod: VMMirror>>ifFail:object:with:executeMethod: et al" [| n args methodArg thisReceiver | ((n := arguments size) between: 2 and: 4) ifFalse: [^self class primitiveFailTokenFor: #'unsupported operation']. ((self objectClass: (args := arguments at: n - 1)) == Array and: [(self objectClass: (methodArg := arguments at: n)) includesBehavior: CompiledMethod]) ifFalse: [^self class primitiveFailTokenFor: #'bad argument']. methodArg numArgs = args size ifFalse: [^self class primitiveFailTokenFor: #'bad number of arguments']. thisReceiver := arguments at: n - 2 ifAbsent: [receiver]. methodArg primitive > 0 ifTrue: [methodArg isQuick ifTrue: [^self push: (methodArg valueWithReceiver: thisReceiver arguments: args)]. ^self doPrimitive: methodArg primitive method: meth receiver: thisReceiver args: args]. ^self activateMethod: methodArg withArgs: args receiver: thisReceiver]. primitiveIndex = 118 ifTrue: "[receiver:]tryPrimitive:withArgs:; avoid recursing in the VM" [(arguments size = 3 and: [(self objectClass: arguments second) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifTrue: [^self doPrimitive: arguments second method: meth receiver: arguments first args: arguments last]. (arguments size = 2 and: [(self objectClass: arguments first) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifFalse: [^self class primitiveFailTokenFor: nil]. ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last]. value := primitiveIndex = 120 "FFI method" ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments] ifFalse: [primitiveIndex = 117 "named primitives" ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments] ifFalse: "should use self receiver: receiver tryPrimitive: primitiveIndex withArgs: arguments but this is only in later VMs (and appears to be broken)" [receiver tryPrimitive: primitiveIndex withArgs: arguments]]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]!

1 0

The Trunk: Regex-Tests-Core-mt.17.mcz
by commits＠source.squeak.org 08 Jun '22

08 Jun '22

Marcel Taeumel uploaded a new version of Regex-Tests-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Tests-Core-mt.17.mcz ==================== Summary ==================== Name: Regex-Tests-Core-mt.17 Author: mt Time: 8 June 2022, 3:03:39.152335 pm UUID: ef50d700-95f4-8f4b-9779-b64ab4635f9e Ancestors: Regex-Tests-Core-mt.16 Let the test #testOptionalLookbehind2 be an expected failure for the next release. =============== Diff against Regex-Tests-Core-mt.16 =============== Item was added: + ----- Method: RxParserTest>>expectedFailures (in category 'failures') ----- + expectedFailures + + ^ #(testOptionalLookbehind2)!

1 0

The Trunk: GraphicsTests-mt.60.mcz
by commits＠source.squeak.org 08 Jun '22

08 Jun '22

Marcel Taeumel uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-mt.60.mcz ==================== Summary ==================== Name: GraphicsTests-mt.60 Author: mt Time: 8 June 2022, 2:51:46.704335 pm UUID: 9f9183cf-e64b-424d-bd3e-292e80ad7c68 Ancestors: GraphicsTests-mt.59 Complements Graphics-mt.520. =============== Diff against GraphicsTests-mt.59 =============== Item was added: + ----- Method: RectangleTest>>testContainsPoint (in category 'tests') ----- + testContainsPoint + + | r | + r := Rectangle origin: 0@0 extent: 50@50. + + { + r center . true . + 1.5(a)1.5 . true . + + r topLeft . true . + r topRight . false . "!!!!!!" + r bottomLeft . false . "!!!!!!" + r bottomRight . false . "!!!!!!" + + } groupsDo: [ :point :result | + self assert: (r containsPoint: point) = result].! Item was changed: ----- Method: RectangleTest>>testPointAtFraction (in category 'tests') ----- testPointAtFraction | r | r := Rectangle origin: 0@0 extent: 50@50. { r topLeft . 0.0 @ 0.0 . r center . 0.5 @ 0.5 . - r bottomRight . 1.0 @ 1.0 . 5@5 . 0.1 @ 0.1 . + 40@50 . 0.8 @ 1.0 . - 40@50 . 0.8 @ 1.0 + r bottomRight . 1.0 @ 1.0 . + 49@49 . 0.99 @ 0.99 . + } groupsDo: [ :expected :fraction | self assert: expected equals: (r pointAtFraction: fraction)].! Item was changed: ----- Method: RectangleTest>>testRandomPoint (in category 'tests') ----- testRandomPoint + | r pt | - | r | r := Rectangle origin: 0@0 extent: 50@50. + pt := r randomPoint. + self + assert: (r containsPoint: pt) + description: ('{1} is not in rectangle {2}' format: {pt. r}); + assert: pt isIntegerPoint + description: ('{1} is not an integer point' format: {pt}).! - self assert: (r containsPoint: r randomPoint). - self assert: r randomPoint isIntegerPoint.!

1 0

← Newer
1
...
23
24
25
26
27
28
29
30
31
Older →

Jump to page: