Squeak-dev December 2023

squeak-dev@lists.squeakfoundation.org

26 participants
124 discussions

simplifying debugger/error handler invocation
by Eliot Miranda 20 Dec '23

20 Dec '23

Hi Jaromir, Hi All, in trying to pass the exception raising an error to the debugger (so that it can highlight the relevant return expression) I'm running into the clumsy plumbing from errors to debuggers, i.e. debugProcess:context:label:contents:fullView:, debugWithTitle:full:contents:, debugException:, debugContext:title:full:contents: et al. I think we urgently need to do to this interface what Colin Putney did to the compiler, introducing CompilerCue to hold all the state, including optional state, for a compilation invocation. We need ErrorHandlerCue, or DebuggerCue, or some such. It can take all the parameters of the above, plus any extras we want to add, and then we can reduce the above selectors to handleErrorCue: anErrorCue or handleDebuggerCue: aDebuggerCue and then easily add additional state, such as the exception, to handlers such as the debugger. Anybody willing to pick up that bucket of whitewash and paint the fence? _,,,^..^,,,_ best, Eliot

3 10

The Trunk: Compiler-mt.495.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-mt.495.mcz ==================== Summary ==================== Name: Compiler-mt.495 Author: mt Time: 20 December 2023, 1:53:28.567841 pm UUID: d96817bb-bd88-6343-9ac8-4a90e8f1c6a0 Ancestors: Compiler-mt.494 Mark old way of scanning for implicit literals #deprecated. We now have ImplicitLiteralFinder. See #implicitLiteralsDo:. =============== Diff against Compiler-mt.494 =============== Item was changed: ----- Method: BytecodeEncoder class>>scanBlockOrNilForLiteral: (in category 'scanning') ----- scanBlockOrNilForLiteral: aLiteral "Answer a block argument for CompiledMethod>>#scanFor: that answers if the method refers to the literal implicitly via a special bytecode. If the literal is not accessible via a special bytecode, answer nil. Subclasses override as appropriate" + self flag: #deprecated. "mt: Use CompiledCode>>#implicitLiteralsDo:." ^nil! Item was changed: ----- Method: EncoderForSistaV1 class>>scanBlockOrNilForLiteral: (in category 'scanning') ----- scanBlockOrNilForLiteral: aLiteral "Answer a block argument for CompiledMethod>>#scanFor: that answers if the method refers to the literal implicitly via a special bytecode. If the literal is not accessible via a special bytecode, answer nil." | value hi lo unextended | "96-111 0110 iiii Send Arithmetic Message #iiii (+ - < > <= >= = ~= * / \\ @ bitShift: // bitAnd: bitOr:) 112-119 01110 iii Send Special Message #iii + 0 (at: at:put: size next nextPut: atEnd == class)" + self flag: #deprecated. "mt: Use CompiledCode>>#implicitLiteralsDo:." aLiteral isSymbol ifTrue: [value := 96 + ((Smalltalk specialSelectors indexOf: aLiteral ifAbsent: [^nil]) // 2). ^[:byte| byte = value]]. "80 01010000 Push 0 81 01010001 Push 1 232 11101000 iiiiiiii Push Integer #iiiiiiii (+ Extend B * 256, where bbbbbbbb = sddddddd, e.g. -32768 = i=0, d=0, s=1)" aLiteral isInteger ifTrue: [aLiteral >= 0 ifTrue: [aLiteral <= 1 ifTrue: [value := aLiteral + 80. ^[:byte| byte = value]]. aLiteral <= 255 ifTrue: [unextended := true. "Don't be fooled by extended cases with the same least significant byte!!" ^[:b1 :b2| | found | found := b1 = 232 and: [b2 = aLiteral and: [unextended]]. unextended := b1 ~= 16rE1. found]]]. (aLiteral between: -32768 and: 32767) ifFalse: [^nil]. lo := aLiteral bitAnd: 255. hi := (aLiteral bitShift: -8) bitAnd: 255. ^[:b1 :b2 :b3 :b4| b1 = 16rE1 and: [b2 = hi and: [b3 = 232 and: [b4 = lo]]]]]. "233 11101001 iiiiiiii Push Character #iiiiiiii (+ Extend B * 256)" aLiteral isCharacter ifTrue: [(value := aLiteral asInteger) <= 255 ifTrue: [unextended := true. "Don't be fooled by extended cases with the same least significant byte!!" ^[:b1 :b2| | found | found := b1 = 233 and: [b2 = value and: [unextended]]. unextended := b1 ~= 16rE1. found]]. ^value <= 65535 ifTrue: [lo := value bitAnd: 255. hi := (value bitShift: -8) bitAnd: 255. [:b1 :b2 :b3 :b4| b1 = 16rE1 and: [b2 = hi and: [b3 = 233 and: [b4 = lo]]]]]]. "77 01001101 Push true 78 01001110 Push false 79 01001111 Push nil 88-91 010110 ii Return Receiver/true/false/nil 93 01011101 BlockReturn nil" aLiteral == true ifTrue: [^[:byte| byte = 77 or: [byte = 89]]]. aLiteral == false ifTrue: [^[:byte| byte = 78 or: [byte = 90]]]. aLiteral == nil ifTrue: [^[:byte| byte = 79 or: [byte = 91 or: [byte = 93]]]]. ^nil! Item was changed: ----- Method: EncoderForV3 class>>scanBlockOrNilForLiteral: (in category 'scanning') ----- scanBlockOrNilForLiteral: aLiteral "Answer a block argument for CompiledMethod>>#scanFor: that answers if the method refers to the literal implicitly via a special bytecode. If the literal is not accessible via a special bytecode, answer nil." | value | "176-191 1011iiii Send Arithmetic Message #iiii 192-207 1100iiii Send Special Message #iiii" + self flag: #deprecated. "mt: Use CompiledCode>>#implicitLiteralsDo:." (aLiteral isSymbol or: [aLiteral isInteger]) ifTrue: [value := aLiteral isSymbol ifTrue: [176 + ((Smalltalk specialSelectors indexOf: aLiteral ifAbsent: [^nil]) // 2)] ifFalse: [(aLiteral between: -1 and: 2) ifFalse: [^nil]. aLiteral + 117]. ^[:byte| byte = value]]. "112-119 01110iii Push (receiver, true, false, nil, -1, 0, 1, 2) [iii] 120-123 011110ii Return (receiver, true, false, nil) [ii] From Message" aLiteral == true ifTrue: [^[:byte| byte = 113 or: [byte = 121]]]. aLiteral == false ifTrue: [^[:byte| byte = 114 or: [byte = 122]]]. aLiteral == nil ifTrue: [^[:byte| byte = 115 or: [byte = 123]]]. ^nil!

1 0

The Trunk: Kernel-mt.1544.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1544.mcz ==================== Summary ==================== Name: Kernel-mt.1544 Author: mt Time: 20 December 2023, 1:53:02.779841 pm UUID: 83d31486-6cba-694f-8c75-ff41d8d10629 Ancestors: Kernel-mt.1543 Mark old way of scanning for implicit literals #deprecated. We now have ImplicitLiteralFinder. See #implicitLiteralsDo:. =============== Diff against Kernel-mt.1543 =============== Item was changed: ----- Method: CompiledCode class>>scanBlocksForLiteral:do: (in category 'scanning') ----- scanBlocksForLiteral: aLiteral do: aBinaryBlock "Evaluate aBinaryBlock with the literal scanners for aLiteral (which will be nil if there are no special bytecodes that access aLiteral), and answer its value." + + self flag: #deprecated. "mt: Use #implicitLiteralsDo:." ^aBinaryBlock value: (PrimaryBytecodeSetEncoderClass scanBlockOrNilForLiteral: aLiteral) value: (SecondaryBytecodeSetEncoderClass scanBlockOrNilForLiteral: aLiteral)!

1 0

Squeak 6.0: Kernel-mt.1488.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Kernel to project Squeak 6.0: http://source.squeak.org/squeak60/Kernel-mt.1488.mcz ==================== Summary ==================== Name: Kernel-mt.1488 Author: mt Time: 20 December 2023, 1:44:51.484382 pm UUID: ac4344ba-6951-d84e-a6cf-5833401cad15 Ancestors: Kernel-mt.1487 Fixes #literalsDo: performance (2 of 2). =============== Diff against Kernel-mt.1487 =============== Item was changed: ----- Method: CompiledCode>>allLiteralsDo: (in category 'literals') ----- allLiteralsDo: aBlock + "Overwritten to really enumerate all literals. Also the implicit ones." - "Enumerate all literals thoroughly. Follow nested instances of CompiledCode. Do not treat compiled code as literals here." + self + allLiteralsDo: aBlock + scanForSpecial: true.! - self codeLiteralsDo: - [:compiledCode | - compiledCode literalsDo: - [:literal | - literal isCompiledCode ifFalse: - [literal allLiteralsDo: aBlock]]. - compiledCode implicitLiteralsDo: aBlock]! Item was removed: - ----- Method: CompiledCode>>hasLiteral:scanForSpecial: (in category 'literals') ----- - hasLiteral: aLiteral scanForSpecial: aBoolean - "Like #hasLiteral: but can scan for encoder-specific special literals. Not that scanning has a noticeable performance impact." - - | scanBlock | - (super hasLiteral: aLiteral) ifTrue: [^ true]. - - aBoolean ifFalse: [^ false]. - - scanBlock := self class - scanBlocksForLiteral: aLiteral - do: [:primaryScanner :secondaryScanner | - "E.g., scanner for SistaV1 or scanner for V3PlusClosures" - self signFlag ifTrue: [secondaryScanner] ifFalse: [primaryScanner]]. - - self codeLiteralsDo: [:compiledCode | - (compiledCode scanFor: scanBlock) ifTrue: [^ true]]. - - ^ false! Item was removed: - ----- Method: CompiledMethod>>allLiteralsDo: (in category 'literals') ----- - allLiteralsDo: aBlock - "Overwritten to skip certain (raw) literals." - - " Exclude method selector (or properties) and the method's class." - 1 to: self numLiterals - 2 do: [:index | - (self literalAt: index) allLiteralsDo: aBlock]. - - "Enumerate the implicit literals in bytecodes of the receiver." - self implicitLiteralsDo: aBlock. - - "Enumerate method selector only through additional method state." - self penultimateLiteral isMethodProperties - ifTrue: [self penultimateLiteral allLiteralsDo: aBlock]! Item was added: + ----- Method: CompiledMethod>>allLiteralsDo:scanForSpecial: (in category 'literals') ----- + allLiteralsDo: aBlock scanForSpecial: aBoolean + "Overwritten to skip certain (raw) literals." + + "Exclude method selector (or properties) and the method's class. Include code literals." + 1 to: self numLiterals - 2 do: [:index | + (self literalAt: index) allLiteralsDo: aBlock scanForSpecial: aBoolean]. + + "Enumerate the implicit literals in bytecodes of the receiver." + aBoolean ifTrue: [self implicitLiteralsDo: aBlock]. + + "Enumerate method selector only through additional method state." + self penultimateLiteral isMethodProperties + ifTrue: [self penultimateLiteral allLiteralsDo: aBlock scanForSpecial: aBoolean]! Item was changed: ----- Method: Object>>allLiteralsDo: (in category 'literals') ----- allLiteralsDo: aBlock + "Enumerate all literals in the receiver. Note that subclasses may override this to expose the literals they hold such as Array or Pragma. Also note that CompiledCode, being the typical entry point for such an operation, will rather call #allLiteralsDo:#scanForSpecial: on all code literals (and regular literals) to avoid expensive byte-code scanning if possible." self flag: #discuss. "mt: Better implement this only on Symbol, Array, Number, Binding, etc. instead of Object?" aBlock value: self.! Item was changed: ----- Method: Object>>hasLiteral: (in category 'literals') ----- hasLiteral: literal + ^ self + hasLiteralSuchThat: [:lit | lit literalEqual: literal] + scanForSpecial: (BytecodeEncoder canBeSpecialLiteral: literal)! - ^ self hasLiteralSuchThat: [:lit | lit literalEqual: literal]! Item was changed: ----- Method: Object>>hasLiteralSuchThat: (in category 'literals') ----- hasLiteralSuchThat: testBlock + "Also see #hasLiteral:. Do not scan for implicit (i.e. special) literals by default to get a faster response." + ^ self hasLiteralSuchThat: testBlock scanForSpecial: false! - self allLiteralsDo: [:literal | - (testBlock value: literal) ifTrue: [^ true]]. - - ^ false!

1 0

Squeak 6.0: Kernel-mt.1487.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Kernel to project Squeak 6.0: http://source.squeak.org/squeak60/Kernel-mt.1487.mcz ==================== Summary ==================== Name: Kernel-mt.1487 Author: mt Time: 20 December 2023, 1:43:23.900382 pm UUID: 652050d7-eb35-b04a-a73a-233abf0008e4 Ancestors: Kernel-mt.1486 Fixes #literalsDo: performance (1 of 2). =============== Diff against Kernel-mt.1486 =============== Item was added: + ----- Method: CompiledCode>>allImplicitLiteralsDo: (in category 'literals') ----- + allImplicitLiteralsDo: aBlock + + self codeLiteralsDo: [:compiledCode | + compiledCode implicitLiteralsDo: aBlock].! Item was added: + ----- Method: CompiledCode>>allLiteralsDo:scanForSpecial: (in category 'literals') ----- + allLiteralsDo: aBlock scanForSpecial: aBoolean + "Enumerate all literals thoroughly. Follow nested instances of CompiledCode. Do not treat compiled code as literals here." + + self codeLiteralsDo: [:compiledCode | + compiledCode literalsDo: [:literal | + literal isCompiledCode ifFalse: [literal allLiteralsDo: aBlock scanForSpecial: aBoolean] ]. + aBoolean ifTrue: [ "Enumerate special selectors/literals such as true/false." + compiledCode implicitLiteralsDo: aBlock] ].! Item was added: + ----- Method: CompiledCode>>hasImplicitLiteral: (in category 'literals') ----- + hasImplicitLiteral: anImplicitLiteral + "Like #hasLiteral:, check thoroughly, whether anImplicitLiteral is in the receiver. See #allImplicitLiteralsDo:." + + self allImplicitLiteralsDo: [:lit | (lit literalEqual: anImplicitLiteral) ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: Object>>allLiteralsDo:scanForSpecial: (in category 'literals') ----- + allLiteralsDo: aBlock scanForSpecial: aBoolean + "Backstop. Avoid bytecode scanning in CompiledCode and below. See #hasLiteral:scanForSpecial:." + + self allLiteralsDo: aBlock.! Item was added: + ----- Method: Object>>hasLiteral:scanForSpecial: (in category 'literals') ----- + hasLiteral: literal scanForSpecial: aBoolean + + ^ self + hasLiteralSuchThat: [:lit | lit literalEqual: literal] + scanForSpecial: aBoolean! Item was added: + ----- Method: Object>>hasLiteralSuchThat:scanForSpecial: (in category 'literals') ----- + hasLiteralSuchThat: testBlock scanForSpecial: aBoolean + "Backstop. Avoid bytecode scanning in CompiledCode and below. See #hasLiteral:scanForSpecial:." + + self + allLiteralsDo: [:literal | (testBlock value: literal) ifTrue: [^ true]] + scanForSpecial: aBoolean. + + ^ false!

1 0

Squeak 6.0: Compiler-mt.478.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Compiler to project Squeak 6.0: http://source.squeak.org/squeak60/Compiler-mt.478.mcz ==================== Summary ==================== Name: Compiler-mt.478 Author: mt Time: 20 December 2023, 1:42:23.219382 pm UUID: fddca1c8-f6aa-1349-be89-574e6f0b7eff Ancestors: Compiler-mt.477 Complements Kernel-mt.1486 =============== Diff against Compiler-mt.477 =============== Item was added: + ----- Method: Decompiler>>methodReturnSpecialConstant: (in category 'instruction decoding') ----- + methodReturnSpecialConstant: value + ^self methodReturnConstant: value!

1 0

Squeak 6.0: Kernel-mt.1486.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Kernel to project Squeak 6.0: http://source.squeak.org/squeak60/Kernel-mt.1486.mcz ==================== Summary ==================== Name: Kernel-mt.1486 Author: mt Time: 20 December 2023, 1:41:58.657382 pm UUID: e72605a7-7084-bb48-893c-ebb7f40ec414 Ancestors: Kernel-eem.1485 Fixes implicit-literal enumeration for ^true, ^false, ^nil etc. constants. =============== Diff against Kernel-eem.1485 =============== Item was added: + ----- Method: Context>>methodReturnSpecialConstant: (in category 'instruction decoding implicit literals') ----- + methodReturnSpecialConstant: value + "Simulate the action of a 'return constant' bytecode whose value is the + argument, value. This corresponds to a source expression like '^0'." + + ^self return: value from: self methodReturnContext! Item was added: + ----- Method: ImplicitLiteralFinder>>methodReturnSpecialConstant: (in category 'instruction decoding - implicit literals') ----- + methodReturnSpecialConstant: value + ^value! Item was added: + ----- Method: ImplicitLiteralInstructionClientHook>>methodReturnSpecialConstant: (in category 'instruction decoding - implicit literals') ----- + methodReturnSpecialConstant: value + "This is a hook to allow clients to intercept implicit literal bytecodes" + ^self methodReturnConstant: value! Item was changed: ----- Method: InstructionStream>>interpretNextSistaV1InstructionFor: (in category 'decoding - private - sista v1') ----- interpretNextSistaV1InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForSistaV1's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 16rE0 and: [byte <= 16rE1]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 16rE0 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 11 ifTrue: [div16 < 6 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset = 12 ifTrue: [^client pushReceiver]. offset = 13 ifTrue: [^client pushSpecialConstant: true]. offset = 14 ifTrue: [^client pushSpecialConstant: false]. offset = 15 ifTrue: [^client pushSpecialConstant: nil]]. "div16 = 5" offset < 2 ifTrue: [^client pushSpecialConstant: offset]. offset = 2 ifTrue: [^self interpretSistaV1ExtendedPush: extB for: client]. offset = 3 ifTrue: [^client doDup]. offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: + [^client methodReturnSpecialConstant: true]. - [^client methodReturnConstant: true]. offset = 10 ifTrue: + [^client methodReturnSpecialConstant: false]. - [^client methodReturnConstant: false]. offset = 11 ifTrue: + [^client methodReturnSpecialConstant: nil]. - [^client methodReturnConstant: nil]. offset = 12 ifTrue: [^client methodReturnTop]. offset = 13 ifTrue: [^client blockReturnConstant: nil]. offset = 14 ifTrue: [^client blockReturnTop]. offset = 15 ifTrue: [^client doNop]. ^self unusedBytecode: client at: savedPC]. "short sends" div16 = 6 ifTrue: [^client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. div16 = 7 ifTrue: [^client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. ^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 8]. "div16 >= 11; bytecode >= 176" div16 < 14 ifTrue: [div16 = 11 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1 if: false]. ^client popIntoReceiverVariable: offset - 8]. "div16 = 13" offset < 8 ifTrue: [^client popIntoTemporaryVariable: offset]. offset = 8 ifTrue: [^client doPop]. offset = 9 ifTrue: [^client trap]. ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 248 ifTrue: [^self interpretNext2ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC! Item was changed: ----- Method: InstructionStream>>interpretNextV3ClosuresInstructionFor: (in category 'decoding - private - v3 plus closures') ----- interpretNextV3ClosuresInstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. + offset < 12 ifTrue: [^ client methodReturnSpecialConstant: (SpecialConstants at: offset - 8)]. - offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. ^ self unusedBytecode: client at: pc - 1]. "offset = 14 & offset = 15, 126 & 127" type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretV3ClosuresExtension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"! Item was changed: ----- Method: InstructionStream>>interpretNextV3InstructionFor: (in category 'decoding - private - v3 plus closures') ----- interpretNextV3InstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. + offset < 12 ifTrue: [^ client methodReturnSpecialConstant: (SpecialConstants at: offset - 8)]. - offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. ^ self unusedBytecode: client at: pc - 1]. "offset = 14 & offset = 15, 126 & 127" type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretV3Extension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"!

1 0

The Trunk: Compiler-mt.494.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-mt.494.mcz ==================== Summary ==================== Name: Compiler-mt.494 Author: mt Time: 20 December 2023, 1:33:45.103692 pm UUID: b95a79b9-da13-d640-b04e-5c28a776ab09 Ancestors: Compiler-pre.493 Complements Kernel-mt.1543 =============== Diff against Compiler-pre.493 =============== Item was added: + ----- Method: Decompiler>>methodReturnSpecialConstant: (in category 'instruction decoding') ----- + methodReturnSpecialConstant: value + ^self methodReturnConstant: value!

1 0

The Trunk: Kernel-mt.1543.mcz
by commits＠source.squeak.org 20 Dec '23

20 Dec '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1543.mcz ==================== Summary ==================== Name: Kernel-mt.1543 Author: mt Time: 20 December 2023, 1:32:47.777692 pm UUID: 82030861-6f6f-b54c-ace9-9439ab79382f Ancestors: Kernel-mt.1542 Fixes implicit-literal enumeration for ^true, ^false, ^nil etc. constants. =============== Diff against Kernel-mt.1542 =============== Item was added: + ----- Method: Context>>methodReturnSpecialConstant: (in category 'instruction decoding implicit literals') ----- + methodReturnSpecialConstant: value + "Simulate the action of a 'return constant' bytecode whose value is the + argument, value. This corresponds to a source expression like '^0'." + + ^self return: value from: self methodReturnContext! Item was added: + ----- Method: ImplicitLiteralFinder>>methodReturnSpecialConstant: (in category 'instruction decoding - implicit literals') ----- + methodReturnSpecialConstant: value + ^value! Item was added: + ----- Method: ImplicitLiteralInstructionClientHook>>methodReturnSpecialConstant: (in category 'instruction decoding - implicit literals') ----- + methodReturnSpecialConstant: value + "This is a hook to allow clients to intercept implicit literal bytecodes" + ^self methodReturnConstant: value! Item was changed: ----- Method: InstructionStream>>interpretNextSistaV1InstructionFor: (in category 'decoding - private - sista v1') ----- interpretNextSistaV1InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForSistaV1's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 16rE0 and: [byte <= 16rE1]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 16rE0 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 11 ifTrue: [div16 < 6 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset = 12 ifTrue: [^client pushReceiver]. offset = 13 ifTrue: [^client pushSpecialConstant: true]. offset = 14 ifTrue: [^client pushSpecialConstant: false]. offset = 15 ifTrue: [^client pushSpecialConstant: nil]]. "div16 = 5" offset < 2 ifTrue: [^client pushSpecialConstant: offset]. offset = 2 ifTrue: [^self interpretSistaV1ExtendedPush: extB for: client]. offset = 3 ifTrue: [^client doDup]. offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: + [^client methodReturnSpecialConstant: true]. - [^client methodReturnConstant: true]. offset = 10 ifTrue: + [^client methodReturnSpecialConstant: false]. - [^client methodReturnConstant: false]. offset = 11 ifTrue: + [^client methodReturnSpecialConstant: nil]. - [^client methodReturnConstant: nil]. offset = 12 ifTrue: [^client methodReturnTop]. offset = 13 ifTrue: [^client blockReturnConstant: nil]. offset = 14 ifTrue: [^client blockReturnTop]. offset = 15 ifTrue: [^client doNop]. ^self unusedBytecode: client at: savedPC]. "short sends" div16 = 6 ifTrue: [^client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. div16 = 7 ifTrue: [^client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. ^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 8]. "div16 >= 11; bytecode >= 176" div16 < 14 ifTrue: [div16 = 11 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1 if: false]. ^client popIntoReceiverVariable: offset - 8]. "div16 = 13" offset < 8 ifTrue: [^client popIntoTemporaryVariable: offset]. offset = 8 ifTrue: [^client doPop]. offset = 9 ifTrue: [^client trap]. ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 248 ifTrue: [^self interpretNext2ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC! Item was changed: ----- Method: InstructionStream>>interpretNextV3ClosuresInstructionFor: (in category 'decoding - private - v3 plus closures') ----- interpretNextV3ClosuresInstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. + offset < 12 ifTrue: [^ client methodReturnSpecialConstant: (SpecialConstants at: offset - 8)]. - offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. ^ self unusedBytecode: client at: pc - 1]. "offset = 14 & offset = 15, 126 & 127" type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretV3ClosuresExtension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"! Item was changed: ----- Method: InstructionStream>>interpretNextV3InstructionFor: (in category 'decoding - private - v3 plus closures') ----- interpretNextV3InstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. + offset < 12 ifTrue: [^ client methodReturnSpecialConstant: (SpecialConstants at: offset - 8)]. - offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. ^ self unusedBytecode: client at: pc - 1]. "offset = 14 & offset = 15, 126 & 127" type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretV3Extension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 1) numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client sendSpecial: (Smalltalk specialSelectorAt: offset + 17) numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"!

1 0

Cannot install Git Browser or Inbox Talk
by Jaromir Matas 16 Dec '23

16 Dec '23

Hi Jakob, Christoph, I've been seeing this error for a while now: whenever I try to install Git Browser or Inbox Talk the installation ends up like this (screenshot): MNU #withSqueakLineEndings while Fetching BaselineOfMetacello. Is this happening to me only? I'm behind a firewall but made no changes recently and haven't seen any suspicious activity. I never encountered this problem until some time ago. Needless to say I've just downloaded the latest image and skipped all preference adjustments. Thanks for any advice. best, Jaromi -- Jaromir Matas mail(a)Jaromir.net

3 4

← Newer
1
...
4
5
6
7
8
9
10
...
13
Older →