Squeak-dev December 2023

squeak-dev@lists.squeakfoundation.org

26 participants
125 discussions

Cannot install Git Browser or Inbox Talk
by Jaromir Matas 16 Dec '23

16 Dec '23

Hi Jakob, Christoph, I've been seeing this error for a while now: whenever I try to install Git Browser or Inbox Talk the installation ends up like this (screenshot): MNU #withSqueakLineEndings while Fetching BaselineOfMetacello. Is this happening to me only? I'm behind a firewall but made no changes recently and haven't seen any suspicious activity. I never encountered this problem until some time ago. Needless to say I've just downloaded the latest image and skipped all preference adjustments. Thanks for any advice. best, Jaromi -- Jaromir Matas mail(a)Jaromir.net

3 4

The Inbox: Collections-ct.1057.mcz
by commits＠source.squeak.org 16 Dec '23

16 Dec '23

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1057.mcz ==================== Summary ==================== Name: Collections-ct.1057 Author: ct Time: 2 December 2023, 10:44:35.409859 pm UUID: 45821343-136e-774f-b3c8-7f4777a26681 Ancestors: Collections-ct.1056 Proposal: Adds #median on Collection, analogously to #average. =============== Diff against Collections-ct.1056 =============== Item was added: + ----- Method: Collection>>median (in category 'math functions') ----- + median + + ^ self asSortedCollection median!

6 8

Infinite debuggers - again?
by Jaromir Matas 15 Dec '23

15 Dec '23

Hi all, Example (CAREFUL - crashes the VM): Process new activateReturn: nil value: nil If you do-it, it'll start spawning an infinite stream of debuggers (the initial do-it encounters an error, spawns a new UI, encounters an error, spawns a new UI, et cetera ad infinitum or until exhausting the memory, whichever comes first). You might dismiss this example as crazy/nonsensical but: If you debug the example everything works as expected - you step into Process>>activateReturn:value: then into Context>>activateReturn:value: and then get an MNU because the receiver is nil - so simple! So why crash the VM when run? Or, try this version: [Process new activateReturn: nil value: nil] fork And now it works as expected and opens just one debugger on the MNU. I'm not deeply familiar with the UI and the debugger implementation, so I can only speculate there's either a bug somewhere in that neighborhood or a race condition of some kind because the infinite debuggers always end up with a context assigning nil to process priority - which makes no sense. (see screenshot of one of them) Any idea what might be wrong? PS: Is there a way to learn about the debugger implementation, other than reverse engineering the code and decrypting the comments? (this might sound sufficient if you already know how debuggers are usually implemented but it really isn't if you don't). Any suggestion greatly appreciated. Thanks, best, Jaromir -- Jaromir Matas mail(a)jaromir.net 420 777 492 777

2 1

Loops on the context stack
by christoph.thiede＠student.hpi.uni-potsdam.de 15 Dec '23

15 Dec '23

Hi all, looking for a new way to crash the image? :-) Here is one: gen := Generator on: [:gen | self assert: gen next isNil. self error]. gen yield: 1. This is a less idiomatic but more comprehensible version: [c := thisContext. [h := thisContext. [h swapSender: thisContext sender. c := thisContext swapSender: c] value. thisContext swapSender: c] value] value. [c := thisContext swapSender: c. self error] value. In a nutshell, the Generator temporarily creates a loop on the stack while switching coroutines. I didn't fully get behind its implementation at the moment, and I acknowledge that I am using the generator in the "wrong" way - usually the #on: block is the producer not the consumer. However, and especially with the recent debate on safe languages in mind, I wonder whether we would be able and willing to make Squeak safe against this phenomen (loops on the stack). The actual crash (or better: hang) comes from primitiveFindHandlerContext, but I assume primitiveFindNextUnwindContext and primitiveTerminateTo would cause a similar effect. A simple fix would be to disable these optional primitives and use the image fallback instead. This makes the method interruptable similar to a convenient infinite loop. However, this is obviously much slower. I wonder whether these primitives could be made aware of possible context stack loops and fail when a loop is detected. When the primitive fails, the fallback code would run so the image would be interruptable again, or even better, we could also detect particular stack loops then: Context>>findNextHandlerContextStarting "Return the next handler marked context, returning nil if there is none. Search starts with self and proceeds up to nil." - | ctx | - <primitive: 197> + | ctx known | ctx := self. + known := IdentitySet new. [ctx isHandlerContext ifTrue:[^ctx]. + (known ifAbsentAdd: ctx) ifFalse: [Processor debugWithTitle: 'Loop on stack detected!' translated full: false]. (ctx := ctx sender) == nil ] whileFalse. ^nil So my questions to you are: Do we want to support this kind of safety (I would like it!)? Is this possible to implement in the VM without a concerning performance impact? Best, Christoph --- Sent from Squeak Inbox Talk

2 2

Context>>cannotReturn: question
by Jaromir Matas 15 Dec '23

15 Dec '23

Hi Eliot, In 2009 you forwarded #cannotReturn: to #cannotReturn:to: to signal BCR rather than just open a debugger. I can't figure out why you made the forwarding conditional: closureOrNil notNil ifTrue: [^self cannotReturn: result to: self home sender]. QUESTION: why signal BCR for illegal block returns only and not all Unless there is a reason I overlooked, why not simplify #cannotReturn: like this: cannotReturn: result self cannotReturn: result to: self home sender. self error: 'Computation has been terminated!' All tests are green but that doesn't mean much; I'd be very grateful if you could help me clarify the above question. Many thanks, Jaromir -- Jaromir Matas mail(a)jaromir.net

2 1

The Trunk: PreferenceBrowser-codefrau.159.mcz
by commits＠source.squeak.org 15 Dec '23

15 Dec '23

Vanessa Freudenberg uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-codefrau.159.mcz ==================== Summary ==================== Name: PreferenceBrowser-codefrau.159 Author: codefrau Time: 6 December 2023, 4:05:30.869311 pm UUID: 8d6c0a15-8c38-451f-b6b1-bcb95b760358 Ancestors: PreferenceBrowser-ul.158 During adjustSettingsForLowPerformance, previewWorld is nil, don't create it unnecessarily (and avoid DNU in resetWorld). =============== Diff against PreferenceBrowser-ul.158 =============== Item was changed: ----- Method: PreferenceWizardMorph>>toggleTraditionalSystemBrowser (in category 'actions - buttons') ----- toggleTraditionalSystemBrowser self stateTraditionalSystemBrowser ifTrue: [SystemBrowser default: TreeBrowser] ifFalse: [SystemBrowser default: Browser]. self changed: #stateTraditionalSystemBrowser. + previewWorld ifNotNil: [self resetWorld]. + ! - self resetWorld.!

3 2

The Trunk: Morphic-ct.2150.mcz
by commits＠source.squeak.org 15 Dec '23

15 Dec '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2150.mcz ==================== Summary ==================== Name: Morphic-ct.2150 Author: ct Time: 15 December 2023, 9:13:30.922435 pm UUID: 36fd3c7b-1832-c74b-b243-c5cea62f97df Ancestors: Morphic-ct.2149, Morphic-ct.2145 Merges Morphic-ct.2144: Makes the code point and Unicode category of characters explorable in explorers, analogously to different representations of numbers. =============== Diff against Morphic-ct.2149 =============== Item was added: + ----- Method: Character>>explorerContents (in category '*Morphic-Explorer') ----- + explorerContents + + ^ {ObjectExplorerWrapper + with: self codePoint + name: 'code point' + model: self. + ObjectExplorerWrapper + with: (Unicode generalCategoryLabelOf: self codePoint) + name: 'category' + model: self}! Item was added: + ----- Method: Character>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + + ^ true!

2 1

The Trunk: Morphic-ct.2145.mcz
by commits＠source.squeak.org 15 Dec '23

15 Dec '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2145.mcz ==================== Summary ==================== Name: Morphic-ct.2145 Author: ct Time: 1 December 2023, 9:00:59.264752 pm UUID: 2cb1f9a9-0aad-eb44-bde5-90138c603659 Ancestors: Morphic-ct.2144 Proposal: Makes the code point and Unicode category of characters explorable in explorers, analogously to different representations of numbers. =============== Diff against Morphic-ct.2144 =============== Item was added: + ----- Method: Character>>explorerContents (in category '*Morphic-Explorer') ----- + explorerContents + + ^ {ObjectExplorerWrapper + with: self codePoint + name: 'code point' + model: self. + ObjectExplorerWrapper + with: (Unicode generalCategoryLabelOf: self codePoint) + name: 'category' + model: self}! Item was added: + ----- Method: Character>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + + ^ true!

1 0

The Trunk: Tools-ct.1243.mcz
by commits＠source.squeak.org 15 Dec '23

15 Dec '23

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1243.mcz ==================== Summary ==================== Name: Tools-ct.1243 Author: ct Time: 1 December 2023, 8:16:16.336752 pm UUID: 351663d4-0cc6-6d42-918a-e275ec86b5b0 Ancestors: Tools-mt.1241 Proposal: When accepting a method in a debugger, allows to proceed compilation despite of no active home method. I noticed a frequent demand for this in myself and others as in many situations, we are not interested in proceeding the suspended process anyway. The second dialog window is optional and might bring clarity or annoyance. Do we need it? =============== Diff against Tools-mt.1241 =============== Item was changed: ----- Method: Debugger>>contents:notifying: (in category 'accessing') ----- contents: aText notifying: aController "Accept new method source of the selected context." | selector classOfMethod category ctxt newMethod | contextStackIndex = 0 ifTrue: [^ false]. "First, handle some edge cases" selector := self selectedClass newParser parseSelector: aText. "selector isDoIt ifTrue: [ currentCompiledMethod := self compileDoIt: aText]." self flag: #todo. "ct: Recompile doIt method *without* creating method litters!! See Compiler>>#evaluateCue:ifFail:." selector = self selectedMessageName ifFalse: [ "Different message compiled, delegating to super" ^ super contents: aText notifying: aController]. self selectedContext isExecutingBlock ifTrue: [ "If we are in a block context, we need to rewind the stack before ." | home | home := self selectedContext activeHome. home ifNil: [ + (self confirm: 'Method for block not found on stack, can''t edit and continue. Edit anyway?' translated) ifFalse: [ + ^ false]. + ^ (super contents: aText notifying: aController) + ifTrue: [ + contents := nil. self contentsChanged. + self inform: 'Method was updated, but cannot revert the stack to it.' translated]; + yourself]. - self inform: 'Method for block not found on stack, can''t edit and continue' translated. - ^ false]. (self confirm: 'I will have to revert to the method from\which this block originated. Is that OK?' translated withCRs) ifFalse: [ ^ false]. self resetContext: home changeContents: false. "N.B. Only reset the contents if the compilation succeeds. If contents would be reset when compilation fails, both compiler error message and modifications were lost." ^ (self contents: aText notifying: aController) ifTrue: [self contentsChanged]; yourself]. classOfMethod := self selectedClass. category := self selectedMessageCategoryName. "Do the actual compilation" selector := classOfMethod compile: aText classified: category notifying: aController. selector ifNil: [^ false]. "compilation cancelled" "Update views" contents := aText. newMethod := classOfMethod compiledMethodAt: selector. newMethod isQuick ifTrue: [ self cutBackExecutionToSenderContext]. ctxt := interruptedProcess popTo: self selectedContext. ctxt == self selectedContext ifFalse: [self inform: 'Method saved, but current context unchanged\because of unwind error. Click OK to see error' translated withCRs] ifTrue: [ newMethod isQuick ifFalse: [ interruptedProcess restartTopWith: newMethod. interruptedProcess stepToSendOrReturn]. contextVariablesInspector object: nil]. self resetContext: ctxt. Project current addDeferredUIMessage: [ self changed: #contentsSelection]. ^ true!

1 0

The Trunk: Tools-ct.1244.mcz
by commits＠source.squeak.org 15 Dec '23

15 Dec '23

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1244.mcz ==================== Summary ==================== Name: Tools-ct.1244 Author: ct Time: 15 December 2023, 9:10:35.361435 pm UUID: d5103ab3-045e-9846-9aff-98217a9e58aa Ancestors: Tools-mt.1242, Tools-ct.1243 Merges and revises Tools-ct.1243: When accepting a method in a debugger, allows to proceed compilation despite of no active home method. I noticed a frequent demand for this in myself and others as in many situations, we are not interested in proceeding the suspended process anyway. The second dialog window is optional and might bring clarity or annoyance. Do we need it? Revision: Slightly changed wording of first message. =============== Diff against Tools-mt.1242 =============== Item was changed: ----- Method: Debugger>>contents:notifying: (in category 'accessing') ----- contents: aText notifying: aController "Accept new method source of the selected context." | selector classOfMethod category ctxt newMethod | contextStackIndex = 0 ifTrue: [^ false]. "First, handle some edge cases" selector := self selectedClass newParser parseSelector: aText. "selector isDoIt ifTrue: [ currentCompiledMethod := self compileDoIt: aText]." self flag: #todo. "ct: Recompile doIt method *without* creating method litters!! See Compiler>>#evaluateCue:ifFail:." selector = self selectedMessageName ifFalse: [ "Different message compiled, delegating to super" ^ super contents: aText notifying: aController]. self selectedContext isExecutingBlock ifTrue: [ "If we are in a block context, we need to rewind the stack before ." | home | home := self selectedContext activeHome. home ifNil: [ + (self confirm: 'Method for block not found on stack, can''t edit and continue. Update method anyway?' translated) ifFalse: [ + ^ false]. + ^ (super contents: aText notifying: aController) + ifTrue: [ + contents := nil. self contentsChanged. + self inform: 'Method was updated, but cannot revert the stack to it.' translated]; + yourself]. - self inform: 'Method for block not found on stack, can''t edit and continue' translated. - ^ false]. (self confirm: 'I will have to revert to the method from\which this block originated. Is that OK?' translated withCRs) ifFalse: [ ^ false]. self resetContext: home changeContents: false. "N.B. Only reset the contents if the compilation succeeds. If contents would be reset when compilation fails, both compiler error message and modifications were lost." ^ (self contents: aText notifying: aController) ifTrue: [self contentsChanged]; yourself]. classOfMethod := self selectedClass. category := self selectedMessageCategoryName. "Do the actual compilation" selector := classOfMethod compile: aText classified: category notifying: aController. selector ifNil: [^ false]. "compilation cancelled" "Update views" contents := aText. newMethod := classOfMethod compiledMethodAt: selector. newMethod isQuick ifTrue: [ self cutBackExecutionToSenderContext]. ctxt := interruptedProcess popTo: self selectedContext. ctxt == self selectedContext ifFalse: [self inform: 'Method saved, but current context unchanged\because of unwind error. Click OK to see error' translated withCRs] ifTrue: [ newMethod isQuick ifFalse: [ interruptedProcess restartTopWith: newMethod. interruptedProcess stepToSendOrReturn]. contextVariablesInspector object: nil]. self resetContext: ctxt. Project current addDeferredUIMessage: [ self changed: #contentsSelection]. ^ true!

1 0

← Newer
1
...
5
6
7
8
9
10
11
12
13
Older →