Squeak-dev February 2023

squeak-dev@lists.squeakfoundation.org

28 participants
108 discussions

Thoughts about values and practices (was: How do I "sleep 5"?)
by Marcel Taeumel 26 Feb '23

26 Feb '23

Hi Benoît -- > [...] I never seriously considered replacing Morphic altogether but we must at least recognize that Morphic could get a bit cleaner. [...] > [...] Why can't we even *suggest* such a thing in Squeak without being attacked on the mailing list? [...] What you might have experienced is a simple defense mechanism. ;-) You cannot expect the active community to be happy about you suggesting that nothing has happened in the past 10 years or so. Some of us have the time and energy to keep on cleaning up and improving Squeak on a daily basis. We know about the dark and dusty corners. There is no "magic wand" but only hard work to be done. Many onward decisions are not easy to be made and *require* people to stick around and stand behind them. One cannot just come along, yell around, delete some classes, and then disappear again. Squeak's community and its ecosystem depend on honest contributions. At best, contributors have their own pet projects that motivate them to keep going and really figure out what's needed and what is not. And they are also able to realize when some area is just not their level of expertise to make substantial suggestions or improvements. Still, they should be encouraged to raise their concerns from time to time. This is Morphic and *so* cool: http://www.zogotounga.net/comp/squeak/rogue.htm > [...] The 6.0 Squeak image I'm looking at right now has *** 512 ** Morph subclasses ! Do we need all that stuff? [...] > Have you tried unloading EToys just for the fun of it? It should be a one click or a one-liner thing but it needs its own page of instructions on the wiki [...] Of course, we are also working on untangling the dependencies between EToys and the base system. Along the way, interesting ideas get even ported to become part of the base system. I may be wrong, but to me, it looks like that you are either looking for or claim to have a "magic wand" that can make huge changes in a short amount of time without leaving people and content (!) behind. https://raw.githubusercontent.com/squeak-smalltalk/squeak-app/squeak-trunk/… https://raw.githubusercontent.com/squeak-smalltalk/squeak-app/squeak-trunk/… https://raw.githubusercontent.com/squeak-smalltalk/squeak-app/squeak-trunk/… https://raw.githubusercontent.com/squeak-smalltalk/squeak-app/squeak-trunk/… > I get the idea of "basic Squeak" versus "Squeak with EVERYTHING it has to offer" but from a user perspective, [...] Well, you are obviously having a kind of narrow perspective here. A Squeak bundle has far from "everything" loaded in the beginning. You might have a personal bias towards not liking EToys or some other content in the system. Then you come up with an argument like "512 Morph subclasses is too many". However, that's besides the point and not helping to clean-up the system. It's not that users are confronted with that number all the time -- tools will usually only show a fraction of that. Fixating an argument on arbitrary metrics overshadows the actual challenge: what *is* there actually and do we need it? Furthermore: do *I* need it or can I simply unload it for my personal project. Yes, we know about all these things. And we have been working on that for many years. You are not mentioning new facts here... even though your words are more evocative compared to what is usually discussed on the list. > [...] One could hear the complaints against Morphic from Cuis & Pharo and honestly recognize that there is/was a problem. [...] My personal guess would be that those communities have a fundamentally different perspective on what a Smalltalk system should be. There are voices that want to "dumb it down" (yes, not simplification but ignorance) by treating such systems as mere IDEs or by focusing on "programming language + standard library". However, I think that Smalltalk systems can shine when treated as being more like operating systems, rich multimedia environments, ...hmm... something malleable that might actually be able to "augmenting human intellect" (-> Doug Engelbart). It's more about a healthy environment with liveness and for exploration. No, I don't think that we should grow a bigger community at all cost, following some fancy (short-living!) trends from other communities... Instead, we should look out for honest and long-lasting contributors that have real interest in understanding what is there and how to evolve it. This here might be an interesting read and worth your time: https://dl.acm.org/doi/10.1145/3563835.3568733 For example, a community that disables the Morphic Halo feature by default does not understand or appreciate the benefits of direct manipulation at all. Here is a simple exercise: instead of picking out things that you do not like, try to make a list of things you do like (about Squeak). And then reflect again and discern "better" (or "worse") from "just different" to counter your personal learning bias. > I think we can say goodbye to portability. Backwards compatibility (from one Squeak version to another) is a totally different thing though. There are several projects that are still portable because they mostly rely on fundamental Smalltalk concepts and standard interfaces such as Collections, Streams, Exceptions, and Tests: - https://github.com/theseion/Fuel (Max is awesome!!) - https://github.com/Metacello/metacello - https://github.com/dalehenrich/filetree - https://github.com/hpi-swa/smalltalkCI - https://github.com/pharo-vcs/tonel (kind of via: https://github.com/squeak-smalltalk/squeak-tonel) - https://github.com/svenvc/ston (kind of via: https://github.com/squeak-smalltalk/squeak-ston) - ... Therefore, I think that portability should have its place in a serious discussion about moving forward. :-) We must consider "Smalltalk as a whole" when looking for its place in the modern computing world. Best, Marcel Am 24.02.2023 17:35:18 schrieb Benoit St-Jean <bstjean(a)yahoo.com>: On 2023-02-24 04:02, Marcel Taeumel via Squeak-dev wrote: Well, common sense does. ;-) Unless we make this a serious discussion considering Pros and Cons, such hasty thoughts will get us nowhere. From what I have read so far, I assume, that you have no substantial experience in writing Morphic applications? I don't know. Sorry, if my conclusion offended you. Your kind of shallow call just triggered something... :-/ Perhaps I wasn't/precise clear enough : I never seriously considered replacing Morphic altogether but we must at least recognize that Morphic could get a bit cleaner. And the Squeak image too! The 6.0 Squeak image I'm looking at right now has *** 512 ** Morph subclasses ! Do we need all that stuff? I guess not. If at least we could unload packages in a *clean* manner, it would make things easier for everyone and facilitate building smaller runtime images. I get the idea of "basic Squeak" versus "Squeak with EVERYTHING it has to offer" but from a user perspective, having 512 subclasses of Morph can be overwhelming. On the other hand, if it's not in the image, how can a user easily find that a particular morph is available and exists in a certain repository/package? If Squeak comes loaded with EVERYTHING in the image, we should at least provide an *easy* way to unload what we don't need/want/use : that's not the case right now. Have you tried unloading EToys just for the fun of it? It should be a one click or a one-liner thing but it needs its own page of instructions on the wiki (https://wiki.squeak.org/squeak/2848 [https://wiki.squeak.org/squeak/2848]). One could hear the complaints against Morphic from Cuis & Pharo and honestly recognize that there is/was a problem. Why can't we even *suggest* such a thing in Squeak without being attacked on the mailing list? And no, I'm not offended and your conclusion/assumption was right: my Morphic experience is limited Maybe because us frequent users of Squeak/Morphic have already realized that both Cuis and Pollock are just different and not inherently better? Well, I don't know about Pollock. Cuis has different goals, backwards compatibility may not be among its most important ones. I think we can say goodbye to portability. Backwards compatibility (from one Squeak version to another) is a totally different thing though. It's not that difficult to come up with something different. The first weeks might be even fun. After that, you figure out all the corner cases and start arguing about compatibility and finding balance within the existing community. It is hard work. It is easy to ignore this fact in the beginning. Best, Marcel Am 24.02.2023 05:47:30 schrieb Benoit St-Jean via Squeak-dev <squeak-dev(a)lists.squeakfoundation.org> [mailto:squeak-dev@lists.squeakfoundation.org]: Nothing prevents us from replacing Morphic or redesigning it! If Juan was able to do it for Cuis and Sam Shuster was able to design Pollock for VW, what's stopping us from even considering that option? On 2023-02-23 20:14, Stephen Travis Pope wrote: Sounds like yet another reason to drop morphic, if you ask me, and go back to good-old MVC… stp -------- Stephen Travis Pope Ojai, California, USA [pastedGraphic.tiff] http://HeavenEverywhere.com [http://HeavenEverywhere.com] http://FASTLabInc.com [http://FASTLabInc.com] https://vimeo.com/user19434036/videos [https://vimeo.com/user19434036/videos] http://heaveneverywhere.com/Reflections [http://heaveneverywhere.com/Reflections] On Feb 23, 2023, at 1:54 PM, Vanessa Freudenberg <vanessa(a)codefrau.net> [mailto:vanessa@codefrau.net] wrote: Because Morphic is not multi-thread-clean, you have to be really careful how to write the do_something to be reliably executed from a different process. You have to coordinate with the UI process. In which case it actually becomes simpler to just stay in the UI process and use the mechanisms available. Vanessa On Thu, Feb 23, 2023 at 11:38 AM Stephen Travis Pope <stephen(a)heaveneverywhere.com [mailto:stephen@heaveneverywhere.com]> wrote: I’ve been watching this thread and wondering why nobody suggests the simplest answer: [(Delay forSeconds: 5) wait. do_something] fork. stp -------- Stephen Travis Pope Ojai, California, USA <pastedGraphic.tiff> http://HeavenEverywhere.com [http://heaveneverywhere.com/] http://FASTLabInc.com [http://fastlabinc.com/] https://vimeo.com/user19434036/videos [https://vimeo.com/user19434036/videos] http://heaveneverywhere.com/Reflections [http://heaveneverywhere.com/Reflections] On Feb 22, 2023, at 11:16 AM, karl ramberg <karlramberg(a)gmail.com [mailto:karlramberg@gmail.com]> wrote: On Wed, Feb 22, 2023 at 8:47 AM Taeumel, Marcel via Squeak-dev <squeak-dev(a)lists.squeakfoundation.org [mailto:squeak-dev@lists.squeakfoundation.org]> wrote: (bm2 future: 1000) doButtonAction. Also works for objects that are not or cannot be in the world. Uses Morphic alarms when when in UI process. Ah, that's cool. I never used #future: :-) Best, Karl Best, Marcel From: Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org [mailto:squeak-dev-bounces@lists.squeakfoundation.org]> on behalf of Eduardo Ochs <eduardoochs(a)gmail.com [mailto:eduardoochs@gmail.com]> Sent: Wednesday, February 22, 2023 7:17:01 AM To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org [mailto:squeak-dev@lists.squeakfoundation.org]> Subject: Re: [squeak-dev] How do I "sleep 5"? Hi Karl! Fantastic, thanks! =) I added this to the class in which I'm putting most of my stuff, !See class methodsFor: 'as yet unclassified' stamp: 'Edrx 2/22/2023 02:54'! run: aBlock after: ms | aButton | aButton := SimpleButtonMorph new. aButton openInWorld; hide; target: aBlock; actionSelector: #value; addAlarm: #doButtonAction after: ms. ! ! and now I can simply run this See run: [ kf := self currentHand keyboardFocus ] after: 5000. to save into the variable kf the morph on which the keyboard focus is after 5 seconds. Neat! =) Cheers, Eduardo Ochs http://anggtwu.net/eev-squeak.html [http://anggtwu.net/eev-squeak.html] On Wed, 22 Feb 2023 at 01:56, karl ramberg <karlramberg(a)gmail.com [mailto:karlramberg@gmail.com]> wrote: Hi, A morph has to be in the world to be able to interact with it; eg. #openInWorld. If you don't want to see the morph you can send it message #hide. It makes the morph invisible but it's still in the world and can interact with it. To see the morph again send #show. To delete the morph send #delete. The morph will be garbage collected. Best, Karl On Tue, Feb 21, 2023 at 11:57 PM Eduardo Ochs <eduardoochs(a)gmail.com [mailto:eduardoochs@gmail.com]> wrote: Hi Vanessa! Thanks! =) This works in a workspace, "Create a SimpleSwitchMorph with label 'Toggle' and a SimpleButtonMorph with label 'Flash'. The button will be placed below the switch." sm := SimpleSwitchMorph new. sm openInWorld. bm := SimpleButtonMorph new. bm openInWorld. bm position: bm position + (0@32). "Three ways of toggling the color of the switch:" sm toggleState. bl := [ sm toggleState ]. bl value. bm target: bl. bm actionSelector: #value. bm doButtonAction. "Two ways of toggling the switch after 1000ms:" sm addAlarm: #toggleState after: 1000. bm addAlarm: #doButtonAction after: 1000. but this doesn't: bm2 := SimpleButtonMorph new. bm2 target: bl. bm2 actionSelector: #value. bm2 addAlarm: #doButtonAction after: 1000. What is the right way to add an alarm to a morph that is not shown on the screen? Also, can I create a new invisible morph every time that I want to run an alarm? Are they going to be garbage collected? Thanks in advance! Eduardo Ochs http://anggtwu.net/eev-squeak.html [http://anggtwu.net/eev-squeak.html] On Tue, 21 Feb 2023 at 02:16, Vanessa Freudenberg <vanessa(a)codefrau.net [mailto:vanessa@codefrau.net]> wrote: The best way to do this in Morphic is with "alarms": self addAlarm: #changeKeyboardFocus after: 5000. which would execute the morph's changeKeyboardFocus method 5 seconds later. The way of sleeping you suggest is possible too but more tricky, since you would have to move your wait code to an extra process to not block the UI process, but then make sure that the actual work is done in the UI process again (Morphic is not multithreaded, although Squeak is). Vanessa On Mon, Feb 20, 2023 at 8:49 PM Eduardo Ochs <eduardoochs(a)gmail.com [mailto:eduardoochs@gmail.com]> wrote: Hi list, a few days ago I asked for help on how to send a "synthetic" keyboard event to a morph, and Karl Ramberg gave me exactly the right hints in this thread: http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-February/223473… [http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-February/223473…] My code is ready except for documentation and comments - I'll work on that in the next few days and then post the result here and on the wiki... ...but there's a feature that I want to add to it that - again =( - needs something that I'm not being able to discover by myself. How do I write a line of code that waits for 5 seconds, sort of like running "sleep 5" in a shell, and that doesn't block the rest of the system? If I have that I'll be able to run these two lines in a workspace, self mySleep: 5000. kf := self currentHand keyboardFocus. switch the keyboard focus to something else by clicking on it, and then the variable kf will be set to this "something else"... Thanks in advance! Eduardo Ochs http://anggtwu.net/eev-squeak.html [http://anggtwu.net/eev-squeak.html]

1 0

A question on non-openInWorld-able morphs
by Eduardo Ochs 25 Feb '23

25 Feb '23

Hi list, I need to ask for more pointers... =( Now I know how to debug what happens when I send certain keys to certains morphs. My code is here - not on the wiki yet, sorry - http://anggtwu.net/eev-squeak.html#key-events and I am using that to learn how lots of things work. But the morphs seem to fall in several different families, each one with a different way of initializing... for morphs like these ones I can just use openInWorld, sm := SimpleSwitchMorph new. sm openInWorld. bm := SimpleButtonMorph new. bm openInWorld. bm position: bm position + (0@32). rm := RectangleMorph new. rm openInWorld. rm position: rm position + (0@64). but for SelectorBrowser I need to use "prototypicalToolWindow" instead of new, and there are other ones, like SearchBar, that I don't know how to create a new morph of that kind... Where can I learn more about that? And where do people usually learn how to create interfaces in which a single window displays several subwindows and subwidgets? In Tcl/Tk this is considered basic... here is an example of this "this": the code below frame .top frame .bottom text .textbox -width 10 -height 5 listbox .listbox -width 10 -height 5 button .button1 -text B1 button .button2 -text B2 button .button3 -text B3 .textbox insert end "Foo\nBar" .listbox insert end "Item 1" .listbox insert end "Item 2" .listbox insert end "Item 3" pack .top -side top pack .bottom -side bottom -fill x -expand 1 pack .listbox -side left -in .top pack .textbox -side right -in .top pack .button1 -side left -in .bottom -fill x -expand 1 pack .button2 -side left -in .bottom -fill x -expand 1 pack .button3 -side left -in .bottom -fill x -expand 1 creates the window in this screenshot: https://i.ibb.co/ZcZGRjW/sshot.png Thanks in advance! =) Eduardo Ochs http://anggtwu.net/eev-squeak.html

2 2

The Trunk: EToys-mt.493.mcz
by commits＠source.squeak.org 24 Feb '23

24 Feb '23

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.493.mcz ==================== Summary ==================== Name: EToys-mt.493 Author: mt Time: 24 February 2023, 10:57:32.196067 am UUID: 026f5e7f-48a8-df46-9d7f-dd63f4acf991 Ancestors: EToys-mt.492 Merges a fix from Ralph (rpb): "This code fixes a bug in fromCameCase. The old code would do: 'AnExampleString' fromCamelCase -> ' anExampleString'. The leading space should not be there. The problem occurs when the leading character is capitalized." =============== Diff against EToys-mt.492 =============== Item was changed: ----- Method: String>>fromCamelCase (in category '*Etoys-Squeakland-converting') ----- fromCamelCase "convert 'anExampleString' to 'an example string'" + ^self findFeatures joinSeparatedBy: String space! - | upper nextWord start | - upper := ($A to: $Z) asCharacterSet. - nextWord := self indexOfAnyOf: upper. - nextWord = 0 ifTrue: [^self]. - start := 1. - - ^String streamContents: [:strm | - [ - strm nextPutAll: (self copyFrom: start to: nextWord-1). - strm space; nextPut: (self at: nextWord) asLowercase. - start := nextWord+1. - nextWord := self indexOfAnyOf: upper startingAt: start. - nextWord = 0 - ] whileFalse. - strm nextPutAll: (self copyFrom: start to: self size). - ].!

1 0

The Inbox: fromCamelCaseBugFix-rpb.2.mcz
by commits＠source.squeak.org 24 Feb '23

24 Feb '23

A new version of fromCamelCaseBugFix was added to project The Inbox: http://source.squeak.org/inbox/fromCamelCaseBugFix-rpb.2.mcz ==================== Summary ==================== Name: fromCamelCaseBugFix-rpb.2 Author: rpb Time: 23 February 2023, 5:30:54.911688 pm UUID: d2c3cefb-be54-457d-bb50-9e522c3de213 Ancestors: fromCamelCaseBugFix-rpb.1 This code fixes a bug in fromCameCase. The old code would do: 'AnExampleString' fromCamelCase -> ' anExampleString'. The leading space should not be there. The problem occurs when the leading character is capitalized. ==================== Snapshot ==================== SystemOrganization addCategory: #fromCamelCaseBugFix! ----- Method: SequenceableCollection>>asSpaceInterleavedString (in category '*fromCamelCaseBugFix') ----- asSpaceInterleavedString "Convert to a string with a space between items. Assumes Elements are strings." | stream | stream := WriteStream on: (String new: 100). self do: [:each | stream nextPutAll: each; space]. self size > 0 ifTrue: [stream skip: -1]. "remove trailing space" ^stream contents.! ----- Method: String>>fromCamelCase (in category '*fromCamelCaseBugFix') ----- fromCamelCase "convert 'anExampleString' to 'an example string'" ^self findFeatures asSpaceInterleavedString! ----- Method: String>>fromCamelCaseBugFixComment (in category '*fromCamelCaseBugFix') ----- fromCamelCaseBugFixComment " The new code fixes a bug in fromCameCase. The old code would do: 'AnExampleString' fromCamelCase -> ' anExampleString'. The leading space should not be there. The problem occurs when the leading character is capitalized. "!

1 0

Squeak Oversight Board Election 2023
by Benoit St-Jean 23 Feb '23

23 Feb '23

Hello everyone, I think it's finally time for me to run for the Squeak Oversight Board and give back to the wonderful Squeak/Smalltalk community! First, let me introduce myself. I've been following/loving Squeak since Dan Ingalls announced the birth of this "new Smalltalk" in 1996! Besides being a fan of Squeak since day 1, I have been professionally a Smalltalker since 1992. I started with ObjectWorks 4.0 and quickly moved to VisualWorks 2.5. Since then, I've been working mostly (and equally) with VisualAge and VisualWorks. Did a few years of coding with VSE (plain) and VSE/PARTS as well. Throw in some Gemstone and some Glorp and some TOPLink and you get a good picture of my professional background. In all occasions, I was lucky enough to work on big projects with big databases (DB/2, Gemstone, Oracle, MySQL, SQL Server, Sybase & some MQSeries). Besides "Smalltalk at work", I enjoy other Smalltalks I haven't used professionally: ObjectStudio, Dolphin, Cuis, Pharo and, obviously, Squeak! And yes, I'm sometimes nostalgic of "The Smalltalk Report", JOOP, BYTE and the "Dr. Dobb's Journal" magazines! ;) I have a particular interest in: -Smalltalk communications with the "outside world", aka web services but MOSTLY databases -runtime image packaging mechanisms (i.e. VSE SLL, VW parcels, VAST Runtime Packager, VW ImageStripper or building from a minimal image) -modularity & modularization (no wonder, the first programming language I learned was Modula-2!) -development tools (Dolphin's IdeaSpace, Pharo's Playground, Refactoring Browser, CodeCritics/SmallLint, GUI Builder, GToolkit) -last, but not the least, Squeak's place on the current Smalltalk scene. I have been under the impression, in recent years, that Squeak was trying to find its place between Cuis & Pharo and be everything to everyone and nice/compatible with everything & everyone. But Cuis is Cuis. And Pharo is Pharo. And both forks have a clear path in mind but I'm not sure Squeak knows what it is anymore and what it wants to be or become. Add to that confusion, SqueakJS & PharoJS ! A few symptoms can tell we're in a delicate place, starting with code compatibility and code repositories! Repositories (SqueakMap, SqueakSource, SqueakSource3, SmalltalkHub) are filled with versions alternating from Pharo to Squeak and back! We lost Scratch. Major projects like Glorp, Magma, Seaside, Moose, Roassal, Magritte, PolyMath and others seemed to have moved away from Squeak. So I think we need to take a step back and ask ourselves a few philosophical questions: -do we want to retain the original goal of being a multimedia/education/experimenting development platform? -do we want compatibility with other Smalltalks or just go our own way? -can we target Raspberry Pi & cell phones as a possible and serious Squeak platform? So I would like to run for the SOB 2023 because I am a user, a developer and... a Smalltalk lover. P.S. Other non-Smalltalk related interests include: genetic algorithms, chess, French literature (long story!), mathematics P.P.S. I also like to code in Modula-2, Julia, R, Pascal, BASIC and Oberon if that helps! P.P.P.S. I'm on Windows and speak French : trouble ahead! ;)

2 1

Squeak Oversight Board Election 2023
by Rein, Patrick 23 Feb '23

23 Feb '23

Hi All, It's that time again (sort of). Time to raise your voices and elect your leaders! Can you believe it's been over a year already? It's a time for you to stand up, help your community and volunteer to serve! Squeak wants you! Every year we elect the SOB (Squeak Oversight Board) consisting of seven members from our community. The current board members are: 1. Marcel Taeumel 2. Tim Rowledge 3. David T. Lewis 4. Craig Latta 5. Jakob Reschke 6. Stéphane Rollandin 7. Bruce O'Neel For more info on the board please see: https://squeak.org/board/#the-mission Everything about the election, including schedule and more, is tracked here: http://wiki.squeak.org/squeak/6664 Now until Friday 24th of February 2023, 18.00 UTC: Nominations of SOB members and campaigning! Candidates should nominate themselves and start their campaign on the squeak-dev mailing list. Or if you nominate someone else, make sure that person really wants to run. :) I will not put anyone on the candidate list until that person makes it known on squeak-dev that he/she intends to run. During this period, the candidates should ideally present themselves on squeak-dev, unless they have already done so, and the community can ask questions. I encourage you to reach out to potential candidates, people that are active in the community and represent your views, and ask them to run. Some people will not run without encouragement. Also, I know that some people wait to the last minute to run for the board to see if others will run but please consider getting this year off to a faster start and just jump right in! The schedule and process are as follows: Now until Friday 24th of February 2023, 18.00 UTC: Nominations of SOB members and campaigning! Friday 24th of February 2023, 18.00 UTC: Candidate list is finalized. Friday 24th of February 2023, 19.00 UTC: Online election starts. Friday 10th of March 2023, 19.00 UTC: Online election ends. Results will be announced immediately after the election ends. The voting period is two week long and ballots are sent out via email. And how do you end up on the voter list? See below. :) IMPORTANT: New voters will NOT be added once the election is started. You MUST try to get on the voter list before the 24th of February 2023 or you will NOT be able to vote. If your Email has changed please try to make sure it is changed on the list of voters before the election starts. -------------------------- If you were invited to vote last year you are already on the voter list, no worries! If you are a new Squeaker and wish to vote you should do ONE of the following: * Get a "known" Squeaker to vouch for you. If a known Squeaker sends an email to voters (at) squeak.org giving me a name and email for you, then I will add you. * Send an email to voters (at) squeak.org yourself (and CC to squeak-dev if you like) with information/arguments showing me that you are indeed serious about voting and that you are indeed a Squeaker. When the voting period starts all voters will receive an email with instructions and a link to the voting website. If there are any further questions, just reply *in this thread* and I will closely track it - or send email to voters (at) squeak.org which points to me. ...so let's get on with it! All the best, Patrick Rein

7 8

The Trunk: Morphic-mt.2093.mcz
by commits＠source.squeak.org 23 Feb '23

23 Feb '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2093.mcz ==================== Summary ==================== Name: Morphic-mt.2093 Author: mt Time: 23 February 2023, 3:22:39.829976 pm UUID: 16263c0a-3cc5-cb4c-8cf3-53eda4c76b4e Ancestors: Morphic-mt.2092 Tree widgets: when collapsing a node via mouse-click, do not select that parent unless there was actually a prior selection (in that collapsed sub-tree). =============== Diff against Morphic-mt.2092 =============== Item was changed: ----- Method: SimpleHierarchicalListMorph>>mouseDown: (in category 'event handling') ----- mouseDown: evt | aMorph selectors | aMorph := self itemFromPoint: evt position. evt yellowButtonPressed "First check for option (menu) click" ifTrue: [ (PluggableListMorph menuRequestUpdatesSelection and: [model okToChange]) ifTrue: [ aMorph == selectedMorph ifFalse: [self setSelectedMorph: aMorph]]. ^ self yellowButtonActivity: evt shiftPressed]. aMorph ifNil: [^ super mouseDown: evt]. (aMorph notNil and:[aMorph inToggleArea: (aMorph point: evt position from: self)]) + ifTrue: [ | priorSelection | + priorSelection := self selectedMorph. - ifTrue: [ self toggleExpandedState: aMorph event: evt. + (priorSelection notNil and: [self selectedMorph isNil]) ifTrue: [ - self selectedMorph ifNil: [ self setProperty: #changeSelectionOnMouseUp toValue: true. self setProperty: #selectedMorph toValue: aMorph]. ^ self]. PluggableListMorph highlightPreSelection ifTrue: [ aMorph highlightedForMouseDown: true. self setProperty: #highlightedMorph toValue: aMorph]. self setProperty: #changeSelectionOnMouseUp toValue: true. selectors := Array with: #click: with: (self doubleClickEnabled ifTrue: [#doubleClick:] ifFalse: [nil]) with: nil with: (self dragEnabled ifTrue:[#startDrag:] ifFalse:[nil]). evt hand waitForClicksOrDrag: self event: evt selectors: selectors threshold: HandMorph dragThreshold "pixels".!

1 0

The Trunk: ToolBuilder-Kernel-mt.163.mcz
by commits＠source.squeak.org 23 Feb '23

23 Feb '23

Marcel Taeumel uploaded a new version of ToolBuilder-Kernel to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Kernel-mt.163.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-mt.163 Author: mt Time: 23 February 2023, 3:14:21.577976 pm UUID: 8ef4f45f-fbff-bb4e-80fd-33c453125c0d Ancestors: ToolBuilder-Kernel-mt.162 Complements ToolBuilder-Morphic-mt.335 =============== Diff against ToolBuilder-Kernel-mt.162 =============== Item was changed: PluggableWidgetSpec subclass: #PluggableTreeSpec + instanceVariableNames: 'roots getSelectedPath setSelectedPath setSelected getSelected setSelectedParent getChildren hasChildren label icon unusedVar menu keyPress doubleClick dropItem dropAccept autoDeselect dragItem dragType nodeClass columns vScrollBarPolicy hScrollBarPolicy dragStarted filterMode searchMode' - instanceVariableNames: 'roots getSelectedPath setSelectedPath setSelected getSelected setSelectedParent getChildren hasChildren label icon unusedVar menu keyPress doubleClick dropItem dropAccept autoDeselect dragItem dragType nodeClass columns vScrollBarPolicy hScrollBarPolicy dragStarted' classVariableNames: '' poolDictionaries: '' category: 'ToolBuilder-Kernel'! !PluggableTreeSpec commentStamp: 'pre 4/24/2018 10:20' prior: 0! A pluggable tree widget. PluggableTrees are slightly different from lists in such that they ALWAYS store the actual objects and use the label selector to query for the label of the item. PluggableTrees also behave somewhat differently in such that they do not have a "getSelected" message but only a getSelectedPath message. The difference is that getSelectedPath is used to indicate by the model that the tree should select the appropriate path. This allows disambiguation of items. Because of this, implementations of PluggableTrees must always set their internal selection directly, e.g., rather than sending the model a setSelected message and wait for an update of the #getSelected the implementation must set the selection before sending the #setSelected message. If a client doesn't want this, it can always just signal a change of getSelectedPath to revert to whatever is needed. Instance variables: roots <Symbol> The message to retrieve the roots of the tree. getSelectedPath <Symbol> The message to retrieve the selected path in the tree. setSelectedPath <Symbol> The message to set the selected path in the tree. setSelected <Symbol> The message to set the selected item in the tree. getChildren <Symbol> The message to retrieve the children of an item hasChildren <Symbol> The message to query for children of an item label <Symbol> The message to query for the label of an item. icon <Symbol> The message to query for the icon of an item. help <Symbol> The message to query for the help of an item. menu <Symbol> The message to query for the tree's menu keyPress <Symbol> The message to process a keystroke. wantsDrop <Symbol> The message to query whether a drop might be accepted. dropItem <Symbol> The message to drop an item. enableDrag <Boolean> Enable dragging from this tree. autoDeselect <Boolean> Whether the tree should allow automatic deselection or not. unusedVar (unused) This variable is a placeholder to fix problems with loading packages in 3.10.! Item was added: + ----- Method: PluggableTreeSpec>>filterMode (in category 'accessing') ----- + filterMode + + ^ filterMode ifNil: [#siblings]! Item was added: + ----- Method: PluggableTreeSpec>>filterMode: (in category 'accessing') ----- + filterMode: aSymbol + "#siblings (default), #visible, #all" + + filterMode := aSymbol.! Item was added: + ----- Method: PluggableTreeSpec>>searchMode (in category 'accessing') ----- + searchMode + + ^ searchMode ifNil: [#breadthFirst]! Item was added: + ----- Method: PluggableTreeSpec>>searchMode: (in category 'accessing') ----- + searchMode: aSymbol + "#breadthFirst (default), #depthFirst" + + searchMode := aSymbol.!

1 0

The Trunk: Morphic-mt.2092.mcz
by commits＠source.squeak.org 23 Feb '23

23 Feb '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2092.mcz ==================== Summary ==================== Name: Morphic-mt.2092 Author: mt Time: 23 February 2023, 3:13:48.782976 pm UUID: b22a193c-cb4d-ef4f-b189-f1ce12cbf7dd Ancestors: Morphic-mt.2091 Complements ToolBuilder-Morphic-mt.335. Increase default type-in filter delay to 1500 milliseconds to account for slow typers by default. Fast typers can hit [backspace] any time for faster reset. =============== Diff against Morphic-mt.2091 =============== Item was added: + ----- Method: IndentingListItemMorph>>applyRecursiveFilter:allowExpand: (in category 'filtering') ----- + applyRecursiveFilter: filter allowExpand: allowExpand + + | selfMatch childMatch | + selfMatch := container matchesPattern: filter contents: contents. + + childMatch := false. + (self isExpanded not and: [allowExpand]) + ifTrue: [self expand]. + self childrenDo: [:child | + (child applyRecursiveFilter: filter allowExpand: allowExpand) ifTrue: [childMatch := true]]. + + selfMatch ifTrue: [ + backgroundColor := FilterBackgroundColor. + childMatch ifFalse: [ + allowExpand + ifTrue: [ + "User is able to expand node again." + self collapse] + ifFalse: [ + "Show at least some context for non-matching children." + self childrenDo: [:child | child extension visible: true] ]]]. + + ^ selfMatch | childMatch + ifTrue: [true] + ifFalse: [self extension visible: false. false]! Item was added: + ----- Method: IndentingListItemMorph>>applyRecursiveFilter:column:allowExpand: (in category 'filtering') ----- + applyRecursiveFilter: filter column: index allowExpand: allowExpand + + | selfMatch childMatch | + index ifNil: [^ self applyRecursiveFilter: filter allowExpand: allowExpand]. + + selfMatch := container matchesPattern: filter contents: contents column: index. + + childMatch := false. + (self isExpanded not and: [allowExpand]) + ifTrue: [self expand]. + self childrenDo: [:child | + (child applyRecursiveFilter: filter column: index allowExpand: allowExpand) + ifTrue: [childMatch := true]]. + + selfMatch ifTrue: [ + backgroundColor := FilterBackgroundColor. + childMatch ifFalse: [ + allowExpand + ifTrue: [self collapse "User is able to expand node again."] + ifFalse: [self childrenDo: [:child | child extension visible: true] ]]]. + + ^ selfMatch | childMatch + ifTrue: [true] + ifFalse: [self extension visible: false. false]! Item was added: + ----- Method: IndentingListItemMorph>>firstChild: (in category 'accessing') ----- + firstChild: aMorph + + firstChild := aMorph.! Item was changed: ----- Method: IndentingListItemMorph>>initializeFromText: (in category 'initialization') ----- initializeFromText: aText "Overridden to keep track of text-based attributes." | priorFont priorEmphasis priorColor | priorFont := self font. priorEmphasis := self emphasis. priorColor := self color. super initializeFromText: aText. self setProperty: #hasFontFromText toValue: priorFont ~~ self font. + self setProperty: #hasEmphasisFromText toValue: priorEmphasis ~~ self emphasis. - self setProperty: #hasEmphasisFromText toValue: priorFont ~~ self emphasis. self setProperty: #hasColorFromText toValue: priorColor ~~ self color.! Item was changed: ----- Method: PluggableListMorph class>>clearFilterDelay (in category 'preferences') ----- clearFilterDelay <preference: 'Filterable Lists Clear Delay' category: 'scrolling' description: 'Defines the maximum delay (in milliseconds) between keystrokes before the filter expression is cleared again.' type: #Number> + ^ ClearFilterDelay ifNil: [1500]! - ^ ClearFilterDelay ifNil: [500]! Item was added: + ----- Method: SimpleHierarchicalListMorph>>collapseAll (in category 'events') ----- + collapseAll + "Do not use #collapse for each child to avoid intermediate layout updates." + + | orphans | + orphans := OrderedCollection new. + self roots do: [:ea | + ea isExpanded: false. + ea firstChild ifNotNil: [:child | child withSiblingsDo: [:node | node recursiveAddTo: orphans]]. + ea firstChild: nil]. + self noteRemovalOfAll: orphans. + + self adjustSubmorphPositions.! Item was changed: ----- Method: SimpleHierarchicalListMorph>>expandAll (in category 'events') ----- expandAll + + selectedMorph ifNil: [^ self]. - (selectedMorph isNil - or: [selectedMorph isExpanded]) - ifTrue: [^self]. self expandAll: selectedMorph. self adjustSubmorphPositions! Item was changed: ----- Method: SimpleHierarchicalListMorph>>expandAll: (in category 'events') ----- expandAll: aMorph + + aMorph canExpand ifFalse: [^ self]. + aMorph isExpanded ifFalse: [aMorph toggleExpandedState]. + aMorph childrenDo: [:child | self expandAll: child].! - | allChildren | - aMorph toggleExpandedState. - allChildren := OrderedCollection new: 10. - aMorph recursiveAddTo: allChildren. - allChildren do: [:each | - (each canExpand and: [each isExpanded not]) - ifTrue: [self expandAll: each]]. - ! Item was changed: ----- Method: SimpleHierarchicalListMorph>>itemFromPoint: (in category 'event handling') ----- itemFromPoint: aPoint "Return the list element (morph) at the given point or nil if outside" | ptY visibleRows | scroller hasSubmorphs ifFalse:[^nil]. (scroller fullBounds containsPoint: aPoint) ifFalse:[^nil]. visibleRows := scroller submorphs select: [:m | m visible]. ptY := (visibleRows first point: aPoint from: self) y. "note: following assumes that submorphs are vertical, non-overlapping, and ordered" visibleRows first top > ptY ifTrue:[^nil]. + visibleRows last bottom < ptY ifTrue:[^visibleRows last]. - visibleRows last bottom < ptY ifTrue:[^nil]. "now use binary search" ^visibleRows findBinary:[:item| (item top <= ptY and:[item bottom >= ptY]) ifTrue:[0] "found" ifFalse:[ (item top + item bottom // 2) > ptY ifTrue:[-1] ifFalse:[1]]] ifNone: [nil]! Item was changed: ----- Method: SimpleHierarchicalListMorph>>update: (in category 'updating') ----- update: aSymbol aSymbol == getSelectionSelector ifTrue: + [self updateSelection. - [self selection: self getCurrentSelectionItem. ^self]. aSymbol == getListSelector ifTrue: [self list: self getList. ^self]. ((aSymbol isKindOf: Array) and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) ifTrue: [^(scroller submorphs at: 1 ifAbsent: [^self]) openPath: aSymbol allButFirst]! Item was added: + ----- Method: SimpleHierarchicalListMorph>>updateSelection (in category 'updating') ----- + updateSelection + "Fetch selected item from the model." + + self selection: self getCurrentSelectionItem.!

1 0

The Trunk: ToolBuilder-Morphic-mt.335.mcz
by commits＠source.squeak.org 23 Feb '23

23 Feb '23

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.335.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.335 Author: mt Time: 23 February 2023, 3:12:28.597976 pm UUID: 19b45f10-c2e0-aa42-9cf9-4cde199d101f Ancestors: ToolBuilder-Morphic-mt.334 Some updates for our tree widgets: - filter modes (type-in): #siblings (default), #visible, #all - search modes (CMD+F/G): #breadthFirst (default), #depthFirst - [backspace] can be used to abort filtering and toggle prior selection (like in lists); [return] will also reset the filter but keep the current selection - select last item when clicking past the last (like in lists) - selection updates: if models omit to communicate the current (i.e., to-be-expanded) path for the current selection, try to fetch that selected path automatically and then try again to set the selection - some bugfixes regarding empty selections and filter updates - new model-changed operations: > model changed: #labelOf: (i.e., getLabelSelector) ... to refresh all labels > model changed: #expandAllNodesRequested with: ... to expand everything behind a specific node (or all roots) > model changed: #expandNodeRequested with: ... to expand one level behind a specific node ! Be aware that the #all type-in filter assumes that there are no recursive model structures. That's why the default #filterMode in the ObjectExplorer is still #siblings. ! =============== Diff against ToolBuilder-Morphic-mt.334 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableTree: (in category 'widgets required') ----- buildPluggableTree: aSpec | widget | widget := self treeClass new. self register: widget id: aSpec name. widget getLabelSelector: aSpec label. widget getIconSelector: aSpec icon. widget model: aSpec model. widget nodeClass: aSpec nodeClass. widget getRootsSelector: aSpec roots. widget getChildrenSelector: aSpec getChildren. widget hasChildrenSelector: aSpec hasChildren. + + widget filterMode: aSpec filterMode. + widget searchMode: aSpec searchMode. - widget getSelectedSelector: aSpec getSelected. - widget setSelectedSelector: aSpec setSelected. widget getSelectedPathSelector: aSpec getSelectedPath. widget setSelectedPathSelector: aSpec setSelectedPath. + widget getSelectedSelector: aSpec getSelected. + widget setSelectedSelector: aSpec setSelected. widget setSelectedParentSelector: aSpec setSelectedParent. widget getHelpSelector: aSpec help. widget getMenuSelector: aSpec menu. widget keystrokeActionSelector: aSpec keyPress. widget autoDeselect: aSpec autoDeselect. widget doubleClickSelector: aSpec doubleClick. widget dropItemSelector: aSpec dropItem. widget wantsDropSelector: aSpec dropAccept. widget dragItemSelector: aSpec dragItem. widget dragStartedSelector: aSpec dragStarted. widget dragTypeSelector: aSpec dragType. widget columns: aSpec columns. "Override default scroll bar policies if needed. Widget will use preference values otherwise." aSpec hScrollBarPolicy ifNotNil: [:policy | policy caseOf: { [#always] -> [widget alwaysShowHScrollBar]. [#never] -> [widget hideHScrollBarIndefinitely]. [#whenNeeded] -> [widget showHScrollBarOnlyWhenNeeded]. } ]. aSpec vScrollBarPolicy ifNotNil: [:policy | policy caseOf: { [#always] -> [widget alwaysShowVScrollBar]. [#never] -> [widget hideVScrollBarIndefinitely]. [#whenNeeded] -> [widget showVScrollBarOnlyWhenNeeded]. } ]. self setFrame: aSpec frame in: widget. self setLayoutHintsFor: widget spec: aSpec. parent ifNotNil:[self add: widget to: parent]. " panes ifNotNil:[ aSpec roots ifNotNil:[panes add: aSpec roots]. ]. " ^widget! Item was changed: SimpleHierarchicalListMorph subclass: #PluggableTreeMorph + instanceVariableNames: 'rootWrappers selectedWrapper getRootsSelector getChildrenSelector hasChildrenSelector getLabelSelector getIconSelector getSelectedPathSelector setSelectedPathSelector setSelectedParentSelector getHelpSelector dropItemSelector wantsDropSelector dragItemSelector dragTypeSelector nodeClass lastKeystrokeTime lastKeystrokes dragStartedSelector doubleClickSelector findText findQueue filterColumnIndex filterMode searchMode priorSelection' + classVariableNames: '' - instanceVariableNames: 'rootWrappers selectedWrapper getRootsSelector getChildrenSelector hasChildrenSelector getLabelSelector getIconSelector getSelectedPathSelector setSelectedPathSelector setSelectedParentSelector getHelpSelector dropItemSelector wantsDropSelector dragItemSelector dragTypeSelector nodeClass lastKeystrokeTime lastKeystrokes dragStartedSelector doubleClickSelector findText findQueue filterColumnIndex' - classVariableNames: 'FilterByLabelsOnly MaximumSearchDepth' poolDictionaries: '' category: 'ToolBuilder-Morphic'! !PluggableTreeMorph commentStamp: 'ar 2/12/2005 04:38' prior: 0! A pluggable tree morph.! Item was added: + ----- Method: PluggableTreeMorph>>checkFilterMode: (in category 'filtering') ----- + checkFilterMode: aSymbol + + aSymbol == #siblings ifTrue: [^ self]. + aSymbol == #visible ifTrue: [^ self]. + aSymbol == #all ifTrue: [^ self]. + + Error signal: 'Invalid value for filter mode. Use #siblings, #visible, or #all.'.! Item was added: + ----- Method: PluggableTreeMorph>>checkSearchMode: (in category 'searching') ----- + checkSearchMode: aSymbol + + aSymbol == #breadthFirst ifTrue: [^ self]. + aSymbol == #depthFirst ifTrue: [^ self]. + + Error signal: 'Invalid value for search mode. Use #breadthFirst or #depthFirst.'.! Item was added: + ----- Method: PluggableTreeMorph>>collapseAllButSelection (in category 'filtering') ----- + collapseAllButSelection + "If the filterMode is set to #all, filtering will expand (and collapse) nodes. Thus, it is can be useful to collapse all nodes again but show the current selection to get an overview again when removing the filter." + + | selectedPath | + self fixateSelectionDuring: [ + selectedPath := self selectedPath. + selectedMorph := nil. "Avoid selection update via #collapseAll. See #noteRemovalOfAll:." + self collapseAll. + self selectedPath: selectedPath].! Item was added: + ----- Method: PluggableTreeMorph>>currentSelectionItem: (in category 'selection') ----- + currentSelectionItem: itemOrNil + "Variation of #selection: to ensure identity check for model data. See #updateSelection." + + | i | + itemOrNil ifNil: [^ self selectionIndex: 0]. + i := scroller submorphs findFirst: [:m | m complexContents item == itemOrNil]. + self selectionIndex: i! Item was added: + ----- Method: PluggableTreeMorph>>filterMode (in category 'accessing') ----- + filterMode + + ^ filterMode ifNil: [filterMode := #siblings]! Item was added: + ----- Method: PluggableTreeMorph>>filterMode: (in category 'accessing') ----- + filterMode: aSymbol + "#siblings, #visible, #all" + + self checkFilterMode: aSymbol. + filterMode := aSymbol.! Item was changed: ----- Method: PluggableTreeMorph>>filterTerm: (in category 'filtering') ----- filterTerm: aString lastKeystrokes = aString ifTrue: [^ self]. lastKeystrokes := aString. + self hasFilter + ifTrue: [self filterTree] + ifFalse: [self removeFilter].! - self filterTreeNow.! Item was changed: ----- Method: PluggableTreeMorph>>filterTree (in category 'filtering') ----- filterTree | currentParent firstMatch | + self filterMode = #siblings ifTrue: [ + "For expanded selections, we assume that the user is already looking at the children. This is beneficial for the ObjectExplorer and a useful heuristic in general." + self selectedMorph ifNotNil: [:focus | + focus isExpanded ifTrue: [self setSelectedMorph: focus firstChild]]]. + "Update the filter, try to keep selection stable." self fixateSelectionDuring: [self filterTreeNow]. + "Now update selection and scroll position as needed." self hoveredMorph: nil. currentParent := self selectedParentMorph. firstMatch := currentParent ifNil: [self roots detect: [:ea | ea visible]] ifNotNil: [:pm | pm firstVisibleChild]. + self selectedMorph + ifNil: [self scrollToTop] + ifNotNil: [:focus | + focus visible ifFalse: [ + "Select the first match only if current selection does not match anymore." + self setSelectedMorph: firstMatch. + self scrollSelectionAndExtraIntoView. + "Keep parent visible to provide context information. Ensure visibility of current selection." + self scrollSelectionParentIntoView: currentParent]].! - self selectedMorph visible ifFalse: [ - "Select the first match only if current selection does not match anymore." - self setSelectedMorph: firstMatch. - self scrollSelectionAndExtraIntoView. - "Keep parent visible to provide context information. Ensure visibility of current selection." - self scrollSelectionParentIntoView: currentParent].! Item was added: + ----- Method: PluggableTreeMorph>>filterTreeButSelection (in category 'filtering') ----- + filterTreeButSelection + "Similar to #collapseAllButSelection. Apply the filter but make sure the current selection stays unchanged." + + | selectedPath | + self fixateSelectionDuring: [ + selectedPath := self selectedPath. + selectedMorph := nil. "Avoid selection update via #collapseAll. See #noteRemovalOfAll:." + self filterTree. + self selectedPath: selectedPath].! Item was changed: ----- Method: PluggableTreeMorph>>filterTreeNow (in category 'filtering') ----- filterTreeNow - | any | self hasFilter ifFalse: [^ self removeFilter]. "Show all current items again before filtering them out." scroller submorphsDo: [:m | m removeFilter]. + (self filterMode caseOf: { + [#siblings] -> [self filterTreeNowSiblings "default"]. + [#visible] -> [self filterTreeNowVisible]. + [#all] -> [self filterTreeNowAll] }) + ifFalse: [ "Remove the last character and try filtering again." + lastKeystrokes := lastKeystrokes allButLast: 1. + ^ self filterTreeNow]. - "Filter the children of the current parent. Do not filter the parent." - any := false. - self selectedParentMorph - ifNil: [self roots do: [:each | - each collapse. "Avoid inadvertent walk-down. See #treeFilterAppend:." - (each applyFilter: lastKeystrokes column: filterColumnIndex) ifTrue: [any := true]]] - ifNotNil: [:pm | pm childrenDo: [:each | - each collapse. "Avoid inadvertent walk-down. See #treeFilterAppend:." - (each applyFilter: lastKeystrokes column: filterColumnIndex) ifTrue: [any := true]]]. - - any ifFalse: [ - "Remove the last character and try filtering again." - lastKeystrokes := lastKeystrokes allButLast: 1. - ^ self filterTreeNow]. + self adjustSubmorphPositions.! - self adjustSubmorphPositions! Item was added: + ----- Method: PluggableTreeMorph>>filterTreeNowAll (in category 'filtering') ----- + filterTreeNowAll + "Apply the current filter term to all nodes. Expand collapsed nodes if needed." + + | any | + any := false. + self roots do: [:each | + (each applyRecursiveFilter: lastKeystrokes column: filterColumnIndex allowExpand: true) + ifTrue: [any := true]]. + ^ any! Item was added: + ----- Method: PluggableTreeMorph>>filterTreeNowSiblings (in category 'filtering') ----- + filterTreeNowSiblings + "Filter the children of the current parent. Do not filter the parent." + + | any | + any := false. + + self selectedParentMorph + ifNil: [self roots do: [:each | + each collapse. "Avoid inadvertent walk-down. See #filterTree." + (each applyFilter: lastKeystrokes column: filterColumnIndex) ifTrue: [any := true]]] + ifNotNil: [:pm | pm childrenDo: [:each | + each collapse. "Avoid inadvertent walk-down. See #filterTree." + (each applyFilter: lastKeystrokes column: filterColumnIndex) ifTrue: [any := true]]]. + + ^ any! Item was added: + ----- Method: PluggableTreeMorph>>filterTreeNowVisible (in category 'filtering') ----- + filterTreeNowVisible + "Apply the current filter term to all (potentially) visible (or expanded) nodes. Do not change any isExpanded state." + + | any | + any := false. + self roots do: [:each | + (each applyRecursiveFilter: lastKeystrokes column: filterColumnIndex allowExpand: false) + ifTrue: [any := true]]. + ^ any! Item was changed: ----- Method: PluggableTreeMorph>>find (in category 'searching') ----- find "Prompt the user for a string to search for breadth first in the tree." | path | self setSearchFromSelection. + path := self selectedPathWrappers ifNotEmpty: [:p | p allButLast]. - path := self selectedPath. (Project uiManager request: ('{1} -> ...\\Find what to select in subtree?' translated withCRs format: {(path collect: [:ea | ea itemName]) joinSeparatedBy: ' -> '}) initialAnswer: findText) ifEmpty: [^ self] ifNotEmpty: [:reply | findText := reply. + findQueue := path + ifEmpty: [self roots collect: [:ea | {ea complexContents}] as: OrderedCollection] + ifNotEmpty: [path last contents collect: [:nextItem | path copyWith: nextItem] as: OrderedCollection]. - findQueue := OrderedCollection withAll: (path last contents collect: [:nextItem | path copyWith: nextItem]). self findAgainNow].! Item was changed: ----- Method: PluggableTreeMorph>>findAgainNow (in category 'searching') ----- findAgainNow - | currentPath | (findQueue isNil or: [findQueue isEmpty]) ifTrue: [^ self flash]. + - - self flag: #todo. "mt: Ask model about breadth-first or depth-first, indicate search progress in UI, allow find-again-backwards, ..." - Cursor wait showWhile: [ + (self searchMode caseOf: { + [#breadthFirst] -> [self findAgainNowBreadthFirst]. + [#depthFirst] -> [self findAgainNowDepthFirst] }) + ifNotNil: [:currentPath | + "Search used model data. View might already be outdated. + Collapse parent now to get up-to-date children." + self selectedMorph ifNotNil: [:focus | + focus isExpanded ifTrue: [ + self toggleExpandedState: self selectedMorph]]. + "Match!! Stop search for now. Select the match." + self selectedPathWrappers: currentPath. + self selectedMorph ifNil: [ + ^ self inform: 'Could not find path. View up to date?' translated]. + "Mimic filter function to highlight (and filter) search results." + lastKeystrokes := findText. + self filterTree. + self scrollSelectionAndExtraIntoView. + ^ self]]. - [findQueue notEmpty] whileTrue: [ - | currentItem | - currentPath := findQueue removeFirst. - currentItem := currentPath last. - currentItem hasContents ifTrue: [ - findQueue addAll: (currentItem contents collect: [:nextItem | currentPath copyWith: nextItem])]. - - (self matches: findText in: currentItem) ifTrue: [ - "Search used model data. View might already be outdated. - Collapse parent now to get up-to-date children." - self selectedMorph isExpanded ifTrue: [ - self toggleExpandedState: self selectedMorph]. - "Match!! Stop search for now. Select the match." - self selectPath: (currentPath collect: [:ea | ea item]). - self selectedMorph ifNil: [ - ^ self inform: 'Could not find path. View up to date?' translated]. - "Revert a side-effect from #selectPath:." - self selectedMorph isExpanded ifTrue: [ - self toggleExpandedState: self selectedMorph]. - "Mimic filter function to highlight (and filter) search results." - lastKeystrokes := findText. - self filterTree. - self scrollSelectionAndExtraIntoView. - ^ self]]]. self inform: 'Nothing found.' translated.! Item was added: + ----- Method: PluggableTreeMorph>>findAgainNowBreadthFirst (in category 'searching') ----- + findAgainNowBreadthFirst + + [findQueue notEmpty] whileTrue: [ + | currentItem currentPath | + currentPath := findQueue removeFirst. + currentItem := currentPath last. + currentItem hasContents ifTrue: [ + findQueue addAll: (currentItem contents collect: [:nextItem | currentPath copyWith: nextItem])]. + (self matches: findText in: currentItem) ifTrue: [^ currentPath]]. + + ^ nil! Item was added: + ----- Method: PluggableTreeMorph>>findAgainNowDepthFirst (in category 'searching') ----- + findAgainNowDepthFirst + + [findQueue notEmpty] whileTrue: [ + | currentItem currentPath | + currentPath := findQueue removeFirst. + currentItem := currentPath last. + currentItem hasContents ifTrue: [ + findQueue addAllFirst: (currentItem contents collect: [:nextItem | currentPath copyWith: nextItem])]. + (self matches: findText in: currentItem) ifTrue: [^ currentPath]]. + + ^ nil! Item was changed: ----- Method: PluggableTreeMorph>>fixateSelectionDuring: (in category 'selection') ----- fixateSelectionDuring: aBlock | vDelta | selectedMorph ifNil: [aBlock value. ^ self]. vDelta := ((selectedMorph localPointToGlobal: selectedMorph topLeft) - (scroller localPointToGlobal: scroller topLeft)) y. aBlock value. + (selectedMorph notNil and: [selectedMorph visible]) ifTrue: [ - selectedMorph visible ifTrue: [ self scrollToBottom. self scrollToShow: (selectedMorph bounds outsetBy: (0@vDelta corner: 0@0))].! Item was removed: - ----- Method: PluggableTreeMorph>>getCurrentSelectionItem (in category 'selection') ----- - getCurrentSelectionItem - "Our models are supposed to return real objects, not wrappers. See PluggableTreeItemNode." - - | selectedObject | - selectedObject := self getSelectedSelector - ifNil: [^ nil] - ifNotNil: [:symbol | model perform: symbol]. - ^ scroller submorphs - detect: [:each | each complexContents item == selectedObject] - ifFound: [:each | each complexContents] - ifNone: [nil]! Item was changed: ----- Method: PluggableTreeMorph>>highlightNoColumn (in category 'filtering') ----- highlightNoColumn + "Reset the filter including any column-specific focus." + - filterColumnIndex := nil. + self hasFilter ifTrue: [self removeFilter].! - self removeFilter.! Item was changed: ----- Method: PluggableTreeMorph>>removeFilter (in category 'filtering') ----- removeFilter + "Remove the current filter. Keep the current selection stable unless it is expanded and needs more space for its children. Note that we must not check for #hasFilter here but in the sender if needed; see #filterTreeNow." - "Remove the current filter. Keep the current selection stable unless it is expanded and needs more space for its children." + lastKeystrokes := String empty. - self fixateSelectionDuring: [ - self filterTerm: String empty. - scroller submorphsDo: [:m | m removeFilter]. - self adjustSubmorphPositions]. + self filterMode = #all + ifTrue: [ + scroller submorphsDo: [:m | m removeFilter]. + self collapseAllButSelection] + ifFalse: [ + self fixateSelectionDuring: [ + scroller submorphsDo: [:m | m removeFilter]. + self adjustSubmorphPositions]]. + "Try to show all children again for the current selection." self scrollSelectionAndChildrenIntoView. self scrollSelectionAndExtraIntoView.! Item was added: + ----- Method: PluggableTreeMorph>>searchMode (in category 'accessing') ----- + searchMode + + ^ searchMode ifNil: [searchMode := #breadthFirst]! Item was added: + ----- Method: PluggableTreeMorph>>searchMode: (in category 'accessing') ----- + searchMode: aSymbol + "#breadthFirst, #depthFirst" + + self checkSearchMode: aSymbol. + searchMode := aSymbol.! Item was changed: ----- Method: PluggableTreeMorph>>selectPath: (in category 'selection') ----- selectPath: path + "Select the given path. Do not tell the model. Just update the view." + | newSelection | + path ifNil: [^ self]. + path ifEmpty: [^ self selectedMorph: nil]. + scroller hasSubmorphs ifFalse: [^ self]. + + newSelection := self selectPath: path in: scroller firstSubmorph. + self adjustSubmorphPositions. "First adjust, then select to keep selection visible." + self selectedMorph: newSelection.! - self - selectPath: path - in: (scroller submorphs at: 1 ifAbsent: [^self]).! Item was changed: ----- Method: PluggableTreeMorph>>selectPath:in: (in category 'selection') ----- selectPath: path in: listItem + "Private. Use #selectPath:." + - path ifNil: [^self]. - path isEmpty ifTrue: [^self setSelectedMorph: nil]. listItem withSiblingsDo: [:each | + each complexContents item = path first ifTrue: [ + each extension visible: true. "Ensure visibility in case of a filter." - (each complexContents item = path first) ifTrue: [ - each isExpanded ifFalse: [ - each toggleExpandedState. - self adjustSubmorphPositions. - ]. - each changed. path size = 1 ifTrue: [ + "Complete match. Finished." + ^ each]. + each isExpanded ifFalse: [ + each toggleExpandedState]. + ^ each firstChild ifNotNil: [:firstChild | + "Partial match. Go on..." + self selectPath: path allButFirst in: firstChild]]]. + ^ nil! - ^self setSelectedMorph: each - ]. - each firstChild ifNil: [^self setSelectedMorph: nil]. - ^self selectPath: path allButFirst in: each firstChild - ]. - ]. - ^self setSelectedMorph: nil - - ! Item was changed: ----- Method: PluggableTreeMorph>>selectedPath (in category 'selection') ----- selectedPath - "Answers the current path without asking the model." + ^ self selectedPathWrappers collect: [:ea | ea item]! - | current path | - current := self selectedMorph. - path := OrderedCollection new. - [current notNil] whileTrue: [ - path add: current. - current := self parentMorphOf: current]. - ^ (path size to: 1 by: -1) collect: [:ea | - (path at: ea) complexContents]! Item was added: + ----- Method: PluggableTreeMorph>>selectedPath: (in category 'selection') ----- + selectedPath: path + "For consistency with #selectedMorph:." + + self selectPath: path.! Item was added: + ----- Method: PluggableTreeMorph>>selectedPathWrappers (in category 'selection') ----- + selectedPathWrappers + "Answers the current path without asking the model." + + | current path | + current := self selectedMorph. + path := OrderedCollection new. + [current notNil] whileTrue: [ + path add: current. + current := self parentMorphOf: current]. + ^ (path size to: 1 by: -1) collect: [:ea | + (path at: ea) complexContents]! Item was added: + ----- Method: PluggableTreeMorph>>selectedPathWrappers: (in category 'selection') ----- + selectedPathWrappers: pathWrappers + + self selectedPath: (pathWrappers collect: [:ea | ea item]).! Item was changed: ----- Method: PluggableTreeMorph>>setSelectedPath: (in category 'selection') ----- setSelectedPath: aMorph + "Tell the model about the currently selected path. The view is already up-to-date." | items wrapperPath | setSelectedPathSelector ifNotNil: [wrapperPath := selectedWrapper ifNil: [#()] ifNotNil: [ wrapperPath := {selectedWrapper} asOrderedCollection. [wrapperPath last parent notNil] whileTrue: [wrapperPath addLast: wrapperPath last parent]. wrapperPath]. items := wrapperPath collect: [:w | w item]. model perform: setSelectedPathSelector with: items]. ! Item was changed: ----- Method: PluggableTreeMorph>>specialKeyPressed: (in category 'event handling') ----- specialKeyPressed: asciiValue (super specialKeyPressed: asciiValue) ifTrue: [^ true]. asciiValue = Character tab asciiValue ifTrue: [ self highlightNextColumn. ^ true]. (#(8 13) includes: asciiValue) ifTrue: [ + "backspace key or return key" - "backspace key" self highlightNoColumn. "i.e., remove filter" + priorSelection ifNotNil: [:prior | + priorSelection := self selectedPath. + asciiValue = 8 ifTrue: [ "backspace key -> revert selection" + self selectedPath: prior. + self setSelectedMorph: self selectedMorph]]. ^ true]. ^ false! Item was changed: ----- Method: PluggableTreeMorph>>toggleExpandedState: (in category 'keyboard navigation') ----- toggleExpandedState: aMorph aMorph toggleExpandedState. + self adjustSubmorphPositions. - " (self hasFilter and: [aMorph isExpanded not and: [aMorph canExpand]]) - ifTrue: [aMorph expandFiltered -- useful at all?] - ifFalse: [aMorph toggleExpandedState]. - " self adjustSubmorphPositions. aMorph isExpanded ifTrue: [self scrollSelectionAndChildrenIntoView] ifFalse: [self scrollSelectionAndExtraIntoView].! Item was changed: ----- Method: PluggableTreeMorph>>treeFilterAppend: (in category 'filtering') ----- treeFilterAppend: aChar | milliseconds slowKeyStroke | model okToChange ifFalse: [^ self]. milliseconds := Time millisecondClockValue. slowKeyStroke := (Time milliseconds: milliseconds since: lastKeystrokeTime) > self class clearFilterDelay. lastKeystrokeTime := milliseconds. slowKeyStroke + ifFalse: [lastKeystrokes := lastKeystrokes , aChar asLowercase asString.] + ifTrue: [lastKeystrokes := aChar asLowercase asString. + priorSelection := self selectedPath]. - ifTrue: [lastKeystrokes := aChar asLowercase asString] - ifFalse: [lastKeystrokes := lastKeystrokes , aChar asLowercase asString.]. self filterableTree + ifTrue: [self filterTree] - ifTrue: [ - "For expanded selections, we assume that the user is already looking at the children." - self selectedMorph isExpanded - ifTrue: [self setSelectedMorph: self selectedMorph firstChild]. - self filterTree] ifFalse: [self selectNextMorphByFilter].! Item was changed: ----- Method: PluggableTreeMorph>>update: (in category 'updating') ----- update: what what ifNil:[^self]. what == getRootsSelector ifTrue:[ self wrapRoots: (model perform: getRootsSelector). ^ self]. what == getSelectedPathSelector ifTrue:[ + self updateSelectedPath. - self selectPath: self getSelectedPath. ^ self]. + + what == getLabelSelector ifTrue: [ + self updateAllLabels. + ^ self]. what == #expandRootsRequested ifTrue: [ self expandRoots. ^ self]. super update: what. ! Item was changed: ----- Method: PluggableTreeMorph>>update:with: (in category 'updating') ----- update: what with: anObject super update: what with: anObject. what == #objectChanged ifTrue: [ + ^ self updateFromChangedObject: anObject]. + what == #expandAllNodesRequested ifTrue: [ + "EX: model changed: #expandAllNodesRequested with: #classChildren:." + "EX: model changed: #expandAllNodesRequested with: {#classChildren:. Morph}." + | scope item | + scope := anObject isArray ifTrue: [anObject first] ifFalse: [anObject]. + item := anObject isArray ifTrue: [anObject second]. + getChildrenSelector == scope ifTrue: [ + item + ifNil: [self roots do: [:ea | self expandAll: ea]] + ifNotNil: [self expandAll: (scroller submorphs detect: [:ea | ea complexContents item == item])]. + self adjustSubmorphPositions. + ^ self]]. + what == #expandNodeRequested ifTrue: [ + "EX: model changed: #expandNodeRequested with: {#classChildren:. Morph}." + | scope item | + scope := anObject first. + item := anObject second. + getChildrenSelector == scope ifTrue: [ + scroller submorphs + detect: [:ea | ea complexContents item == item] + ifFound: [:morph | (morph canExpand and: [morph isExpanded not]) + ifTrue: [self toggleExpandedState: morph]]. + ^ self]].! - self updateFromChangedObject: anObject].! Item was added: + ----- Method: PluggableTreeMorph>>updateAllLabels (in category 'updating') ----- + updateAllLabels + + scroller submorphs do: [:ea | ea contents: ea getLabel]. + "self adjustSubmorphPositions. --- not required"! Item was added: + ----- Method: PluggableTreeMorph>>updateSelectedPath (in category 'updating') ----- + updateSelectedPath + "Fetch selected path from the model. Also tell the model about the new selection. There is no need that the model notifies about both kinds of selection changes, either one (path or item) is enough." + + self selectedPath: self getSelectedPath. + self setSelectedMorph: self selectedMorph.! Item was added: + ----- Method: PluggableTreeMorph>>updateSelection (in category 'updating') ----- + updateSelection + "Overwritten to try to fetch the current path if the selection cannot be found. Also, in case of a filter, ensure that the selection is always visible." + + | item | + self currentSelectionItem: (item := self getCurrentSelectionItem). + item ifNotNil: [ + self selectedMorph + ifNil: [self updateSelectedPath] + ifNotNil: [:focus | focus visible ifFalse: [ + self selectedPath: self selectedPath]]]! Item was changed: ----- Method: PluggableTreeMorph>>wrapRoots: (in category 'updating') ----- wrapRoots: someObjects rootWrappers := someObjects collect: [:item| self nodeClass with: item model: self]. + self list: rootWrappers. + self hasFilter ifTrue: [ + self filterMode = #siblings + ifTrue: [self removeFilter "bc. it depends on the current selection"] + ifFalse: [self filterTreeButSelection]].! - self list: rootWrappers.!

1 0

← Newer
1
2
3
4
5
6
7
8
...
11
Older →