Squeak-dev

squeak-dev@lists.squeakfoundation.org

16 participants
79922 discussions

The Trunk: Morphic-ct.2155.mcz
by commits＠source.squeak.org 03 May '24

03 May '24

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2155.mcz ==================== Summary ==================== Name: Morphic-ct.2155 Author: ct Time: 3 May 2024, 6:24:46.710377 pm UUID: ea10ff8e-6579-4cd4-9131-d2af6e8a800a Ancestors: Morphic-mt.2152 Fixes halo transfer to morphs that overlap with another morph that overlaps with the current halo. This was a regression from Morphic-ct.1794. =============== Diff against Morphic-mt.2152 =============== Item was changed: ----- Method: MorphicHaloDispatcher>>dispatchHalo:createFor: (in category 'dispatching') ----- dispatchHalo: anEvent createFor: aContainer "Invoke a halo on any aContainer's submorph that wants it. Dispatch uses anEvent's #position. The dispatch only ends in that container if no other morph wants it. Note that the event's #shiftPressed state determines whether the dispatch goes innermost-to-outermost (if pressed) or the other way around (if not pressed). If there already is a halo, check whether the event still points into the same hierarchy. If it does, do nothing here but rely on the halo itself to process the event (see implementors of #transferHalo:from:). If, however, the event points to a different hierarchy in the container, invoke a new halo and discard the current one. We do this here because the current halo should not bother with its container but only its #target." | stack innermost haloTarget | "The stack is the frontmost (i.e. innermost) to backmost (i.e. outermost) morph." stack := (aContainer morphsAt: anEvent position unlocked: true useFullBounds: true) select: [ : each | each wantsHaloFromClick or: [ each isRenderer ] ]. "self assert: [ stack last == aContainer ]." innermost := anEvent hand halo ifNil: [ stack first ] ifNotNil: [ : existingHalo | "self assert: [ existingHalo wantsHaloFromClick not ]. " stack + detect: [ : each | each owner == aContainer ] - detect: [ : each | each owner == aContainer - and: [ existingHalo bounds intersects: (existingHalo haloBoundsFor: each) ] ] ifFound: [ : topInContainer | "Is existingHalo's target part of the same topInContainer as the morph clicked?" (existingHalo target withAllOwners includes: topInContainer) ifTrue: [ "same hierarchy, let #transferHalo: continue to handle it for now." ^ false ] ifFalse: [ "different hierarchy, remove + add." anEvent hand removeHalo. anEvent shiftPressed ifTrue: [ stack first ] ifFalse: [ topInContainer ] ] ] ifNone: [ "existingHalo is on the World, defer to #transferHalo: for now." ^ false ] ]. "If modifier key is pressed, start at innermost (the target), otherwise the outermost (direct child of the world (self))." haloTarget := (innermost == aContainer or: [ anEvent shiftPressed ]) ifTrue: [ innermost ] ifFalse: [ "Find the outermost owner that wants it. Ignore containment above aContainer." stack := innermost withAllOwners. (stack first: (stack findFirst: [ : each | each owner == aContainer ])) reversed detect: [ : each | each wantsHaloFromClick or: [ each isRenderer ] ] ifNone: [ "haloTarget has its own mouseDown handler, don't halo." ^ false ] ]. "Now that we have the haloTarget, show the halo." self invokeHaloOrMove: anEvent on: haloTarget. ^ true!

1 0

The Trunk: Collections-ct.1067.mcz
by commits＠source.squeak.org 03 May '24

03 May '24

Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1067.mcz ==================== Summary ==================== Name: Collections-ct.1067 Author: ct Time: 2 May 2024, 8:39:12.852788 pm UUID: bd1e7a83-4090-4c9f-917a-b73e19e850c1 Ancestors: Collections-nice.1060 Fixes typo in String>>truncateWithElipsisTo: but keeps the old method to preserve compatibility. Adds truncateWithEllipsisTo: on Text as well. =============== Diff against Collections-nice.1060 =============== Item was changed: ----- Method: String>>truncateWithElipsisTo: (in category 'converting') ----- truncateWithElipsisTo: maxLength + "Historical typo kept for compatibility." - "Return myself or a copy suitably shortened but with elipsis added" + ^ self truncateWithEllipsisTo: maxLength! - ^ self size <= maxLength - ifTrue: - [self] - ifFalse: - [(self copyFrom: 1 to: (maxLength - 3)), '...'] - - - "'truncateWithElipsisTo:' truncateWithElipsisTo: 20"! Item was added: + ----- Method: String>>truncateWithEllipsisTo: (in category 'converting') ----- + truncateWithEllipsisTo: maxLength + "Return myself or a copy suitably shortened but with ellipsis added" + + ^ self size <= maxLength + ifTrue: + [self] + ifFalse: + [(self copyFrom: 1 to: (maxLength - 3)), '...'] + + + "'truncateWithEllipsisTo:' truncateWithEllipsisTo: 20"! Item was added: + ----- Method: Text>>truncateWithEllipsisTo: (in category 'converting') ----- + truncateWithEllipsisTo: maxLength + "Return myself or a copy suitably shortened but with ellipsis added" + + ^ self size <= maxLength + ifTrue: + [self] + ifFalse: + [(self copyFrom: 1 to: (maxLength - 3)), '...']!

2 1

keyCode vs keyValue
by Lauren Pullen 03 May '24

03 May '24

Hi List, I'm curious about a behavior I ran into involving the difference between a keystroke and a keyDown and their numeric values. When I press the directional arrows, I get a different keyValue depending on whether the event was a keystroke or a keyDown. Take for example the up arrow. The scan code is 126 in both cases, but a keystroke has the keyValue of 30 and a keyDown has the keyValue of 126. Why are they different?

3 3

The Trunk: SUnit-cmm.146.mcz
by commits＠source.squeak.org 02 May '24

02 May '24

Chris Muller uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-cmm.146.mcz ==================== Summary ==================== Name: SUnit-cmm.146 Author: cmm Time: 30 April 2024, 12:43:19.759559 am UUID: 51424d55-94d0-4d2e-b8dc-f470b05cb44d Ancestors: SUnit-mt.145 Let SUnit provide consistent results when running vs. debugging, rather than quietly hiding SUnit timeout configuration bugs when debugging. =============== Diff against SUnit-mt.145 =============== Item was changed: ----- Method: TestCase>>debug (in category 'running') ----- debug "Run the receiver and open a debugger on the first failure or error." + ^ self assureResourcesDuring: [self runCase]! - ^ self assureResourcesDuring: [self runCaseWithoutTimeout]! Item was changed: ----- Method: TestCase>>debugAsFailure (in category 'running') ----- debugAsFailure "Spawn a debugger that is ready to debug the receiver." (Process forBlock: [self debug] runUntil: [:context | context isClosureContext "navigate the process directly to the point where it is about to send #setUp" + and: [context selector = #runCase]]) - and: [context selector = #runCaseWithoutTimeout]]) debug.!

5 5

The Trunk: SUnit-cmm.147.mcz
by commits＠source.squeak.org 01 May '24

01 May '24

Chris Muller uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-cmm.147.mcz ==================== Summary ==================== Name: SUnit-cmm.147 Author: cmm Time: 1 May 2024, 3:44:58.989279 pm UUID: fa6494d6-4801-4f74-b349-938d8125ba74 Ancestors: SUnit-cmm.146 Revert cmm.146 and continue override #defaultTimeout instead. =============== Diff against SUnit-cmm.146 =============== Item was changed: ----- Method: TestCase>>debug (in category 'running') ----- debug "Run the receiver and open a debugger on the first failure or error." + ^ self assureResourcesDuring: [self runCaseWithoutTimeout]! - ^ self assureResourcesDuring: [self runCase]! Item was changed: ----- Method: TestCase>>debugAsFailure (in category 'running') ----- debugAsFailure "Spawn a debugger that is ready to debug the receiver." (Process forBlock: [self debug] runUntil: [:context | context isClosureContext "navigate the process directly to the point where it is about to send #setUp" + and: [context selector = #runCaseWithoutTimeout]]) - and: [context selector = #runCase]]) debug.!

1 0

The Trunk: Regex-Core-ct.89.mcz
by commits＠source.squeak.org 01 May '24

01 May '24

Christoph Thiede uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-ct.89.mcz ==================== Summary ==================== Name: Regex-Core-ct.89 Author: ct Time: 1 May 2024, 6:10:49.419117 pm UUID: d2c4145b-80ff-4c4f-baa6-7fcd9f929a42 Ancestors: Regex-Core-ct.87 Fixes and documents order of keyed subexpressions to be top-down and left-to-right (complements Regex-Tests-Core-ct.36). Documents index offset in positional #subexpression: and #subexpressions:. =============== Diff against Regex-Core-ct.87 =============== Item was changed: ----- Method: RxMatcher>>keyedSubexpressionRanges: (in category 'accessing') ----- keyedSubexpressionRanges: key + "Answer an array of all match ranges (inclusiveStart -> inclusiveStop) of the subexpression at the given key. If a key is defined in multiple groups, sort ranges top-down and left-to-right." - "Answer an array of all match ranges (inclusiveStart -> inclusiveStop) of the subexpression at the given key." ^ ((keyedMarkerPositions at: key) gather: [:pair | (markerPositions at: pair first) with: (markerPositions at: pair second) collect: [:start :stop | start + 1 to: stop]]) "Since the same key can be defined for multiple markers, ordering the matches is non-trivial." + reverse sort: [:range | range start] ascending! - sort: [:range | range stop] ascending! Item was changed: ----- Method: RxMatcher>>subexpression: (in category 'accessing') ----- subexpression: subIndex "Answer a string that matched the subexpression at the given index. If there are multiple matches, answer the last one. If there are no matches, answer nil. + NB: index 1 is the entire match, index 2 is the first capture group, etc. (NB: it used to answer an empty string but I think nil makes more sense)." ^ (self subexpressions: subIndex) ifNotEmpty: [:expressions | expressions last] ifEmpty: [nil]! Item was changed: ----- Method: RxMatcher>>subexpressions: (in category 'accessing') ----- subexpressions: subIndex "Answer an array of all matches of the subexpression at the given index. + The answer is always an array; it is empty if there are no matches. + NB: index 1 is the entire match, index 2 is the first capture group, etc." - The answer is always an array; it is empty if there are no matches." | originalPosition startPositions stopPositions reply | originalPosition := stream position. startPositions := self subBeginning: subIndex. stopPositions := self subEnd: subIndex. (startPositions isEmpty or: [stopPositions isEmpty]) ifTrue: [^Array new]. reply := Array new: startPositions size. 1 to: reply size do: [ :index | | start stop | start := startPositions at: index. stop := stopPositions at: index. stream position: start. reply at: index put: (stream next: stop - start) ]. stream position: originalPosition. ^reply!

1 0

The Trunk: Regex-Tests-Core-ct.36.mcz
by commits＠source.squeak.org 01 May '24

01 May '24

Christoph Thiede uploaded a new version of Regex-Tests-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Tests-Core-ct.36.mcz ==================== Summary ==================== Name: Regex-Tests-Core-ct.36 Author: ct Time: 1 May 2024, 6:09:32.080028 pm UUID: b163c0fb-36ce-4b29-b751-97759ff56c37 Ancestors: Regex-Tests-Core-mt.35 Fixes expected order of keyed subexpressions to be top-down and left-to-right. Documents significant edge case of empty keyed subexpressions. =============== Diff against Regex-Tests-Core-mt.35 =============== Item was changed: ----- Method: RxMatcherTest>>testKeyedSubexpressions (in category 'testing-protocol') ----- testKeyedSubexpressions { #('abc' () ()). #('(\w)+' () ()). {'(?<foo>a)b(c)'. #(foo ('a')). {#foo. {1 to: 1}}}. {'(?<foo>\w+)'. #(foo ('abc')). {#foo. {1 to: 3}}}. {'(?<foo>\w)+'. #(foo ('a' 'b' 'c')). {#foo. {1 to: 1. 2 to: 2. 3 to: 3}}}. + {'(?<foo>((?<foo>b)|(?<foo>[^b]))+)'. #(foo ('abc' 'a' 'b' 'c')). {#foo. {1 to: 3. 1 to: 1. 2 to: 2. 3 to: 3}}}. + #('abc(?<foo>\w)?' (foo ()) (foo ())). + {'(?<foo>)(?<foo>\w)*(?<foo>)'. #(foo ('' 'a' 'b' 'c' '')). {#foo. {1 to: 0. 1 to: 1. 2 to: 2. 3 to: 3. 4 to: 3}}}. - {'(?<foo>((?<foo>b)|(?<foo>[^b]))+)'. #(foo ('a' 'b' 'c' 'abc' )). {#foo. {1 to: 1. 2 to: 2. 3 to: 3. 1 to: 3}}}. - #('abc(?<foo>\w)?' (foo ()) (foo ())) } do: [:spec | | matcher | matcher := spec first asRegex. self assert: (matcher matches: 'abc'). self assert: (Dictionary newFromPairs: spec second) equals: matcher allKeyedSubexpressions. self assert: (Dictionary newFromPairs: spec third) associations equals: (matcher keyedMarkers collect: [:key | key -> (matcher keyedSubexpressionRanges: key) asArray])].!

1 0

The Inbox: Collections-ct.1066.mcz
by commits＠source.squeak.org 01 May '24

01 May '24

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1066.mcz ==================== Summary ==================== Name: Collections-ct.1066 Author: ct Time: 1 May 2024, 2:10:22.308347 am UUID: 35ae4315-698f-4530-8f4b-208540868481 Ancestors: Collections-nice.1060 Implements #atAll:put: and #atAll:putAll: on Dictionary, which already is understood by sequenceable collections. Usage: Dictionary new at: #one put: 1; atAll: #(zero null nada) put: 0; atAll: #(eins zwei) putAll: #(1 2); yourself =============== Diff against Collections-nice.1060 =============== Item was added: + ----- Method: Dictionary>>atAll:put: (in category 'accessing') ----- + atAll: keys put: anObject + + keys do: [:key | self at: key put: anObject]. + ^ anObject! Item was added: + ----- Method: Dictionary>>atAll:putAll: (in category 'accessing') ----- + atAll: keyArray putAll: valueArray + + keyArray with: valueArray do: [:key :value | + self at: key put: value]. + ^ valueArray!

1 0

The Inbox: Collections-ct.1065.mcz
by commits＠source.squeak.org 30 Apr '24

30 Apr '24

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.1065.mcz ==================== Summary ==================== Name: Collections-ct.1065 Author: ct Time: 30 April 2024, 11:11:49.008608 pm UUID: 0ec4bc54-aa90-442f-8d1c-0bdcaf1a7672 Ancestors: Collections-nice.1060 Fixes Text>>addAttribute:from:to: for not inserting attributes beyond stop when the interval is empty. Example: self assert: ((Text streamContents: [:stream | stream nextPut: $a. stream withAttribute: TextEmphasis bold do: []. stream nextPut: $b]) attributesAt: 2) isEmpty. Please review. =============== Diff against Collections-nice.1060 =============== Item was changed: ----- Method: Text>>addAttribute:from:to: (in category 'emphasis') ----- addAttribute: att from: start to: stop "Set the attribute for characters in the interval start to stop." | stringSize realStart realStop | (stringSize := self size) = 0 ifTrue: [^ self]. start < 1 ifTrue: [realStart := 1] ifFalse: [realStart := start min: stringSize]. stop > self size ifTrue: [realStop := stringSize] + ifFalse: [realStop := stop]. + realStart <= realStop ifFalse: [^ self]. - ifFalse: [realStop := stop max: realStart]. runs := runs copyReplaceFrom: realStart to: realStop with: ((runs copyFrom: realStart to: realStop) replace: [:attributes | Text addAttribute: att toArray: attributes]) !

1 0

The User Interupt behaviour is very much improved, thank you.
by gettimothy 29 Apr '24

29 Apr '24

I, King of the endless loops and infinite recursions, am very, very appreciative of the responsiveness of the User Interupt. Thank you.

1 0

← Newer
1
2
3
4
5
6
7
8
...
7993
Older →

Jump to page: