Couldn't we remove the failing tests and put them in a sort of "unstable", since presumably they are like a task list of things that we want to work at some point?
There should be no failing tests in a stable release. If you *want* your test to fail, then just reverse the assertion so it is a green test when it works the way it should. And for tests that fail if something is not present, can't the test check if what ever it is actually is present first?
Of course you could keep the failing tests in the stable image if you can put them in a selection like "future work" or something that doesn't show up unless you turn it on. Otherwise deleting sounds ok to me. For the sanity of any release team, red *has to* mean broken.
From: Elod Kironsky kironsky@grisoft.cz Reply-To: The general-purpose Squeak developers listsqueak-dev@lists.squeakfoundation.org To: The general-purpose Squeak developers listsqueak-dev@lists.squeakfoundation.org Subject: Re: improving the quality of the image Date: Mon, 29 Jan 2007 11:47:14 +0100
Philippe Marschall wrote:
2007/1/29, Elod Kironsky kironsky@grisoft.cz:
Philippe Marschall wrote:
2007/1/26, Bert Freudenberg bert@freudenbergs.de:
On Jan 26, 2007, at 16:03 , Philippe Marschall wrote:
2007/1/26, Ralph Johnson johnson@cs.uiuc.edu: > One of my goals for 3.10 is to improve the quality of the image.
Our
> first release (coming soon!) will have only green tests, and each > following release will have only green tests.
How does removing failing tests improve the quality?
Woa, where does that hostility come from? There is another way to ensure all tests are green, besides removing the failing ones.
What hostility? I could not see why this improves the quality because to me the first step to fix a problem is to admit that you have a problem. Failing tests are pointer to problems for me. Removing failing tests because they can not be fixed today or tomorrow looked to me like an attempt to hide hide a problem. So I asked and now I know the reason why it was done.
Philippe
Philippe, where did you read that failing tests will be removed? "First release will have only green tests" means, that all tests remain and will pass, not fail. There will be no test removal at all! I'm, pretty sure you misunderstood something.
http://bugs.impara.de/view.php?id=5527
Philippe
Sorry Philippe, then I have to agree with you and join to Goran's proposition to classify the test, removing them is not a good solution I think.
Elod
_________________________________________________________________ Check out all that glitters with the MSN Entertainment Guide to the Academy Awards® http://movies.msn.com/movies/oscars2007/?icid=ncoscartagline2