After revisiting this, keeping the changes file unaffected seems not easily possible in this case, as the test specifically tests whether the updated source text has been written to the changes file. I have just merged this and Kernel-ct.1355 via KernelTests-ct.452, Compiler-ct.496, and Kernel-ct.1554.
Best, Christoph
--- Sent from Squeak Inbox Talk
On 2020-10-24T05:12:11-05:00, forums.jakob@resfarm.de wrote:
commits-2 wrote
Should I invest further complexity into this test for the purpose of keeping the production source logs clean?
I think keeping the logs clean is a worthy goal (especially if you have to recover changes after not saving for a while).
Does your implementation still log anything? Since the test does not use Monticello I think it should be silent. For extra emphasis you could have used compileSilently: instead of compile:, though I thought muting the SystemChangeNotifier would be sufficient here.
I tend to override performTest: to wrap the doSilently: around the test method execution, if most of the tests in the class are exepected to log something.
-- Sent from: http://forum.world.st/Squeak-Dev-f45488.html