Hi Romain,
If I may, a couple of more suggestions.
- make the colors be clearly distinct between each other. In my monitor (a very old and used one, I admit it) they look pretty much the same.
- If the selection has a wide of zero, make it transparent if it has no focus.
Take the following and please evaluate it on a workspace:
SystemWindow new setWindowColor: Color lightGray; addMorph: (PluggableTextMorph on: nil text: nil accept: nil) frame: (0@0 corner: 1@0.25); addMorph: (PluggableTextMorph on: nil text: nil accept: nil) frame: (0@0.25 corner: 1@0.5); addMorph: (PluggableTextMorph on: nil text: nil accept: nil) frame: (0@0.5 corner: 1@0.75); addMorph: (PluggableTextMorph on: nil text: nil accept: nil) frame: (0@0.75 corner: 1@1); openInHand.
What you see here is a window with 4 text fields. The all 4 are showing a text cursor and for me it's not clearly which one has focus.
Side note: In my opinion the root of the problem here is that 'text selection' and 'text cursor' are a same concept on Squeak while they should be two separate ones.
Regards, Hernan
-----Mensaje original----- De: squeak-dev-bounces@lists.squeakfoundation.org [mailto:squeak-dev-bounces@lists.squeakfoundation.org]En nombre de rrobbes@info.unicaen.fr Enviado el: Lunes, 22 de Marzo de 2004 09:54 Para: squeak-dev@lists.squeakfoundation.org Asunto: [FIX] TextMorphSelectionFix-rr ([sm][cd] new version)
from preamble:
"Change Set: FocusFixes-rr Date: 23 March 2004 Author: Romain Robbes
V2 : provides more visual feedback by changing the selection color upon focus change, as suggested by Hernan Tylim.
Makes the selected text in a TextMorph not disappear when the morph loses focus, by removing the call to releaseEditor in TextMorph>>keyboardFocusChange: .
This makes the TextMorphs' behavior more consistent with text panes in the host platforms, and makes Squeak a more consistent with itself, as this will allow all menus to behave according to the menuKeyboardControl preference, including the ones in a paragraph.
Also included are the changes in PluggableTextMorph and StrikeFont, to allow menus to be invoked modally, and thus having keyboard control if the preference is set"!