Hi Christoph --
Nope. The traditional cancel operation can still be of value. That's exactly why I did not change #cancelEdits but added an extra one. ;-)
Best, Marcel Am 26.12.2021 19:26:05 schrieb christoph.thiede@student.hpi.uni-potsdam.de christoph.thiede@student.hpi.uni-potsdam.de: Note that classical #cancelEdits has no sends in the TextMorph hierarchy since Morphic-mt.1810. Should we deprecate it?
Best, Christoph
--- Sent from Squeak Inbox Talk [https://github.com/hpi-swa-lab/squeak-inbox-talk]
On 2021-12-26T18:23:26+00:00, commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.1831.mcz
==================== Summary ====================
Name: Morphic-ct.1831 Author: ct Time: 26 December 2021, 7:22:25.591061 pm UUID: 12a8abbc-80b9-5341-aaf2-16be98564328 Ancestors: Morphic-mt.1830
Fixes editor regression that raised an MNU for #cancel in simple text morphs. Minor refactoring in TextMorphForEditView >> #cancelEdits.
=============== Diff against Morphic-mt.1830 ===============
Item was added:
- ----- Method: TextMorph>>cancelEditsSafely (in category 'editing') -----
- cancelEditsSafely
- "Safe variation of #cancelEdits, where the undo history is not discarded and can thus be used to undo the cancel operation.
- This default implementation does nothing."!
Item was changed: ----- Method: TextMorphForEditView>>cancelEdits (in category 'editing') ----- cancelEdits "The message is sent when the user hits enter or Cmd-L. Cancel the current contents and end editing."
- super cancelEdits.
- self releaseParagraph.
editView cancel!