On 02.09.2007, at 11:42, stephane ducasse wrote:
I forwarded the mail to marcus since he does not read the list. He is on vacation for a week so will certainly answer it later.
I'm very sorry that I am only now answering this mail...
The change to Heap (removing the emptycheck) was not a good idea and should never have been done. So the best is to retract this change.
Marcus
Stef
Begin forwarded message:
From: Andreas Raab andreas.raab@gmx.de Date: 31 août 2007 05:22:52 HAEC To: The general-purpose Squeak developers list <squeak- dev@lists.squeakfoundation.org> Subject: Heap>>first broken? Reply-To: The general-purpose Squeak developers list <squeak- dev@lists.squeakfoundation.org>
Hi -
Just stumbled over this:
self should:[Heap new first] raise: Error.
Right? However, in Squeak 3.9 and later it doesn't. From the 3.9 change log it appears it got introduced here:
Change Set: decompileBlock-md Date: 24 November 2005 Author: Marcus Denker A simplification for BlockContext>>decompileBlock: The Method got the tempNames by compiling the source of the method. This is already implemented in methodNode tempNames... thus not needed here.
remove emptycheck for Heap>>fist and SequencableCollection
#first, #last, #middle
but no comment as to why. Any insights into the reasons for this change anyone?
Cheers,
- Andreas
Marcus -- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker