Interesting, I would not have assumed that this would be only about performance, sounded like a more profound design decision to me.
If no one sees a problem in changing this behavior, I can try my luck. :-)
Best,
Christoph
http://www.hpi.de/ ________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Taeumel, Marcel Gesendet: Dienstag, 15. September 2020 16:42:11 An: squeak-dev Betreff: Re: [squeak-dev] FormInspector, or also: Text>>#= and its consequences
Hi Christoph.
Performance. Change it, bench it, post the results here. :-) Please specify you machine and try it on a slow RaspPi, too.
Best, Marcel
Am 10.09.2020 20:32:34 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
Hi all,
is there any old thread about the design discussion of how Text>>#= works? (It does not consider attributes for quality.) Has this decision ever been questioned?
Naively and without an overview of any existing components that could rely on this implementation, I would like to question it.
Why should 'foo' asText allBold be equal to 'foo' asText addAttribute: TextURL new? With the same logic, we could also say that two dictionaries are equal iff they have got the same keys ...
There is even a concrete client in the Trunk suffering from this design decision: Marcel's new FormInspector (and analogously, MorphInspector). It uses
TextFontReference with a FormSetFont to display a screenshot right in the inspector pane. Unfortunately, the pane is never updated automatically because even if the screenshot changes, the text morph thinks the old text would equal the new one. I'd like to fix that without hacking any workaround into the inspectors. Even though this inspector implementation is a bit unusual, in my opinion, it shows that the current Text >> #= implementation might not be a perfect solution.
I'm looking forward to your opinions.
Best, Christoph