Hi Christoph --
Something is wrong with this change ... why do you hardcode "trunk" here instead of using #ciBranch? This looks wrong...
Please fix.
Best, Marcel
Am 19.12.2022 15:42:58 schrieb Eliot Miranda eliot.miranda@gmail.com:
On Dec 18, 2022, at 11:19 AM, Thiede, Christoph Christoph.Thiede@student.hpi.uni-potsdam.de wrote:
Hi,
should we backport this to Squeak 6.0?
+1
Best,
Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 18. Dezember 2022 20:19:23 An: squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org Betreff: [squeak-dev] The Trunk: System-ct.1377.mcz
Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1377.mcz
==================== Summary ====================
Name: System-ct.1377 Author: ct Time: 18 December 2022, 8:19:19.152987 pm UUID: 74200562-3e0e-6d49-a67d-98c0682a5677 Ancestors: System-eem.1376
Repairs CI status badge in update version message. Complements https://github.com/badges/shields/issues/8671.
=============== Diff against System-eem.1376 ===============
Item was changed: ----- Method: SystemVersion>>ciStatusBadgeUrl (in category 'continuous integration') ----- ciStatusBadgeUrl "shields.io needs a workflow's descriptive name, not the name of the .yml file."
+ ^ 'https://raster.shields.io/github/actions/workflow/status/squeak-smalltalk/sq...' - ^ 'https://raster.shields.io/github/workflow/status/squeak-smalltalk/squeak-app...' format: {self ciWorkflowName encodeForHTTP. self ciBranch}!
Item was changed: ----- Method: SystemVersion>>ciWorkflowName (in category 'continuous integration') ----- ciWorkflowName + "Name of the workflow .yml file in .github/workflows. Case sensitive." - "See 'name' in #ciWorkflow .yml file. Case sensitive."
+ ^ 'bundle.yml'! - ^ 'Bundle'!