The only changes I needed to make were to handle ConnectionRefused in a couple places where I was only handling ConnectionTimedOut. After that all tests are green.
Thanks.
On Sat, Jun 16, 2012 at 10:33 AM, David T. Lewis lewis@mail.msen.com wrote:
I think that we are getting close to sorting out the open issues in this set of network updates, which currently are at Network-dtl.128 and NetworkTests-dtl.29 in the inbox. Chris Muller has identified several issues through the Magma tests, and there may be one or two more to deal with, but tests are green now and things seem to be working.
I would appreciate if anyone running Seaside, Aida, or other applications that depend heavily on networking could try loading the inbox updates and report any problems are found. Also, testing any unusual operating system and VM combinations would help.
If no further problems are found, I'll plan to move this to trunk some time within the next week.
Thanks, Dave
On Tue, Jun 05, 2012 at 06:17:30PM -0500, Chris Muller wrote:
Tests for Ma-Client-Server-Core cannot get out of the gate -- at some point it executes:
Socket newTCP connectTo: NetNameResolver localHostAddress port: link port "1314" waitForConnectionFor: 5.
and a few stack frames into doing this it's got a primitive failure. SqueakDebug.log attached.
On Tue, Jun 5, 2012 at 8:13 AM, Bert Freudenberg bert@freudenbergs.de wrote:
On 05.06.2012, at 04:31, David T. Lewis wrote:
On Wed, Jun 22, 2011 at 08:29:29PM -0500, Chris Muller wrote:
Just an FYI, the Magma test suite is pretty heavy on networking activity, but I didn't encounter any problems with this loaded.
So what needs to happen for us as a community to make a decision on whether to accept or reject this? ??I assume we will accept it, but maybe some of those more familiar with it can make some comments..? Who is our best networking expert who might want to review it and discuss?
I have merged Levente's Network-ul.100 updates into the current Squeak trunk, and made some additional changes to get unit tests working.
The updates are in the inbox in Network-dtl.123 and NetworkTests-dtl.28. I would appreciate if a couple of folks could load these updates, run the network tests, and let us know if any problems arise.
If there are no objections after a few days, I'll move the updates to trunk and we can sort out any remaining issues there.
Dave
I committed a small fix to inbox as Network-bf.124. This is needed if you run on a VM that has only the old primitives (like, the Cog VM I'm using).
With that fix the fallback code appears to work fine (at least I can use Monticello).
A similar fix might be needed for Etoys, but we never ran into it, because we had the new plugin for ages.
Btw, shouldn't asSocketAddress rather be an extension of the Network package?
- Bert -