[Seaside] SqP - Design question

[Cees de Groot]

On Thu, 2003-12-18 at 09:35, Julian Fitzell wrote:
> Looks pretty reasonable.  Your overall structure seems pretty much right 
> on.  I made a few fixes and a few changes to bring it a little more in 
> line with how I would factor it.  You're welcome to use or not use 
> whatever parts of it you see fit.  They're in beta4's MC repos at 
> http://beta4.com/mc/sqp.
> 
Thanks! I'll look at them right away.

> - the profile.xml files are invalid - I had to add a / before the 
> closing > in all the <auth> tags
>
Ah - my password munger probable. 

> - calling "self session" instead of "SqpSeaSession currentSession" is 
> preferred.
>
Yup - I noted that myself yesterday. 

> - #standardSeaLinkOn: seems problematic, mostly because it depends on 
> #currentSession above.  I think it would be better to pass in the 
> session, or a block, or something.  Or, my preference would be... eh, 
> I'll just refactor it how I'd do it an commit the version. :)  Might 
> just be a difference of opinion <shrug>
>
If you're declaring #currentSession private, that's ok and a refactoring
is fine.

> - I wonder whether the sidebars should be in components?  Might not be 
> necessary - but I think I'd like them to stay around even when you drill 
> down deeper..?
> 
Yeah, I thought about that myself. But that's all details, currently I'm
mostly concerned about overal structure - I have a lot of ideas on how
the final portal will look, but I'm trying very hard to resist the
temptation to start tweaking right now ;-).

Ok, seems I grokked, more or less, how to structure a Seaside app.
That's good - thanks for taking the trouble to read my code (it's not as
bad as Vogon poetry, but only barely so).

Off to your MC version ;-)

Regards,

Cees