[Seaside] fixCallbackTemps

[Avi Bryant]

On Oct 30, 2006, at 5:32 AM, Michel Bany wrote:

>> So I added a #tempVarRefs method to BlockContext.  This scans the  
>> bytecodes for the block and returns the indices of any temps that  
>> the block uses.  I think added a variation of #fixTemps named  
>> #fixCallbackTemps which, after copying the home context, goes  
>> through the temps and nils out any that don't appear in #tempVarRefs.
>>
>> I then changed every reference to #fixTemps within Seaside to  
>> #fixCallbackTemps.  The upshot is that all stored callbacks in  
>> Seaside should avoid holding onto any temps that they don't  
>> actually use.
>>
>
> Avi,
>
> I can see many references to #fixTemps in the live callback methods
> of the SeasideAsync package.
> Should all of these be replaced with #fixCallbackTemps as well ?

Probably.  There at least shouldn't be any harm to doing so.

> A second question.
> You did not replace #fixTemps in #clearHandlers and  
> #unregisterExpiredHandlers.
> Was it intentional ?

Yes, because I know it won't help in those cases.

Avi