[Seaside] loading Seaside 3.0.6.3 in Pharo 1.4

[Dale Henrichs]

Esteban,

If it were me, I'd isolate the specific changes in two new packages:

  KomHttpServerPortability.common
  KomHttpServerPortability.pharo14

existing implementation in the common branch and the Pharo1.4 changes in the pharo14 branch.

I've attached a new version of the configuration that creates a new baseline and version with the necessary changes ...

As other posters have mentioned #trimBoth could be used, but currently Kom does not depend upon Grease, so I would be curious whether other users of Kom would all of a sudden want Grease included in the image ... I'm not the Kom maintainer so I would choose to create the Portability package with the two branches as the the least impactful change ...

TranscriptStream is currently not managed with Grease and it could be, but then Grease doesn't have any Pharo1.4 specific packages either (yet....)...

My $0.02..

Dale

----- Original Message -----
| From: "Esteban Lorenzano" <estebanlm at gmail.com>
| To: "Pharo Development" <pharo-project at lists.gforge.inria.fr>, "Seaside - general discussion"
| <seaside at lists.squeakfoundation.org>
| Sent: Sunday, January 29, 2012 12:23:45 PM
| Subject: [Seaside] loading Seaside 3.0.6.3 in Pharo 1.4
| 
| Hi,
| 
| I loaded last version of seaside into a pharo 1.4 image.
| Everything looks working fine, but there a couple of fixes:
| 
| 1)
| 
| KomLogger>>#attachTranscript
| 	self detachTheTranscript.
| 	^(self streams detect: [:ea | ea isTranscriptStream] ifNone: [nil])
| 		ifNil: [self addStream: TranscriptStream new]
| 
| 
| "TranscriptStream" is not anymore on pharo and should be replaced
| with ThreadSafeTranscript
| 
| 2) String>>#withBlanksTrimmed is deprecated, and now it should use
| #trimBoth
| 
| how can I proceed to apply this fixes into seaside (without breaking
| other platforms)?
| 
| cheers,
| Esteban_______________________________________________
| seaside mailing list
| seaside at lists.squeakfoundation.org
| http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
| 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ConfigurationOfKomHttpServer-dkh.26.mcz
Type: application/zip
Size: 8312 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/seaside/attachments/20120129/23500e27/ConfigurationOfKomHttpServer-dkh.26-0001.zip