[FIX] creation of a LineMorph ([sm] [cd] doubts about this)
Scott Wallace
scott.wallace at squeakland.org
Sat Mar 8 22:25:38 UTC 2003
Before jumping into adopting this "fix", please look at the class
comment of LineMorph.
If I understand Dan's intentions correctly, LineMorph (which adds no
instance variables and has no instance-side methods) is never
intended to be instantiated; all instantiation calls to LineMorph are
*expected* to result in instances of vanilla PolygonMorph.
Thus, Dan's use of the hard-coded "PolygonMorph" in LineMorph
class-side method #from:to:color:width: was decidedly intentional,
and the proposed "easy to understand fix" violates that intention.
Cheers,
-- Scott
>[FIX] creation of a LineMorph ([sm][cd] easy to understand fix)
>Hannes Hirzel hannes.hirzel.squeaklist at bluewin.ch
>Sat Mar 8 19:04:26 CET 2003
>
>------------------------------------------------------------------------
>
>
>... The only change actually done in the change set was
>replacing 'PolygonMorph' with 'self' in a class method.
>
>No problem. A good fix.
>
>-- Hannes
>
>
>chris at funkyobjects.org wrote:
>>
>> --==CelesteAttachment73100==
>>
>> from preamble:
>>
>> "Change Set: creation of a LineMorph
>> Date: 23 February 2003
>> Author: Chris Muller
>>
>> replaces a hard-coded reference to PolygonMorph with logical class
> > reference (self), allowing subclasses of LineMorph to properly
> > instantiate."!
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030308/283e2ba3/attachment.htm
More information about the Squeak-dev
mailing list
|