Squeak-dev February 2004

squeak-dev@lists.squeakfoundation.org

175 participants
596 discussions

[BUG] HTTPClient doesnt support proxy authentication
by David Faught 29 Feb '04

29 Feb '04

The HTTPClient package on Squeakmap doesn't support HTTP requests through a proxy firewall that requires authentication. Because BFAV2 requires the HTTPClient code, anyone that uses proxy authentication cannot help out very efficiently with the Harvesting process. See <http://www.ietf.org/rfc/rfc2617.txt> for details on both Basic and Proxy HTTP Authentication. __________________________________ Do you Yahoo!? Get better spam protection with Yahoo! Mail. http://antispam.yahoo.com/tools

1 0

[FIX][BUG][ENH] ProxyAuthEnh (fixes httpPost methods)
by David Faught 29 Feb '04

29 Feb '04

This changeset fixes the httpPost methods of the HTTPSocket class to work properly with a proxy that requires authentication. It complements update 5659, which fixed the httpGet methods. Having the httpPost methods fixed means that the Navigator flap functions (i.e. posting a project to a SuperSwiki) will now work through an authenticated proxy firewall. __________________________________ Do you Yahoo!? Get better spam protection with Yahoo! Mail. http://antispam.yahoo.com/tools

1 0

Re: [BUG] KomPackagingInfo class>>doesNotUnderstand: #default when loading KomHttpServer from SM
by Avi Bryant 29 Feb '04

29 Feb '04

On Feb 29, 2004, at 8:33 AM, bernhard(a)pieber.com wrote: > Has anyone managed to get Seaside and KomHttpServer running in a > 3.7alpha image? Yes, I run them in 3.7a frequently. What other packages do you have installed? Perhaps there's a conflict somewhere?

3 2

Re: Squeak coding style...
by Jack Keel 29 Feb '04

29 Feb '04

Sorry -- I'm on the daily digest version of this list and you may have already discussed these points but in case not: And point #0 sillyfy: string seems to imply that your original string class might more properly have been a sub-class of String (can't tell without seeing your other methods and local variables) but perhaps refractoring: yourObjectString asSilly. is the more appropriate call? Jack

1 0

Re: Squeak coding style...
by Jack Keel 29 Feb '04

29 Feb '04

And of course #7 (probably number 1): 7. Don't invent a new pattern or selector sequence when an old one (that everyone else expects) already exists: asSilly: aString "Take the String argument and sillyfy it" ^ aString, ' is silly'. see String category converting, e.g.. String>>romanNumber instead of asRomanNumber and while you implied it you didn't state it explicitly #8 (probably number 2): 8. The argument name or the comment must specify all the valid classes (or protocols) that are valid for the argument. There is nothing more annoying than trying to look for all messages passed to a references to the value passed into a method trying to figure out what is valid to pass into the method (i.e., can the argument be a list, an array or a single object, multiple objects and what can those objects be? If you can't tell the class of the argument object by looking at the method you want to call -- it is a bitch!) asSilly: aThingWhichIKnowandYouNeedToDiscoverToMakeSilly "Take the argument and sillyfy it" ^ aThingWhichIKnowandYouNeedToDiscoverToMakeSilly, ' is silly'. Which for everyone but the original author yields: whateverYouThoughtWasValid doesNotUnderstand:, arrrrrghhh! Jack > From: goran.krampe(a)bluefish.se > Date: February 28, 2004 6:52:51 AM CST > To: squeak-dev(a)lists.squeakfoundation.org > Subject: Squeak coding style... > Reply-To: The general-purpose Squeak developers list > <squeak-dev(a)lists.squeakfoundation.org> > > > Hi all! > > I have been BFAVing quite a bit the latest week and one thing that has > annoyed me a bit :) is our lack of consistency in coding style. Sure, > it > is not a BIG THING - but at the same time a consistent style improves > the impression. > > Now - we all have different preferences here, but let me show you a > hypothetical example: > > sillyFy: string > "take the argument and sillyfy it" > ^ string, ' is silly'. > > > Ok, there are 6 things here that annoys me. :) Note though that I write > this with toungue in cheek! Some of these things are plain silly but I > confess - they still bug me. :) Here goes: > > 1. The comment starts with lower case and has no period. Just looks > sloppy IMHO. This one is actually one that I think we could agree on. > Right? > > 2. There is no empty line between the code and the comment. I like an > empty line there so that I can easily see where the code starts. If > there is no comment at all then I usually still have an empty line > below > the signature before the code. Also hopefully a style convention we > could try to follow perhaps. > > 3. The code should be indented. Agree? :) > > 4. There is a space after ^. Sure, people do it differently. :) > > 5. The naming of the parameter "string" is not really in my taste. I > would have liked "aString" better. > > 6. There is a period after the last statement. Not needed. > > > Anyway, the above was just to spark the thread. I know this topic is of > very low importance though so.... well. :) > > regards, Göran > > PS. Perhaps we could write a "styleifier"? Some of these things are > both > easily detected and corrected.

1 0

[BUG] in FileList2
by Trygve Reenskaug 28 Feb '04

28 Feb '04

Squeak3.6-5429-full.image ------------------------- I tried the instance creation messages recommended in the FileLis2 class comment. Two problems: 1) FileList2 morphicView openInWorld "an alternative to the standard FileList" The upper, left fill-in-the-blank pane opens with an *, but does not appear to have any effect. There is no menu. I probably miss something. 2) FileList2 morphicViewImageViewer openInWorld "useful for finding and using images" Results in 'unkown selector' menu enjoy --Trygve -- Trygve Reenskaug mailto: trygver(a)ifi.uio.no Morgedalsvn. 5A http://heim.ifi.uio.no/~trygver N-0378 Oslo Tel: (+47) 22 49 57 27 Norway

2 1

[BUG][Chronology] Dates are never invalid
by Avi Bryant 28 Feb '04

28 Feb '04

In Squeak 3.7a 5707, Date year: 2004 month: 2 day: 30 returns a Date object representing March . In 3.6 this would have been an error. I don't think it's useful here to try to silently "do what I mean" - the input is probably invalid because of user error (for example, switching the values for day and month). This needs to be caught.

1 0

file size primitive bug?
by Julian Fitzell 28 Feb '04

28 Feb '04

I've encountered a problem, while using OmniBase, in that squeak returns an incorrect file size if the size has changed since it was opened. This appears to be because the file size is returned from a rarely-updated file structure. I have solved this by changing sqFileSize() to get a file descriptor with "fileno(f->file)" and then using fstat() to get the file size. There are several other references to f->fileSize which I think could be replaced with calls to the new and improved sqFileSize() (or this could be pulled out into another helper I guess... Does anyone see any reason why this shouldn't work this way? Is it too slow in some case or something? I guess fstat() isn't ANSI-compliant... how much does that matter compared to returning an incorrect value? I guess my questions are two-fold: 1) Is there some reason I shouldn't be doing this in my own VM? 2) Should I be preparing this to submit as a fix? Julian

4 8

Re: Your message to Squeak-dev awaits moderator approval
by Nevin Pratt 28 Feb '04

28 Feb '04

OK, how do I add 'nevin(a)bountifulbaby.com' to the list of acceptable email addresses? squeak-dev-bounces(a)lists.squeakfoundation.org wrote: >Your mail to 'Squeak-dev' with the subject > > Re: Squeak coding style... > >Is being held until the list moderator can review it for approval. > >The reason it is being held: > > Post by non-member to a members-only list > >Either the message will get posted to the list, or you will receive >notification of the moderator's decision. If you would like to cancel >this posting, please visit the following URL: > > http://lists.squeakfoundation.org/confirm/squeak-dev/a64eca24493aa4f1a4fcb1… > > > >

2 1

Re: [ENH] beginsEndsWith-bp (fixed-up test suite attached)
by Frank Shearar 28 Feb '04

28 Feb '04

On Fri, 27 Feb 2004 22:28:55 +0100 (MET), ducasse wrote > hi frank > > your tests does not load. Can you fix that and resent it.? > > Stef Ah, my apologies, Stef - I sent it without adding the SequenceableCollectionTest class first. I've attached a fixed version. I hope BFAV snarfs this up correctly. frank

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
60
Older →

Jump to page: