Squeak-dev February 2023

squeak-dev@lists.squeakfoundation.org

28 participants
92 discussions

SmartRefStream tweak?
by Stéphane Rollandin 27 Sep '23

27 Sep '23

I am in the process of porting my code to 6.0, and I found that I had to tweak the #next method in SmartRefStream in order to load properly some morphs that were serialized from a 5.1 image. I had to add four calls to #rehash (see attached code). Would that be something useful to have, or am I (again) missing something? Stef

3 3

Review Request: noUNCPaths
by christoph.thiede＠student.hpi.uni-potsdam.de 31 Aug '23

31 Aug '23

Repairs FileDirectory>>#exists for long paths (> 260 characters) on Windows by well-defining an edge case in the Windows implementation of the FilePlugin primitiveDirectoryEntry, that is, to specify a single dot (.) as the file name. Documents the present limitations to syntactic sugar in long file paths in the platform code, the relevant plugin methods, and on the image side of Squeak Trunk. An alternative consideration was to rewrite FileDirectory>>#exists to pass an empty string as file name to the primitive instead of modifying the VM, but strictly speaking, even this would have exploited an undefined behavior in the VM plugin, and an empty file name would be less idiomatic than a single dot. For the original bug report, see: https://github.com/hpi-swa-teaching/Morphic-Testing-Framework/issues/13 Thanks to Marcel (mt) for his support! Signed-off-by: Christoph Thiede <christoph.thiede(a)student.hpi.de> --- Note that this mail contains both a git diff for the changes in the opensmalltalk-vm repository and a changeset for the changes in the Squeak Trunk so that they may be reviewed together. Any feedback on this formatting approach will be appreciated. Excited to receive your review! platforms/win32/vm/sqWin32Directory.c | 29 +++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/platforms/win32/vm/sqWin32Directory.c b/platforms/win32/vm/sqWin32Directory.c index 2b3d090ec..0aa5c2108 100644 --- a/platforms/win32/vm/sqWin32Directory.c +++ b/platforms/win32/vm/sqWin32Directory.c @@ -196,6 +196,15 @@ sqInt dir_Lookup(char *pathString, sqInt pathLength, sqInt index, /* Lookup the index-th entry of the directory with the given path, starting at the root of the file system. Set the name, name length, creation date, creation time, directory flag, and file size (if the entry is a file). + + Note that, due to restrictions by the operating system, this method only + has limited support for paths longer than 260 characters. In the case of + longer paths, they must not contain syntactic sugar such as ".", "..", or + "a/b".* For more details, see: + https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#paths + *) Long paths are automatically converted into UNC paths, which only + support a subset of the normal path syntax. + Return: 0 if a entry is found at the given index 1 if the directory has fewer than index entries @@ -354,6 +363,20 @@ sqInt dir_EntryLookup(char *pathString, sqInt pathLength, char* nameString, sqIn /* Lookup a given file in a given named directory. Set the name, name length, creation date, creation time, directory flag, and file size (if the entry is a file). + + Note that, due to restrictions by the operating system, this method only + has limited support for paths longer than 260 characters (for the full + path concatenated from the directory path, a backslash, and the file + name). In the case of longer paths, neither the path nor the file name + must contain syntactic sugar such as ".", "..", or "a/b".* However, this + method defines a single (!) convention for passing nameString as ".", + which is also supported for long paths. This convention is provided for + an efficient existence check of the directory (e.g., + FileDirectory>>#exists). For more details, see: + https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#paths + *) Long paths are automatically converted into UNC paths, which only + support a subset of the normal path syntax. + Return: 0 if found (a file or directory 'nameString' exists in directory 'pathString') 1 if the directory has no such entry @@ -416,6 +439,12 @@ sqInt dir_EntryLookup(char *pathString, sqInt pathLength, char* nameString, sqIn fullPath=(char *)calloc(fullPathLength,sizeof(char)); memcpy(fullPath,pathString,pathLength); if (pathString[pathLength-1] != '\\') fullPath[pathLength]='\\'; + if (nameStringLength == 1 && nameString[0] == '.') { + /* special syntax: "." is the current directory. Trim it from the full + path to avoid generating a UNC path with an unresolved ".", which is + not supported there. See comment above. */ + nameStringLength = 0; + } memcpy(fullPath+fullPathLength-nameStringLength,nameString,nameStringLength); /* convert the path name into a null-terminated C string */ -- 2.37.3.windows.1 =============== Summary =============== Change Set: noUNCPaths Date: 30 November 2022 Author: Christoph Thiede Documents the present limitations to syntactic sugar in long file paths in the relevant plugin methods and on the image side. For the original bug report, see: https://github.com/hpi-swa-teaching/Morphic-Testing-Framework/issues/13 Thanks to Marcel (mt) for his support! =============== Diff =============== FileDirectory>>primLookupEntryIn:index: {private} · ct 11/29/2022 20:24 (changed) primLookupEntryIn: fullPath index: index "Look up the index-th entry of the directory with the given fully-qualified path (i.e., starting from the root of the file hierarchy) and return an array containing: <name> <creationTime> <modificationTime> <dirFlag> <fileSize> The empty string enumerates the top-level files or drives. (For example, on Unix, the empty path enumerates the contents of '/'. On Macs and PCs, it enumerates the mounted volumes/drives.) + Note that in general, fullPath must not contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters. See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryLookup' module: 'FilePlugin'> ^ #badDirectoryPath FileDirectory>>primLookupEntryIn:name: {private} · ct 11/30/2022 15:38 (changed) primLookupEntryIn: fullPath name: fName - "Look up <fName> (a simple file name) in the directory identified by <fullPath> and return an array containing: <fName> <creationTime> <modificationTime> <dirFlag> <fileSize> On Unix, the empty path denotes '/'. On Macs and PCs, it is the container of the system volumes.) + Note that in general, neither fullPath nor fName must contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters (for the full path concatenated from the directory path, a backslash, and the file name). As a single (!) exception, the file name may always be a single dot ('.'), which is supported for an efficient existence test of the directory path (e.g., FileDirectory>>#exists). See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryEntry' module: 'FilePlugin'> ^ #primFailed "to distinguish from nil" FilePlugin>>primitiveDirectoryEntry {directory primitives} · ct 11/30/2022 15:13 (changed) primitiveDirectoryEntry "Two arguments - directory path, and simple file name; returns an array (see primitiveDirectoryLookup) describing the file or directory, or nil if it does not exist. + + Note that in general, neither the directory path nor the file name must + contain syntactic sugar for the current platform (e.g., '.' or '..', or on + Windows, forward slashes instead of backslashes). These conventions are + only fully supported on Unix platforms; on Windows, they are only + supported for short non-UNC file paths containing max 260 characters (for + the full path concatenated from the directory path, a backslash, and the + file name). As a single (!) exception, the file name may always be a + single dot ('.'), which is supported for an efficient existence test of + the directory path (e.g., FileDirectory>>#exists). See the comment in + sqWin32Directory.c for more details. + Primitive fails if the outer path does not identify a readable directory. (This is a lookup-by-name variant of primitiveDirectoryLookup.)" | requestedName pathName pathNameIndex pathNameSize status entryName entryNameSize createDate modifiedDate dirFlag posixPermissions symlinkFlag fileSize okToList reqNameIndex reqNameSize | <var: 'entryName' declareC: 'char entryName[256]'> <var: 'pathNameIndex' type: #'char *'> <var: 'reqNameIndex' type: #'char *'> <var: 'fileSize' type: #squeakFileOffsetType> <export: true> requestedName := interpreterProxy stackValue: 0. pathName := interpreterProxy stackValue: 1. (interpreterProxy isBytes: pathName) ifFalse: [^interpreterProxy primitiveFail]. "Outbound string parameters" pathNameIndex := interpreterProxy firstIndexableField: pathName. pathNameSize := interpreterProxy byteSizeOf: pathName. reqNameIndex := interpreterProxy firstIndexableField: requestedName. reqNameSize := interpreterProxy byteSizeOf: requestedName. self cCode: '' inSmalltalk: [entryName := ByteString new: 256. entryNameSize := createDate := modifiedDate := dirFlag := fileSize := posixPermissions := symlinkFlag := nil]. "If the security plugin can be loaded, use it to check for permission. If not, assume it's ok" okToList := sCLPfn ~= 0 ifTrue: [self cCode: '((sqInt (*)(char *, sqInt))sCLPfn)(pathNameIndex, pathNameSize)' inSmalltalk: [true]] ifFalse: [true]. status := okToList ifTrue: [self dir_EntryLookup: pathNameIndex _: pathNameSize _: reqNameIndex _: reqNameSize _: entryName _: (self addressOf: entryNameSize put: [:v| entryNameSize := v]) _: (self addressOf: createDate put: [:v| createDate := v]) _: (self addressOf: modifiedDate put: [:v| modifiedDate := v]) _: (self addressOf: dirFlag put: [:v| dirFlag := v]) _: (self addressOf: fileSize put: [:v| fileSize := v]) _: (self addressOf: posixPermissions put: [:v| posixPermissions := v]) _: (self addressOf: symlinkFlag put: [:v| symlinkFlag := v])] ifFalse: [DirNoMoreEntries]. interpreterProxy failed ifTrue: [^nil]. status = DirNoMoreEntries ifTrue: "no entry; return nil" [interpreterProxy "pop pathName, index, rcvr" pop: 3 thenPush: interpreterProxy nilObject. ^nil]. status = DirBadPath ifTrue: [^interpreterProxy primitiveFail]."bad path" interpreterProxy pop: 3 "pop pathName, index, rcvr" thenPush: (self cppIf: PharoVM ifTrue: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize posixPermissions: posixPermissions isSymlink: symlinkFlag] ifFalse: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize]) FilePlugin>>primitiveDirectoryLookup {directory primitives} · ct 11/30/2022 15:00 (changed) primitiveDirectoryLookup + "Two arguments - directory path, and an index to an item; returns an array (see primitiveDirectoryLookup) describing the file or directory, or nil if it does not exist. + + Note that in general, the directory path must not contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters. See the comment in sqWin32Directory.c for more details. + + Primitive fails if the outer path does not identify a readable directory. (For a lookup-by-name variant, see primitiveDirectoryEntry.)" | index pathName pathNameIndex pathNameSize status entryName entryNameSize createDate modifiedDate dirFlag symlinkFlag posixPermissions fileSize okToList | <var: 'entryName' declareC: 'char entryName[256]'> <var: 'pathNameIndex' type: #'char *'> <var: 'fileSize' type: #squeakFileOffsetType> <export: true> index := interpreterProxy stackIntegerValue: 0. pathName := interpreterProxy stackValue: 1. (interpreterProxy isBytes: pathName) ifFalse: [^interpreterProxy primitiveFail]. pathNameIndex := interpreterProxy firstIndexableField: pathName. pathNameSize := interpreterProxy byteSizeOf: pathName. self cCode: '' inSmalltalk: [entryName := ByteString new: 256. entryNameSize := createDate := modifiedDate := dirFlag := fileSize := posixPermissions := symlinkFlag := nil]. "If the security plugin can be loaded, use it to check for permission. If not, assume it's ok" okToList := sCLPfn ~= 0 ifTrue: [self cCode: '((sqInt (*)(char *, sqInt))sCLPfn)(pathNameIndex, pathNameSize)' inSmalltalk: [true]] ifFalse: [true]. status := okToList ifTrue: [self dir_Lookup: pathNameIndex _: pathNameSize _: index _: entryName _: (self addressOf: entryNameSize put: [:v| entryNameSize := v]) _: (self addressOf: createDate put: [:v| createDate := v]) _: (self addressOf: modifiedDate put: [:v| modifiedDate := v]) _: (self addressOf: dirFlag put: [:v| dirFlag := v]) _: (self addressOf: fileSize put: [:v| fileSize := v]) _: (self addressOf: posixPermissions put: [:v| posixPermissions := v]) _: (self addressOf: symlinkFlag put: [:v| symlinkFlag := v])] ifFalse: [DirNoMoreEntries]. interpreterProxy failed ifTrue: [^nil]. status = DirNoMoreEntries ifTrue: "no more entries; return nil" [interpreterProxy "pop pathName, index, rcvr" pop: 3 thenPush: interpreterProxy nilObject. ^nil]. status = DirBadPath ifTrue: [^interpreterProxy primitiveFail]."bad path" interpreterProxy pop: 3 "pop pathName, index, rcvr" thenPush: (self cppIf: PharoVM ifTrue: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize posixPermissions: posixPermissions isSymlink: symlinkFlag] ifFalse: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize]) --- Sent from Squeak Inbox Talk ["noUNCPaths.3.cs"]

3 5

On the rejection of Promises due to errors
by Jakob Reschke 26 Aug '23

26 Aug '23

Hi all, Tony has recently fixed our Promise implementation to make it more Promises/A+ compliant, thank you! In the discussion that lead to this fix [1], I already pointed out a difference between exceptions in Smalltalk and in JavaScript, where the Promises/A+ specification originates: Smalltalk exceptions can be resumed, while JavaScript exceptions cannot be resumed and always unroll the stack. The spec [2] says that if the onFulfilled or onRejected callback of a #then call on a promise throws an exception, then the promise returned by the #then call shall be rejected with the exception thrown. Our current Promise implementation matches this for the blocks supplied to #then:, #ifRejected: or #then:ifRejected, by catching all Errors in the blocks and rejecting the promise. But this does not allow a Squeak user to deal with exceptions in a debugger if they are signalled in the callbacks, because they are caught. The same also applies to #future promises. The latter are not really covered by the Promises/A+ spec (because it does not force the resolution or rejection of a promise that is not the result of a #then, and there is no #future in JavaScript), but futures exhibit the same problem of not being resumable in the debugger. Example: promise := 1 future / 0. "<= inspect it => promise is rejected, regardless of your actions in the debugger" Number compile: 'methodWithTypo ^ self asstring'. promise := 1 future methodWithTypo. "<= inspect it => promise is rejected, no chance to fix the misspelling of asString in the debugger and proceed" I could imagine instead letting all exceptions pass during the future or callback block evaluation, and only reject the promise if the evaluation is eventually curtailed due to the exception (be it an Error or not, think of Warning or ModificationForbidden). Example expectations: promise := 1 future / 0. "<= inspect it, press Proceed in the debugger, => promise is resolved" promise := 1 future / 0. "<= inspect it, press Abandon in the debugger, => promise is rejected" promise := 1 future methodWithTypo. "<= inspect it, fix the typo of asString in the debugger, proceed, => promise is resolved with '1'" It could be done by fulfilling a Promise about aBlock similar to this: [ self resolveWith: aBlock value ] on: Exception do: [ :ex | | resumed | resumed := false. [ | result | result := ex outer. resumed := true. ex resume: result] ifCurtailed: [resumed ifFalse: [self future rejectWith: ex]]] (Find the current implementations here: Promise>>#fulfillWith:passErrors: and Promise>>#then:ifRejected:) Note that the #outer send would only trigger handlers in the Project/World loop, or the defaultAction of the exception. The #future in front of #rejectWith: is there to avoid curtailing the unwind block context of ifCurtailed: itself if there are further errors in the rejection callbacks of the promise. The behavior of non-local exits from unwind contexts is undefined in the Smalltalk ANSI standard (just like resume: or return: in a defaultAction, or not sending resume: or return: in an on:do: exception handler at all -- VA Smalltalk interprets that as resume, while Squeak does return, for example). This implementation would also allow all deferred Notifications to pass and not reject the promise. That is because true notifications just resume silently if they are not handled. promise := [Notification signal: 'hi there'. 42] future value. "<= inspect it => Expected: resolved with 42. Actual (today): it is needlessly rejected with Notification 'hi there'" Pressing Proceed in the debugger on officially non-resumable errors (which is possible) would also not reject the promise. But further errors/debuggers are likely to appear, of which one may eventually be used to abort the execution. If the execution finishes after repeatedly pressing Proceed, then fine, resolve the promise with whatever the outcome was. promise := [self error: 'Fatal error'. 42] future value. "<= inspect it, proceed after the so-called fatal error, => Expected: resolved with 42. Actual: there is no debugger, the promise is immediately rejected." promise := [1 / 0 + 3] future value. "<= Cannot be resumed/proceeded because if ZeroDivide is resumed, it will return the exception, and ZeroDivide does not understand +, which cannot be resumed without changing the code. So you'd have to curtail the block execution => Expected: rejected with ZeroDivide or MessageNotUnderstood (depending on when you press Abandon or recompile the DoIt)." promise := [1 / 0 + 3] future value. "... or instead of changing the code or aborting, you could choose 'return entered value' in one of the debuggers, and thereby complete the evaluation of the block => Expected: resolved with whatever you entered to return in the debugger" Promises with whenRejected:/ifRejected: callbacks would no longer swallow errors, and would only be rejected when the user aborts in the debuggers, or if the future execution catches errors by itself and converts them to rejected promises, so the future promise will also be rejected. This could pose a compatibility problem for existing code. promise := (1 future / 0) then: [:result | result + 3] ifRejected: [:reason | #cancelled]. "<= inspect it => Actual: resolved with #cancelled immediately. Expected with my proposed changes: it would first show the ZeroDivide debugger, which you can abandon to resolve with #cancelled, or proceed to a MessageNotUnderstood +. If you abandon the MNU, the promise would be rejected with the MNU, not #cancelled, in accordance with the Promises/A+ spec." How to get back a catch-all->reject-immediately future under these circumstances: promise := [[1 / 0] on: Error do: [:e | e return: (Promise new rejectWith: e)]] future value. promise := [1 future + 1 then: [:n | [n / 0] on: Error do: [:e | e return: (Promise new rejectWith: e)]] future value. We could also introduce a convenience constructor for immediately-rejected promises like in JavaScript: Promise rejected: e. Or a convenience exception handler: [...] rejectOn: Error. Or [...] rejectIfCurtailed (the fullfill/then methods would probably use this as well). What do you think? As Tom Beckmann has already suggested in the last thread on the topic [1], I could also use a custom class of Promise to get just the behavior I want. But then I cannot solve it for the use of #future. At least not without patching something about the compiler in my package preamble... ;-) [1] http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-April/208546.ht… [2] https://promisesaplus.com/ Kind regards, Jakob

6 17

WeakSet but no WeakIdentitySet?
by Igor Stasenko 26 Aug '23

26 Aug '23

Hello, i need to keep a bunch of CompiledMethods in WeakSet, but i am a bit afraid, that it wont work as i want to, because of CompiledMethod>>= implementation, because a code, which i currently writing doesn't changing a method's bytecode, but changing its trailer instead, and so, this could lead to undesirable effects.. If i could have a WeakIdentitySet... Meanwhile, i think i have nothing else, but just use a degenerate WeakIdentityKeyDictionary , with methods in keys and nils in values. :( -- Best regards, Igor Stasenko AKA sig.

4 3

tracking issues with the "squeak-object-memory" repo
by Craig Latta 17 Aug '23

17 Aug '23

Hi all-- The Squeak board is trying an experiment. We've created the GitHub repo "squeak-object-memory", and are curious to see how useful it is to track issues there. With this message, I can close the first issue[1]. :) Please bring on the other thirty gazillion of them... thanks! Craig, on behalf of the Squeak board [1] https://github.com/squeak-smalltalk/squeak-object-memory/issues/1 -- Craig Latta :: research computer scientist Black Page Digital :: Berkeley, California 663137D7940BF5C0AFC :: 1349FB2ADA32C4D5314CE

5 10

veryDeepCopy, ImageSegments, and actionMaps
by Ned Konz 17 Aug '23

17 Aug '23

Any Object can have dependents whether or not it has an instance variable to keep track of them (these are kept in the DependentsFields class variable of Object). The only class that keeps its own dependents is Model. Any Object can have an actionMap. These are supplied by EventManager class by default, and are stored in the ActionMaps class variable of EventManager. The only class that keeps its own action maps is Morph. When we veryDeepCopy an object we also copy the global dependents (see DeepCopier>>fixDependents). However, we don't copy the actionMap in those cases where it's held by the EventManager class. When we file out an object that uses DependentsFields out into an ImageSegment, we also file out the dependents (see ImageSegment>>dependentsSave:) if it's in a project. We do this by adding a project parameter called #GlobalDependentsInProject. However, we don't file out the actionMap in those cases where it's held by the EventManager class. My question is this: should we fix these behaviors (copying and serialization) to include these "global action maps" just like we already include the "global dependents"? Or should we discourage the use of the "global action maps"? -- Ned Konz http://bike-nomad.com GPG key ID: BEEA7EFE

3 2

The Inbox: Tools-ct.1032.mcz
by commits＠source.squeak.org 15 Aug '23

15 Aug '23

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1032.mcz ==================== Summary ==================== Name: Tools-ct.1032 Author: ct Time: 10 March 2021, 6:51:33.356304 pm UUID: 897e4ea2-3740-6a45-a054-d7da65105568 Ancestors: Tools-mt.1030 In the Message Names tool, show definition, comment, and hierarchy for class hits. In particular helpful to find out efficiently whether a selector belongs to a binding or to an actual class. =============== Diff against Tools-mt.1030 =============== Item was changed: ----- Method: MessageNames>>computeMessageList (in category 'search') ----- computeMessageList + | selector | + selectorListIndex = 0 ifTrue: [^ #()]. + + selector := selectorList at: selectorListIndex. + ^ (selector first isUppercase ifTrue: [Smalltalk classNamed: selector]) + ifNotNil: [:class | + class := Smalltalk classNamed: selector. + #(Definition Comment Hierarchy) collect: [:sel | + MethodReference class: class selector: sel] ] + ifNil: [self systemNavigation allImplementorsOf: selector]! - ^ selectorListIndex = 0 - ifTrue: [#()] - ifFalse: [self systemNavigation - allImplementorsOf: (selectorList at: selectorListIndex)]! Item was changed: ----- Method: MessageNames>>selectedMessageName (in category 'message list') ----- selectedMessageName selectorList basicSize = 0 ifTrue: [^ nil]. "Deals with selectorList nil or empty" + ^super selectedMessageName ifNil: [ + "only message name selected" + selectorList at: (selectorListIndex max: 1) ifAbsent: [nil] "If no selection we can still find a selector"]! - ^selectorList at: (selectorListIndex max: 1) ifAbsent: [nil] "If no selection we can still find a selector"! Item was changed: ----- Method: MessageSet>>aboutToStyle: (in category 'code pane') ----- + aboutToStyle: aStyler + "This is a notification that aStyler is about to re-style its text. + Set the classOrMetaClass in aStyler, so that identifiers will be resolved correctly. - aboutToStyle: aPluggableShoutMorphOrView - "This is a notification that aPluggableShoutMorphOrView is about to re-style its text. - Set the classOrMetaClass in aPluggableShoutMorphOrView, so that identifiers - will be resolved correctly. Answer true to allow styling to proceed, or false to veto the styling" | selectedMessageName showingMethod | self showingSource ifFalse: [^false]. selectedMessageName := self selectedMessageName. showingMethod := (#(Comment Definition Hierarchy) includes: selectedMessageName) not. + aStyler parseAMethod: showingMethod. "Hack!! setting classOrMetaClass: to nil allows doit or class definition colouring." + aStyler classOrMetaClass: (showingMethod ifTrue: [self selectedClassOrMetaClass]). - aPluggableShoutMorphOrView classOrMetaClass: (showingMethod ifTrue: [self selectedClassOrMetaClass]). ^(#(Comment Hierarchy) includes: selectedMessageName) not! Item was changed: ----- Method: MessageSet>>selectedMessage (in category 'message list') ----- selectedMessage "Answer the source method for the currently selected message." - self setClassAndSelectorIn: [:class :selector | | source | class ifNil: [^ 'Class vanished']. selector first isUppercase ifTrue: [selector == #Comment ifTrue: + ["currentCompiledMethod := class organization commentRemoteStr." - [currentCompiledMethod := class organization commentRemoteStr. ^ class comment]. selector == #Definition ifTrue: [^ class definition]. selector == #Hierarchy ifTrue: [^ class printHierarchy]]. source := class sourceMethodAt: selector ifAbsent: [currentCompiledMethod := nil. ^ 'Missing']. self showingDecompile ifTrue: [^ self decompiledSourceIntoContents]. currentCompiledMethod := class compiledMethodAt: selector ifAbsent: [nil]. self showingDocumentation ifTrue: [^ self commentContents]. source := self sourceStringPrettifiedAndDiffed. ^ source asText makeSelectorBoldIn: class]!

3 2

The Inbox: Regex-Tests-Core-tobe.34.mcz
by commits＠source.squeak.org 25 Jun '23

25 Jun '23

A new version of Regex-Tests-Core was added to project The Inbox: http://source.squeak.org/inbox/Regex-Tests-Core-tobe.34.mcz ==================== Summary ==================== Name: Regex-Tests-Core-tobe.34 Author: tobe Time: 13 February 2023, 10:30:58.863775 am UUID: 897286b7-bca5-405c-92c0-52e09604b1fc Ancestors: Regex-Tests-Core-ct.33 Complements Regex-Core-tobe.86 =============== Diff against Regex-Tests-Core-ct.33 =============== Item was added: + ----- Method: RxParserTest>>testNonQuantifier (in category 'tests') ----- + testNonQuantifier + "Test expressions that look like quantifier expressions but do not fully match" + self assert: ('a{x}' matchesRegex: 'a{x}'). + self assert: ('a{,x}' matchesRegex: 'a{,x}'). + self assert: ('a{,}' matchesRegex: 'a{,}'). + self assert: ('a{,,}' matchesRegex: 'a{,,}'). + self assert: ('a{1,2,}' matchesRegex: 'a{1,2,}'). + self assert: ('a{,' matchesRegex: 'a{,'). + self assert: ('a{' matchesRegex: 'a{'). + self assert: ('a{1' matchesRegex: 'a{1'). + self assert: ('a{1,' matchesRegex: 'a{1,').!

4 4

The Trunk: Collections-pre.857.mcz
by commits＠source.squeak.org 05 Jun '23

05 Jun '23

Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.857.mcz ==================== Summary ==================== Name: Collections-pre.857 Author: pre Time: 4 October 2019, 11:04:30.363303 am UUID: 5ef00b65-3884-c445-b276-0cc01f0b10a1 Ancestors: Collections-pre.856 Adds startOfHeader to Character, adds empty abstract implementations of scanFrom:, writeScanOn: to TextAttribute to allow for Texts which include TextAttributes which do not implement serialization to still be serialized, adds a comment to these methods. =============== Diff against Collections-pre.856 =============== Item was added: + ----- Method: Character class>>startOfHeader (in category 'accessing untypeable characters') ----- + startOfHeader + + ^ self value: 1 ! Item was added: + ----- Method: TextAttribute class>>scanFrom: (in category 'fileIn/Out') ----- + scanFrom: strm + "Read the text attribute properties from the stream. When this method has + been called the concrete TextAttribute class has already been selected via + scanCharacter. (see TextAttribute class>>#newFrom:). + For writing the format see TextAttribute>>#writeScanOn:"! Item was added: + ----- Method: TextAttribute>>writeScanOn: (in category 'fileIn/fileOut') ----- + writeScanOn: strm + "Implement this method for a text attribute to define how it it should be written + to a serialized form of a text object. The form should correspond to the source + file format, i.e. use a scan character to denote its subclass. + As TextAttributes are stored in RunArrays, this method is mostly called from RunArray>>#write scan. + For reading the written information see TextAttribute class>>#scanFrom:" + + "Do nothing because of abstract class"!

8 17

Review Request: mcSlips
by christoph.thiede＠student.hpi.uni-potsdam.de 21 May '23

21 May '23

Any fundamental objections before I would merge this into the Trunk? :-) =============== Summary =============== Change Set: mcSlips Date: 16 January 2022 Author: Christoph Thiede This changeset integrates the slip detection mechanism, previously only known from the domain of changesets, into the Monticello system. When users save a new version, it will automatically notify them about any possible slips and let them decide whether to browse them first or proceed the saving. Users can also scan their patch for slips manually by invocating the item from the patch list menu. The value of the preference #checkForSlips is still honored for the automatic detection, and the description of that preference is updated to mention the new usage. =============== Postscript =============== "Postscript:" (Preferences preferenceAt: #checkForSlips) helpString: 'If true, then whenever you file out a change set or save a Monticello version, it is checked for ''slips'' and if any are found, you are so informed and given a chance to open a browser on them.'. =============== Diff =============== CompiledMethod>>hasReportableSlip {testing} · ct 1/15/2022 22:32 (changed) hasReportableSlip "Answer whether the receiver contains anything that should be brought to the attention of the author when filing out. Customize the lists here to suit your preferences. If slips do not get reported in spite of your best efforts here, make certain that the Preference 'checkForSlips' is set to true." - #(#doOnlyOnce: #halt #halt: #hottest #printDirectlyToDisplay #toRemove #personal #urgent #haltOnce #haltOnce: #haltIf: ) + #(#doOnlyOnce: #halt #halt: #hottest #printDirectlyToDisplay #toRemove #personal #urgent #haltOnce #haltOnce: #haltIf: #haltIfNil #haltOnCount: #halt:onCount: #break ) do: [:aLit | (self hasLiteral: aLit) ifTrue: [^ true]]. #(#Transcript #AA #BB #CC #DD #EE ) do: [:aSymbol | | assoc | (assoc := Smalltalk globals associationAt: aSymbol ifAbsent: []) ifNotNil: [(self hasLiteral: assoc) ifTrue: [^ true]]]. ^ false MCChangeSelector>>select {actions} · ct 1/15/2022 22:46 (changed) select + + (Preferences checkForSlips ==> [self lookForSlips]) ifFalse: [^ self]. + self answer: (MCPatch operations: kept) MCDefinition>>hasReportableSlip {testing} · ct 1/15/2022 22:49 + hasReportableSlip + + ^ false MCMethodDefinition (changed) MCDefinition subclass: #MCMethodDefinition - instanceVariableNames: 'classIsMeta source category selector className timeStamp' + instanceVariableNames: 'classIsMeta source category selector className timeStamp hasReportableSlip' classVariableNames: '' poolDictionaries: '' category: 'Monticello-Modeling' MCMethodDefinition class instanceVariableNames: 'definitions' "" MCMethodDefinition class>>forMethodReference: {create} · ct 1/15/2022 22:53 (changed) forMethodReference: aMethodReference | definition | definition := self cachedDefinitions at: aMethodReference compiledMethod ifAbsent: []. (definition isNil or: [definition selector ~= aMethodReference methodSymbol or: [definition className ~= aMethodReference classSymbol or: [definition classIsMeta ~= aMethodReference classIsMeta or: [definition category ~= aMethodReference category]]]]) ifTrue: [definition := self className: aMethodReference classSymbol classIsMeta: aMethodReference classIsMeta selector: aMethodReference methodSymbol category: aMethodReference category timeStamp: aMethodReference timeStamp source: aMethodReference source. + definition hasReportableSlip: aMethodReference compiledMethod hasReportableSlip. self cachedDefinitions at: aMethodReference compiledMethod put: definition]. ^ definition MCMethodDefinition>>hasReportableSlip {accessing} · ct 1/15/2022 22:54 + hasReportableSlip + + ^ hasReportableSlip ifNil: [false] MCMethodDefinition>>hasReportableSlip: {accessing} · ct 1/15/2022 22:53 + hasReportableSlip: aBoolean + + hasReportableSlip := aBoolean. MCPatchBrowser>>checkForSlips {actions} · ct 1/15/2022 23:12 + checkForSlips + + ^ self checkForSlipsIn: self items MCPatchBrowser>>checkForSlipsIn: {actions} · ct 1/15/2022 23:07 + checkForSlipsIn: patchItems + + ^ patchItems select: [:ea | ea hasReportableSlip] MCPatchBrowser>>lookForSlips {actions} · ct 1/15/2022 23:11 + lookForSlips + "Look for slips in all changes. If there are any, ask the user how to treat them. Answer true if the operation should go on, or false if it should be canceled." + + | slips | + slips := self checkForSlips ifEmpty: [^ true]. + (Project uiManager + chooseFromLabeledValues: (OrderedDictionary new + at: 'Browse slips' translated put: [self systemNavigation + browseMessageList: (slips collect: [:ea | ea definition asMethodReference]) + name: 'Possible slips in new version' translated]; + at: 'Ignore slips and continue' translated put: [^ true]; + at: 'Cancel' translated put: [^ false]; + yourself) + title: ('This patch contains {1} halts, Transcript sends, or other possible slips.\\Save the new version anyway?' withCRs translated format: {slips size})) value. + ^ false MCPatchBrowser>>methodListMenu: {menus} · ct 1/15/2022 23:01 + methodListMenu: aMenu + + super methodListMenu: aMenu. + + aMenu add: 'check for slips' translated help: 'Check all changes for possible slips such as forgotten breakpoints or logging statements.' translated action: #reportSlips. + + ^ aMenu MCPatchBrowser>>reportSlips {actions} · ct 1/15/2022 23:05 + reportSlips + "Look for slips in all changes and report to the user what was found." + + | slips | + slips := self checkForSlips ifEmpty: [^ self inform: 'There were no obvious slips in this patch' translated]. + self systemNavigation + browseMessageList: (slips collect: [:ea | ea definition asMethodReference]) + name: 'Possible slips in new version' translated. MCPatchOperation>>hasReportableSlip {testing} · ct 1/15/2022 22:49 + hasReportableSlip + + ^ self targetDefinition + ifNil: [false] + ifNotNil: [:def | def hasReportableSlip] MCSaveVersionDialog>>accept {actions} · ct 1/15/2022 23:06 (changed) accept | logMessage logMessageWidget | self updateItems. + + (Preferences checkForSlips ==> [self lookForSlips]) ifFalse: [^ self]. + logMessage := (logMessageWidget := self findTextMorph: #logMessage) text asString. (logMessage isEmpty or: [logMessage beginsWith: 'empty log message']) ifTrue: - [(UIManager confirm: 'the log message is empty; are you sure you want to commit') ifFalse: [^ self]] + [(self confirm: 'The log message is empty; are you sure you want to commit?' translated) ifFalse: [^ self]] ifFalse: [logMessageWidget accept]. + self answer: { (self findTextMorph: #versionName) text asString. logMessage. ignore } MCSaveVersionDialog>>checkForSlips {actions} · ct 1/15/2022 23:12 + checkForSlips + + ^ super checkForSlipsIn: (self items copyWithoutAll: self ignore) Preference>>helpString: {menu} · ct 1/16/2022 01:31 + helpString: aString + + helpString := aString --- Sent from Squeak Inbox Talk ["mcSlips.1.cs"] ["mcSlips.png"]

4 10